Re: [Freeipa-devel] [PATCHES] 0025-26 Test improvements

2012-03-27 Thread Petr Viktorin
On 03/26/2012 10:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 25 fixes errors I found by running pylint on the testsuite. They were in code that was unused, either by error or because it only runs on errors. Patch 26 adds a test for the batch plugin. In patch 25 the second

Re: [Freeipa-devel] [PATCH] 70 Parse zone indices in IPv6 addresses in CheckedIPAddress

2012-03-27 Thread Martin Kosek
On Mon, 2012-03-19 at 14:02 +0100, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2138 Honza This will work, I just think that a documentation of this issue can be improved. 1) A short comment in the following part explaining why do we partition by % would clarify it for

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-27 Thread Petr Viktorin
On 03/26/2012 10:34 PM, John Dennis wrote: On 03/26/2012 01:11 PM, Petr Viktorin wrote: Just a one-liner: The docstring of validate_anonymous_substitutions isn't up to par ­­– there's a missing quote, extra “a”, and the '%s occurred' has no context. I suggest: We do not permit multiple

Re: [Freeipa-devel] [PATCH] 70 Parse zone indices in IPv6 addresses in CheckedIPAddress

2012-03-27 Thread Jan Cholasta
On 27.3.2012 10:43, Martin Kosek wrote: On Mon, 2012-03-19 at 14:02 +0100, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2138 Honza This will work, I just think that a documentation of this issue can be improved. 1) A short comment in the following part explaining why do we

Re: [Freeipa-devel] [PATCH] 70 Parse zone indices in IPv6 addresses in CheckedIPAddress

2012-03-27 Thread Martin Kosek
On Tue, 2012-03-27 at 11:50 +0200, Jan Cholasta wrote: On 27.3.2012 10:43, Martin Kosek wrote: On Mon, 2012-03-19 at 14:02 +0100, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2138 Honza This will work, I just think that a documentation of this issue can be improved.

Re: [Freeipa-devel] [PATCH] 15 Confusing default user groups

2012-03-27 Thread Petr Vobornik
On 03/26/2012 10:27 PM, Rob Crittenden wrote: Ondrej Hamada wrote: On 03/19/2012 05:25 PM, Martin Kosek wrote: On Tue, 2012-03-06 at 19:07 +0100, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2354 There was added '(fallback)' string in the automember plugin labels referring to

[Freeipa-devel] [PATCH] 244 Fix dnsrecord-del interactive mode

2012-03-27 Thread Martin Kosek
User was not able to select multiple values in dnsrecord-del interactive mode. https://fedorahosted.org/freeipa/ticket/2581 From eccd9d41a142d927979b7f5606ec96e4ae11db25 Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Tue, 27 Mar 2012 13:02:35 +0200 Subject: [PATCH] Fix

Re: [Freeipa-devel] [PATCH] 72 Fix uses of O=REALM instead of the configured certificate subject base

2012-03-27 Thread Jan Cholasta
On 26.3.2012 22:17, Rob Crittenden wrote: Jan Cholasta wrote: On 26.3.2012 16:15, Rob Crittenden wrote: Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2521 Honza You can still set a custom subject base for selfsign installations so you need a special case in valid_issuer().

Re: [Freeipa-devel] [PATCH] 72 Fix uses of O=REALM instead of the configured certificate subject base

2012-03-27 Thread Rob Crittenden
Jan Cholasta wrote: On 26.3.2012 22:17, Rob Crittenden wrote: Jan Cholasta wrote: On 26.3.2012 16:15, Rob Crittenden wrote: Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2521 Honza You can still set a custom subject base for selfsign installations so you need a special case

Re: [Freeipa-devel] [PATCHES] Improve framework parameter validation

2012-03-27 Thread Martin Kosek
On Thu, 2012-03-15 at 14:57 +0100, Jan Cholasta wrote: On 15.3.2012 14:20, Petr Viktorin wrote: On 03/15/2012 12:05 PM, Jan Cholasta wrote: On 15.3.2012 11:36, Jan Cholasta wrote: (this is a continuation of http://www.redhat.com/archives/freeipa-devel/2011-September/msg00327.html)

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-27 Thread Rob Crittenden
Petr Viktorin wrote: On 03/26/2012 10:34 PM, John Dennis wrote: On 03/26/2012 01:11 PM, Petr Viktorin wrote: Just a one-liner: The docstring of validate_anonymous_substitutions isn't up to par ­­– there's a missing quote, extra “a”, and the '%s occurred' has no context. I suggest: We do not

Re: [Freeipa-devel] [PATCH] 244 Fix dnsrecord-del interactive mode

2012-03-27 Thread Petr Viktorin
On 03/27/2012 01:06 PM, Martin Kosek wrote: User was not able to select multiple values in dnsrecord-del interactive mode. https://fedorahosted.org/freeipa/ticket/2581 ACK -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCHES] Improve framework parameter validation

2012-03-27 Thread Jan Cholasta
On 27.3.2012 16:00, Martin Kosek wrote: On Thu, 2012-03-15 at 14:57 +0100, Jan Cholasta wrote: On 15.3.2012 14:20, Petr Viktorin wrote: On 03/15/2012 12:05 PM, Jan Cholasta wrote: On 15.3.2012 11:36, Jan Cholasta wrote: (this is a continuation of

[Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread John Dennis
This patch addresses ticket 2582, see comments in commit message. -- John Dennis jden...@redhat.com Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From fff7d0a42f7643039987d49c4de69b248f9baa9f Mon Sep 17 00:00:00 2001 From: John Dennis jden...@redhat.com Date: Tue, 27 Mar 2012

Re: [Freeipa-devel] [PATCHES] Improve framework parameter validation

2012-03-27 Thread Martin Kosek
On Tue, 2012-03-27 at 16:30 +0200, Jan Cholasta wrote: On 27.3.2012 16:00, Martin Kosek wrote: On Thu, 2012-03-15 at 14:57 +0100, Jan Cholasta wrote: On 15.3.2012 14:20, Petr Viktorin wrote: On 03/15/2012 12:05 PM, Jan Cholasta wrote: On 15.3.2012 11:36, Jan Cholasta wrote: (this is a

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread John Dennis
On 03/27/2012 10:34 AM, John Dennis wrote: This patch addresses ticket 2582, see comments in commit message. Sorry, the patch I originally posted was incorrect, the work had been done in several commits but I forgot to squash them into one commit and patch before posting it. This new patch

Re: [Freeipa-devel] [PATCHES] 113-114 Facet expiration flag

2012-03-27 Thread Endi Sukma Dewata
On 3/22/2012 12:50 PM, Petr Vobornik wrote: The effort was split to two patches. See patch descriptions. ACK on both. Nice job. See comments below. Notes: Case #7 (automatic: an open facet should automatically refresh itself when it expires) I don't want to implement because I think it can

Re: [Freeipa-devel] [PATCHES] Improve framework parameter validation

2012-03-27 Thread Martin Kosek
On Tue, 2012-03-27 at 16:42 +0200, Martin Kosek wrote: On Tue, 2012-03-27 at 16:30 +0200, Jan Cholasta wrote: On 27.3.2012 16:00, Martin Kosek wrote: On Thu, 2012-03-15 at 14:57 +0100, Jan Cholasta wrote: On 15.3.2012 14:20, Petr Viktorin wrote: On 03/15/2012 12:05 PM, Jan Cholasta

Re: [Freeipa-devel] [PATCH] 16 Netgroup nisdomain and hosts validation

2012-03-27 Thread Ondrej Hamada
On 03/27/2012 01:57 PM, Martin Kosek wrote: On Fri, 2012-03-23 at 23:10 +0100, Ondrej Hamada wrote: On 03/15/2012 08:13 AM, Martin Kosek wrote: On Wed, 2012-03-14 at 16:54 +0100, Ondrej Hamada wrote: On 03/09/2012 04:34 PM, Martin Kosek wrote: On Thu, 2012-03-08 at 14:52 +0100, Ondrej Hamada

Re: [Freeipa-devel] [PATCH] 244 Fix dnsrecord-del interactive mode

2012-03-27 Thread Martin Kosek
On Tue, 2012-03-27 at 16:10 +0200, Petr Viktorin wrote: On 03/27/2012 01:06 PM, Martin Kosek wrote: User was not able to select multiple values in dnsrecord-del interactive mode. https://fedorahosted.org/freeipa/ticket/2581 ACK Pushed to master, ipa-2-2. Martin

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-27 Thread Petr Viktorin
Updated with a regression test for https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp records interactively) which Martin fixed recently. -- Petr³ From 585423feb041cd434977130bd6f00975808ccf30 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue,

[Freeipa-devel] [PATCH] 997 add client package requires on python-krbV

2012-03-27 Thread Rob Crittenden
We initialize ipalib in the client installer now so need a Requires on python-krbV. rob From 38c4e23853a319cdc33cc33f2a0b32f40a342f21 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Tue, 27 Mar 2012 13:30:05 -0400 Subject: [PATCH] Add requires on python-krbV to client

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread Petr Viktorin
On 03/27/2012 04:58 PM, John Dennis wrote: [...] def test_create_translation(): f = text.create_translation key = ('foo', None) @@ -129,6 +45,84 @@ def test_create_translation(): assert context.__dict__[key] is t +class test_TestLang(object): +def setUp(self): +

[Freeipa-devel] [PATCH] 490 Fix s4u2proxy handling when a MS-PAC is available

2012-03-27 Thread Simo Sorce
This patch fixes #2504, the logic to choose the client principal to use was basically reversed, and we ended up using the wrong principal to verify the PAC owner. This patch fixes it. Tested and s4u2proxy keeps working both with and without a PAC attached. It also keeps working with normal TGS

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread John Dennis
On 03/27/2012 01:57 PM, Petr Viktorin wrote: Seeing this, I definitely recommend putting po_file_iterate in an importable package. Of course I considered that. Clearly not any existing top level directory in the tree, those are reserved for what we install and what is import visible after

[Freeipa-devel] [PATCH] 998 certmonger restarts services on renewal

2012-03-27 Thread Rob Crittenden
Certmonger will currently automatically renew server certificates but doesn't restart the services so you can still end up with expired certificates if you services never restart. This patch registers are restart command with certmonger so the IPA services will automatically be restarted to