Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-30 Thread Petr Viktorin
On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line arguments in some uniform way (which is also needed before logging setup to detect ipa-server-

Re: [Freeipa-devel] [PATCH] 0032 Move DNS test skipping to class setup

2012-03-30 Thread Petr Viktorin
On 03/29/2012 10:18 PM, Rob Crittenden wrote: Petr Viktorin wrote: Currently, each DNS test case first checks if DNS is configured by creating and deleting a test zone. This takes quite a lot of time. This patch moves the check to the setUpClass method, so the check is only done once for all t

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-30 Thread Petr Viktorin
On 03/30/2012 02:41 AM, John Dennis wrote: On 03/28/2012 04:40 AM, Petr Viktorin wrote: Can install/po/Makefile just call test_i18n.py from the tests/ tree? It doesn't import any IPA code so there's no need to set sys.path in this case (though there'd have to be a comment saying we depend on thi

Re: [Freeipa-devel] [PATCH] 993 disable UPG for migration

2012-03-30 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2012-03-29 at 11:27 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-03-28 at 17:28 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-03-22 at 15:21 -0400, Rob Crittenden wrote: We don't want to create private groups automatically for migr

[Freeipa-devel] [PATCH] 1000 fix upgrade crash when updating replication agreements

2012-03-30 Thread Rob Crittenden
We check existing agreements to see if they are missing memberof in the EXCLUDE list. It would crash if this list wasn't present at all. So we need to catch this and add in the missing exclusions if they aren't there at all. rob >From 70a92610568d4e2dc102574c0fdca83b61d9d7e1 Mon Sep 17 00:00:

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-30 Thread Rob Crittenden
Petr Viktorin wrote: On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line arguments in some uniform way (which is also needed before logging setup