[Freeipa-devel] [PATCH] 248 Raise proper exception when LDAP limits are exceeded

2012-04-10 Thread Martin Kosek
Few test hints are attached to the ticket. --- ldap2 plugin returns NotFound error for find_entries/get_entry queries when the server did not manage to return an entry due to time limits. This may be confusing for user when the entry he searches actually exists. This patch fixes the behavior in

Re: [Freeipa-devel] [PATCH] 0034 Limit permission and selfservice names

2012-04-10 Thread Petr Viktorin
On 04/09/2012 03:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2585: ipa permission-add throws internal server error when name contains '', '' or other special characters. The problem is, of course, proper escaping; not only in DNs but also in ACIs.

Re: [Freeipa-devel] [PATCH] 115 Reworked netgroup Web UI to allow setting user/host category

2012-04-10 Thread Petr Vobornik
On 04/05/2012 04:54 PM, Endi Sukma Dewata wrote: On 3/29/2012 7:46 AM, Petr Vobornik wrote: This patch is changing netgroup web ui to look more like hbac or sudo rule UI. This change allows to define and display user category, host category and external host. The core of the change is changing

Re: [Freeipa-devel] [PATCH] 116 Fixed: permission attrs table didn't update its available options on load

2012-04-10 Thread Petr Vobornik
On 04/05/2012 04:55 PM, Endi Sukma Dewata wrote: On 4/4/2012 2:18 AM, Petr Vobornik wrote: It could lead to state where attributes from other object type were displayed instead of the correct ones. https://fedorahosted.org/freeipa/ticket/2590 ACK. Pushed to master, ipa-2-2. -- Petr

Re: [Freeipa-devel] [PATCH] 118-119 DNS forward policy: checkboxes changed to radio buttons

2012-04-10 Thread Endi Sukma Dewata
On 4/5/2012 10:58 AM, Petr Vobornik wrote: Revised patch 118 attached. I used: * Forward first * Forward only and set 'default_value' to 'first'. So there would be always some value checked, which indicates what is actually used. There is a little issue with undo button if policy is not set ''

Re: [Freeipa-devel] [PATCH] 0034 Limit permission and selfservice names

2012-04-10 Thread Rob Crittenden
Petr Viktorin wrote: On 04/09/2012 03:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2585: ipa permission-add throws internal server error when name contains '', '' or other special characters. The problem is, of course, proper escaping; not only in

Re: [Freeipa-devel] [PATCH] 118-119 DNS forward policy: checkboxes changed to radio buttons

2012-04-10 Thread Petr Vobornik
On 04/10/2012 03:39 PM, Endi Sukma Dewata wrote: On 4/5/2012 10:58 AM, Petr Vobornik wrote: Revised patch 118 attached. I used: * Forward first * Forward only and set 'default_value' to 'first'. So there would be always some value checked, which indicates what is actually used. There is a

[Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Petr Viktorin
I'm aware that we have backwards compatibility requirements so we have to stick with unfortunate decisions, but I wanted you to know what I think. Please tell me I'm wrong! It is not clear what --{set,add,del}attr and friends should do. On the one hand they should be powerful -- presumably

Re: [Freeipa-devel] [PATCH] 0034 Limit permission and selfservice names

2012-04-10 Thread Petr Viktorin
On 04/10/2012 03:46 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/09/2012 03:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2585: ipa permission-add throws internal server error when name contains '', '' or other special characters. The

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Jan Cholasta
On 10.4.2012 16:00, Petr Viktorin wrote: I'm aware that we have backwards compatibility requirements so we have to stick with unfortunate decisions, but I wanted you to know what I think. Please tell me I'm wrong! It is not clear what --{set,add,del}attr and friends should do. On the one hand

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-10 Thread John Dennis
On 04/06/2012 10:11 AM, John Dennis wrote: On 04/06/2012 04:40 AM, Martin Kosek wrote: 1) We still crash when the parameter is empty. We may want to make it required (the same fix Rob did for cert rejection reason): # echo secret123 | ipa migrate-ds ldap://vm-054.idm.lab.bos.redhat.com

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-10 Thread Jan Cholasta
On 10.4.2012 17:03, John Dennis wrote: On 04/06/2012 10:11 AM, John Dennis wrote: On 04/06/2012 04:40 AM, Martin Kosek wrote: 1) We still crash when the parameter is empty. We may want to make it required (the same fix Rob did for cert rejection reason): # echo secret123 | ipa migrate-ds

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Petr Viktorin
On 04/10/2012 05:03 PM, Jan Cholasta wrote: To be functionally complete, we should also add validated equivalents of --{add,del}attr to *-mod commands for all multivalue params (think --add-param and --del-param for each --param). We need something like that anyway. Requiring users to learn

Re: [Freeipa-devel] [PATCH] 1005 fix password history

2012-04-10 Thread Martin Kosek
On Mon, 2012-04-09 at 23:54 -0400, Rob Crittenden wrote: Password history wasn't working because the qsort comparison function was comparing pointers, not data. This resulted in a random element being removed from the history on overflow rather than the oldest. We sort in reverse so we

[Freeipa-devel] [PATCH] 0035 Convert --setattr values for attributes marked no_update

2012-04-10 Thread Petr Viktorin
Fix --setattr to work on no_update params. https://fedorahosted.org/freeipa/ticket/2616 -- PetrĀ³ From b22c159e4f4c3d411850b30267fce61e56100acd Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 10 Apr 2012 07:44:21 -0400 Subject: [PATCH] Convert --setattr values for

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Petr Spacek
On 04/10/2012 05:31 PM, Petr Viktorin wrote: On 04/10/2012 05:03 PM, Jan Cholasta wrote: On 04/10/2012 05:31 PM, Petr Viktorin wrote: tl;dr: --setattr work on IPA-managed attributes (with validation) is a mistake. +1 It adds no functionality, only complexity. We don't want people to use

[Freeipa-devel] [PATCH] 120 Removal of memberofindirect_permissons from privileges

2012-04-10 Thread Petr Vobornik
Problem: In the Privilege page, can list Permissions. This Shows Results for Direct Membership. But there is an option to list this for Indirect Membership also. There isn't a way to nest permissions, so this option is not needed. Solution: This patch removes the memberofindirect_persmission

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-10 Thread Martin Kosek
On Tue, 2012-04-10 at 11:03 -0400, John Dennis wrote: On 04/06/2012 10:11 AM, John Dennis wrote: On 04/06/2012 04:40 AM, Martin Kosek wrote: 1) We still crash when the parameter is empty. We may want to make it required (the same fix Rob did for cert rejection reason): # echo secret123

[Freeipa-devel] [PATCH] 21 Unable to rename permission object

2012-04-10 Thread Ondrej Hamada
https://fedorahosted.org/freeipa/ticket/2571 The update was failing because of the case insensitivity of permission object DN. -- Regards, Ondrej Hamada FreeIPA team jabber: oh...@jabbim.cz IRC: ohamada From 75772d91024d961fc4193654a8ca128664b2d4d5 Mon Sep 17 00:00:00 2001 From: Ondrej Hamada

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Martin Kosek
On Tue, 2012-04-10 at 17:03 +0200, Jan Cholasta wrote: On 10.4.2012 16:00, Petr Viktorin wrote: I'm aware that we have backwards compatibility requirements so we have to stick with unfortunate decisions, but I wanted you to know what I think. Please tell me I'm wrong! It is not

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-04-10 Thread Petr Viktorin
On 04/09/2012 05:24 PM, John Dennis wrote: On 03/30/2012 08:57 AM, Petr Viktorin wrote: On 03/30/2012 02:41 AM, John Dennis wrote: On 03/28/2012 04:40 AM, Petr Viktorin wrote: Can install/po/Makefile just call test_i18n.py from the tests/ tree? It doesn't import any IPA code so there's no

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Petr Viktorin
On 04/10/2012 07:07 PM, Martin Kosek wrote: On Tue, 2012-04-10 at 17:03 +0200, Jan Cholasta wrote: On 10.4.2012 16:00, Petr Viktorin wrote: I'm aware that we have backwards compatibility requirements so we have to stick with unfortunate decisions, but I wanted you to know what I think. Please

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Rob Crittenden
Petr Viktorin wrote: On 04/10/2012 07:07 PM, Martin Kosek wrote: On Tue, 2012-04-10 at 17:03 +0200, Jan Cholasta wrote: On 10.4.2012 16:00, Petr Viktorin wrote: I'm aware that we have backwards compatibility requirements so we have to stick with unfortunate decisions, but I wanted you to know

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Stephen Ingram
On Tue, Apr 10, 2012 at 10:25 AM, Petr Viktorin pvikt...@redhat.com wrote: On 04/10/2012 07:07 PM, Martin Kosek wrote: On Tue, 2012-04-10 at 17:03 +0200, Jan Cholasta wrote: On 10.4.2012 16:00, Petr Viktorin wrote: I'm aware that we have backwards compatibility requirements so we have to

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-10 Thread Dmitri Pal
On 04/10/2012 01:48 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/10/2012 07:07 PM, Martin Kosek wrote: On Tue, 2012-04-10 at 17:03 +0200, Jan Cholasta wrote: On 10.4.2012 16:00, Petr Viktorin wrote: I'm aware that we have backwards compatibility requirements so we have to stick with

Re: [Freeipa-devel] [PATCH] 0034 Limit permission and selfservice names

2012-04-10 Thread Rob Crittenden
Petr Viktorin wrote: On 04/10/2012 03:46 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/09/2012 03:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2585: ipa permission-add throws internal server error when name contains '', '' or other special

Re: [Freeipa-devel] [PATCH] 0035 Convert --setattr values for attributes marked no_update

2012-04-10 Thread Rob Crittenden
Petr Viktorin wrote: Fix --setattr to work on no_update params. https://fedorahosted.org/freeipa/ticket/2616 ACK, pushed to master and ipa-2-2 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 120 Removal of memberofindirect_permissons from privileges

2012-04-10 Thread Rob Crittenden
Petr Vobornik wrote: Problem: In the Privilege page, can list Permissions. This Shows Results for Direct Membership. But there is an option to list this for Indirect Membership also. There isn't a way to nest permissions, so this option is not needed. Solution: This patch removes the

Re: [Freeipa-devel] [PATCH] 21 Unable to rename permission object

2012-04-10 Thread Rob Crittenden
Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2571 The update was failing because of the case insensitivity of permission object DN. Can you wrap the error in _() and add a couple of test cases for this, say one for the case insensitivity and one for empty rename attempt?

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-10 Thread Rob Crittenden
Petr Viktorin wrote: On 03/30/2012 11:00 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line

Re: [Freeipa-devel] [PATCH] 998 certmonger restarts services on renewal

2012-04-10 Thread Martin Kosek
On Fri, 2012-04-06 at 10:22 +0200, Martin Kosek wrote: On Thu, 2012-04-05 at 16:47 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2012-04-03 at 10:45 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-04-02 at 15:36

Re: [Freeipa-devel] [PATCH] 998 certmonger restarts services on renewal

2012-04-10 Thread Dmitri Pal
On 04/10/2012 04:48 PM, Martin Kosek wrote: On Fri, 2012-04-06 at 10:22 +0200, Martin Kosek wrote: On Thu, 2012-04-05 at 16:47 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2012-04-03 at 10:45 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek

Re: [Freeipa-devel] [PATCH] 998 certmonger restarts services on renewal

2012-04-10 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2012-04-06 at 10:22 +0200, Martin Kosek wrote: On Thu, 2012-04-05 at 16:47 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2012-04-03 at 10:45 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Mon,