Re: [Freeipa-devel] [PATCH] 1019 require policycoreutils if SELinux is enabled

2012-05-30 Thread Martin Kosek
On Tue, 2012-05-29 at 16:50 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > On Fri, 2012-05-18 at 11:53 -0400, Rob Crittenden wrote: > >> We don't have an explicit requires on the policycoreutils package in the > >> client because SELinux is not required (just recommended). > >> > >> SELinux

Re: [Freeipa-devel] [PATCH] 0040 Move install script error handling to a common function

2012-05-30 Thread Petr Viktorin
On 05/29/2012 12:46 PM, Martin Kosek wrote: On Tue, 2012-05-22 at 15:45 +0200, Petr Viktorin wrote: On 2012-04-23 17:05, John Dennis wrote: On 04/23/2012 05:19 AM, Petr Viktorin wrote: This fixes https://fedorahosted.org/freeipa/ticket/2071 (Add final debug message in installers). I submitted

Re: [Freeipa-devel] [PATCH] 269 permission-find missed some results with --pkey-only option

2012-05-30 Thread Ondrej Hamada
On 05/30/2012 07:45 AM, Martin Kosek wrote: When permission-find post callback detected a --pkey-only option, it just terminated. However, this way the results that could have been added from aci_find matches were not included. Fix the post callback to go through the entire matching process. Als

Re: [Freeipa-devel] [PATCH] 0048 Rework the CallbackInterface

2012-05-30 Thread Petr Viktorin
On 05/15/2012 10:25 AM, Petr Viktorin wrote: On 05/10/2012 02:20 PM, Petr Viktorin wrote: While investigating ticket 2674, I found several problems with our implementation of the CallbackInterface ­— it required complicated calling code, and would subtly break if command classes were instantiate

Re: [Freeipa-devel] [PATCH] 268 Add rename option for DNS records

2012-05-30 Thread Jan Cholasta
On 29.5.2012 16:59, Martin Kosek wrote: On Tue, 2012-05-29 at 16:40 +0200, Jan Cholasta wrote: On 29.5.2012 16:01, Martin Kosek wrote: This option will make renaming DNS records much easier. Add a unit test for this new functionality. https://fedorahosted.org/freeipa/ticket/2600 I wonder, h

Re: [Freeipa-devel] [PATCH] 1019 require policycoreutils if SELinux is enabled

2012-05-30 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2012-05-29 at 16:50 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-05-18 at 11:53 -0400, Rob Crittenden wrote: We don't have an explicit requires on the policycoreutils package in the client because SELinux is not required (just recommended). SELinux