Re: [Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

2013-10-18 Thread Martin Kosek
On 10/17/2013 10:29 PM, Alexander Bokovoy wrote: > On Thu, 17 Oct 2013, Ana Krivokapic wrote: > >> Hello, >> >> This patch adds ipa-advise plugins for configuring legacy clients using >> nss-pam-ldapd. >> >> https://fedorahosted.org/freeipa/ticket/3672 > Thanks. Looks good. I have one comment belo

Re: [Freeipa-devel] [PATCHES] 0311-0312 Use new CLI options in certinstall tests

2013-10-18 Thread Petr Vobornik
On 10/09/2013 06:31 PM, Petr Viktorin wrote: Patch 0311: one-liner (or one-byter) to fix the last certinstall test Patch 0312 adds tests for http://www.freeipa.org/page/V3/ipa-server-certinstall_CLI_cleanup ACK -- Petr Vobornik ___ Freeipa-devel ma

Re: [Freeipa-devel] [PATCHES] 0311-0312 Use new CLI options in certinstall tests

2013-10-18 Thread Petr Viktorin
On 10/18/2013 12:24 PM, Petr Vobornik wrote: On 10/09/2013 06:31 PM, Petr Viktorin wrote: Patch 0311: one-liner (or one-byter) to fix the last certinstall test Patch 0312 adds tests for http://www.freeipa.org/page/V3/ipa-server-certinstall_CLI_cleanup ACK Thanks, pushed to: master: c97f4e8

Re: [Freeipa-devel] [PATCH] [DOC] 0003 Split text commands & descriptions into XML tables.

2013-10-18 Thread Petr Viktorin
On 10/15/2013 06:19 PM, Jérôme Fenal wrote: kk2013/10/15 Martin Kosek : Thanks. It would be ideal, if this table is (in future) generated somehow semi-automatically as practically all this info can be gathered from FreeIPA code. But for now, this is great. I see some issues with the patch thoug

Re: [Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

2013-10-18 Thread Ana Krivokapic
On 10/18/2013 09:48 AM, Martin Kosek wrote: > On 10/17/2013 10:29 PM, Alexander Bokovoy wrote: >> On Thu, 17 Oct 2013, Ana Krivokapic wrote: >> >>> Hello, >>> >>> This patch adds ipa-advise plugins for configuring legacy clients using >>> nss-pam-ldapd. >>> >>> https://fedorahosted.org/freeipa/tick

Re: [Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

2013-10-18 Thread Ana Krivokapic
On 10/18/2013 01:31 PM, Ana Krivokapic wrote: > On 10/18/2013 09:48 AM, Martin Kosek wrote: >> On 10/17/2013 10:29 PM, Alexander Bokovoy wrote: >>> On Thu, 17 Oct 2013, Ana Krivokapic wrote: >>> Hello, This patch adds ipa-advise plugins for configuring legacy clients using nss-p

Re: [Freeipa-devel] [PATCH] [DOC] 0003 Split text commands & descriptions into XML tables.

2013-10-18 Thread Jérôme Fenal
2013/10/18 Petr Viktorin : > On 10/15/2013 06:19 PM, Jérôme Fenal wrote: >> >> kk2013/10/15 Martin Kosek : >>> >>> Thanks. It would be ideal, if this table is (in future) generated somehow >>> semi-automatically as practically all this info can be gathered from >>> FreeIPA >>> code. But for now, th

Re: [Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

2013-10-18 Thread Alexander Bokovoy
On Fri, 18 Oct 2013, Ana Krivokapic wrote: On 10/18/2013 01:31 PM, Ana Krivokapic wrote: On 10/18/2013 09:48 AM, Martin Kosek wrote: On 10/17/2013 10:29 PM, Alexander Bokovoy wrote: On Thu, 17 Oct 2013, Ana Krivokapic wrote: Hello, This patch adds ipa-advise plugins for configuring legacy

Re: [Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

2013-10-18 Thread Petr Viktorin
On 10/18/2013 04:07 PM, Alexander Bokovoy wrote: On Fri, 18 Oct 2013, Ana Krivokapic wrote: On 10/18/2013 01:31 PM, Ana Krivokapic wrote: On 10/18/2013 09:48 AM, Martin Kosek wrote: On 10/17/2013 10:29 PM, Alexander Bokovoy wrote: On Thu, 17 Oct 2013, Ana Krivokapic wrote: Hello, This pat

Re: [Freeipa-devel] [PATCH] 0288 Use a user result template in tests

2013-10-18 Thread Ana Krivokapic
On 09/30/2013 05:05 PM, Petr Viktorin wrote: > Hello, > > This patch introduces an user "template" with the result of a default user > add/show. The template is then customized and used in each test. > > This makes the tests shorter, and highlights the "non-default" (interesting) > pieces of the re

Re: [Freeipa-devel] [PATCHES] 0289-0302 Managed Read permissions

2013-10-18 Thread Petr Viktorin
On 10/03/2013 12:42 PM, Martin Kosek wrote: On 10/02/2013 01:26 PM, Petr Viktorin wrote: On 10/02/2013 01:07 PM, Simo Sorce wrote: ... To sum it up, I would rather not build our permission system on this group. I think we need top base our ACIs on LDAP bind targets ldap:///all and ldap:///an

Re: [Freeipa-devel] Reviews still needed

2013-10-18 Thread Petr Viktorin
On 10/09/2013 08:57 PM, Nathaniel McCallum wrote: I still need reviews on the following patches. The first two (0015 and 0016) should be close if not ready to merge. They have undergone four revisions. The third is probably in the middle of reviews. Please help me push this over the goal line. :)

[Freeipa-devel] [PATCH] 0014 [RFE] ipa migrate-ds should have an argument to specify cert to use for DS connection

2013-10-18 Thread Martin Basti
Patch attached. Ticket: https://fedorahosted.org/freeipa/ticket/3243 -- Martin Basti >From 9ad994eaae48f37404a65a99964b58daf0dd5370 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 18 Oct 2013 16:40:27 +0200 Subject: [PATCH] migrate-ds added --ca-cert-file=FILE option FILE is used to spec

Re: [Freeipa-devel] [PATCH] 0288 Use a user result template in tests

2013-10-18 Thread Petr Viktorin
On 10/18/2013 04:21 PM, Ana Krivokapic wrote: On 09/30/2013 05:05 PM, Petr Viktorin wrote: Hello, This patch introduces an user "template" with the result of a default user add/show. The template is then customized and used in each test. This makes the tests shorter, and highlights the "non-de

Re: [Freeipa-devel] [PATCH] 0274 test_simple_replication: Fix waiting for replication

2013-10-18 Thread Ana Krivokapic
On 09/13/2013 06:24 PM, Petr Viktorin wrote: > The "simple replication" test is failing intermittently. It's quite hard to > manually verify if this patch fixes that completely, but my testing says it > does make a positive difference. > > See commit message for details. > > > > ___

[Freeipa-devel] [PATCH][DOC] 0015 Added section migration using TLS

2013-10-18 Thread Martin Basti
Document changes in patch freeipa-mbasti-0014 Patch attached. -- Martin Basti >From 88b67e18a53f339097d200f1a5968123bb067fca Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 18 Oct 2013 17:46:16 +0200 Subject: [PATCH] Added new section migration with TLS Documented ticket: https://fedorah

Re: [Freeipa-devel] [PATCH] 0274 test_simple_replication: Fix waiting for replication

2013-10-18 Thread Petr Viktorin
On 10/18/2013 05:53 PM, Ana Krivokapic wrote: On 09/13/2013 06:24 PM, Petr Viktorin wrote: The "simple replication" test is failing intermittently. It's quite hard to manually verify if this patch fixes that completely, but my testing says it does make a positive difference. See commit message