Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-12-11 Thread Tomas Babej
On 11/27/2013 03:38 PM, Simo Sorce wrote: On Wed, 2013-11-27 at 08:50 +0100, Tomas Babej wrote: Sorry to nitpick but ... diff --git a/daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c b/daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c index

Re: [Freeipa-devel] [PATCH] 0129 fix trust.get_dn to distinguish creating and re-adding trusts

2013-12-11 Thread Tomas Babej
On 12/05/2013 12:51 PM, Alexander Bokovoy wrote: Latest support for subdomains introduced regression that masked difference between newly added trust and re-added one. Additionally, in case no new subdomains were found, the code was returning None instead of an empty list which later could

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-12-11 Thread Alexander Bokovoy
On Wed, 11 Dec 2013, Tomas Babej wrote: On 11/27/2013 03:38 PM, Simo Sorce wrote: On Wed, 2013-11-27 at 08:50 +0100, Tomas Babej wrote: Sorry to nitpick but ... diff --git a/daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c b/daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c

Re: [Freeipa-devel] Troubleshooting FreeIPA

2013-12-11 Thread Martin Kosek
On 12/04/2013 03:31 PM, Dmitri Pal wrote: On 12/04/2013 07:11 AM, Martin Kosek wrote: Hello all, I have started a Troubleshooting page which should help FreeIPA users troubleshoot and report bugs. The first attempt can be found here: http://www.freeipa.org/page/Troubleshooting This is mostly

Re: [Freeipa-devel] [PATCH 0024] Add OTP support to ipalib CLI

2013-12-11 Thread Jan Cholasta
On 14.11.2013 20:23, Nathaniel McCallum wrote: On Wed, 2013-10-30 at 08:57 +0100, Jan Cholasta wrote: On 8.10.2013 16:35, Nathaniel McCallum wrote: On Tue, 2013-10-08 at 09:19 +0200, Jan Cholasta wrote: +class Base32DecodeError(ExecutionError): Is this really necessary? Are we going to add

Re: [Freeipa-devel] [PATCH 0024] Add OTP support to ipalib CLI

2013-12-11 Thread Martin Kosek
On 12/11/2013 01:24 PM, Jan Cholasta wrote: On 14.11.2013 20:23, Nathaniel McCallum wrote: On Wed, 2013-10-30 at 08:57 +0100, Jan Cholasta wrote: On 8.10.2013 16:35, Nathaniel McCallum wrote: On Tue, 2013-10-08 at 09:19 +0200, Jan Cholasta wrote: +class Base32DecodeError(ExecutionError):

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-12-11 Thread Martin Kosek
On 12/11/2013 12:56 PM, Alexander Bokovoy wrote: On Wed, 11 Dec 2013, Tomas Babej wrote: On 11/27/2013 03:38 PM, Simo Sorce wrote: On Wed, 2013-11-27 at 08:50 +0100, Tomas Babej wrote: Sorry to nitpick but ... diff --git a/daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c

Re: [Freeipa-devel] [PATCHES] 0022-0023 [RFE] DNS - IDN support

2013-12-11 Thread Jan Cholasta
On 6.12.2013 14:48, Martin Basti wrote: Hello, patches here contain a *draft* of IDN support for IPA DNS. Overview: 1) IND domains stored in LDAP are punycoded(A-labels) 2) now domain can contains almost everything 3) domains have to be normalized (AD requires normalized domains too). Example:

Re: [Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2013-12-11 Thread Petr Viktorin
On 12/10/2013 02:10 PM, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/3488. Honza These look great, thanks! Just a couple of questions/nicpicks. 213: ACK 214: ACK 215: ACK 216: ACK 217: ACK 218: ACK 219: Does the new method guarantee

Re: [Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2013-12-11 Thread Petr Viktorin
On 12/11/2013 05:05 PM, Petr Viktorin wrote: On 12/10/2013 02:10 PM, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/3488. Honza These look great, thanks! Just a couple of questions/nicpicks. 213: ACK 214: ACK 215: ACK 216: ACK 217: ACK 218: ACK