Re: [Freeipa-devel] [PATCH 0018] ipa-client-automount should not configure nsswitch.conf

2014-05-16 Thread Petr Viktorin
On 05/14/2014 04:24 PM, Gabe Alford wrote: Thanks. Updated patch. Great! ACK, there's just some whitespace left in the patch. Removed trailing whitespace, pushed to master: 98102832789412f567a96693dfe27b0e00cc98e5 On Wed, May 14, 2014 at 3:49 AM, Petr Viktorin pvikt...@redhat.com

Re: [Freeipa-devel] [PATCH] 0455 Replace replica admins read access ACI with a permission

2014-05-16 Thread Martin Kosek
On 04/30/2014 05:16 PM, Petr Viktorin wrote: This should fix https://fedorahosted.org/freeipa/ticket/3829 You mistakenly assigned the permission to all authenticated users. When I changed bind type from all to permission, it gave the expected and correct results. Admin user was no longer able

Re: [Freeipa-devel] [PATCH][DOC] Sometimes users set bad uid ranges

2014-05-16 Thread Petr Viktorin
On 05/14/2014 06:42 PM, Gabe Alford wrote: MINUID and MINSSSUID sound fine. Gabe Thanks! Pushed to docs master: 4978945ab168b471a15a6d5536ca397e934fe8fc On Wed, May 14, 2014 at 9:11 AM, Petr Spacek pspa...@redhat.com mailto:pspa...@redhat.com wrote: On 14.5.2014 16:55, Gabe Alford

Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu

2014-05-16 Thread Kyle Baker
Hey Petr, I would actually say the inverse here. Your second option creates unnecessary nesting which we should avoid if possible. We would only want to go to multiple levels in the nav if the number of items in the nav got unwieldy, we then should categorize. Since there are only two items the

Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu

2014-05-16 Thread Petr Vobornik
On 16.5.2014 15:19, Kyle Baker wrote: Hey Petr, I would actually say the inverse here. Your second option creates unnecessary nesting which we should avoid if possible. We would only want to go to multiple levels in the nav if the number of items in the nav got unwieldy, we then should

Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu

2014-05-16 Thread Kyle Baker
- Original Message - On 16.5.2014 15:19, Kyle Baker wrote: Hey Petr, I would actually say the inverse here. Your second option creates unnecessary nesting which we should avoid if possible. We would only want to go to multiple levels in the nav if the number of items in the nav

Re: [Freeipa-devel] [PATCHES] 0540-0542 Add managed read permissions to user

2014-05-16 Thread Petr Viktorin
On 05/16/2014 01:54 PM, Martin Kosek wrote: On 04/29/2014 11:00 PM, Petr Viktorin wrote: Patch 0540 adds a bunch of managed read ACIs for user, as discussed previously [0]. Patch 0541 is some minor refactoring for the next part. Patch 0542 sets the read acces to addressbook attributes to