Re: [Freeipa-devel] Switching to pytest

2014-10-07 Thread Petr Viktorin
On 10/06/2014 11:21 PM, John Dennis wrote: On 10/03/2014 09:24 AM, Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/4610 Our test suite is currently not very maintainable. I want to dedicate some time to improve this. The biggest part of this effort will be switching to a different

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread thierry bordaz
On 10/01/2014 06:16 PM, Alexander Bokovoy wrote: Hi! Attached are patches to add support of FreeIPA ID views to Schema compatibility plugin (slapi-nis). There are two patches for FreeIPA and a separate patch for slapi-nis. Patches can be applied independently; if old slapi-nis is installed, it

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Alexander Bokovoy
On Tue, 07 Oct 2014, thierry bordaz wrote: A question about backend_search_filter_has_cn_uid. It checks if a filter components contains (uid|uidNumber|gidNumber|memberUid) and in this case returns SLAPI_FILTER_SCAN_STOP. This value will interrupt the filter rewriting. In addition, for

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Ludwig Krispenz
Hi Alex, slapi_attr_set_valueset() calls slapi_valueset_set_valueset(), but this does not free the existing values, cf https://access.redhat.com/documentation/en-US/Red_Hat_Directory_Server/9.0/html/Plug-in_Guide/Plugin_Programming_Guide-Function_Reference-slapi_valueset_set_valueset.html

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Alexander Bokovoy
On Tue, 07 Oct 2014, Ludwig Krispenz wrote: Hi Alex, slapi_attr_set_valueset() calls slapi_valueset_set_valueset(), but this does not free the existing values, Here is the problem, I cannot free original values as slapi_attr_get_valueset() returns a copy and I never can get access to the

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Ludwig Krispenz
On 10/07/2014 12:12 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Ludwig Krispenz wrote: Hi Alex, slapi_attr_set_valueset() calls slapi_valueset_set_valueset(), but this does not free the existing values, Here is the problem, I cannot free original values as slapi_attr_get_valueset()

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Alexander Bokovoy
On Tue, 07 Oct 2014, Ludwig Krispenz wrote: On 10/07/2014 12:12 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Ludwig Krispenz wrote: Hi Alex, slapi_attr_set_valueset() calls slapi_valueset_set_valueset(), but this does not free the existing values, Here is the problem, I cannot free

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Ludwig Krispenz
On 10/07/2014 12:39 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Ludwig Krispenz wrote: On 10/07/2014 12:12 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Ludwig Krispenz wrote: Hi Alex, slapi_attr_set_valueset() calls slapi_valueset_set_valueset(), but this does not free the

Re: [Freeipa-devel] Switching to pytest

2014-10-07 Thread John Dennis
On 10/07/2014 04:37 AM, Petr Viktorin wrote: So in the test framework war I'm betting on this one. That is the info I was looking for. Thanks!! -- John ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Alexander Bokovoy
On Tue, 07 Oct 2014, Ludwig Krispenz wrote: On 10/07/2014 12:39 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Ludwig Krispenz wrote: On 10/07/2014 12:12 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Ludwig Krispenz wrote: Hi Alex, slapi_attr_set_valueset() calls

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread thierry bordaz
On 10/07/2014 11:43 AM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, thierry bordaz wrote: A question about backend_search_filter_has_cn_uid. It checks if a filter components contains (uid|uidNumber|gidNumber|memberUid) and in this case returns SLAPI_FILTER_SCAN_STOP. This value will

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Ludwig Krispenz
On 10/07/2014 01:32 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Ludwig Krispenz wrote: On 10/07/2014 12:39 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, Ludwig Krispenz wrote: On 10/07/2014 12:12 PM, Alexander Bokovoy wrote: On Tue,

Re: [Freeipa-devel] Dogtag lightweight sub-CAs; updated design

2014-10-07 Thread Simo Sorce
On Tue, 07 Oct 2014 13:47:05 +0200 Martin Kosek mko...@redhat.com wrote: On 10/07/2014 05:31 AM, Fraser Tweedale wrote: Hi all, The Dogtag lightweight sub-CAs design has undergone major revision and expansion ahead of beginning the implementation (I plan to begin later this week).

Re: [Freeipa-devel] Dogtag lightweight sub-CAs; updated design

2014-10-07 Thread Rob Crittenden
Simo Sorce wrote: On Tue, 07 Oct 2014 13:47:05 +0200 Martin Kosek mko...@redhat.com wrote: On 10/07/2014 05:31 AM, Fraser Tweedale wrote: Hi all, The Dogtag lightweight sub-CAs design has undergone major revision and expansion ahead of beginning the implementation (I plan to begin later

Re: [Freeipa-devel] Dogtag lightweight sub-CAs; updated design

2014-10-07 Thread Simo Sorce
On Tue, 07 Oct 2014 09:29:33 -0400 Rob Crittenden rcrit...@redhat.com wrote: Simo Sorce wrote: On Tue, 07 Oct 2014 13:47:05 +0200 Martin Kosek mko...@redhat.com wrote: On 10/07/2014 05:31 AM, Fraser Tweedale wrote: Hi all, The Dogtag lightweight sub-CAs design has undergone major

Re: [Freeipa-devel] [PATCH 0034] Missing requires on python-dns

2014-10-07 Thread Gabe Alford
Forgot to add patch. On Tue, Oct 7, 2014 at 7:58 AM, Gabe Alford redhatri...@gmail.com wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/4613 Thanks, Gabe From 2506c1ac5c9d92a1817bfc4fb321c206107222a0 Mon Sep 17 00:00:00 2001 From: Gabe redhatri...@gmail.com Date: Tue,

[Freeipa-devel] [PATCH 0034] Missing requires on python-dns

2014-10-07 Thread Gabe Alford
Hello, Fix for https://fedorahosted.org/freeipa/ticket/4613 Thanks, Gabe ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread thierry bordaz
On 10/01/2014 06:16 PM, Alexander Bokovoy wrote: Hi! Attached are patches to add support of FreeIPA ID views to Schema compatibility plugin (slapi-nis). There are two patches for FreeIPA and a separate patch for slapi-nis. Patches can be applied independently; if old slapi-nis is installed, it

[Freeipa-devel] [PATCH] 0020 Set IPA CA for freeipa certificates

2014-10-07 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4618 -- David Kupka From ab15f67ee35d29cd30b6b6d703a000c3cfe3188b Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Tue, 7 Oct 2014 10:19:09 -0400 Subject: [PATCH] Set IPA CA for freeipa certificates. In previous versions (before moving

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Alexander Bokovoy
On Tue, 07 Oct 2014, thierry bordaz wrote: On 10/01/2014 06:16 PM, Alexander Bokovoy wrote: Hi! Attached are patches to add support of FreeIPA ID views to Schema compatibility plugin (slapi-nis). There are two patches for FreeIPA and a separate patch for slapi-nis. Patches can be applied

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread thierry bordaz
On 10/07/2014 05:00 PM, Alexander Bokovoy wrote: On Tue, 07 Oct 2014, thierry bordaz wrote: On 10/01/2014 06:16 PM, Alexander Bokovoy wrote: Hi! Attached are patches to add support of FreeIPA ID views to Schema compatibility plugin (slapi-nis). There are two patches for FreeIPA and a separate

Re: [Freeipa-devel] [PATCH] 0159-0160 Support ID views in compat tree

2014-10-07 Thread Ludwig Krispenz
Hi Alex, I have a question regarding cbdata.target. It is/was a reference to the pblock used to generate a new dn, but now in idview_replace_target_dn(cbdata.target,...) it can be newly allocated and should be freed, so I think there should be a return code indicating if it was allocated or

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

2014-10-07 Thread Nathaniel McCallum
Attached is the latest patch. I believe this includes all of our discussions up until this point. However, a few bits of additional information are needed. First, I have renamed the plugin to ipa-otp-counter. I believe all replay prevention work can land inside this plugin, so the name is

[Freeipa-devel] [PATCH] 347 Fix CA cert validity check for CA-less and external CA installer options

2014-10-07 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4612. Honza -- Jan Cholasta From a8c5e11b428ea53119c091f565ca4c1f4ec32672 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 7 Oct 2014 18:16:53 +0200 Subject: [PATCH] Fix CA cert validity check for

[Freeipa-devel] [PATCH] 348 Remove misleading authorization error message in cert-request with --add

2014-10-07 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4540. The error message is now the generic ACI error message, e.g. Insufficient access: Insufficient 'add' privilege to add the entry

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

2014-10-07 Thread thierry bordaz
On 10/07/2014 06:00 PM, Nathaniel McCallum wrote: Attached is the latest patch. I believe this includes all of our discussions up until this point. However, a few bits of additional information are needed. First, I have renamed the plugin to ipa-otp-counter. I believe all replay prevention work

Re: [Freeipa-devel] [PATCH 0034] Missing requires on python-dns

2014-10-07 Thread Martin Basti
On 07/10/14 15:58, Gabe Alford wrote: Forgot to add patch. On Tue, Oct 7, 2014 at 7:58 AM, Gabe Alford redhatri...@gmail.com mailto:redhatri...@gmail.com wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/4613 Thanks, Gabe

Re: [Freeipa-devel] [PATCH 0034] Missing requires on python-dns

2014-10-07 Thread Gabe Alford
Done. Update patch to use python-dns = 1.11.1 On Tue, Oct 7, 2014 at 11:26 AM, Martin Basti mba...@redhat.com wrote: On 07/10/14 15:58, Gabe Alford wrote: Forgot to add patch. On Tue, Oct 7, 2014 at 7:58 AM, Gabe Alford redhatri...@gmail.com wrote: Hello, Fix for

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

2014-10-07 Thread Nathaniel McCallum
On Tue, 2014-10-07 at 18:54 +0200, thierry bordaz wrote: On 10/07/2014 06:00 PM, Nathaniel McCallum wrote: Attached is the latest patch. I believe this includes all of our discussions up until this point. However, a few bits of additional information are needed. First, I have renamed

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

2014-10-07 Thread Noriko Hosoi
On 2014/10/07 10:48, Nathaniel McCallum wrote: On Tue, 2014-10-07 at 18:54 +0200, thierry bordaz wrote: On 10/07/2014 06:00 PM, Nathaniel McCallum wrote: Attached is the latest patch. I believe this includes all of our discussions up until this point. However, a few bits of additional

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

2014-10-07 Thread Nathaniel McCallum
On Tue, 2014-10-07 at 10:52 -0700, Noriko Hosoi wrote: On 2014/10/07 10:48, Nathaniel McCallum wrote: On Tue, 2014-10-07 at 18:54 +0200, thierry bordaz wrote: On 10/07/2014 06:00 PM, Nathaniel McCallum wrote: Attached is the latest patch. I believe this includes all of our discussions

[Freeipa-devel] [PATCH] 0021 Fix example usage in ipa man page.

2014-10-07 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4587 -- David Kupka From 883e90237fbde1075d00990568cde18773e80611 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Wed, 8 Oct 2014 01:43:47 -0400 Subject: [PATCH] Fix example usage in ipa man page.