Re: [Freeipa-devel] [PATCHES 0191-0194] Fix restoring states of services after uninstalling

2015-02-17 Thread Martin Basti
On 17/02/15 12:18, David Kupka wrote: On 02/11/2015 05:13 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4869 Fixes: - enable/start a service after uninstallation if the service was enabled/running before in correct way - store status of service before

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-17 Thread Gabe Alford
Hello, I was wondering if I could get a review of this patch. Thanks, Gabe On Thursday, January 29, 2015, Gabe Alford redhatri...@gmail.com wrote: Hello, Here is a patch for https://fedorahosted.org/freeipa/ticket/4029 I added test cases for valid and invalid advice.

Re: [Freeipa-devel] [PATCHES 0191-0194] Fix restoring states of services after uninstalling

2015-02-17 Thread David Kupka
On 02/11/2015 05:13 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4869 Fixes: - enable/start a service after uninstallation if the service was enabled/running before in correct way - store status of service before disable/stop/start/enable operation - run uninstall only for