[Freeipa-devel] [PATCH 0195] Fix memory leaks in ipapkcs11helper module

2015-02-25 Thread Martin Basti
Ticket: https://fedorahosted.org/freeipa/ticket/4657 Patch attached. -- Martin Basti From 15509e09b658e9b2460ce42081baa1bb77a4d1e8 Mon Sep 17 00:00:00 2001 From: Martin Basti mba...@redhat.com Date: Tue, 24 Feb 2015 19:25:31 +0100 Subject: [PATCH] Fix memory leaks in ipap11helper Ticket:

[Freeipa-devel] [PATCH 0194] Remove unused method to export secret key from ipapkcs11helper module

2015-02-25 Thread Martin Basti
The method never been used, and never will be, because we do not want to export secrets. Ticket: https://fedorahosted.org/freeipa/ticket/4657 Patch attached (may require mbasti-0195, mbasti-0190) -- Martin Basti From b812b72924aff118ed5c83d40040dc93f623c22b Mon Sep 17 00:00:00 2001 From:

Re: [Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-02-25 Thread Alexander Bokovoy
On Wed, 25 Feb 2015, Martin Basti wrote: Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin disabled, cn=uid uniqueness,cn=plugins,cn=config is checking the same attribute. * POST_UPDATE plugin for uid removed, I moved it to update file.

Re: [Freeipa-devel] [PATCH 133] ipa-range-check: do not treat missing objects as error

2015-02-25 Thread Martin Kosek
On 02/24/2015 06:47 PM, Sumit Bose wrote: Hi, this patch changes a return code and should fix https://fedorahosted.org/freeipa/ticket/4924 . bye, Sumit I have a related question. Do I read the plugin right, that whenever any object is changed, this plugins loads the whole entry and tests

[Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-02-25 Thread Martin Basti
Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin disabled, cn=uid uniqueness,cn=plugins,cn=config is checking the same attribute. * POST_UPDATE plugin for uid removed, I moved it to update file. Is it okay Alexander? I haven't found

[Freeipa-devel] [PATCH 0199] Remove unused disable-betxn.ldif file

2015-02-25 Thread Martin Basti
Hello, the file 'disable-betxn.ldif' is not used in code in IPA master branch. There is 10-enable-betxn.update which is used. If I'm right we can remove it. Patch attached. Please correct me if the file is needed. Martin^2 -- Martin Basti From 9d6f9e4099cdc699ec146a647829c2b626468547 Mon Sep

[Freeipa-devel] Announcing FreeIPA 4.1.3

2015-02-25 Thread Petr Vobornik
The FreeIPA team would like to announce FreeIPA v4.1.3 bug fix release! It can be downloaded from http://www.freeipa.org/page/Downloads . Fedora 21 builds are already on their way to updates-testing repository. Builds for Fedora 20 are available in the official COPR repository

Re: [Freeipa-devel] [PATCH 0195] Fix memory leaks in ipapkcs11helper module

2015-02-25 Thread Martin Basti
On 25/02/15 14:21, Martin Basti wrote: Ticket: https://fedorahosted.org/freeipa/ticket/4657 Patch attached. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel I forgot to mention, requires

Re: [Freeipa-devel] [PATCH 133] ipa-range-check: do not treat missing objects as error

2015-02-25 Thread Sumit Bose
On Wed, Feb 25, 2015 at 02:43:05PM +0100, Martin Kosek wrote: On 02/24/2015 06:47 PM, Sumit Bose wrote: Hi, this patch changes a return code and should fix https://fedorahosted.org/freeipa/ticket/4924 . bye, Sumit I have a related question. Do I read the plugin right, that

Re: [Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-02-25 Thread Martin Kosek
On 02/25/2015 04:00 PM, Alexander Bokovoy wrote: On Wed, 25 Feb 2015, Martin Basti wrote: On 25/02/15 15:37, Alexander Bokovoy wrote: On Wed, 25 Feb 2015, Martin Basti wrote: Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-25 Thread Gabe Alford
No worries about the delay. Thanks for taking the time! Updated patch attached. Thanks, Gabe On Tue, Feb 24, 2015 at 11:03 AM, Tomas Babej tba...@redhat.com wrote: Hi Gabe, sorry for the delay. Here comes the review! 1.) All the tests fail, since the IPA master is not installed at all:

Re: [Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-02-25 Thread Martin Basti
On 25/02/15 15:37, Alexander Bokovoy wrote: On Wed, 25 Feb 2015, Martin Basti wrote: Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin disabled, cn=uid uniqueness,cn=plugins,cn=config is checking the same attribute. * POST_UPDATE

Re: [Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-02-25 Thread Alexander Bokovoy
On Wed, 25 Feb 2015, Martin Basti wrote: On 25/02/15 15:37, Alexander Bokovoy wrote: On Wed, 25 Feb 2015, Martin Basti wrote: Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin disabled, cn=uid uniqueness,cn=plugins,cn=config is

Re: [Freeipa-devel] [PATCH 133] ipa-range-check: do not treat missing objects as error

2015-02-25 Thread thierry bordaz
On 02/25/2015 02:43 PM, Martin Kosek wrote: On 02/24/2015 06:47 PM, Sumit Bose wrote: Hi, this patch changes a return code and should fix https://fedorahosted.org/freeipa/ticket/4924 . bye, Sumit I have a related question. Do I read the plugin right, that whenever any object is changed, this

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-02-25 Thread Petr Spacek
On 24.2.2015 19:10, Martin Basti wrote: Hello all, please read the design page, any objections/suggestions appreciated http://www.freeipa.org/page/V4/Server_Upgrade_Refactoring Thank you for the design, I have only few nitpicks. Increase update files numbers range Update files number will

[Freeipa-devel] [PATCH] 808 webui: service: add ipakrbrequirespreauth checkbox

2015-02-25 Thread Petr Vobornik
Allow to configure missing krb ticket flag - ipakrbrequirespreauth from Web UI. -- Petr Vobornik From 23def2a08bf3aec43bc341bafeebaf4fee302ad2 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 25 Feb 2015 12:56:19 +0100 Subject: [PATCH] webui: service: add

Re: [Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-02-25 Thread thierry bordaz
On 02/25/2015 02:34 PM, Martin Basti wrote: Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin disabled, cn=uid uniqueness,cn=plugins,cn=config is checking the same attribute. * POST_UPDATE plugin for uid removed, I moved it to update

Re: [Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-02-25 Thread thierry bordaz
On 02/25/2015 05:28 PM, Martin Basti wrote: On 25/02/15 17:23, thierry bordaz wrote: On 02/25/2015 02:34 PM, Martin Basti wrote: Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin disabled, cn=uid uniqueness,cn=plugins,cn=config is

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-02-25 Thread Martin Basti
On 25/02/15 17:15, Petr Spacek wrote: On 24.2.2015 19:10, Martin Basti wrote: Hello all, please read the design page, any objections/suggestions appreciated http://www.freeipa.org/page/V4/Server_Upgrade_Refactoring Thank you for the design, I have only few nitpicks. Increase update files

Re: [Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-02-25 Thread Martin Basti
On 25/02/15 17:23, thierry bordaz wrote: On 02/25/2015 02:34 PM, Martin Basti wrote: Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin disabled, cn=uid uniqueness,cn=plugins,cn=config is checking the same attribute. * POST_UPDATE

[Freeipa-devel] [PATCH 0042] ipa-replica-prepare should document ipv6 options

2015-02-25 Thread Gabe Alford
Hello, Fix for https://fedorahosted.org/freeipa/ticket/4877. I just took what was in the ticket. Thanks, Gabe freeipa-rga-0042-ipa-replica-prepare-should-document-ipv6-options.patch Description: Binary data ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCHES 0001-0002] ipa-client-install NTP fixes

2015-02-25 Thread Nathan Kinder
Hi, The two attached patches address some issues that affect ipa-client-install when syncing time from the NTP server. Now that we use ntpd to perform the time sync, the client install can end up hanging forever when the server is not reachable (firewall issues, etc.). These patches address the

Re: [Freeipa-devel] [PATCH 0042] ipa-replica-prepare should document ipv6 options

2015-02-25 Thread Tomas Babej
On 02/25/2015 09:26 PM, Gabe Alford wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/4877. I just took what was in the ticket. Thanks, Gabe ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-25 Thread Tomas Babej
Hi Gabe, sorry for not being clear. This approach will not work: +class TestAdvice(BaseTestInvalidAdvice, + BaseTestFedoraAuthconfig, + BaseTestFreeBSDNSSPAM, + BaseTestGenericNSSPAM, + BaseTestGenericSSSDBefore19, +

Re: [Freeipa-devel] [PATCH] 808 webui: service: add ipakrbrequirespreauth checkbox

2015-02-25 Thread Tomas Babej
On 02/25/2015 05:22 PM, Petr Vobornik wrote: Allow to configure missing krb ticket flag - ipakrbrequirespreauth from Web UI. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK, works