Re: [Freeipa-devel] [PATCH] 0039 Try continue ipa-client-automount even if nsslapd-minssf 0.

2015-02-26 Thread Rob Crittenden
Martin Basti wrote: On 26/02/15 10:57, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4902 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Works for me, ACK. NACK. If

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-26 Thread Gabe Alford
Yeah. That makes more sense. Updated patch attached. Thanks, Gabe On Wed, Feb 25, 2015 at 3:55 PM, Tomas Babej tba...@redhat.com wrote: Hi Gabe, sorry for not being clear. This approach will not work: +class TestAdvice(BaseTestInvalidAdvice, + BaseTestFedoraAuthconfig,

Re: [Freeipa-devel] [PATCH 0190] DNSSEC: add support for CKM_RSA_PKCS_OAEP mechanism

2015-02-26 Thread Martin Basti
On 26/02/15 12:47, Petr Spacek wrote: On 11.2.2015 14:10, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4657#comment:13 Patch attached. -- Martin Basti freeipa-mbasti-0190-DNSSEC-add-support-for-CKM_RSA_PKCS_OAEP-mechanism.patch From 4d698a5adaa94eb854c75bd9bcaf3093f31a11e5

Re: [Freeipa-devel] [PATCH 0195] Fix memory leaks in ipapkcs11helper module

2015-02-26 Thread Martin Basti
On 26/02/15 13:06, Petr Spacek wrote: Hello Martin, thank you for patch! This NACK is only aesthetic :-) On 25.2.2015 14:21, Martin Basti wrote: if (!check_return_value(rv, import_wrapped_key: key unwrapping)) { +error = 1; +goto final; +} This exact sequence is

Re: [Freeipa-devel] [PATCH] 0039 Try continue ipa-client-automount even if nsslapd-minssf 0.

2015-02-26 Thread David Kupka
On 02/26/2015 02:55 PM, Rob Crittenden wrote: Martin Basti wrote: On 26/02/15 10:57, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4902 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-02-26 Thread Martin Basti
On 26/02/15 10:45, Petr Spacek wrote: On 25.2.2015 17:49, Martin Basti wrote: On 25/02/15 17:15, Petr Spacek wrote: On 24.2.2015 19:10, Martin Basti wrote: Hello all, please read the design page, any objections/suggestions appreciated http://www.freeipa.org/page/V4/Server_Upgrade_Refactoring

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-26 Thread Tomas Babej
ACK. Pushed to: ipa-4-1: ddd7fb6a68fd413b1561eab9c29bac18882e5efd master: ae4ee6b53376bb7f3d1b4707c4e105c91b5cd8ab On 02/26/2015 05:58 PM, Gabe Alford wrote: Yeah. That makes more sense. Updated patch attached. Thanks, Gabe On Wed, Feb 25, 2015 at 3:55 PM, Tomas Babej tba...@redhat.com

Re: [Freeipa-devel] IPA Server upgrade 4.2 design

2015-02-26 Thread Petr Spacek
On 25.2.2015 17:49, Martin Basti wrote: On 25/02/15 17:15, Petr Spacek wrote: On 24.2.2015 19:10, Martin Basti wrote: Hello all, please read the design page, any objections/suggestions appreciated http://www.freeipa.org/page/V4/Server_Upgrade_Refactoring Thank you for the design, I have

[Freeipa-devel] [PATCH] 0039 Try continue ipa-client-automount even if nsslapd-minssf 0.

2015-02-26 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4902 -- David Kupka From 06f268e0c6435f3ba421787cf57e49c2ef2ac00d Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Thu, 26 Feb 2015 04:44:26 -0500 Subject: [PATCH] Try continue ipa-client-automount even if nsslapd-minssf 0. If

Re: [Freeipa-devel] [PATCH 0190] DNSSEC: add support for CKM_RSA_PKCS_OAEP mechanism

2015-02-26 Thread Petr Spacek
On 11.2.2015 14:10, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4657#comment:13 Patch attached. -- Martin Basti freeipa-mbasti-0190-DNSSEC-add-support-for-CKM_RSA_PKCS_OAEP-mechanism.patch From 4d698a5adaa94eb854c75bd9bcaf3093f31a11e5 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCHES 0001-0002] ipa-client-install NTP fixes

2015-02-26 Thread Martin Kosek
On 02/26/2015 03:28 AM, Nathan Kinder wrote: Hi, The two attached patches address some issues that affect ipa-client-install when syncing time from the NTP server. Now that we use ntpd to perform the time sync, the client install can end up hanging forever when the server is not reachable

Re: [Freeipa-devel] [PATCH] 0039 Try continue ipa-client-automount even if nsslapd-minssf 0.

2015-02-26 Thread Martin Basti
On 26/02/15 10:57, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4902 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Works for me, ACK. -- Martin Basti

Re: [Freeipa-devel] [PATCH 0195] Fix memory leaks in ipapkcs11helper module

2015-02-26 Thread Petr Spacek
Hello Martin, thank you for patch! This NACK is only aesthetic :-) On 25.2.2015 14:21, Martin Basti wrote: if (!check_return_value(rv, import_wrapped_key: key unwrapping)) { +error = 1; +goto final; +} This exact sequence is repeated many times in the code. I