Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-13 Thread Martin Babinsky
On 03/11/2015 12:42 PM, Petr Spacek wrote: diff --git a/ipaserver/rpcserver.py b/ipaserver/rpcserver.py index d6bc955b9d9910a24eec5df1def579310eb54786..36f16908ac8477d9982bfee613b77576853054eb 100644 --- a/ipaserver/rpcserver.py +++ b/ipaserver/rpcserver.py @@ -958,8 +958,8 @@ class

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Basti
On 13/03/15 11:55, Petr Spacek wrote: On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote:

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Kosek
On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to

Re: [Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

2015-03-13 Thread Sumit Bose
On Wed, Mar 04, 2015 at 06:42:05PM +0100, Sumit Bose wrote: Hi, this is the first patch for https://fedorahosted.org/freeipa/ticket/4922 which converts the check-based tests of the extdom plugin to cmocka. bye, Sumit Rebased version attached. bye, Sumit From

Re: [Freeipa-devel] [PATCHES 0001-0002] ipa-client-install NTP fixes

2015-03-13 Thread Martin Kosek
On 03/12/2015 09:43 PM, Nathan Kinder wrote: On 03/04/2015 11:25 AM, Nathan Kinder wrote: On 03/04/2015 10:58 AM, Martin Basti wrote: On 04/03/15 19:56, Nathan Kinder wrote: On 03/04/2015 10:41 AM, Rob Crittenden wrote: Nathan Kinder wrote: On 02/28/2015 01:13 PM, Nathan Kinder wrote:

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Petr Spacek
On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Alexander Bokovoy
On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Petr Spacek
On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Kosek
On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Petr Spacek
On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden

Re: [Freeipa-devel] [PATCHES 137-139] extdom: add err_msg member to request context

2015-03-13 Thread Sumit Bose
On Wed, Mar 04, 2015 at 06:35:22PM +0100, Sumit Bose wrote: Hi, this patch series improves error reporting of the extdom plugin especially on the client side. Currently there is only SSSD ticket https://fedorahosted.org/sssd/ticket/2463 . Shall I create a corresponding FreeIPA ticket as

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Jan Cholasta
Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On

Re: [Freeipa-devel] [PATCH 0044] Man pages: ipa-replica-prepare can only be created on first master

2015-03-13 Thread Gabe Alford
On Thu, Mar 12, 2015 at 8:26 AM, Martin Kosek mko...@redhat.com wrote: On 03/12/2015 02:37 PM, Gabe Alford wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/4944. Since there seems to be plenty of time, I added it to the freeipa-4-1 branch. Thanks Gabe! I would still

Re: [Freeipa-devel] Purpose of default user group

2015-03-13 Thread Petr Vobornik
Thanks all for the answers. On 03/10/2015 03:27 PM, Rob Crittenden wrote: Petr Vobornik wrote: In ipa migrate-ds we also set the group to all users who are not member of anything. Why is it important for a user to be a member of a group? Every POSIX user needs a default GID. We don't create

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Jan Cholasta
Dne 13.3.2015 v 12:08 Petr Spacek napsal(a): On 13.3.2015 12:01, Martin Basti wrote: On 13/03/15 11:55, Petr Spacek wrote: On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy

Re: [Freeipa-devel] [PATCH 0044] Man pages: ipa-replica-prepare can only be created on first master

2015-03-13 Thread Martin Kosek
On 03/13/2015 02:13 PM, Gabe Alford wrote: On Thu, Mar 12, 2015 at 8:26 AM, Martin Kosek mko...@redhat.com mailto:mko...@redhat.com wrote: On 03/12/2015 02:37 PM, Gabe Alford wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/4944. Since there seems to be

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Basti
On 13/03/15 12:50, Jan Cholasta wrote: Dne 13.3.2015 v 12:08 Petr Spacek napsal(a): On 13.3.2015 12:01, Martin Basti wrote: On 13/03/15 11:55, Petr Spacek wrote: On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote:

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Basti
On 13/03/15 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test

Re: [Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

2015-03-13 Thread Jakub Hrozek
On Fri, Mar 13, 2015 at 11:56:46AM +0100, Sumit Bose wrote: On Wed, Mar 04, 2015 at 06:42:05PM +0100, Sumit Bose wrote: Hi, this is the first patch for https://fedorahosted.org/freeipa/ticket/4922 which converts the check-based tests of the extdom plugin to cmocka. bye, Sumit

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Rob Crittenden
Jan Cholasta wrote: Dne 13.3.2015 v 12:08 Petr Spacek napsal(a): On 13.3.2015 12:01, Martin Basti wrote: On 13/03/15 11:55, Petr Spacek wrote: On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42,

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-13 Thread Simo Sorce
On Wed, 2015-03-11 at 12:42 +0100, Petr Spacek wrote: I would like to see new code compatible with Python 3. Here I'm not sure what is the generic solution for xrange but in this particular case I would recommend you to use just range. Attempts variable should have small values so the x/range

Re: [Freeipa-devel] [PATCH 0044] Man pages: ipa-replica-prepare can only be created on first master

2015-03-13 Thread Gabe Alford
Limitations is fine with me. Updated patch attached. On Fri, Mar 13, 2015 at 7:17 AM, Martin Kosek mko...@redhat.com wrote: On 03/13/2015 02:13 PM, Gabe Alford wrote: On Thu, Mar 12, 2015 at 8:26 AM, Martin Kosek mko...@redhat.com mailto:mko...@redhat.com wrote: On 03/12/2015 02:37 PM,

Re: [Freeipa-devel] [PATCH 0044] Man pages: ipa-replica-prepare can only be created on first master

2015-03-13 Thread Martin Kosek
On 03/13/2015 02:38 PM, Gabe Alford wrote: Limitations is fine with me. Updated patch attached. Works for me. I just changed the case of the subsection name to be consistent with man pages like ipa-client-install. Thanks Gabe! ACK. Pushed to: master:

Re: [Freeipa-devel] Purpose of default user group

2015-03-13 Thread Rob Crittenden
Petr Vobornik wrote: Thanks all for the answers. On 03/10/2015 03:27 PM, Rob Crittenden wrote: Petr Vobornik wrote: In ipa migrate-ds we also set the group to all users who are not member of anything. Why is it important for a user to be a member of a group? Every POSIX user needs a

[Freeipa-devel] [PATCH] ipatests: port of p11helper test from github

2015-03-13 Thread Milan Kubik
Hi, this is a patch with port of [1] to pytest. [1]: https://github.com/spacekpe/freeipa-pkcs11/blob/master/python/run.py Cheers, Milan From 0bbd56eb04e9494ed008d212dabdf32cf6f36e17 Mon Sep 17 00:00:00 2001 From: Milan Kubik mku...@redhat.com Date: Thu, 12 Mar 2015 16:52:33 +0100 Subject:

Re: [Freeipa-devel] [PATCHES 0204-0207, 0211] Server upgrade: Make LDAP data upgrade deterministic

2015-03-13 Thread Martin Basti
On 12/03/15 16:21, Rob Crittenden wrote: Martin Basti wrote: The patchset ensure, the upgrade order will respect ordering of entries in *.update files. Required for: https://fedorahosted.org/freeipa/ticket/4904 Patch 205 also fixes https://fedorahosted.org/freeipa/ticket/3560 Required patch

Re: [Freeipa-devel] [PATCHES 137-139] extdom: add err_msg member to request context

2015-03-13 Thread Jakub Hrozek
On Fri, Mar 13, 2015 at 11:55:09AM +0100, Sumit Bose wrote: On Wed, Mar 04, 2015 at 06:35:22PM +0100, Sumit Bose wrote: Hi, this patch series improves error reporting of the extdom plugin especially on the client side. Currently there is only SSSD ticket

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-13 Thread Martin Babinsky
Attaching the next iteration of patches. I have tried my best to reword the ipa-client-install man page bit about the new option. Any suggestions to further improve it are welcome. I have also slightly modified the 'kinit_keytab' function so that in Kerberos errors are reported for each