Re: [Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

2015-12-10 Thread Petr Spacek
On 10.12.2015 17:31, David Kupka wrote: > On 09/12/15 18:55, Petr Spacek wrote: >> On 9.12.2015 13:37, David Kupka wrote: >>> On 08/12/15 15:24, Petr Spacek wrote: On 8.12.2015 12:19, David Kupka wrote: > On 08/12/15 08:56, Petr Spacek wrote: >> On 7.12.2015 14:41, David Kupka wrote:

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-10 Thread Lukas Slebodnik
On (08/12/15 14:47), Tomas Babej wrote: > > >On 12/03/2015 04:33 PM, Tomas Babej wrote: >> >> >> On 12/03/2015 04:26 PM, Aleš Mareček wrote: >>> Hello, >>> >>> ACK for code >>> NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py >>> (this function should be in some more

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

2015-12-10 Thread Jan Cholasta
On 9.12.2015 16:38, Jan Cholasta wrote: On 9.12.2015 14:52, Jan Cholasta wrote: On 9.12.2015 10:02, Jan Cholasta wrote: Hi, the attached patches fix . Note that this needs selinux-policy fix to work, so put SELinux into permissive mode for

Re: [Freeipa-devel] [PATCH 0113] properly add ACIs to custodia container during IPA upgrade

2015-12-10 Thread Martin Babinsky
On 12/08/2015 10:45 AM, Martin Babinsky wrote: fixes https://fedorahosted.org/freeipa/ticket/5524 Attaching updated patch with simpler fix suggested by Jan. -- Martin^3 Babinsky From 9c7accdc7facec47e9a75f91168dca28db9e343d Mon Sep 17 00:00:00 2001 From: Martin Babinsky

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

2015-12-10 Thread Martin Basti
On 10.12.2015 09:13, Lukas Slebodnik wrote: On (09/12/15 19:22), Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5535 Patch attached. >From 8ef93485d61e8732166fb0c5b6c4559209740f3e Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 9 Dec 2015 18:53:35

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

2015-12-10 Thread Filip Škola
Hi, this if fixed. Also issues with test_stageuser_plugin caused by UserTracker changes should be fixed here. Filip On Mon, 7 Dec 2015 09:29:31 -0500 (EST) Aleš Mareček wrote: > NACK. > > $ ./make-lint > * Module ipatests.test_xmlrpc.test_user_plugin >

Re: [Freeipa-devel] [PATCHES 516-517] spec file: put Python modules into standalone packages

2015-12-10 Thread Jan Cholasta
On 9.12.2015 20:51, Petr Vobornik wrote: On 12/07/2015 04:21 PM, Jan Cholasta wrote: Hi, the attached patches partially fix . This is done to allow the addition of Python 3 packages, see

Re: [Freeipa-devel] [PATCH 0069] Add 'review' target for make

2015-12-10 Thread Petr Spacek
On 9.12.2015 15:30, Petr Spacek wrote: > Hello, > > this patch automates some of sanity checks proposed by Petr Vobornik. > > 'make review' should be used in root of clean Git tree which has patches under > review applied. > > Magic in review.sh attempts to detect nearest remote branch which

[Freeipa-devel] [PATCH 0376] KRA: add RA cert during replica promotion

2015-12-10 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5512 patch attached. From 75b69aee3e3911cdf66c0d6dd40c49fd0da61492 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 10 Dec 2015 13:46:07 +0100 Subject: [PATCH] Install RA cert during replica promotion This cert is needed with KRA

Re: [Freeipa-devel] [PATCH 0395] replicainstall: Make sure the enrollment state is preserved

2015-12-10 Thread Tomas Babej
On 12/10/2015 02:18 PM, Tomas Babej wrote: > Hi, > > During the promote_check phase, the subsequent checks after the machine > is enrolled may cause the installation to abort, hence leaving it > enrolled even though it might not have been prior to the execution of > the ipa-replica-install

Re: [Freeipa-devel] [PATCHES 509-514] replica promotion: use host credentials when setting up replication

2015-12-10 Thread Martin Babinsky
On 12/10/2015 07:57 AM, Jan Cholasta wrote: On 9.12.2015 16:39, Jan Cholasta wrote: On 7.12.2015 08:14, Jan Cholasta wrote: On 6.12.2015 21:32, Martin Basti wrote: On 04.12.2015 16:58, Simo Sorce wrote: On Fri, 2015-12-04 at 15:39 +0100, Jan Cholasta wrote: On 4.12.2015 15:16, Jan

Re: [Freeipa-devel] [PATCHES 516-517] spec file: put Python modules into standalone packages

2015-12-10 Thread Jan Cholasta
On 10.12.2015 11:32, Jan Cholasta wrote: On 9.12.2015 20:51, Petr Vobornik wrote: On 12/07/2015 04:21 PM, Jan Cholasta wrote: Hi, the attached patches partially fix . This is done to allow the addition of Python 3 packages, see

[Freeipa-devel] [PATCH 0395] replicainstall: Make sure the enrollment state is preserved

2015-12-10 Thread Tomas Babej
Hi, During the promote_check phase, the subsequent checks after the machine is enrolled may cause the installation to abort, hence leaving it enrolled even though it might not have been prior to the execution of the ipa-replica-install command. Make sure that ipa-client-install --uninstall is

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

2015-12-10 Thread Jan Cholasta
On 11.12.2015 07:08, Jan Cholasta wrote: On 10.12.2015 15:56, Martin Babinsky wrote: On 12/10/2015 09:48 AM, Jan Cholasta wrote: On 9.12.2015 16:38, Jan Cholasta wrote: On 9.12.2015 14:52, Jan Cholasta wrote: On 9.12.2015 10:02, Jan Cholasta wrote: Hi, the attached patches fix

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

2015-12-10 Thread Martin Basti
On 10.12.2015 15:49, Tomas Babej wrote: On 12/10/2015 11:23 AM, Martin Basti wrote: On 10.12.2015 09:13, Lukas Slebodnik wrote: On (09/12/15 19:22), Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5535 Patch attached. >From 8ef93485d61e8732166fb0c5b6c4559209740f3e Mon Sep 17

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

2015-12-10 Thread Jan Cholasta
On 10.12.2015 15:56, Martin Babinsky wrote: On 12/10/2015 09:48 AM, Jan Cholasta wrote: On 9.12.2015 16:38, Jan Cholasta wrote: On 9.12.2015 14:52, Jan Cholasta wrote: On 9.12.2015 10:02, Jan Cholasta wrote: Hi, the attached patches fix . Note

Re: [Freeipa-devel] [PATCH 0098-0099] domain level 1 topology checks during IPA server uninstall

2015-12-10 Thread Jan Cholasta
On 9.12.2015 16:22, Martin Babinsky wrote: On 12/09/2015 03:48 PM, Jan Cholasta wrote: On 2.12.2015 14:19, Martin Basti wrote: On 02.12.2015 14:10, Martin Basti wrote: On 02.12.2015 14:08, Martin Babinsky wrote: On 12/02/2015 10:45 AM, Martin Babinsky wrote: On 12/01/2015 02:40 PM,

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

2015-12-10 Thread Martin Babinsky
On 12/10/2015 09:48 AM, Jan Cholasta wrote: On 9.12.2015 16:38, Jan Cholasta wrote: On 9.12.2015 14:52, Jan Cholasta wrote: On 9.12.2015 10:02, Jan Cholasta wrote: Hi, the attached patches fix . Note that this needs selinux-policy fix to work,

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

2015-12-10 Thread Aleš Mareček
Ahoj Filipe, zase tam vidim to '\r\n'... Prisel jsi na to, co to zpusobuje? Jinak patche jdu otestovat... - alich - - Original Message - > From: "Filip Škola" > To: "Aleš Mareček" > Cc: freeipa-devel@redhat.com, "Milan Kubík"

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

2015-12-10 Thread Tomas Babej
On 12/10/2015 11:23 AM, Martin Basti wrote: > > > On 10.12.2015 09:13, Lukas Slebodnik wrote: >> On (09/12/15 19:22), Martin Basti wrote: >>> https://fedorahosted.org/freeipa/ticket/5535 >>> >>> Patch attached. >> >From 8ef93485d61e8732166fb0c5b6c4559209740f3e Mon Sep 17 00:00:00 2001 >>>

Re: [Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

2015-12-10 Thread David Kupka
On 09/12/15 18:55, Petr Spacek wrote: On 9.12.2015 13:37, David Kupka wrote: On 08/12/15 15:24, Petr Spacek wrote: On 8.12.2015 12:19, David Kupka wrote: On 08/12/15 08:56, Petr Spacek wrote: On 7.12.2015 14:41, David Kupka wrote: +def is_host_resolvable(fqdn): +if not isinstance(fqdn,