[Freeipa-devel] [PATCH 0374-0375] Fix permissions on newly created directories

Hello, patch 0374 fixes the ticket, but I found more issues with directory permission, I fixed them in 0375 https://fedorahosted.org/freeipa/ticket/5520 Patches attached. From ae0bcea3f6173bd6466d26a7d0cb2886029a10f6 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed,

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On 12/10/2015 09:05 AM, Lukas Slebodnik wrote: > On (08/12/15 14:47), Tomas Babej wrote: >> >> >> On 12/03/2015 04:33 PM, Tomas Babej wrote: >>> >>> >>> On 12/03/2015 04:26 PM, Aleš Mareček wrote: Hello, ACK for code NACK for the placing "get_client_ip_with_hostmask" function

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

Ah, sorry, haven't realized there had been devel list attached. Ok, there is some problem with \r\n in the patch. Filip, please take a look at it... Thanks... - alich - - Original Message - > From: "Filip Škola" > To: "Aleš Mareček" > Cc:

[Freeipa-devel] [PATCH 0116] CI tests: remove '-p' option from ipa-dns-install calls

See commit message. -- Martin^3 Babinsky From 108ce5787620227ef657c8e655dd3427655ebd06 Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Thu, 10 Dec 2015 16:32:35 +0100 Subject: [PATCH] CI tests: remove '-p' option from ipa-dns-install calls fix for

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

Hi, I don't know what is causing the \r\n issue. I use vim and than send each email with claws-mail. Didn't spot this issue when trying emailing the patch to my other address. I'm trying to send it from zimbra now, let me know if that helped pls. Fix for the stageuser plugin issues caused by

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On Mon, 7 Dec 2015 17:49:18 +0100 Milan Kubík wrote: > On 12/03/2015 08:15 PM, Filip Škola wrote: > > On Mon, 30 Nov 2015 17:18:30 +0100 > > Milan Kubík wrote: > > > >> On 11/23/2015 04:42 PM, Filip Škola wrote: > >>> Sending updated patch. > >>> > >>> F. >

Re: [Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

On 9.12.2015 13:37, David Kupka wrote: > On 08/12/15 15:24, Petr Spacek wrote: >> On 8.12.2015 12:19, David Kupka wrote: >>> On 08/12/15 08:56, Petr Spacek wrote: On 7.12.2015 14:41, David Kupka wrote: > +def is_host_resolvable(fqdn): > +if not isinstance(fqdn, DNSName): > +

Re: [Freeipa-devel] [PATCHES 516-517] spec file: put Python modules into standalone packages

On 12/10/2015 01:51 PM, Jan Cholasta wrote: On 10.12.2015 11:32, Jan Cholasta wrote: On 9.12.2015 20:51, Petr Vobornik wrote: On 12/07/2015 04:21 PM, Jan Cholasta wrote: Hi, the attached patches partially fix . This is done to allow the addition

Re: [Freeipa-devel] [TESTS][PATCH 0006] Add comments to stageuser plugin tests

On 09.12.2015 12:40, Martin Babinsky wrote: On 12/09/2015 11:29 AM, Lenka Doudova wrote: On 12/09/2015 10:13 AM, Martin Basti wrote: On 09.12.2015 09:41, Lenka Doudova wrote: Hi, attaching fixed patches for master and ipa-4-2 branch. Also fixes test accordingly to

[Freeipa-devel] [PATCH 0377] CI: fix test_vault installation on domain level 1

Patch attached. From 028049d455a12b4a5e97845e967aaf0b6103c0fc Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 9 Dec 2015 09:35:59 +0100 Subject: [PATCH] CI: fix ipa-kra-install on domain level 1 --- ipatests/test_integration/test_vault.py | 7 +-- 1 file changed,

Re: [Freeipa-devel] [PATCHES 529-530] ca install: use host credentials in domain level 1

On 10.12.2015 09:51, Jan Cholasta wrote: Hi, the attached patches fix . My patches 523-525 are required for this: . Honza Rebased patches attached. -- Jan Cholasta From

Re: [Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

On 08/12/15 15:24, Petr Spacek wrote: On 8.12.2015 12:19, David Kupka wrote: On 08/12/15 08:56, Petr Spacek wrote: On 7.12.2015 14:41, David Kupka wrote: +def is_host_resolvable(fqdn): +if not isinstance(fqdn, DNSName): +fqdn = DNSName(fqdn) +for rdtype in (rdatatype.A,

Re: [Freeipa-devel] [PATCH 0115] fix error message assertion in negative forced client reenrollment tests

On 08.12.2015 18:02, Martin Babinsky wrote: This patch fixes the assertions in negative test cases of 'test_forced_client_reenrollment' CI test suite. On ipa-4-2 it fixes https://fedorahosted.org/freeipa/ticket/5511 and makes all 8 tests in this suite green, shiny and happy again. It also

Re: [Freeipa-devel] [PATCHES 509-514] replica promotion: use host credentials when setting up replication

On 10.12.2015 15:01, Martin Babinsky wrote: On 12/10/2015 07:57 AM, Jan Cholasta wrote: On 9.12.2015 16:39, Jan Cholasta wrote: On 7.12.2015 08:14, Jan Cholasta wrote: On 6.12.2015 21:32, Martin Basti wrote: On 04.12.2015 16:58, Simo Sorce wrote: On Fri, 2015-12-04 at 15:39 +0100, Jan

Re: [Freeipa-devel] [PATCH 0069] Add 'review' target for make

On (10/12/15 18:04), Petr Spacek wrote: >On 9.12.2015 15:30, Petr Spacek wrote: >> Hello, >> >> this patch automates some of sanity checks proposed by Petr Vobornik. >> >> 'make review' should be used in root of clean Git tree which has patches >> under >> review applied. >> +1 for

[Freeipa-devel] [PATCH 0070] Makefile: disable parallel build

Hello, Makefile: disable parallel build IPA build system cannot cope with parallel build anyway, so this patch disables parallel build explicitly so it does not blow up when user has -j specified in default MAKEOPTS. -- Petr^2 Spacek From 6fe4d68d1357d3e7716ed3925b4d4a89f87f1a72 Mon Sep 17

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

On 09.12.2015 11:14, Oleg Fayans wrote: Hi Martin On 12/09/2015 10:30 AM, Martin Basti wrote: On 08.12.2015 23:48, Oleg Fayans wrote: Substituted a hardcoded suffix name with a constant DOMAIN_SUFFIX_NAME On 12/08/2015 02:33 PM, Oleg Fayans wrote: Hi all, The patches are rebased

Re: [Freeipa-devel] [PATCH 0071] replica: Fix ipa-replica-install with replica file (domain, level 0).

On 12/09/2015 08:31 AM, David Kupka wrote: > On 08/12/15 16:33, Tomas Babej wrote: >> >> >> On 12/08/2015 04:20 PM, Oleg Fayans wrote: >>> ACK. The initial issue is fixed. >>> >>> On 12/08/2015 03:03 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/5531 >>> >> >> Can

Re: [Freeipa-devel] [PATCH 0395] replicainstall: Make sure the enrollment state is preserved

On 12/11/2015 06:05 PM, Martin Basti wrote: > > > On 11.12.2015 14:03, Tomas Babej wrote: >> >> On 12/10/2015 02:22 PM, Tomas Babej wrote: >>> >>> On 12/10/2015 02:18 PM, Tomas Babej wrote: Hi, During the promote_check phase, the subsequent checks after the machine is

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

On 12/11/2015 05:37 PM, Martin Basti wrote: > > > On 11.12.2015 15:40, Jan Cholasta wrote: >> On 11.12.2015 08:03, Jan Cholasta wrote: >>> On 11.12.2015 07:08, Jan Cholasta wrote: On 10.12.2015 15:56, Martin Babinsky wrote: > On 12/10/2015 09:48 AM, Jan Cholasta wrote: >> On

Re: [Freeipa-devel] [PATCH 0111] prevent crashes of server uninstall check caused by failed, 5 LDAP connections

On 07.12.2015 16:05, Martin Babinsky wrote: On 12/04/2015 08:49 PM, Rob Crittenden wrote: Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5409 Should it also warn about the potential loss of the DNSSEC master? rob Probably, but that warrants a separate ticket IMHO. IIRC

Re: [Freeipa-devel] [PATCH 0395] replicainstall: Make sure the enrollment state is preserved

On 11.12.2015 14:03, Tomas Babej wrote: On 12/10/2015 02:22 PM, Tomas Babej wrote: On 12/10/2015 02:18 PM, Tomas Babej wrote: Hi, During the promote_check phase, the subsequent checks after the machine is enrolled may cause the installation to abort, hence leaving it enrolled even though

Re: [Freeipa-devel] [PATCH 0018] Fixed install_ca and install_kra failures at domain level 0

On 11.12.2015 17:28, Oleg Fayans wrote: +myre = re.compile(".*Backed up to (?P.*?)\n.*") IMO this regexp is not good. 1) please name it better than "myre" 2) initial '.*' is not needed because regexp does not start with '^' and you use search() later 3) trailing '.*' is not needed

[Freeipa-devel] [PATCHES 529-530] ca install: use host credentials in domain level 1

Hi, the attached patches fix . My patches 523-525 are required for this: . Honza -- Jan Cholasta From 4bcb399365501265ee062020ff9ef80fd6235a66 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On (09/12/15 19:22), Martin Basti wrote: >https://fedorahosted.org/freeipa/ticket/5535 > >Patch attached. >From 8ef93485d61e8732166fb0c5b6c4559209740f3e Mon Sep 17 00:00:00 2001 >From: Martin Basti >Date: Wed, 9 Dec 2015 18:53:35 +0100 >Subject: [PATCH] Fix version comparison

[Freeipa-devel] [PATCH] Add 'review' target for make

Hello, this patch automates some of sanity checks proposed by Petr Vobornik. 'make review' should be used in root of clean Git tree which has patches under review applied. Magic in review.sh attempts to detect nearest remote branch which can be used as diff base for review. Please see review.sh

Re: [Freeipa-devel] [PATCH 0115] fix error message assertion in negative forced client reenrollment tests

On (08/12/15 18:02), Martin Babinsky wrote: >This patch fixes the assertions in negative test cases of >'test_forced_client_reenrollment' CI test suite. > >On ipa-4-2 it fixes https://fedorahosted.org/freeipa/ticket/5511 and makes >all 8 tests in this suite green, shiny and happy again. > >It also

[Freeipa-devel] [PATCH] 0047 dogtaginstance: remove unused function 'check_inst'

Just some drive-by cleanup of an unused function. Cheers, Fraser From 6eb963aac30376a1d86bbdc4b9ce299cbec5220a Mon Sep 17 00:00:00 2001 From: Fraser Tweedale Date: Mon, 14 Dec 2015 16:52:40 +1100 Subject: [PATCH] dogtaginstance: remove unused function 'check_inst' ---

Re: [Freeipa-devel] [PATCH 0373] Upgrade: Fix IPA version comparison

On 11.12.2015 19:01, Tomas Babej wrote: On 12/11/2015 09:36 AM, Martin Kosek wrote: On 12/10/2015 05:09 PM, Martin Basti wrote: On 10.12.2015 15:49, Tomas Babej wrote: On 12/10/2015 11:23 AM, Martin Basti wrote: On 10.12.2015 09:13, Lukas Slebodnik wrote: On (09/12/15 19:22), Martin

Re: [Freeipa-devel] [PATCHES 523-525] replica install: add remote connection check over API

On 11.12.2015 18:49, Tomas Babej wrote: On 12/11/2015 05:37 PM, Martin Basti wrote: On 11.12.2015 15:40, Jan Cholasta wrote: On 11.12.2015 08:03, Jan Cholasta wrote: On 11.12.2015 07:08, Jan Cholasta wrote: On 10.12.2015 15:56, Martin Babinsky wrote: On 12/10/2015 09:48 AM, Jan Cholasta

Re: [Freeipa-devel] [PATCHES 529-530] ca install: use host credentials in domain level 1

On 11.12.2015 17:24, Martin Basti wrote: On 11.12.2015 15:00, Jan Cholasta wrote: On 10.12.2015 09:51, Jan Cholasta wrote: Hi, the attached patches fix . My patches 523-525 are required for this:

Re: [Freeipa-devel] [PATCH] 0751 spec: Split out python-ipap11helper and, python-default_encoding_utf8

On 4.12.2015 14:29, Jan Cholasta wrote: Hi, On 3.12.2015 17:32, Petr Viktorin wrote: Hello, This specfile patch makes python-ipalib noarch, by splitting out the arch-dependent stuff. I'm not sure if this should be done at all. Both py_default_encoding and (especially) _ipap11helper are