Re: [Freeipa-devel] [PATCH 0125] IPA upgrade: move replication ACIs to the mapping tree entry

2016-01-12 Thread Jan Cholasta
On 12.1.2016 19:13, Martin Babinsky wrote: commit 6ea868e172738bdd6a8fae34e65126cdd134bbbe broke replica install and management on IPA servers upgraded from pre-4.3 version. The attached patch fixes this. https://fedorahosted.org/freeipa/ticket/5575 Any reason to repeat the DN 3 times?

Re: [Freeipa-devel] [PATCH] 0048 Decode HTTP reason phrase as iso-8859-1

2016-01-12 Thread Jan Cholasta
On 8.1.2016 11:56, Fraser Tweedale wrote: On Thu, Jan 07, 2016 at 08:00:51PM +1000, Fraser Tweedale wrote: On Thu, Jan 07, 2016 at 07:56:15AM +0100, Jan Cholasta wrote: Hi, On 6.1.2016 05:26, Fraser Tweedale wrote: Happy new year, all. The attached patch fixes a unicode decode error

Re: [Freeipa-devel] [PATCH 0001] ipa-server-certinstall should not tell certmonger to track 3rd party certificates

2016-01-12 Thread Jan Cholasta
Hi Thorsten, thanks for the patch, but unfortunately it isn't as simple as this - if the provided certificate was issued by our CA, we should still track it. As part of installer improvements in 4.4, we plan to always track all certificates, even 3rd party ones (this way we can have the same

Re: [Freeipa-devel] [PATCHES 0396-0397] DNSSEC CI: fix tests

2016-01-12 Thread Martin Babinsky
On 01/06/2016 06:05 PM, Martin Basti wrote: Patches attached. ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0077-8] ipa-replica-prepare: Add '--auto-reverse' and, '--allow-zone-overlap' options

2016-01-12 Thread Martin Basti
On 22.12.2015 16:19, Petr Spacek wrote: On 22.12.2015 15:14, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/5563 NACK: $ ipa-replica-prepare vm-058-106.abc.idm.lab.eng.brq.redhat.com --ip-address=10.34.58.106 --reverse-zone=58.34.10.in-addr.arpa. Directory Manager (existing

Re: [Freeipa-devel] [PATCH 536] ipapython: remove default_encoding_utf8

2016-01-12 Thread Jan Cholasta
On 6.1.2016 12:33, Christian Heimes wrote: On 2016-01-05 11:30, Tomas Babej wrote: On 01/05/2016 08:54 AM, Jan Cholasta wrote: Hi, the attached patch replaces the default_encoding_utf8 binary module with 2 lines of equivalent Python code. Honza This looks fine to me, however, I

Re: [Freeipa-devel] [PATCH 0122-0123] reimplementation of package version comparison code

2016-01-12 Thread Martin Babinsky
On 01/11/2016 06:38 PM, Martin Basti wrote: On 11.01.2016 17:58, Jan Cholasta wrote: On 11.1.2016 16:29, Martin Babinsky wrote: On 01/11/2016 02:27 PM, Martin Babinsky wrote: On 01/11/2016 02:01 PM, Jan Cholasta wrote: On 11.1.2016 13:14, Martin Babinsky wrote: On 01/11/2016 07:47 AM, Jan

Re: [Freeipa-devel] [PATCHES 0396-0397] DNSSEC CI: fix tests

2016-01-12 Thread Martin Basti
On 12.01.2016 10:44, Martin Babinsky wrote: On 01/06/2016 06:05 PM, Martin Basti wrote: Patches attached. ACK Pushed to: master: 34b197afa4beb0a84ca01cb594c39859abdc4706 ipa-4-3: d2c103df5d3bec3fbaafb854291a5ab245c436f8 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-12 Thread Martin Basti
On 12.01.2016 10:19, Jan Cholasta wrote: On 12.1.2016 09:32, Martin Basti wrote: On 07.01.2016 14:13, Jan Cholasta wrote: On 7.1.2016 09:50, Jan Cholasta wrote: Hi, the attached patch ports the _ipap11helper module to python-cffi. Combined with my patch 536 [1], this makes ipapython

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-12 Thread Martin Basti
On 12.01.2016 12:24, Jan Cholasta wrote: On 12.1.2016 12:17, Martin Basti wrote: On 12.01.2016 10:19, Jan Cholasta wrote: On 12.1.2016 09:32, Martin Basti wrote: On 07.01.2016 14:13, Jan Cholasta wrote: On 7.1.2016 09:50, Jan Cholasta wrote: Hi, the attached patch ports the

Re: [Freeipa-devel] [PATCH 0003] Refactor test_replace

2016-01-12 Thread Milan Kubík
On 12/04/2015 11:29 AM, Filip Škola wrote: On Fri, 4 Dec 2015 10:08:40 +0100 Milan Kubík wrote: On 12/04/2015 10:04 AM, Filip Škola wrote: Hi, sending rather short one this time. F. NACK, UserTracker is implemented in ipatests.test_xmlrpc.tracker.user_plugin. Ah,

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-12 Thread Petr Viktorin
On 01/11/2016 02:49 PM, Martin Basti wrote: > > > On 08.01.2016 12:45, Petr Viktorin wrote: >> On 01/06/2016 03:28 PM, Petr Viktorin wrote: >>> Hello, >>> >>> Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except >>> "no-absolute-import" (which seems redundant to me) and the ones

Re: [Freeipa-devel] Design: Automatic Empty Zone handling in bind-dyndb-ldap

2016-01-12 Thread Petr Spacek
On 8.1.2016 18:14, Martin Basti wrote: > > > On 08.01.2016 16:57, Petr Spacek wrote: >> Hello, >> >> recent improvements in FreeIPA 4.3.0 (finally) prevent FreeIPA installer from >> creating made-up DNS reverse zones, which already exist on some other DNS >> server. >> >> This change uncovered a

Re: [Freeipa-devel] Design: Automatic Empty Zone handling in bind-dyndb-ldap

2016-01-12 Thread Martin Basti
On 12.01.2016 15:06, Petr Spacek wrote: On 8.1.2016 18:14, Martin Basti wrote: On 08.01.2016 16:57, Petr Spacek wrote: Hello, recent improvements in FreeIPA 4.3.0 (finally) prevent FreeIPA installer from creating made-up DNS reverse zones, which already exist on some other DNS server.

[Freeipa-devel] [PATCH 0125] IPA upgrade: move replication ACIs to the mapping tree entry

2016-01-12 Thread Martin Babinsky
commit 6ea868e172738bdd6a8fae34e65126cdd134bbbe broke replica install and management on IPA servers upgraded from pre-4.3 version. The attached patch fixes this. https://fedorahosted.org/freeipa/ticket/5575 -- Martin^3 Babinsky From 44ece4b282cbfd5b090ce17e7eb6fef46e1660cc Mon Sep 17 00:00:00

Re: [Freeipa-devel] [PATCH 0122-0123] reimplementation of package version comparison code

2016-01-12 Thread Martin Babinsky
On 01/12/2016 01:03 PM, Martin Basti wrote: On 12.01.2016 10:23, Martin Babinsky wrote: On 01/11/2016 06:38 PM, Martin Basti wrote: On 11.01.2016 17:58, Jan Cholasta wrote: On 11.1.2016 16:29, Martin Babinsky wrote: On 01/11/2016 02:27 PM, Martin Babinsky wrote: On 01/11/2016 02:01 PM,

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2016-01-12 Thread Milan Kubik
Hello, sorry for delays. The patch no longer applies to master. Rebase it, please. Milan - Original Message - From: "Filip Škola" To: "Milan Kubík" Cc: freeipa-devel@redhat.com Sent: Wednesday, 9 December, 2015 7:01:02 PM Subject: Re:

Re: [Freeipa-devel] [PATCH 0088] Don't error when find_base() fails if a base is not required

2016-01-12 Thread Martin Basti
On 11.01.2016 18:05, Martin Basti wrote: On 11.01.2016 17:52, Nathaniel McCallum wrote: On Mon, 2016-01-11 at 17:45 +0100, Martin Basti wrote: On 14.12.2015 16:22, Nathaniel McCallum wrote: We always have to call find_base() in order to force libldap to open the socket. However, if no

[Freeipa-devel] [PATCH 0401] Pylint enable unbalanced tuple unpacking check

2016-01-12 Thread Martin Basti
Patch attached. From ac8af289c283aaf44d7ac42e1b8bfeecc417e59c Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 17 Dec 2015 16:07:10 +0100 Subject: [PATCH] Enable pylint unbalanced-tuple-unpacking check Enables check and fixes one issue. get_entries can be replaced by

Re: [Freeipa-devel] [PATCH 0122-0123] reimplementation of package version comparison code

2016-01-12 Thread Martin Basti
On 12.01.2016 10:23, Martin Babinsky wrote: On 01/11/2016 06:38 PM, Martin Basti wrote: On 11.01.2016 17:58, Jan Cholasta wrote: On 11.1.2016 16:29, Martin Babinsky wrote: On 01/11/2016 02:27 PM, Martin Babinsky wrote: On 01/11/2016 02:01 PM, Jan Cholasta wrote: On 11.1.2016 13:14,

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

2016-01-12 Thread Milan Kubik
Hi, the patch no longer applies to master. Please rebase it. Thanks, Milan - Original Message - From: "Filip Skola" To: freeipa-devel@redhat.com Cc: "Milan Kubík" , "Aleš Mareček" Sent: Tuesday, 22 December, 2015 11:56:15 AM

Re: [Freeipa-devel] [PATCH 0122-0123] reimplementation of package version comparison code

2016-01-12 Thread Martin Basti
On 12.01.2016 13:14, Martin Babinsky wrote: On 01/12/2016 01:03 PM, Martin Basti wrote: On 12.01.2016 10:23, Martin Babinsky wrote: On 01/11/2016 06:38 PM, Martin Basti wrote: On 11.01.2016 17:58, Jan Cholasta wrote: On 11.1.2016 16:29, Martin Babinsky wrote: On 01/11/2016 02:27 PM,

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-12 Thread Petr Viktorin
>> Hello I tried --py3k option and it doesn't print any error, can we >> enable that check by default to prevent python3 regressions? >> >> # ./make-lint --py3k >> No config file found, using default configuration > > Squash in the other attached patch to enable it by default. Sorry, please

[Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta From 8a1327f8810608c958da985bf3b304c12376849e Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Tue, 12 Jan 2016 15:41:43 +0100 Subject: [PATCH] ipalib: assume version 2.0

Re: [Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Martin Kosek
On 01/12/2016 03:46 PM, Jan Cholasta wrote: > Hi, > > the attached patch fixes . > > Honza I see you set the version to 2.0. As I am reading https://bugzilla.redhat.com/show_bug.cgi?id=1297811#c1 , shouldn't the minimal version be set to something

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-12 Thread Martin Basti
On 12.01.2016 14:44, Jan Cholasta wrote: On 12.1.2016 13:32, Martin Basti wrote: On 12.01.2016 12:24, Jan Cholasta wrote: On 12.1.2016 12:17, Martin Basti wrote: On 12.01.2016 10:19, Jan Cholasta wrote: On 12.1.2016 09:32, Martin Basti wrote: On 07.01.2016 14:13, Jan Cholasta wrote:

Re: [Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Jan Pazdziora
On Tue, Jan 12, 2016 at 03:58:49PM +0100, Martin Kosek wrote: > On 01/12/2016 03:46 PM, Jan Cholasta wrote: > > Hi, > > > > the attached patch fixes . > > > > Honza > > I see you set the version to 2.0. As I am reading >

Re: [Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Martin Basti
On 12.01.2016 16:07, Jan Cholasta wrote: On 12.1.2016 15:58, Martin Kosek wrote: On 01/12/2016 03:46 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza I see you set the version to 2.0. As I am reading