Re: [Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

2016-01-28 Thread Martin Babinsky
On 01/28/2016 03:20 PM, Tomas Babej wrote: On 01/27/2016 03:58 PM, Martin Babinsky wrote: On 01/18/2016 06:43 PM, Martin Babinsky wrote: A little patch that should make some future pylint errors disappear. Attaching updated patch that does not promote direct molestation of instance

[Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled

2016-01-28 Thread Petr Vobornik
Reworks also sessionStorage test because disablement of cookies might be connected with sessionStorage and localStorage. E.g. Chrome raises exception when *Storage is accessed with "Block sites from setting any data" settings set in "Content Settings/Cookies" section.

Re: [Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

2016-01-28 Thread Tomas Babej
On 01/28/2016 04:44 PM, Martin Babinsky wrote: > On 01/28/2016 03:20 PM, Tomas Babej wrote: >> >> >> On 01/27/2016 03:58 PM, Martin Babinsky wrote: >>> On 01/18/2016 06:43 PM, Martin Babinsky wrote: A little patch that should make some future pylint errors disappear. >>>

Re: [Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

2016-01-28 Thread Martin Babinsky
On 01/28/2016 05:06 PM, Tomas Babej wrote: On 01/28/2016 04:44 PM, Martin Babinsky wrote: On 01/28/2016 03:20 PM, Tomas Babej wrote: On 01/27/2016 03:58 PM, Martin Babinsky wrote: On 01/18/2016 06:43 PM, Martin Babinsky wrote: A little patch that should make some future pylint errors

Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled

2016-01-28 Thread Tomas Babej
On 01/28/2016 04:15 PM, Petr Vobornik wrote: > Reworks also sessionStorage test because disablement of cookies might be > connected with sessionStorage and localStorage. E.g. Chrome raises > exception when *Storage is accessed with "Block sites from setting any > data" settings set in "Content

Re: [Freeipa-devel] [PATCH 154] ipa-kdb: map_groups() consider all results

2016-01-28 Thread Alexander Bokovoy
On Tue, 05 Jan 2016, Sumit Bose wrote: Hi, to find out to which local group a external user is mapped we do a dereference search over the external groups with the SIDs related to the external user. If a SID is mapped to more than one external group we currently consider only the first returned

Re: [Freeipa-devel] [PATCH 0011-0012][RFE] ipa-replica-manage: automatically clean dangling RUVs

2016-01-28 Thread Stanislav Laznicka
On 01/26/2016 06:56 PM, Martin Basti wrote: On 25.01.2016 16:41, Stanislav Laznicka wrote: Hi, Worked those comments into the code. Also added a bit different info message in clean_ruv with ca=True (ipa-replica-manage:430). Also adding stepst to reproduce: 1. Create a master and some

Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled

2016-01-28 Thread Petr Vobornik
On 01/28/2016 04:23 PM, Tomas Babej wrote: On 01/28/2016 04:15 PM, Petr Vobornik wrote: Reworks also sessionStorage test because disablement of cookies might be connected with sessionStorage and localStorage. E.g. Chrome raises exception when *Storage is accessed with "Block sites from

Re: [Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

2016-01-28 Thread Pavel Vomacka
Hello, On 01/28/2016 12:20 PM, Pavel Vomacka wrote: 'Issue new certificate' dialog now validates whether user fills 'principal' and 'csr' field. In case that one of these fields is empty then it does not allow to submit the dialog. https://fedorahosted.org/freeipa/ticket/5432 I'm sending

Re: [Freeipa-devel] New tool tips for Refresh, Revert, Undo and Undo All buttons

2016-01-28 Thread Petr Vobornik
On 01/25/2016 01:55 PM, Pavel Vomacka wrote: Hello everyone, I just made a patch for the https://fedorahosted.org/freeipa/ticket/5428 ticket. The patch adds tool tips to the buttons in detail views. The text of new tool tips is written in the comment of the ticket. Pavel Vomacka Intern Hi,

Re: [Freeipa-devel] [TEST][Patch 0020] Enabled recreation of test directory during ipa reinstallation

2016-01-28 Thread Oleg Fayans
Fellas, can anyone spend a free moment to review this? On 01/27/2016 09:24 AM, Oleg Fayans wrote: > Hi guys, > > Any chance this can be reviewed any time soon? > > On 01/21/2016 12:59 PM, Oleg Fayans wrote: >> >> >> > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2016-01-28 Thread Filip Skola
- Original Message - > On 01/25/2016 11:11 AM, Filip Skola wrote: > > > > - Original Message - > >> On 01/15/2016 03:38 PM, Filip Skola wrote: > >>> Hi, > >>> > >>> sending rebased patch. > >>> > >>> F. > >>> > >>> - Original Message - > Hello, > > sorry

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

2016-01-28 Thread Filip Skola
- Original Message - > On 01/18/2016 02:26 PM, Filip Skola wrote: > > Hi, > > > > this should be fixed in this patch. > > > > F. > > > > - Original Message - > >> On 01/15/2016 03:37 PM, Filip Skola wrote: > >>> Hi, > >>> > >>> sending rebased patch. > >>> > >>> F. > >>> > >>>

Re: [Freeipa-devel] [PATCH 0030] Modernize mod_nss's cipher suites

2016-01-28 Thread Martin Basti
On 22.01.2016 12:32, Martin Kosek wrote: On 01/21/2016 04:21 PM, Christian Heimes wrote: The list of supported TLS cipher suites in /etc/httpd/conf.d/nss.conf has been modernized. Insecure or less secure algorithms such as RC4, DES and 3DES are removed. Perfect forward secrecy suites with

Re: [Freeipa-devel] [TEST][Patch 0021] Fixed recent replica installation issues in the lab

2016-01-28 Thread Oleg Fayans
Guys, could you take a look at this one? On 01/27/2016 11:16 AM, Oleg Fayans wrote: > Sorry, trailing whitespace detected. This version passes lint > > On 01/27/2016 09:23 AM, Oleg Fayans wrote: >> Hi, >> >> On 01/21/2016 04:41 PM, Petr Spacek wrote: >>> Hello, >>> >>> On 21.1.2016 13:42, Oleg

Re: [Freeipa-devel] [PATCH 154] ipa-kdb: map_groups() consider all results

2016-01-28 Thread Petr Vobornik
On 01/05/2016 07:55 PM, Sumit Bose wrote: Hi, to find out to which local group a external user is mapped we do a dereference search over the external groups with the SIDs related to the external user. If a SID is mapped to more than one external group we currently consider only the first

[Freeipa-devel] [PATCH] 0008 Refactor test_sudocmdgroup_plugin, create SudoCmdGroupTracker

2016-01-28 Thread Filip Skola
Hi, sending the next sudo patch. This one depends on the previous one (sudocmd_plugin). Filip From 9aab785cf39233998f42917b10cab3ef976f91f1 Mon Sep 17 00:00:00 2001 From: Filip Skola Date: Thu, 28 Jan 2016 11:57:08 +0100 Subject: [PATCH] Refactor test_sudocmdgroup_plugin,

[Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

2016-01-28 Thread Pavel Vomacka
Hello, I made a patch for the https://fedorahosted.org/freeipa/ticket/5432 ticket. All Issue new certificate dialogs now validates input data. -- Pavel Vomacka >From 2d323f8cf997af594de01405b9d242360f625b86 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka Date: Thu, 28 Jan

Re: [Freeipa-devel] [PATCH 0131] fix standalone installation of externally signed CA on IPA master

2016-01-28 Thread Martin Basti
On 26.01.2016 13:44, Martin Babinsky wrote: On 01/26/2016 01:06 PM, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5636 This also happens on ipa-4-3/master but the offending check was moved around. Attaching patch for 4-3/master branches. ACK for master and ipa-4-3 I

Re: [Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

2016-01-28 Thread Tomas Babej
On 01/27/2016 03:58 PM, Martin Babinsky wrote: > On 01/18/2016 06:43 PM, Martin Babinsky wrote: >> A little patch that should make some future pylint errors disappear. >> >> >> > Attaching updated patch that does not promote direct molestation of > instance dictionaries. > > > Patch looks

Re: [Freeipa-devel] [PATCH 0131] fix standalone installation of externally signed CA on IPA master

2016-01-28 Thread Martin Basti
On 28.01.2016 14:49, Martin Basti wrote: On 26.01.2016 13:44, Martin Babinsky wrote: On 01/26/2016 01:06 PM, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5636 This also happens on ipa-4-3/master but the offending check was moved around. Attaching patch for 4-3/master