Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

Hi, On 29.1.2016 15:49, Martin Basti wrote: On 29.01.2016 15:49, Stanislav Laznicka wrote: Reworded the commits so that they better reflect what's going on in those. On 01/29/2016 02:49 PM, Stanislav Laznicka wrote: Hello, I made some patches based on the Coverity report from 18.1.2016. C

Re: [Freeipa-devel] [PATCH 0411] upgrade: log to ipaupgrade.log if ipa is not installed

On 29.01.2016 12:12, Martin Kosek wrote: On 01/29/2016 10:48 AM, Martin Basti wrote: Missing record in ipaupgrade.log that upgrade failed because IPA is not installed, causes harder time to debugging upgrade from log. Patch attached. I am thinking that in these general catch-all clauses, it

Re: [Freeipa-devel] [TEST][Patch 0021] Fixed recent replica installation issues in the lab

Hi Petr, Please find the new version of the patch attached. Comments are inline On 01/29/2016 11:58 AM, Petr Spacek wrote: > On 27.1.2016 11:16, Oleg Fayans wrote: >> Sorry, trailing whitespace detected. This version passes lint >> >> On 01/27/2016 09:23 AM, Oleg Fayans wrote: Hi,

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

On 1.2.2016 09:03, Jan Cholasta wrote: > Hi, > > On 29.1.2016 15:49, Martin Basti wrote: >> >> >> On 29.01.2016 15:49, Stanislav Laznicka wrote: >>> Reworded the commits so that they better reflect what's going on in those. >>> >>> On 01/29/2016 02:49 PM, Stanislav Laznicka wrote: Hello,

[Freeipa-devel] [TEST][Patch 0023] Updated connect/disconnect replica to work on both domain levels

-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 6842d2c1d068853f16f42df893112cb1e8d716ff Mon Sep 17 00:00:00 2001 From: Oleg Fayans Date: Mon, 1 Feb 2016 11:34:11 +0100 Subject: [PATCH] Updated connect/disconnect replica to work with both domainlevels --- ipatests/test_integration/t

Re: [Freeipa-devel] [TEST][Patch 0021] Fixed recent replica installation issues in the lab

On 1.2.2016 11:52, Oleg Fayans wrote: > Hi Petr, > > Please find the new version of the patch attached. Comments are inline > > On 01/29/2016 11:58 AM, Petr Spacek wrote: >> On 27.1.2016 11:16, Oleg Fayans wrote: >>> Sorry, trailing whitespace detected. This version passes lint >>> >>> On 01/27/2

Re: [Freeipa-devel] [PATCH 562-563] Fix ipa-sam to use the getkeytab control instead of the setkeytab control

On 14.01.2016 10:01, Alexander Bokovoy wrote: On Thu, 14 Jan 2016, Martin Basti wrote: On 14.01.2016 08:24, Alexander Bokovoy wrote: On Thu, 03 Dec 2015, Simo Sorce wrote: The first patch is preparatory and is needed in general now that we want top allow alias and use krbCanonicalName as

[Freeipa-devel] [PATCH 0132] always start certmonger during IPA server configuration upgrade

https://fedorahosted.org/freeipa/ticket/5655 -- Martin^3 Babinsky From bfa239bd1ac71f89a54f8be548432b89b2f527dd Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Mon, 1 Feb 2016 12:59:04 +0100 Subject: [PATCH] always start certmonger during IPA server configuration upgrade This patch fixes

Re: [Freeipa-devel] [PATCH 0407] make lint: migration to config file and pylint plugin due pylint 1.5.2

On 26.01.2016 14:16, Martin Basti wrote: On 20.01.2016 14:38, Jan Cholasta wrote: Hi, On 19.1.2016 13:43, Martin Basti wrote: New pylint version will broke our custom make-lint script again, attached patch migrates make-lint to: * config file * pylint plugin which are supported by pylint a

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

On 1.2.2016 12:11, Petr Spacek wrote: On 1.2.2016 09:03, Jan Cholasta wrote: Hi, On 29.1.2016 15:49, Martin Basti wrote: On 29.01.2016 15:49, Stanislav Laznicka wrote: Reworded the commits so that they better reflect what's going on in those. On 01/29/2016 02:49 PM, Stanislav Laznicka wrot

Re: [Freeipa-devel] [PATCH 542] replica install: validate DS and HTTP server certificates

On 27.01.2016 09:10, Martin Babinsky wrote: On 01/25/2016 08:29 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza You may need to rebase the patch on top of ipa-4-2, otherwise ACK. Pushed to: master: 465ce82a4d098c4c419913f30a1a0

Re: [Freeipa-devel] [PATCH 0132] always start certmonger during IPA server configuration upgrade

On 01.02.2016 13:55, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5655 LGTM, works for me, tested on both ca-less server and CA-full server. Because patch is touching certmonger I would like to get final ACK from Honza. -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 0126-0127] reset openldap client config to point to freshly promote replica

On 29.01.2016 18:06, Martin Basti wrote: On 29.01.2016 09:01, Martin Babinsky wrote: On 01/20/2016 09:40 AM, Martin Babinsky wrote: On 01/14/2016 05:29 PM, Martin Babinsky wrote: On 01/13/2016 05:59 PM, Rob Crittenden wrote: Martin Babinsky wrote: fixes https://fedorahosted.org/freeipa/t

Re: [Freeipa-devel] [TEST][Patch 0023] Updated connect/disconnect replica to work on both domain levels

On 01.02.2016 12:21, Oleg Fayans wrote: ACK Pushed to: master: aa30199e0b6002aeb8c01e2561a3d55fe3f1ceb5 ipa-4-3: a8775de8aaca56a2f589d5aebe957f78ffc66c16 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to Fre

Re: [Freeipa-devel] [PATCH 154] ipa-kdb: map_groups() consider all results

On Tue, Jan 05, 2016 at 07:55:33PM +0100, Sumit Bose wrote: > Hi, > > to find out to which local group a external user is mapped we do a > dereference search over the external groups with the SIDs related to the > external user. If a SID is mapped to more than one external group we > currently con