Re: [Freeipa-devel] Converting plugin output

2016-03-22 Thread Christian Heimes
On 2016-03-21 12:02, Jan Cholasta wrote: > Hi, > > On 18.3.2016 15:26, Christian Heimes wrote: >> Hi, >> >> I'd like to use FreeIPA's RPC interface from Ansible directly. But the >> output of plugins is rather unfriendly and unpythonic: >> > print(api.Command.dnsconfig_show()) >> {u'result':

Re: [Freeipa-devel] [PATCH] Added fix for notifying user about account expiration in Web UI

2016-03-22 Thread Abhijeet Kasurde
Hi All, Please find the updated patches as per review comments. On 03/18/2016 07:39 PM, Petr Vobornik wrote: On 03/18/2016 02:21 PM, Abhijeet Kasurde wrote: Hi All, Please review these patches. Fixes : https://fedorahosted.org/freeipa/ticket/5077 Thanks, Abhijeet Kasurde 'invalid' is a

Re: [Freeipa-devel] [PATCH 0139] otptoken-add: improve the robustness of QR code printing to tty

2016-03-22 Thread Martin Babinsky
On 03/16/2016 02:17 PM, Martin Babinsky wrote: On 03/16/2016 01:35 PM, Nathaniel McCallum wrote: On Wed, 2016-03-16 at 07:25 +0100, Jan Cholasta wrote: On 15.3.2016 22:22, Nathaniel McCallum wrote: On Tue, 2016-03-15 at 17:54 +0100, Martin Babinsky wrote: On 03/15/2016 03:36 PM, Martin

Re: [Freeipa-devel] [PATCH 0428] SPEC: do not execute upgrade when ipa server is not installed

2016-03-22 Thread Martin Basti
On 18.03.2016 14:12, Martin Babinsky wrote: On 03/02/2016 07:26 AM, Jan Cholasta wrote: On 1.3.2016 20:36, Rob Crittenden wrote: Martin Basti wrote: On 01.03.2016 20:13, Rob Crittenden wrote: Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5704 Patch attached. Would it be

Re: [Freeipa-devel] [PATCH 0029] Move user/group constants for PKI and DS into ipaplatform

2016-03-22 Thread Martin Basti
On 18.03.2016 11:53, Christian Heimes wrote: On 2016-03-18 10:22, Martin Basti wrote: On 29.02.2016 16:02, David Kupka wrote: Hello Christian, sorry for letting this patch rot for so long. I've forget about it the minute Fraser replied. To compensate a little I've fixed pep8 error, rebased

Re: [Freeipa-devel] [PATCHES 0442-0449] Pylint: sunday code cleanup

2016-03-22 Thread Martin Basti
On 21.03.2016 16:52, Petr Spacek wrote: On 21.3.2016 13:50, Lukas Slebodnik wrote: On (21/03/16 12:30), Martin Basti wrote: On 21.03.2016 10:33, Christian Heimes wrote: On 2016-03-21 10:29, Petr Spacek wrote: On 20.3.2016 21:56, Martin Basti wrote: Patches attached. I do not really like

Re: [Freeipa-devel] [PATCH 0141] ipa-replica-manage: print traceback on unexpected error when in verbose mode

2016-03-22 Thread Martin Basti
On 18.03.2016 14:02, Martin Babinsky wrote: On 03/18/2016 01:38 PM, Martin Basti wrote: On 15.03.2016 16:03, Martin Babinsky wrote: On 03/14/2016 06:26 PM, Martin Basti wrote: On 10.03.2016 15:59, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5380 NACK 1) Maybe we

Re: [Freeipa-devel] [TEST][Patch-0027] Fixed test failure during in-tree session, ticket N 5736

2016-03-22 Thread Martin Basti
On 21.03.2016 09:11, Oleg Fayans wrote: Hi Martin, On 03/16/2016 03:35 PM, Martin Basti wrote: On 16.03.2016 15:13, Martin Basti wrote: On 16.03.2016 14:59, Oleg Fayans wrote: Hi Martin On 03/16/2016 02:39 PM, Martin Basti wrote: On 16.03.2016 10:59, Oleg Fayans wrote: With this patch

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-22 Thread Oleg Fayans
On 03/22/2016 02:06 PM, Martin Basti wrote: > > > On 21.03.2016 15:54, Oleg Fayans wrote: >> Hi Lukas, Martin, >> >> Looks I've implemented the approach proposed by Martin. The issue seems >> to have gone (see the external_ca_out for external_ca test output). >> Would like you to take a look

[Freeipa-devel] [PATCH 0099] Look up HTTPD_USER's UID and GID during installation.

2016-03-22 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/5712 -- David Kupka From 00959a382a34bfd77539443cd51b8033ca9c3ee1 Mon Sep 17 00:00:00 2001 From: David Kupka Date: Tue, 22 Mar 2016 09:40:43 +0100 Subject: [PATCH] Look up HTTPD_USER's UID and GID during installation. Those values

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-22 Thread Martin Basti
On 21.03.2016 15:54, Oleg Fayans wrote: Hi Lukas, Martin, Looks I've implemented the approach proposed by Martin. The issue seems to have gone (see the external_ca_out for external_ca test output). Would like you to take a look and tell me what'd you think. On 03/17/2016 08:37 PM, Lukas

Re: [Freeipa-devel] [PATCH] 0005 webui: topology graph: canvas resizes itself according to the window size

2016-03-22 Thread Petr Vobornik
On 03/21/2016 06:57 PM, Pavel Vomacka wrote: 1. -width: 960, -height: 500, Graph even without this patch allows to set initial size in a constructor, e.g.: E.g. so he could also use: this.graph = new topology_graph.TopoGraph({ nodes: data.nodes, links: data.links,

Re: [Freeipa-devel] [PATCH 0029] Move user/group constants for PKI and DS into ipaplatform

2016-03-22 Thread Martin Basti
On 22.03.2016 10:43, Martin Basti wrote: On 18.03.2016 11:53, Christian Heimes wrote: On 2016-03-18 10:22, Martin Basti wrote: On 29.02.2016 16:02, David Kupka wrote: Hello Christian, sorry for letting this patch rot for so long. I've forget about it the minute Fraser replied. To

[Freeipa-devel] [DRAFT] FreeIPA 4.3.1 release notes

2016-03-22 Thread Petr Vobornik
Hello all, I prepared the release notes on FreeIPA.org wiki: http://www.freeipa.org/page/Releases/4.3.1 Updates or improvements to release notes page welcome. Particularly if you think some bug fixes/improvements deserves to be noted out as a highlight, please give a suggestion or edit the page

Re: [Freeipa-devel] [PATCH 0451] regression fix: catch Exception instead of more specific exception types

2016-03-22 Thread Martin Babinsky
On 03/22/2016 05:28 PM, Martin Basti wrote: Patch attached, it fixes regression caused by mbasti-442 patch (master only). ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [PATCH 0451] regression fix: catch Exception instead of more specific exception types

2016-03-22 Thread Martin Basti
Patch attached, it fixes regression caused by mbasti-442 patch (master only). From cedddc4cf22fd4ccab44346e4a7472b9d16e390f Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 22 Mar 2016 16:39:39 +0100 Subject: [PATCH] Fix: catch Exception instead of more specific

Re: [Freeipa-devel] [PATCH 0451] regression fix: catch Exception instead of more specific exception types

2016-03-22 Thread Martin Basti
On 22.03.2016 17:32, Martin Babinsky wrote: On 03/22/2016 05:28 PM, Martin Basti wrote: Patch attached, it fixes regression caused by mbasti-442 patch (master only). ACK Pushed to master: d1e29fe60e75a6f40a780eb45e86f2ed87d00e5a -- Manage your subscription for the Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH 0432, 0450] stageuser-activate: noralize manager value + tests

2016-03-22 Thread Martin Basti
On 16.03.2016 09:13, Martin Basti wrote: On 15.03.2016 10:46, David Kupka wrote: On 08/03/16 12:02, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5481 Patch attached. Works for me, ACK. Pushed to master: 4871cb5b549042f383ee883e527e773c0abe9d87 Pushed to ipa-4-3:

Re: [Freeipa-devel] [PATCH 0099] Look up HTTPD_USER's UID and GID during installation.

2016-03-22 Thread Timo Aaltonen
22.03.2016, 14:36, David Kupka kirjoitti: > https://fedorahosted.org/freeipa/ticket/5712 sweet, thanks! -- t -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0012-0013] Improve ipaplatform.constants

2016-03-22 Thread Timo Aaltonen
18.03.2016, 12:30, Timo Aaltonen kirjoitti: > > Fix some hardcoded uid/gid strings to help with porting. rebased and simplified against current master. -- t From 424d3cf28f92a624b9970701a341dfa26370f616 Mon Sep 17 00:00:00 2001 From: Timo Aaltonen Date: Fri, 18 Mar 2016

[Freeipa-devel] [PATCH 0015] use ipaplatform.paths in kdc.conf.template

2016-03-22 Thread Timo Aaltonen
https://fedorahosted.org/freeipa/ticket/5343 -- t From 5798e8c04e716bc6fad01c8ea87473a1859eea28 Mon Sep 17 00:00:00 2001 From: Timo Aaltonen Date: Wed, 23 Mar 2016 00:32:52 +0200 Subject: [PATCH] Fix kdc.conf.template to use ipaplatform.paths.

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-22 Thread Martin Basti
On 22.03.2016 14:30, Oleg Fayans wrote: On 03/22/2016 02:06 PM, Martin Basti wrote: On 21.03.2016 15:54, Oleg Fayans wrote: Hi Lukas, Martin, Looks I've implemented the approach proposed by Martin. The issue seems to have gone (see the external_ca_out for external_ca test output). Would

Re: [Freeipa-devel] [PATCH 0143-0144] different errors/warnings for different LDAP limit type exceeded

2016-03-22 Thread Martin Babinsky
On 03/21/2016 12:25 PM, Jan Cholasta wrote: On 21.3.2016 10:17, Petr Spacek wrote: On 18.3.2016 13:49, Rob Crittenden wrote: Martin Babinsky wrote: These patches implement behavior agreed upon during discussion of https://fedorahosted.org/freeipa/ticket/5677 However I'm not sure if we want

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-22 Thread Oleg Fayans
Hi Martin, As per discussion, reverted 0025 patch and added try-catch in prepare_host method to make replica promotion tests pass On 03/22/2016 03:03 PM, Martin Basti wrote: > > > On 22.03.2016 14:30, Oleg Fayans wrote: >> >> On 03/22/2016 02:06 PM, Martin Basti wrote: >>> >>> On 21.03.2016

Re: [Freeipa-devel] [PATCH 0143-0144] different errors/warnings for different LDAP limit type exceeded

2016-03-22 Thread Rob Crittenden
Martin Babinsky wrote: On 03/21/2016 12:25 PM, Jan Cholasta wrote: On 21.3.2016 10:17, Petr Spacek wrote: On 18.3.2016 13:49, Rob Crittenden wrote: Martin Babinsky wrote: These patches implement behavior agreed upon during discussion of https://fedorahosted.org/freeipa/ticket/5677 However