Re: [Freeipa-devel] [PATCH 0405] idviews: Add user certificate attribute to user ID overrides

2016-04-28 Thread Tomas Babej
On 04/19/2016 08:20 AM, Jan Cholasta wrote: > On 13.4.2016 14:13, Tomas Babej wrote: >> On 04/13/2016 09:55 AM, Tomas Babej wrote: >>> On 04/07/2016 01:53 PM, Sumit Bose wrote: On Mon, Apr 04, 2016 at 04:27:02PM +0200, Jan Cholasta wrote: > Hi, > > On 1.4.2016 16:53, Tomas Babej

Re: [Freeipa-devel] [PATCH 0088-0095] Add --forward-policy option into installers

2016-04-28 Thread Martin Basti
On 22.04.2016 14:35, Petr Spacek wrote: On 12.4.2016 17:26, Martin Basti wrote: On 04.04.2016 17:37, Petr Spacek wrote: On 31.3.2016 13:45, Martin Basti wrote: On 21.03.2016 16:51, Petr Spacek wrote: On 10.3.2016 22:17, Lukas Slebodnik wrote: On (10/03/16 22:14), Petr Spacek wrote:

Re: [Freeipa-devel] More Python 3 fixes

2016-04-28 Thread Martin Basti
On 26.04.2016 15:31, Petr Viktorin wrote: Hello, Here are two patches for problems with using IPA with Python 3. ACK Pushed master: * 28b0bfaefea02fe188b57b602396f5ef62863726 dns plugin: Fix zone normalization under Python 3 * 05cb4ba4e97d8cbffaf1c16451c488db4a90a878 sysrestore: Iterate

Re: [Freeipa-devel] [PATCH] Added fix for notifying user about locked user account in WebUI

2016-04-28 Thread Martin Basti
On 28.04.2016 16:16, Pavel Vomacka wrote: On 04/20/2016 07:52 AM, Abhijeet Kasurde wrote: Hi All, Please review this patch. Fixes : https://fedorahosted.org/freeipa/ticket/5076 Thanks, Abhijeet Kasurde Hi, Javascript part LGTM. -- Pavel^3 Vomacka ACK Pushed to master:

Re: [Freeipa-devel] [PATCH 0097-0098] Makefile: replace perl with sed

2016-04-28 Thread Martin Basti
On 25.04.2016 09:39, Lukas Slebodnik wrote: On (22/04/16 13:29), Petr Spacek wrote: Hello, Makefile: add sed to BuildRequires It was requried since forever but we did not explicitly mention it. Makefile: replace perl with sed Perl was missing in BuildRequires anyway and it is used only on

Re: [Freeipa-devel] [TESTS][PATCH] Ping module tests in a non-declarative way

2016-04-28 Thread Martin Basti
On 08.04.2016 10:32, Peter Lacko wrote: Hello, I have a few comments: 1) Please set up your git name and email correctly (consistently for all patches) this is not right From: root 2) -# Copyright (C) 2012 Red Hat +# Copyright (C) 2016

Re: [Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

2016-04-28 Thread Martin Basti
On 28.04.2016 14:42, Martin Basti wrote: On 28.01.2016 17:55, Pavel Vomacka wrote: Hello, On 01/28/2016 12:20 PM, Pavel Vomacka wrote: 'Issue new certificate' dialog now validates whether user fills 'principal' and 'csr' field. In case that one of these fields is empty then it does not

[Freeipa-devel] [WIP] Thin client

2016-04-28 Thread Jan Cholasta
Hi, I have pushed my thin client WIP branch to GitHub: . All commits up to "ipalib: use relative imports for cross-plugin imports" should be good for review. The rest is subject to change (WARNING: I will force push into this branch).

Re: [Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

2016-04-28 Thread Martin Basti
On 28.01.2016 17:55, Pavel Vomacka wrote: Hello, On 01/28/2016 12:20 PM, Pavel Vomacka wrote: 'Issue new certificate' dialog now validates whether user fills 'principal' and 'csr' field. In case that one of these fields is empty then it does not allow to submit the dialog.

Re: [Freeipa-devel] [PATCH 0099] ipa-nis-manage: add status option

2016-04-28 Thread Abhijeet Kasurde
Hi Petr, On 04/25/2016 08:28 PM, Petr Spacek wrote: Hello, ipa-nis-manage: add status option https://bugzilla.redhat.com/show_bug.cgi?id=1329275 Can you reword the error message here as well ? if len(args) != 1: sys.exit("You must specify one action, either enable or

Re: [Freeipa-devel] [PATCH] Added warning to user for Internet Explorer

2016-04-28 Thread Martin Basti
On 27.04.2016 19:05, Rob Crittenden wrote: Abhijeet Kasurde wrote: Updated patch attached. On 04/26/2016 09:07 PM, Rob Crittenden wrote: Internet Explorer is no longer a supported browser. ACK pushed to master: * f61910084d737f66b9914f3f945e9830a393c8af Added warning to user for

Re: [Freeipa-devel] [PATCH 0099] ipa-nis-manage: add status option

2016-04-28 Thread Petr Vobornik
On 04/25/2016 04:58 PM, Petr Spacek wrote: > Hello, > > ipa-nis-manage: add status option > > https://bugzilla.redhat.com/show_bug.cgi?id=1329275 > Trac ticket https://fedorahosted.org/freeipa/ticket/5856 -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH] Added fix for notifying user about locked user account in WebUI

2016-04-28 Thread Pavel Vomacka
On 04/20/2016 07:52 AM, Abhijeet Kasurde wrote: Hi All, Please review this patch. Fixes : https://fedorahosted.org/freeipa/ticket/5076 Thanks, Abhijeet Kasurde Hi, Javascript part LGTM. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0024] ipa-replica-manage: added --suffix option for certain commands

2016-04-28 Thread Martin Basti
On 25.04.2016 10:39, Stanislav Laznicka wrote: On 04/22/2016 05:15 PM, Stanislav Laznicka wrote: On 04/22/2016 01:13 PM, Martin Basti wrote: On 15.04.2016 14:30, Stanislav Laznicka wrote: On 04/13/2016 01:40 PM, Martin Basti wrote: On 06.04.2016 14:04, Stanislav Laznicka wrote: On

Re: [Freeipa-devel] [PATCH 0088-0095] Add --forward-policy option into installers

2016-04-28 Thread Petr Vobornik
On 04/28/2016 06:29 PM, Martin Basti wrote: > > > On 28.04.2016 17:27, Petr Spacek wrote: >> On 28.4.2016 16:14, Martin Basti wrote: >>> >>> On 22.04.2016 14:35, Petr Spacek wrote: On 12.4.2016 17:26, Martin Basti wrote: > On 04.04.2016 17:37, Petr Spacek wrote: >> On 31.3.2016

Re: [Freeipa-devel] [PATCH 0088-0095] Add --forward-policy option into installers

2016-04-28 Thread Martin Basti
On 28.04.2016 17:27, Petr Spacek wrote: On 28.4.2016 16:14, Martin Basti wrote: On 22.04.2016 14:35, Petr Spacek wrote: On 12.4.2016 17:26, Martin Basti wrote: On 04.04.2016 17:37, Petr Spacek wrote: On 31.3.2016 13:45, Martin Basti wrote: On 21.03.2016 16:51, Petr Spacek wrote: On

Re: [Freeipa-devel] [PATCH] 0001 ipa_kdb add krbPrincipalAuthInd handling

2016-04-28 Thread Matt Rogers
On 04/27, Matt Rogers wrote: > On 04/27, Sumit Bose wrote: > > On Tue, Apr 26, 2016 at 02:02:04PM -0400, Matt Rogers wrote: > > > On 04/26, Sumit Bose wrote: > > > > On Thu, Apr 14, 2016 at 12:59:55PM -0400, Matt Rogers wrote: > > > > > > > > > > > > > > > - Original Message - > > > > >

Re: [Freeipa-devel] [PATCH 0088-0095] Add --forward-policy option into installers

2016-04-28 Thread Petr Spacek
On 28.4.2016 16:14, Martin Basti wrote: > > > On 22.04.2016 14:35, Petr Spacek wrote: >> On 12.4.2016 17:26, Martin Basti wrote: >>> >>> On 04.04.2016 17:37, Petr Spacek wrote: On 31.3.2016 13:45, Martin Basti wrote: > On 21.03.2016 16:51, Petr Spacek wrote: >> On 10.3.2016 22:17,