URL: https://github.com/freeipa/freeipa/pull/73
Author: apophys
Title: #73: Tests for certificates with SAN
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/73/head:pr73
git checkout pr73
From
On 18.7.2016 08:22, Jan Cholasta wrote:
> On 8.7.2016 15:59, Rob Crittenden wrote:
>> Petr Spacek wrote:
>>> On 8.7.2016 15:31, Rob Crittenden wrote:
Petr Spacek wrote:
> Hi,
>
> our docs
>
>
URL: https://github.com/freeipa/freeipa/pull/114
Title: #114: Raise errors from service.py:_ldap_mod() by default
mbasti-rh commented:
"""
This issues are caused mostly by newer replica install, so I don't think that
earlier devel cycle will help us , we need good upgrade testing.
However I
On Wed, Sep 21, 2016 at 12:01:44PM +0200, Jan Pazdziora wrote:
>
> I've recently hit again the situation of IPA installer not happy
> about the provided IP address not being local to it, this time in
> containerized environment:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1377973
>
>
URL: https://github.com/freeipa/freeipa/pull/122
Author: dkupka
Title: #122: Acceptance tests
Action: opened
PR body:
"""
Starting with minimal suite that will grow as necessary.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/115
Author: tomaskrizek
Title: #115: Don't show traceback when ipa config file is not an absolute path
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
mbasti-rh commented:
"""
I disagree, I really think that there should not be assert
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/121#issuecomment-249816977
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
mbasti-rh commented:
"""
NACK, please see inline comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/115#issuecomment-249846654
--
Manage
URL: https://github.com/freeipa/freeipa/pull/122
Title: #122: Acceptance tests
mbasti-rh commented:
"""
I quite disagree with marks, please read my inline comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/122#issuecomment-249858212
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/123
Author: mirielka
Title: #123: Tests: Remove silent deleting and creating entries by tracker
Action: opened
PR body:
"""
https://fedorahosted.org/freeipa/ticket/6123
"""
To pull the PR as Git branch:
git remote add ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
flo-renaud commented:
"""
Agree with you, ACK.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/121#issuecomment-249822167
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/114
Title: #114: Raise errors from service.py:_ldap_mod() by default
mbasti-rh commented:
"""
This issues are caused mostly by newer replica install, so I don't think that
earlier devel cycle will help us , we need good upgrade testing.
However I
URL: https://github.com/freeipa/freeipa/pull/114
Title: #114: Raise errors from service.py:_ldap_mod() by default
mbasti-rh commented:
"""
This issues are caused mostly by newer replica install, so I don't think that
earlier devel cycle will help us, we need good upgrade testing.
However I
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
stlaz commented:
"""
The latest changes fixed the nitpicks mentioned, ACK. Thanks :+1:
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/121#issuecomment-249830361
--
Manage
URL: https://github.com/freeipa/freeipa/pull/121
Author: mbasti-rh
Title: #121: Pylint: enable unused-variable check
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/121/head:pr121
git checkout pr121
--
Manage
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/0f88f8fe889ae4801fc8d5ece1ad51c5246718ac
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
pspacek commented:
"""
Why the file must be absolute? I would rather remove this requirement and be
done with it. `open()` the file and if it succeeds - use it. If it
URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout
On ti, 27 syys 2016, Nathaniel McCallum wrote:
In at least one case, when an LDAP socket closes, a read event is fired
rather than an error event. Without this patch, ipa-otpd silently
ignores this event and enters a state where all bind auths fail.
To remedy this problem, we pass error events
URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode
tomaskrizek commented:
"""
NACK, please see inline comments.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/117#issuecomment-249814914
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/124
Author: mbasti-rh
Title: #124: Fix: find OSCP certificate test
Action: opened
PR body:
"""
Test should check if any OSCP certificate has been returned
https://fedorahosted.org/freeipa/ticket/6359
"""
To pull the PR as Git branch:
git remote
URL: https://github.com/freeipa/freeipa/pull/73
Author: apophys
Title: #73: Tests for certificates with SAN
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/73/head:pr73
git checkout pr73
From
URL: https://github.com/freeipa/freeipa/pull/115
Author: tomaskrizek
Title: #115: Don't show traceback when ipa config file is not an absolute path
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/115
Author: tomaskrizek
Title: #115: Don't show traceback when ipa config file is not an absolute path
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
tomaskrizek commented:
"""
I found no reason why the path should be absolute, so I removed that constraint.
The parser check to verify if file exists should remain,
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
mbasti-rh commented:
"""
NACK, please see my inline comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/115#issuecomment-249783814
--
In at least one case, when an LDAP socket closes, a read event is fired
rather than an error event. Without this patch, ipa-otpd silently
ignores this event and enters a state where all bind auths fail.
To remedy this problem, we pass error events along the same path as
read events. Should the
On Tue, 2016-09-27 at 14:54 -0400, Nathaniel McCallum wrote:
> In at least one case, when an LDAP socket closes, a read event is
> fired
> rather than an error event. Without this patch, ipa-otpd silently
> ignores this event and enters a state where all bind auths fail.
>
> To remedy this
URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check
stlaz commented:
"""
The changes seem fine except for the two small nitpicks.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/121#issuecomment-249823191
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/121
Author: mbasti-rh
Title: #121: Pylint: enable unused-variable check
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/121/head:pr121
git checkout pr121
From
32 matches
Mail list logo
