[Freeipa-devel] [freeipa PR#135][synchronized] Pylint: remove unused variables from install modules and scripts

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/135 Author: mbasti-rh Title: #135: Pylint: remove unused variables from install modules and scripts Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#135][opened] Pylint: remove unused variables from install modules and scripts

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/135 Author: mbasti-rh Title: #135: Pylint: remove unused variables from install modules and scripts Action: opened PR body: """ Would be nice to merge this patch before refactoring of installers starts """ To pull the PR as Git branch: git remote

[Freeipa-devel] [freeipa PR#135][edited] Pylint: remove unused variables

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/135 Author: mbasti-rh Title: #135: Pylint: remove unused variables Action: edited Changed field: title Original value: """ Pylint: remove unused variables from install modules and scripts """ -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#126][synchronized] Fix ipa migrate-ds when it finds a search reference

2016-10-04 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/126 Author: flo-renaud Title: #126: Fix ipa migrate-ds when it finds a search reference Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/126/head:pr126 git

[Freeipa-devel] [freeipa PR#134][comment] DNS URI support

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/134 Title: #134: DNS URI support mbasti-rh commented: """ jslint failed please fix it (you can leave pep8 as is, to be consistent with current code) """ See the full comment at https://github.com/freeipa/freeipa/pull/134#issuecomment-251467798 --

[Freeipa-devel] [freeipa PR#135][synchronized] Pylint: remove unused variables from install modules and scripts

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/135 Author: mbasti-rh Title: #135: Pylint: remove unused variables from install modules and scripts Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#136][opened] [WIP] Fix KRA install tests

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/136 Author: mbasti-rh Title: #136: [WIP] Fix KRA install tests Action: opened PR body: """ - in test_installation testsuite KRA related tests were duplicated, this PR removes it - in test_installation test suite with domain level 0, some KRA tests

[Freeipa-devel] [freeipa PR#131][comment] Fixed script generating certs to address untrusted sub-ca

2016-10-04 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/131 Title: #131: Fixed script generating certs to address untrusted sub-ca frasertweedale commented: """ Obvious ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/131#issuecomment-251532635 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#125][synchronized] Add iSecStore.span

2016-10-04 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/125 Author: tiran Title: #125: Add iSecStore.span Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/125/head:pr125 git checkout pr125 From

[Freeipa-devel] [freeipa PR#132][opened] Draft for a new setup.py (WIP)

2016-10-04 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/132 Author: tiran Title: #132: Draft for a new setup.py (WIP) Action: opened PR body: """ PREVIEW, please don't merge yet. This is my take on FreeIPA's setup.py files. I have moved all common code and constants into ipasetup.py.in and converted

[Freeipa-devel] [freeipa PR#122][comment] Acceptance tests

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/122 Title: #122: Acceptance tests mbasti-rh commented: """ Please see my inline comments, I would not bother with removing DNS tests from suite because they are fast and should not affect CA/KRA """ See the full comment at

[Freeipa-devel] [freeipa PR#130][closed] Added --ip-address paramenter to client installation

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/130 Author: ofayans Title: #130: Added --ip-address paramenter to client installation Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/130/head:pr130 git checkout

[Freeipa-devel] [freeipa PR#130][comment] Added --ip-address paramenter to client installation

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/130 Title: #130: Added --ip-address paramenter to client installation mbasti-rh commented: """ I don't see any disagreement so I'm closing this PR """ See the full comment at https://github.com/freeipa/freeipa/pull/130#issuecomment-251370026 --

[Freeipa-devel] [freeipa PR#130][+rejected] Added --ip-address paramenter to client installation

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/130 Title: #130: Added --ip-address paramenter to client installation Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#131][opened] Fixed script generating certs to address untrusted sub-ca

2016-10-04 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/131 Author: ofayans Title: #131: Fixed script generating certs to address untrusted sub-ca Action: opened PR body: """ Changed the path length from 0 to -1 (unlimited length) https://fedorahosted.org/freeipa/ticket/6348 """ To pull the PR as Git

[Freeipa-devel] [freeipa PR#114][comment] Raise errors from service.py:_ldap_mod() by default

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/114 Title: #114: Raise errors from service.py:_ldap_mod() by default mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/c56256e2a29f076e6afa559225a66f58b0773eb5 """ See the full comment at

[Freeipa-devel] [freeipa PR#114][+pushed] Raise errors from service.py:_ldap_mod() by default

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/114 Title: #114: Raise errors from service.py:_ldap_mod() by default Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#114][closed] Raise errors from service.py:_ldap_mod() by default

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/114 Author: pspacek Title: #114: Raise errors from service.py:_ldap_mod() by default Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/114/head:pr114 git checkout pr114

[Freeipa-devel] [freeipa PR#129][closed] Fix test_util.test_assert_deepequal test

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/129 Author: stlaz Title: #129: Fix test_util.test_assert_deepequal test Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/129/head:pr129 git checkout pr129 -- Manage

[Freeipa-devel] [freeipa PR#129][comment] Fix test_util.test_assert_deepequal test

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/129 Title: #129: Fix test_util.test_assert_deepequal test mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d70d71846d6eb7d8e6a730965e54e737e7b49f15 ipa-4-4:

[Freeipa-devel] [freeipa PR#125][comment] Add iSecStore.span

2016-10-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/125 Title: #125: Add iSecStore.span mbasti-rh commented: """ Please fix PEP8 error, otherwise LGTM """ See the full comment at https://github.com/freeipa/freeipa/pull/125#issuecomment-251371815 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#117][synchronized] Make ipa-replica-install run in interactive mode

2016-10-04 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/117 Author: stlaz Title: #117: Make ipa-replica-install run in interactive mode Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/117/head:pr117 git checkout

[Freeipa-devel] [freeipa PR#133][opened] Tests: print what was expected from exceptions and callables in xmlrpc_tests

2016-10-04 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/133 Author: pspacek Title: #133: Tests: print what was expected from exceptions and callables in xmlrpc_tests Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch

[Freeipa-devel] [freeipa PR#134][opened] DNS URI support

2016-10-04 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Author: pspacek Title: #134: DNS URI support Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/134/head:pr134 git checkout pr134 From

[Freeipa-devel] [freeipa PR#134][synchronized] DNS URI support

2016-10-04 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Author: pspacek Title: #134: DNS URI support Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/134/head:pr134 git checkout pr134 From

[Freeipa-devel] [freeipa PR#108][comment] Bump pki min version and add commentary about sub-CA revocation on delete

2016-10-04 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/108 Title: #108: Bump pki min version and add commentary about sub-CA revocation on delete frasertweedale commented: """ @mbasti-rh I think the BuildRequires bump is appropriate. If we say (in the doc) that such and such will happen, we want to be

[Freeipa-devel] [freeipa PR#108][synchronized] Bump pki min version and add commentary about sub-CA revocation on delete

2016-10-04 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/108 Author: frasertweedale Title: #108: Bump pki min version and add commentary about sub-CA revocation on delete Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#73][+pushed] Tests for certificates with SAN

2016-10-04 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#73][closed] Tests for certificates with SAN

2016-10-04 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/73 Author: apophys Title: #73: Tests for certificates with SAN Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/73/head:pr73 git checkout pr73 -- Manage your

[Freeipa-devel] [freeipa PR#73][comment] Tests for certificates with SAN

2016-10-04 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4f8e212c428b1fff63f38ea15d7ce9f230085c5c

[Freeipa-devel] [freeipa PR#73][+ack] Tests for certificates with SAN

2016-10-04 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code