[Freeipa-devel] [freeipa PR#161][opened] CI: workaround: wait for dogtag before replica-prepare

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/161 Author: mbasti-rh Title: #161: CI: workaround: wait for dogtag before replica-prepare Action: opened PR body: """ In domain level 0 ipa-replica-prepare fails because dogtag is not ready so soon after final restart during installation (tests are

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-13 Thread Martin Basti
I think that you forgot to squash commits. Patch 47 doesn't apply On 13.10.2016 14:01, Oleg Fayans wrote: Hi Martin, Thanks for the review. With disabling directory server it works as well, thanks for the hint. Also I moved the cleanup logic to the test itself for the sake of simplicity.

Re: [Freeipa-devel] [Design Review Request] V4/Automatic_Certificate_Request_Generation

2016-10-13 Thread Ben Lipton
Thank you, this was a really helpful clarification of your point. Comments below. Once again, I'm sorry I missed the email for so long. Ben On 09/05/2016 06:52 AM, Jan Cholasta wrote: On 27.8.2016 22:40, Ben Lipton wrote: On 08/25/2016 04:11 PM, Rob Crittenden wrote: Ben Lipton wrote: On

[Freeipa-devel] [freeipa PR#160][comment] Reverted the assertion for replica uninstall returncode

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/160 Title: #160: Reverted the assertion for replica uninstall returncode mbasti-rh commented: """ Ticket https://fedorahosted.org/freeipa/ticket/5725 is in already closed milestone, please create a new one (I suppose you want backport to 4.4.3) """

[Freeipa-devel] [freeipa PR#161][comment] CI: workaround: wait for dogtag before replica-prepare

2016-10-13 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/161 Title: #161: CI: workaround: wait for dogtag before replica-prepare martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/91b51e702f1e105329ebea29c633d94516cd673c """ See the full comment at

[Freeipa-devel] [freeipa PR#160][comment] Reverted the assertion for replica uninstall returncode

2016-10-13 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/160 Title: #160: Reverted the assertion for replica uninstall returncode martbab commented: """ I think that issue reported in https://fedorahosted.org/freeipa/ticket/3230 is orthogonal to uninstaller returning 0 on error. I fail to see why we are

[Freeipa-devel] [freeipa PR#155][+ack] Build system cleanup

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/155 Title: #155: Build system cleanup Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#155][comment] Build system cleanup

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/155 Title: #155: Build system cleanup mbasti-rh commented: """ Works for me, Not pushing yet to give time to others to disagree """ See the full comment at https://github.com/freeipa/freeipa/pull/155#issuecomment-253555492 -- Manage your

Re: [Freeipa-devel] Heimdal Kerberos support for client

2016-10-13 Thread Petr Spacek
On 12.10.2016 20:22, Rob Crittenden wrote: > Petr Spacek wrote: >> Hello list, >> >> I just noticed that client/configure.ac contains some checks to detect and >> support Heimdal Kerberos libraries. >> >> Was it tested? Does it work? Can I drop it? :-) >> > > Wow, that's some old code. > > Only

[Freeipa-devel] [freeipa PR#161][+pushed] CI: workaround: wait for dogtag before replica-prepare

2016-10-13 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/161 Title: #161: CI: workaround: wait for dogtag before replica-prepare Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#161][closed] CI: workaround: wait for dogtag before replica-prepare

2016-10-13 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/161 Author: mbasti-rh Title: #161: CI: workaround: wait for dogtag before replica-prepare Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/161/head:pr161 git checkout

[Freeipa-devel] [freeipa PR#161][+ack] CI: workaround: wait for dogtag before replica-prepare

2016-10-13 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/161 Title: #161: CI: workaround: wait for dogtag before replica-prepare Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#136][synchronized] Fix KRA install tests

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/136 Author: mbasti-rh Title: #136: Fix KRA install tests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/136/head:pr136 git checkout pr136 From

Re: [Freeipa-devel] Heimdal Kerberos support for client

2016-10-13 Thread Timo Aaltonen
On 13.10.2016 18:56, Petr Spacek wrote: > On 12.10.2016 20:22, Rob Crittenden wrote: >> Petr Spacek wrote: >>> Hello list, >>> >>> I just noticed that client/configure.ac contains some checks to detect and >>> support Heimdal Kerberos libraries. >>> >>> Was it tested? Does it work? Can I drop it?

Re: [Freeipa-devel] [RFC] Matching and Mapping Certificates

2016-10-13 Thread Sumit Bose
On Tue, Oct 11, 2016 at 01:37:09PM +0200, Sumit Bose wrote: > On Thu, Oct 06, 2016 at 12:49:30PM +0200, Sumit Bose wrote: > > Hi, > > > > I've started to write a SSSD design page about enhancing the current > > mapping of certificates to users and how to select/match a suitable > > certificate if

Re: [Freeipa-devel] Broken IPA installation caused by new python-dns package

2016-10-13 Thread Martin Basti
On 13.10.2016 19:49, Petr Vobornik wrote: On 10/12/2016 11:11 AM, Petr Spacek wrote: On 10.10.2016 10:28, Martin Basti wrote: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1857421df6 Please set karma accordingly Traceback: ... 2016-10-10T04:44:05Z DEBUG The ipa-replica-install

Re: [Freeipa-devel] Broken IPA installation caused by new python-dns package

2016-10-13 Thread Petr Vobornik
On 10/12/2016 11:11 AM, Petr Spacek wrote: > On 10.10.2016 10:28, Martin Basti wrote: >> https://bodhi.fedoraproject.org/updates/FEDORA-2016-1857421df6 >> >> >> Please set karma accordingly >> >> >> Traceback: >> >> ... >> >> 2016-10-10T04:44:05Z DEBUG The ipa-replica-install command failed,

[Freeipa-devel] [freeipa PR#127][comment] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/6c53765ac1746ea3cb82554775a37fe43af062e8

[Freeipa-devel] [freeipa PR#127][closed] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/127 Author: tjaalton Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/127/head:pr127 git checkout

[Freeipa-devel] [freeipa PR#127][+pushed] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#156][+pushed] cert: add revocation reason back to cert-find output

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/156 Title: #156: cert: add revocation reason back to cert-find output Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#156][closed] cert: add revocation reason back to cert-find output

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/156 Author: jcholast Title: #156: cert: add revocation reason back to cert-find output Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/156/head:pr156 git checkout

[Freeipa-devel] [freeipa PR#156][comment] cert: add revocation reason back to cert-find output

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/156 Title: #156: cert: add revocation reason back to cert-find output mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/16dad1c3cb09acee946bc5b2409447279a8bc0de ipa-4-4:

[Freeipa-devel] [freeipa PR#161][comment] CI: workaround: wait for dogtag before replica-prepare

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/161 Title: #161: CI: workaround: wait for dogtag before replica-prepare mbasti-rh commented: """ It looks that 30 seconds is not enough, majority of ipa-replica-prepare passed, but I had a few test where it is still failing (randomly) """ See the

[Freeipa-devel] [freeipa PR#127][+ack] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#136][edited] Fix KRA install tests

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/136 Author: mbasti-rh Title: #136: Fix KRA install tests Action: edited Changed field: body Original value: """ - in test_installation testsuite KRA related tests were duplicated, this PR removes it - in test_installation test suite with domain

[Freeipa-devel] [freeipa PR#162][opened] Certificate processing refactoring

2016-10-13 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/162 Author: frasertweedale Title: #162: Certificate processing refactoring Action: opened PR body: """ This PR contains ready-for-review/test commits that: - support converting python-cryptography Name type to DN - avoid the need to parse

[Freeipa-devel] [freeipa PR#163][opened] Do not create Object Signing certificate

2016-10-13 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/163 Author: frasertweedale Title: #163: Do not create Object Signing certificate Action: opened PR body: """ The Object Signing certificate created during server installation was used only for signing the (recently removed) Firefox extension, so

[Freeipa-devel] [freeipa PR#162][synchronized] Certificate processing refactoring

2016-10-13 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/162 Author: frasertweedale Title: #162: Certificate processing refactoring Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/162/head:pr162 git checkout pr162

[Freeipa-devel] [freeipa PR#127][comment] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-13 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension frasertweedale commented: """ I think this change has caused SELinux errors when starting the daemon. (I had to `setenforce 0` to get the installer to complete). """ See the full

[Freeipa-devel] [bind-dyndb-ldap PR#2][comment] fix ldif syntax and add idnsTemplateAttribute

2016-10-13 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Title: #2: fix ldif syntax and add idnsTemplateAttribute pspacek commented: """ @mbasti-rh , the white-space at the end of line is required here because the first space at the beginning of line will be consumed by LDIF parser. I agree

Re: [Freeipa-devel] links to docs in the messages from code

2016-10-13 Thread Pavel Vomacka
On 10/13/2016 08:54 AM, Martin Basti wrote: On 12.10.2016 19:56, Petr Spacek wrote: Hello FreeIPA developers, looking at freeipa-users mailing list, a lot of questions could be answered by just quick glance to the docs. I wonder if we should add links HTML version of docs on

[Freeipa-devel] [bind-dyndb-ldap PR#2][comment] fix ldif syntax and add idnsTemplateAttribute

2016-10-13 Thread stutiredboy
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Title: #2: fix ldif syntax and add idnsTemplateAttribute stutiredboy commented: """ so sorry for the root committer, but the white space is needed by OpenLDAP LDIF parser. I have fixed the ugly pull request. :-) Thanks. """ See the full

[Freeipa-devel] [freeipa PR#160][comment] Reverted the essertion for replica uninstall returncode

2016-10-13 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/160 Title: #160: Reverted the essertion for replica uninstall returncode martbab commented: """ Please mention either git commit (f7764cda6824a2fe73abe11f6daa28758a185319) that fixed this behavior, or put the link to closed ticket

[Freeipa-devel] [freeipa PR#160][synchronized] Reverted the essertion for replica uninstall returncode

2016-10-13 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/160 Author: ofayans Title: #160: Reverted the essertion for replica uninstall returncode Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/160/head:pr160 git

[Freeipa-devel] [freeipa PR#160][comment] Reverted the essertion for replica uninstall returncode

2016-10-13 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/160 Title: #160: Reverted the essertion for replica uninstall returncode ofayans commented: """ Fair point. Fixed. Should we also update the initial (3230) issue? """ See the full comment at

Re: [Freeipa-devel] links to docs in the messages from code

2016-10-13 Thread Martin Basti
On 12.10.2016 19:56, Petr Spacek wrote: Hello FreeIPA developers, looking at freeipa-users mailing list, a lot of questions could be answered by just quick glance to the docs. I wonder if we should add links HTML version of docs on access.redhat.com to the messages generated by the code. If

[Freeipa-devel] [bind-dyndb-ldap PR#2][comment] fix ldif syntax and add idnsTemplateAttribute

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Title: #2: fix ldif syntax and add idnsTemplateAttribute mbasti-rh commented: """ Hello, I wrote inline comments. Please set proper author name in commit (no root please) """ See the full comment at

[Freeipa-devel] [freeipa PR#156][comment] cert: add revocation reason back to cert-find output

2016-10-13 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/156 Title: #156: cert: add revocation reason back to cert-find output pvomacka commented: """ Ah, OK, then it works correctly. ACK """ See the full comment at https://github.com/freeipa/freeipa/pull/156#issuecomment-253441752 -- Manage your

[Freeipa-devel] [freeipa PR#156][+ack] cert: add revocation reason back to cert-find output

2016-10-13 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/156 Title: #156: cert: add revocation reason back to cert-find output Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-13 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ Interestingly, the CI failed with following errors: * Module ipatests.test_xmlrpc.test_automount_plugin ipatests/test_xmlrpc/test_automount_plugin.py:34:

[Freeipa-devel] [bind-dyndb-ldap PR#2][synchronized] fix ldif syntax and add idnsTemplateAttribute

2016-10-13 Thread stutiredboy
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Author: stutiredboy Title: #2: fix ldif syntax and add idnsTemplateAttribute Action: synchronized To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap

[Freeipa-devel] [freeipa PR#160][opened] Reverted the essertion for replica uninstall returncode

2016-10-13 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/160 Author: ofayans Title: #160: Reverted the essertion for replica uninstall returncode Action: opened PR body: """ As the issue with ipa installer always returning 0 returncode is apparently addressed, the test needs to be made aware of this

Re: [Freeipa-devel] links to docs in the messages from code

2016-10-13 Thread Petr Spacek
On 13.10.2016 08:54, Martin Basti wrote: > > > On 12.10.2016 19:56, Petr Spacek wrote: >> Hello FreeIPA developers, >> >> looking at freeipa-users mailing list, a lot of questions could be answered >> by >> just quick glance to the docs. >> >> I wonder if we should add links HTML version of

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires mbasti-rh commented: """ Please update BUILD.txt with how to run pylint with build, probably freeipa.org should be updated as well """ See the full comment at

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#127][comment] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension mbasti-rh commented: """ Hello @tjaalton, I cannot apply second commit, it needs rebase. """ See the full comment at

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

Re: [Freeipa-devel] FleetCommander integration

2016-10-13 Thread Sumit Bose
On Tue, Sep 06, 2016 at 01:18:14PM +0300, Alexander Bokovoy wrote: > Hi, > > Now that FreeIPA 4.4.1 is out, I've pushed to github my prototype for > FleetCommander integration: https://github.com/abbra/freeipa-desktop-profile/ > > You can read the design page: >

Re: [Freeipa-devel] FleetCommander integration

2016-10-13 Thread Alexander Bokovoy
On to, 13 loka 2016, Sumit Bose wrote: On Tue, Sep 06, 2016 at 01:18:14PM +0300, Alexander Bokovoy wrote: Hi, Now that FreeIPA 4.4.1 is out, I've pushed to github my prototype for FleetCommander integration: https://github.com/abbra/freeipa-desktop-profile/ You can read the design page:

[Freeipa-devel] [freeipa PR#160][edited] Reverted the assertion for replica uninstall returncode

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/160 Author: ofayans Title: #160: Reverted the assertion for replica uninstall returncode Action: edited Changed field: title Original value: """ Reverted the essertion for replica uninstall returncode """ -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#127][synchronized] Move ipa-otpd to $libexecdir/ipa, purge ffextension

2016-10-13 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/127 Author: tjaalton Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/127/head:pr127 git

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires jcholast commented: """ @pspacek, @mbasti-rh, fixed. """ See the full comment at https://github.com/freeipa/freeipa/pull/159#issuecomment-253491282 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#126][comment] Fix ipa migrate-ds when it finds a search reference

2016-10-13 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/126 Title: #126: Fix ipa migrate-ds when it finds a search reference mbasti-rh commented: """ Hello, LGTM but PR needs rebase """ See the full comment at https://github.com/freeipa/freeipa/pull/126#issuecomment-253491876 -- Manage your

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-13 Thread Oleg Fayans
Hi Martin, Thanks for the review. With disabling directory server it works as well, thanks for the hint. Also I moved the cleanup logic to the test itself for the sake of simplicity. Patch-0048 was not changed On 10/12/2016 02:35 PM, Martin Basti wrote: 1) Can you just turn off dirsrv on