[Freeipa-devel] [freeipa PR#169][+ack] Replace ipaplatform's symlinks with __path__

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/169 Title: #169: Replace ipaplatform's symlinks with __path__ Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#174][opened] add log module

2016-10-20 Thread shanyin
URL: https://github.com/freeipa/freeipa/pull/174 Author: shanyin Title: #174: add log module Action: opened PR body: """ add log module on the ipa-4-3 branch, the function of log module is to record any of our operation. """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ @lslebodn Decision if we need client_only build is still open. We may drop it so reimplementing it would be busy work. """ See the full comment at

[Freeipa-devel] [freeipa PR#132][comment] Port all setup.py files to setuptools

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools tiran commented: """ The PR is no longer provisional and ready-to-merge. """ See the full comment at https://github.com/freeipa/freeipa/pull/132#issuecomment-255065278 -- Manage your

[Freeipa-devel] [freeipa PR#132][comment] Port all setup.py files to setuptools

2016-10-20 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools jcholast commented: """ LGTM, but shouldn't we also move `/setup.py` to `/ipaserver/setup.py`? """ See the full comment at https://github.com/freeipa/freeipa/pull/132#issuecomment-255085433 --

[Freeipa-devel] [freeipa PR#132][edited] Port all setup.py files to setuptools

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/132 Author: tiran Title: #132: Port all setup.py files to setuptools Action: edited Changed field: title Original value: """ Draft for a new setup.py (WIP) """ -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-10-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management tomaskrizek commented: """ Please review the code. I fixed a problem that was identified with the previous set of integration tests, but I'm still waiting for results of this build.

[Freeipa-devel] [freeipa PR#175][closed] Remove ipapython/ipa.conf

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/175 Author: tiran Title: #175: Remove ipapython/ipa.conf Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/175/head:pr175 git checkout pr175 -- Manage your

[Freeipa-devel] [freeipa PR#132][synchronized] Draft for a new setup.py (WIP)

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/132 Author: tiran Title: #132: Draft for a new setup.py (WIP) Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/132/head:pr132 git checkout pr132 From

[Freeipa-devel] [freeipa PR#175][comment] Remove ipapython/ipa.conf

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/175 Title: #175: Remove ipapython/ipa.conf tiran commented: """ @pspacek prefers a separate commit in PR #132 """ See the full comment at https://github.com/freeipa/freeipa/pull/175#issuecomment-255064396 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#132][synchronized] Draft for a new setup.py (WIP)

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/132 Author: tiran Title: #132: Draft for a new setup.py (WIP) Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/132/head:pr132 git checkout pr132 From

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ Commit 6256e8014aa3d68dc46e6c878be813473bffd1ac breaks pylint because it is not compatible with ipaplatform implementation introduced in

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ Commit 6256e8014aa3d68dc46e6c878be813473bffd1ac breaks pylint because it is not compatible with ipaplatform implementation introduced in

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-20 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ @lslebodn Please discuss this matter on freeipa-devel list to gethigher visibility. Please note that current client-only build is quite broken and requires heavy machinery in

[Freeipa-devel] [freeipa PR#169][comment] Replace ipaplatform's symlinks with __path__

2016-10-20 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/169 Title: #169: Replace ipaplatform's symlinks with __path__ dkupka commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/8f98fa1bd5f1da207fab6f89b75e0cdc19d00797 """ See the full comment at

[Freeipa-devel] [freeipa PR#169][closed] Replace ipaplatform's symlinks with __path__

2016-10-20 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/169 Author: tiran Title: #169: Replace ipaplatform's symlinks with __path__ Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/169/head:pr169 git checkout pr169 --

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-10-20 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module mbasti-rh commented: """ Hello, what is use case for this? "I'm admin and I want to audit what commads were used" or what? Have you tried, http://www.freeipa.org/page/Centralized_Logging ? Does it match your use

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ Version rebased on top of current master (without PR 171) is available from https://github.com/pspacek/freeipa/tree/pr159-rebase . """ See the full comment at

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 lslebodn commented: """ > Please note that current client-only build is quite broken and requires heavy > machinery in downstream spec file so it is hard to speak about any reusage. That's the problem of

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 lslebodn commented: """ My proposal would not require any reimplementation because it will reuse current solution. And I would like to know the reasons why upstream might consider to drop client_only

[Freeipa-devel] [freeipa PR#169][+pushed] Replace ipaplatform's symlinks with __path__

2016-10-20 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/169 Title: #169: Replace ipaplatform's symlinks with __path__ Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#132][synchronized] Draft for a new setup.py (WIP)

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/132 Author: tiran Title: #132: Draft for a new setup.py (WIP) Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/132/head:pr132 git checkout pr132 From

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 tiran commented: """ I agree with @lslebodn . It should be possible to build only the necessary bits and pieces for an IPA client. It should be rather simple to implement a ```--without-server```

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 tiran commented: """ ACK make rpms is passing on my machine. """ See the full comment at https://github.com/freeipa/freeipa/pull/171#issuecomment-255099321 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-10-20 Thread rcritten
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management rcritten commented: """ Removing the connection timeout makes me a bit edgy. It is quite unclear why that's there, perhaps python-ldap doesn't provide a timeout and things hung forever, I'm

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ This version replaces ipaplatform magic with symlinks generated by configure. It should work with jcholast's PR 159. """ See the full comment at

[Freeipa-devel] [freeipa PR#132][comment] Port all setup.py files to setuptools

2016-10-20 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools pvoborni commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4cd83fb51cc35a2ba7773b62a7aa8d295a1e1e4a

[Freeipa-devel] [freeipa PR#132][+ack] Port all setup.py files to setuptools

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#132][comment] Port all setup.py files to setuptools

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools pspacek commented: """ Jenkins does not complain. ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/132#issuecomment-255142707 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#132][+pushed] Port all setup.py files to setuptools

2016-10-20 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#132][closed] Port all setup.py files to setuptools

2016-10-20 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/132 Author: tiran Title: #132: Port all setup.py files to setuptools Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/132/head:pr132 git checkout pr132 -- Manage your

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ @lslebodn I'm really trying to explain this but I'm still not able to get the point across. > My concerns are related purely to C-code. Please understand that IPA client consists

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ This pull request was (again) rebased on top of PR#171. PR#171 changes ipaplatform handling to symlinks so the issue caused by `__path__` trick should go away. I.e. the

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ This pull request was (again) rebased on top of PR#171. PR#171 changes ipaplatform handling to symlinks so the issue caused by `__path__` trick should go away. I.e. the

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ This PR including additional patches on top have passed build + all XMLRPC tests in Jenkins: job/build_refactoring-build-f24build_refactoring/18/ Additional commits can be found

[Freeipa-devel] [freeipa PR#10][comment] Client-side CSR autogeneration

2016-10-20 Thread LiptonB
URL: https://github.com/freeipa/freeipa/pull/10 Title: #10: Client-side CSR autogeneration LiptonB commented: """ Updated to fix conflicts with master again. I'm not sure what's up with Travis, it seems to be checking out PR #109 instead of this one for the pep8 check: ``` $ cd

Re: [Freeipa-devel] [Design Review Request] V4/Automatic_Certificate_Request_Generation

2016-10-20 Thread Ben Lipton
On 10/17/2016 02:16 AM, Jan Cholasta wrote: On 13.10.2016 17:23, Ben Lipton wrote: Thank you, this was a really helpful clarification of your point. Comments below. Once again, I'm sorry I missed the email for so long. Ben On 09/05/2016 06:52 AM, Jan Cholasta wrote: On 27.8.2016 22:40, Ben

[Freeipa-devel] [freeipa PR#176][opened] cert-show: show validity in default output

2016-10-20 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/176 Author: frasertweedale Title: #176: cert-show: show validity in default output Action: opened PR body: """ cert-show no longer shows validity dates without `--all', but this is important information that should be shown by default. Make it so.

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-10-20 Thread shanyin
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module shanyin commented: """ Yes. As you see, our use case is I'm admin and want to audit what commads were used. - Because I use freeipa 4.3.1 version, adaptation through on this version, I saw the master branch source

[Freeipa-devel] [freeipa PR#175][comment] Remove ipapython/ipa.conf

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/175 Title: #175: Remove ipapython/ipa.conf pspacek commented: """ Sorry for the confusing here. Marking as rejected so it does not pop out in reports. """ See the full comment at https://github.com/freeipa/freeipa/pull/175#issuecomment-255103443

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 lslebodn commented: """ > 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer > solution to me. I do not think it > is that easy as you claim, especially when we count

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 tiran commented: """ I agree with @lslebodn . It should be possible to build only the necessary bits and pieces for an IPA client. It should be rather simple to implement a ```--without-server```

[Freeipa-devel] [freeipa PR#175][comment] Remove ipapython/ipa.conf

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/175 Title: #175: Remove ipapython/ipa.conf pspacek commented: """ Sorry for the confusing here. Marking as rejected so it does not pop out in reports. """ See the full comment at https://github.com/freeipa/freeipa/pull/175#issuecomment-255103443

[Freeipa-devel] [freeipa PR#175][+rejected] Remove ipapython/ipa.conf

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/175 Title: #175: Remove ipapython/ipa.conf Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 lslebodn commented: """ > 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer > solution to me. I do not think it > is that easy as you claim, especially when we count

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 lslebodn commented: """ > 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer > solution to me. I do not think it > is that easy as you claim, especially when we count

[Freeipa-devel] [freeipa PR#132][comment] Port all setup.py files to setuptools

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools tiran commented: """ I have moved /setup.py into /ipaserver/, fixed some make distclean targets (they were still removing setup.py) and made /ipaclient/setup.u install the ipa script. make rpms

[Freeipa-devel] [freeipa PR#132][synchronized] Port all setup.py files to setuptools

2016-10-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/132 Author: tiran Title: #132: Port all setup.py files to setuptools Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/132/head:pr132 git checkout pr132 From