[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-10-24 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir tiran commented: """ Please ack. """ See the full comment at https://github.com/freeipa/freeipa/pull/143#issuecomment-255664324 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#180][opened] Make api.env.nss_dir relative to api.env.confdir

2016-10-24 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/180 Author: tiran Title: #180: Make api.env.nss_dir relative to api.env.confdir Action: opened PR body: """ api.env.nss_dir is no longer hard-coded to paths.IPA_NSSDB_DIR. Instead the path is calculated relatively to api.env.confdir. The default

[Freeipa-devel] [freeipa PR#177][comment] Add options to write lightweight CA cert or chain to file

2016-10-24 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/177 Title: #177: Add options to write lightweight CA cert or chain to file jcholast commented: """ The original review thread is available at: https://www.redhat.com/archives/freeipa-devel/2016-October/msg00578.html """ See the full comment at

[Freeipa-devel] [freeipa PR#143][synchronized] Issue6386 nss dir

2016-10-24 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/143 Author: tiran Title: #143: Issue6386 nss dir Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/143/head:pr143 git checkout pr143 From

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-10-24 Thread shanyin
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module shanyin commented: """ I'm sorry didn't reply your message in time. - I will set up centralized logging environment later. - Because my environment is Ubuntu, currently the latest freeIPA version is 4.3.x, so I can

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-10-24 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#171][+pushed] Build system cleanup phase 2

2016-10-24 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-24 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 dkupka commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/329f080e6ac832ffd568e79ebca9907771f8ad61

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-24 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#182][opened] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-10-24 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Author: tiran Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context Action: opened PR body: """ For 'cli' contexts, the environment variable IPA_CONFDIR overrides the default confdir path. The value of the environment variable

[Freeipa-devel] [freeipa PR#159][+pushed] spec file: clean up BuildRequires

2016-10-24 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-24 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires dkupka commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/21395d1724e6bf044438a8bc25ba028ed38cde8c

[Freeipa-devel] [freeipa PR#159][closed] spec file: clean up BuildRequires

2016-10-24 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 -- Manage your

[Freeipa-devel] [freeipa PR#183][opened] Add __name__ == __main__ guards to setup.pys

2016-10-24 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/183 Author: tiran Title: #183: Add __name__ == __main__ guards to setup.pys Action: opened PR body: """ Signed-off-by: Christian Heimes """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#184][opened] Minor install script fixes

2016-10-24 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/184 Author: simo5 Title: #184: Minor install script fixes Action: opened PR body: """ - Use the correct unicode string for an error message, otherwise an exception will generate another exception about incorrect type, masking the original error. -

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-10-24 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#183][comment] Add __name__ == __main__ guards to setup.pys

2016-10-24 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/183 Title: #183: Add __name__ == __main__ guards to setup.pys mirielka commented: """ Thanks, this fixes setup.py related failure in intree tests. """ See the full comment at https://github.com/freeipa/freeipa/pull/183#issuecomment-255745533 --

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-10-24 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context jcholast commented: """ This seems rather unnecessary to me, as you can do: ``` $ ipa -e confdir=/path/to/confdir command ``` In case there is some shortcoming in the above, I

[Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes

2016-10-24 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/184 Title: #184: Minor install script fixes abbra commented: """ ACK from my side if you would split the commit into two small ones, please. Note that CI integration is currently broken so travis says your commits failed the checks. """ See the

[Freeipa-devel] [freeipa PR#183][comment] Add __name__ == __main__ guards to setup.pys

2016-10-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/183 Title: #183: Add __name__ == __main__ guards to setup.pys pspacek commented: """ @tiran PEP8 errors need to be fixed first: ~~~ ./ipaclient/setup.py:28:80: E501 line too long (80 > 79 characters) ./ipalib/setup.py:28:80: E501 line too long (80 >

[Freeipa-devel] [freeipa PR#184][synchronized] Minor install script fixes

2016-10-24 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/184 Author: simo5 Title: #184: Minor install script fixes Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/184/head:pr184 git checkout pr184 From

Re: [Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes

2016-10-24 Thread Simo Sorce
On Mon, 2016-10-24 at 17:38 +0200, abbra wrote: > URL: https://github.com/freeipa/freeipa/pull/184 > Title: #184: Minor install script fixes > > abbra commented: > """ > ACK from my side if you would split the commit into two small ones, please. > > Note that CI integration is currently broken

Re: [Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes

2016-10-24 Thread Alexander Bokovoy
On ma, 24 loka 2016, Simo Sorce wrote: On Mon, 2016-10-24 at 17:38 +0200, abbra wrote: URL: https://github.com/freeipa/freeipa/pull/184 Title: #184: Minor install script fixes abbra commented: """ ACK from my side if you would split the commit into two small ones, please. Note that CI

[Freeipa-devel] [freeipa PR#181][opened] Tests : User Tracker creation of user with minimal values

2016-10-24 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: opened PR body: """ Fix provide possibility to create user-add test with minimal values, where uid is not specified, to provide better coverage