[Freeipa-devel] [freeipa PR#211][comment] IPA Allows Password Reuse with History value defined when admin reset…

2016-11-02 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/211 Title: #211: IPA Allows Password Reuse with History value defined when admin reset… martbab commented: """ Please address the comment in code. """ See the full comment at https://github.com/freeipa/freeipa/pull/211#issuecomment-257952076 --

[Freeipa-devel] [freeipa PR#211][opened] IPA Allows Password Reuse with History value defined when admin reset…

2016-11-02 Thread tbordaz
URL: https://github.com/freeipa/freeipa/pull/211 Author: tbordaz Title: #211: IPA Allows Password Reuse with History value defined when admin reset… Action: opened PR body: """ …s the password. When admin reset a user password, history of user passwords is preserved according to its policy.

[Freeipa-devel] Is checks/check-ra.py still useful?

2016-11-02 Thread Petr Spacek
Hi, when working on build system refactoring, I've noticed file checks/check-ra.py. README follows: > This directory is for integration tests that require a live backend (LDAP, > Certificate Server, etc.). It's named "checks" so nose wont discover tests > here. Is it still useful? As far as I

Re: [Freeipa-devel] Is checks/check-ra.py still useful?

2016-11-02 Thread Rob Crittenden
Petr Spacek wrote: > Hi, > > when working on build system refactoring, I've noticed file > checks/check-ra.py. > > README follows: >> This directory is for integration tests that require a live backend (LDAP, >> Certificate Server, etc.). It's named "checks" so nose wont discover tests >> here.

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-02 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management tomaskrizek commented: """ I've made some modifications based on the feedback. Since I've changed a lot of code, I've once again tested some use cases manually and fixed all the bugs I was

[Freeipa-devel] [freeipa PR#205][synchronized] Support DAL version 5 and version 6

2016-11-02 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/205 Author: simo5 Title: #205: Support DAL version 5 and version 6 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/205/head:pr205 git checkout pr205 From

[Freeipa-devel] [freeipa PR#205][comment] Support DAL version 5 and version 6

2016-11-02 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/205 Title: #205: Support DAL version 5 and version 6 simo5 commented: """ Updated """ See the full comment at https://github.com/freeipa/freeipa/pull/205#issuecomment-257820109 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-11-02 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-02 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/203 Title: #203: Add sdist_list plugin to all setup.py pspacek commented: """ > 1. redirect stderr and use python setup.py --quiet sdist_list. The order is > import, python setup.py sdist_list --quiet only silences sdist_list command, > not

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-02 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value pspacek commented: """ The approach with wiping env adds another layer of problems, e.g. inability to use `KRB5_TRACE` environment variable for debugging etc. IMHO we should use

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-02 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/203 Title: #203: Add sdist_list plugin to all setup.py pspacek commented: """ > There is nothing to fix here. Just use the --source-list argument. I would rather avoid temporary file and related logic. For this reason I would like to see `--quiet`

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-02 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/203 Title: #203: Add sdist_list plugin to all setup.py tiran commented: """ It can't be done in a clean way. distutils and setuptools starts logging to stdout before the command has a chance to change the log level. I don't want to change the log

[Freeipa-devel] [freeipa PR#209][opened] Enumerate available options in IPA installer

2016-11-02 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/209 Author: Akasurde Title: #209: Enumerate available options in IPA installer Action: opened PR body: """ Fix adds enumerated list of available options in IPA server installer and IPA CA installer help options Fixes

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-02 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value mbasti-rh commented: """ https://fedorahosted.org/freeipa/ticket/6449 """ See the full comment at https://github.com/freeipa/freeipa/pull/204#issuecomment-257847185 -- Manage your

[Freeipa-devel] [freeipa PR#200][synchronized] Test: basic kerberos over http functionality

2016-11-02 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/200 Author: ofayans Title: #200: Test: basic kerberos over http functionality Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/200/head:pr200 git checkout pr200

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-02 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/203 Title: #203: Add sdist_list plugin to all setup.py tiran commented: """ There is nothing to fix here. Just use the ```--source-list``` argument. """ See the full comment at https://github.com/freeipa/freeipa/pull/203#issuecomment-257838678 --

[Freeipa-devel] CSR autogeneration next steps

2016-11-02 Thread Ben Lipton
Hi everybody, Soon I'm going to have to reduce the amount of time I spend on new development work for the CSR autogeneration project, and I want to leave the project in as organized a state as possible. So, I'm taking inventory of the work I've done in order to make sure that what's ready

Re: [Freeipa-devel] [Design Review Request] V4/Automatic_Certificate_Request_Generation

2016-11-02 Thread Ben Lipton
On 10/20/2016 03:52 PM, Ben Lipton wrote: On 10/17/2016 02:16 AM, Jan Cholasta wrote: On 13.10.2016 17:23, Ben Lipton wrote: Thank you, this was a really helpful clarification of your point. Comments below. Once again, I'm sorry I missed the email for so long. Ben On 09/05/2016 06:52 AM, Jan

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-02 Thread rcritten
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value rcritten commented: """ +1 on using absolute paths. I don't recall any cases where KRB5_TRACE was needed so is this a theoretical use case or an actual one? Yes, LD_PRELOAD or

[Freeipa-devel] [freeipa PR#210][opened] Tests: Stage User Tracker implementation

2016-11-02 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: opened PR body: """ Fix provide possibility of creation stage user with minimal values, with uid not specified. Implementation is the same as for User Tracker.

[Freeipa-devel] [freeipa PR#210][synchronized] Tests: Stage User Tracker implementation

2016-11-02 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/210/head:pr210 git checkout pr210

[Freeipa-devel] [freeipa PR#204][closed] ipautil.run: Remove hardcoded environ PATH value

2016-11-02 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/204 Author: mbasti-rh Title: #204: ipautil.run: Remove hardcoded environ PATH value Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/204/head:pr204 git checkout pr204

[Freeipa-devel] [freeipa PR#202][synchronized] ipa-getkeytab enhancements

2016-11-02 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/202 Author: martbab Title: #202: ipa-getkeytab enhancements Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/202/head:pr202 git checkout pr202 From

[Freeipa-devel] [freeipa PR#202][comment] ipa-getkeytab enhancements

2016-11-02 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/202 Title: #202: ipa-getkeytab enhancements martbab commented: """ Thank you for review @simo5 . I have fixed the issues and reworked the LDAP initialization and binding logic a bit to clean it up. It produced green tests for me. I have also

[Freeipa-devel] [freeipa PR#204][comment] ipautil.run: Remove hardcoded environ PATH value

2016-11-02 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value mbasti-rh commented: """ Closing this PR, how to handle environment variables must be discussed and designed first. """ See the full comment at

[Freeipa-devel] [freeipa PR#204][+rejected] ipautil.run: Remove hardcoded environ PATH value

2016-11-02 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/204 Title: #204: ipautil.run: Remove hardcoded environ PATH value Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#208][opened] Tests: Fix integration sudo test

2016-11-02 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/208 Author: mirielka Title: #208: Tests: Fix integration sudo test Action: opened PR body: """ Tests with sudorules using only RunAsGroups attributes with empty RunAsUsers attribute fail due to different expected value than is really returned. This

[Freeipa-devel] [freeipa PR#208][edited] Tests: Fix integration sudo test

2016-11-02 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/208 Author: mirielka Title: #208: Tests: Fix integration sudo test Action: edited Changed field: body Original value: """ Tests with sudorules using only RunAsGroups attributes with empty RunAsUsers attribute fail due to different expected value

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-02 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management jcholast commented: """ In addition to my inline comments: * use component name ("ipaldap", "ldap2", "install", ...) rather than "lda refactoring" as a prefix in commit subjects, * please move

[Freeipa-devel] [freeipa PR#207][opened] Provide user hint about IP address in IPA install

2016-11-02 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/207 Author: Akasurde Title: #207: Provide user hint about IP address in IPA install Action: opened PR body: """ With this fix, user will be notified about pressing enter to proceed with IPA installation procedure, if user has provided valid IP