[Freeipa-devel] [freeipa PR#219][comment] Refactor installer code requesting certificates

2016-11-10 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates flo-renaud commented: """ I updated the patch for renewal lock with a new fix. The timeout needs to be increased, but the lock may also happen because the renewal scripts are run by

[Freeipa-devel] [freeipa PR#229][synchronized] Remove the renewal lock file upon uninstall

2016-11-10 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/229 Author: flo-renaud Title: #229: Remove the renewal lock file upon uninstall Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/229/head:pr229 git checkout

[Freeipa-devel] [freeipa PR#173][closed] Ensure correct IPA CA nickname in DS and HTTP NSSDBs

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/173 Author: frasertweedale Title: #173: Ensure correct IPA CA nickname in DS and HTTP NSSDBs Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/173/head:pr173 git

[Freeipa-devel] [freeipa PR#173][comment] Ensure correct IPA CA nickname in DS and HTTP NSSDBs

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/173 Title: #173: Ensure correct IPA CA nickname in DS and HTTP NSSDBs jcholast commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/cdd41e06e6ef97efafd36ee9e4c8d3be9e4099e7 """ See the full comment at

[Freeipa-devel] [freeipa PR#173][+pushed] Ensure correct IPA CA nickname in DS and HTTP NSSDBs

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/173 Title: #173: Ensure correct IPA CA nickname in DS and HTTP NSSDBs Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#229][comment] Remove the renewal lock file upon uninstall

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall frasertweedale commented: """ Works as expected. """ See the full comment at https://github.com/freeipa/freeipa/pull/229#issuecomment-259883307 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#173][synchronized] Ensure correct IPA CA nickname in DS and HTTP NSSDBs

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/173 Author: frasertweedale Title: #173: Ensure correct IPA CA nickname in DS and HTTP NSSDBs Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/173/head:pr173 git

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context jcholast commented: """ Sorry, but I just don't see an explanation in the comment you linked, just that you think it's easier to set an environment variable rather than an

[Freeipa-devel] [freeipa PR#172][+rejected] fix pki-tomcat error after uninstall

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/172 Title: #172: fix pki-tomcat error after uninstall Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#229][comment] Remove the renewal lock file upon uninstall

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall jcholast commented: """ The file is owned by the server, not the client, so it should be deleted in `ipa-server-install --uninstall`, not in `ipa-client-install --uninstall`. """ See the

[Freeipa-devel] [freeipa PR#187][comment] Register entry points of Custodia plugins

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/187 Title: #187: Register entry points of Custodia plugins tiran commented: """ @simo5 wrote the code. He should know why he did not follow PEP8 naming conventions for the class. """ See the full comment at

[Freeipa-devel] [freeipa PR#229][comment] Remove the renewal lock file upon uninstall

2016-11-10 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall flo-renaud commented: """ You are right, I updated the PR to put the code at the end of server uninstallation. """ See the full comment at

[Freeipa-devel] [freeipa PR#182][synchronized] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Author: tiran Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/182/head:pr182 git

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 tiran commented: """ memo for me: - [ ] /freeipa*.tar.gz is not removed - [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__ and other pyc/pyo. add ```clean-local: rm -rf

[Freeipa-devel] [freeipa PR#219][+ack] Refactor installer code requesting certificates

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#219][comment] Refactor installer code requesting certificates

2016-11-10 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates dkupka commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/7462adec13c5b25b6868d2863dc38062c97d0ff7

[Freeipa-devel] [freeipa PR#219][+pushed] Refactor installer code requesting certificates

2016-11-10 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#219][closed] Refactor installer code requesting certificates

2016-11-10 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/219 Author: flo-renaud Title: #219: Refactor installer code requesting certificates Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/219/head:pr219 git checkout pr219

[Freeipa-devel] [freeipa PR#231][opened] Do not log DM password in ca/kra installation logs

2016-11-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/231 Author: stlaz Title: #231: Do not log DM password in ca/kra installation logs Action: opened PR body: """ We can merge this after refactoring merges not to mess the rebases. https://fedorahosted.org/freeipa/ticket/6461 """ To pull the PR as

[Freeipa-devel] [freeipa PR#226][synchronized] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Author: pspacek Title: #226: Build refactoring phase 5 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/226/head:pr226 git checkout pr226 From

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-11-10 Thread Oleg Fayans
On 11/10/2016 09:43 AM, Martin Basti wrote: ACK On the other hand, make it a conditional one. The link in the comment does not work. Please fix that. -- Milan Kubik -- Milan Kubik After offline discussion and some clarification, the comment is right. ACK -- Milan Kubik

[Freeipa-devel] [freeipa PR#217][+pushed] change certificate processing code to use python-cryptography

2016-11-10 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/217 Title: #217: change certificate processing code to use python-cryptography Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#217][closed] change certificate processing code to use python-cryptography

2016-11-10 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/217 Author: frasertweedale Title: #217: change certificate processing code to use python-cryptography Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/217/head:pr217

[Freeipa-devel] [freeipa PR#217][comment] change certificate processing code to use python-cryptography

2016-11-10 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/217 Title: #217: change certificate processing code to use python-cryptography dkupka commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/9522970bfa28900abc90e959de483f59c79a3e5f

[Freeipa-devel] [freeipa PR#177][synchronized] Add options to write lightweight CA cert or chain to file

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/177 Author: frasertweedale Title: #177: Add options to write lightweight CA cert or chain to file Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/177/head:pr177

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context tiran commented: """ Let me google that for you: * https://specifications.freedesktop.org/basedir-spec/latest/ar01s03.html *

[Freeipa-devel] [freeipa PR#205][closed] Support DAL version 5 and version 6

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/205 Author: simo5 Title: #205: Support DAL version 5 and version 6 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/205/head:pr205 git checkout pr205 -- Manage your

[Freeipa-devel] [freeipa PR#205][comment] Support DAL version 5 and version 6

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/205 Title: #205: Support DAL version 5 and version 6 mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/2775042787be4ea236c0b99dd75337414e24b89d """ See the full comment at

[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir jcholast commented: """ For example, if your `IPA_CONFDIR` PR was merged, setting the variable could break `ipa-client-install`, because the hard coded half of it assumes that the configuration directory is always

[Freeipa-devel] [freeipa PR#168][+rejected] Update cli.py

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/168 Title: #168: Update cli.py Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#182][synchronized] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Author: tiran Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/182/head:pr182 git

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context tiran commented: """ For a long time FreeIPA ignored Python packaging guidelines. It did neither support pip and wheels nor virtual envs or local configuration. There is

[Freeipa-devel] [freeipa PR#226][synchronized] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Author: pspacek Title: #226: Build refactoring phase 5 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/226/head:pr226 git checkout pr226 From

[Freeipa-devel] [freeipa PR#226][comment] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Title: #226: Build refactoring phase 5 pspacek commented: """ I've added missing files to .gitignore. """ See the full comment at https://github.com/freeipa/freeipa/pull/226#issuecomment-259694249 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#226][comment] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Title: #226: Build refactoring phase 5 pspacek commented: """ Rebased on top of current master. """ See the full comment at https://github.com/freeipa/freeipa/pull/226#issuecomment-259695270 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context mbasti-rh commented: """ For the long history of IPA we haven't had need for our own environment variables. I agree with Honza, why we should have the another way how to pass

[Freeipa-devel] [freeipa PR#230][opened] cert-request: accept CSRs with extraneous data

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/230 Author: frasertweedale Title: #230: cert-request: accept CSRs with extraneous data Action: opened PR body: """ The cert-request command used to accept CSRs that had extra data surrounding the PEM data, e.g. commentary about the contents of the

[Freeipa-devel] [freeipa PR#219][comment] Refactor installer code requesting certificates

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates jcholast commented: """ Turns out the request does not time out in certmonger, but the 60 seconds wait in `request_and_wait_for_cert()` it too short. """ See the full comment at

[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir tiran commented: """ No, #182 does not break ```ipa-client-install ``` in a bad way. The command simply refuses to work in the presence of ```IPA_CONFDIR```. ```api.bootstrap()``` does not support

[Freeipa-devel] [freeipa PR#213][edited] Build system refactoring phase 3

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Author: pspacek Title: #213: Build system refactoring phase 3 Action: edited Changed field: body Original value: """ This monster patch-set refactors most of build system and moves most of the logic from SPEC file to build system. It is not

[Freeipa-devel] [freeipa PR#217][+ack] change certificate processing code to use python-cryptography

2016-11-10 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/217 Title: #217: change certificate processing code to use python-cryptography Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [test][patch-0057] test for ticket N 6146 (installing rules with service principals)

2016-11-10 Thread Oleg Fayans
The patch was added to existing PR: https://github.com/freeipa/freeipa/pull/224 On 11/08/2016 05:24 PM, Oleg Fayans wrote: And this one. On 11/03/2016 09:42 AM, Oleg Fayans wrote: One more ping for review On 10/27/2016 02:21 PM, Oleg Fayans wrote: ping for review On 10/25/2016 11:29 AM,

[Freeipa-devel] [freeipa PR#224][synchronized] Integration tests for certs in idoverrides

2016-11-10 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/224 Author: ofayans Title: #224: Integration tests for certs in idoverrides Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/224/head:pr224 git checkout pr224

[Freeipa-devel] [freeipa PR#220][+ack] Build: fix make clean to remove build artifacts from top-level directory

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/220 Title: #220: Build: fix make clean to remove build artifacts from top-level directory Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context jcholast commented: """ "Everyone else does it" is not really a good argument to anything. Just saying. Also you still haven't provided a single example of where explicitly

[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir tiran commented: """ The other locations are used for FreeIPA installation and therefore out of scope for this change. """ See the full comment at

[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir jcholast commented: """ Sure, just please keep this in mind for your other changes. """ See the full comment at https://github.com/freeipa/freeipa/pull/143#issuecomment-259670294 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#228][opened] cert-request: allow directoryName in SAN extension

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/228 Author: frasertweedale Title: #228: cert-request: allow directoryName in SAN extension Action: opened PR body: """ Allow directoryName in SAN extension if the value matches the subject principal's DN in the IPA directory. Fixes:

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-11-10 Thread Martin Basti
On 10.11.2016 10:06, Oleg Fayans wrote: On 11/10/2016 09:43 AM, Martin Basti wrote: ACK On the other hand, make it a conditional one. The link in the comment does not work. Please fix that. -- Milan Kubik -- Milan Kubik After offline discussion and some clarification, the

[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir jcholast commented: """ OK, but you should at least make sure that where the code depends on hard-coded paths, the API is bootstrapped with a hard coded `confdir` as well, otherwise things might break. """ See

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context jcholast commented: """ Care to point me to some actual standard which recommends this? Using explicit configuration via library initialization arguments is no NIH, everyone

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context tiran commented: """ Everyone else does it is a very good argument. Standards and common practices provide a good user and developer experience. I detest _Not Invented Here_

[Freeipa-devel] [freeipa PR#219][comment] Refactor installer code requesting certificates

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates frasertweedale commented: """ Well I couldn't wait 'til tomorrow so I checked just then. I could not reproduce the issue :) """ See the full comment at

[Freeipa-devel] [freeipa PR#219][comment] Refactor installer code requesting certificates

2016-11-10 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates flo-renaud commented: """ Thanks Fraser! The patch for renewal lock file deletion is available at https://github.com/freeipa/freeipa/pull/229 """ See the full comment at

[Freeipa-devel] [freeipa PR#196][comment] ipatests: unresolvable nested netgroups

2016-11-10 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/196 Title: #196: ipatests: unresolvable nested netgroups apophys commented: """ Ping for review. """ See the full comment at https://github.com/freeipa/freeipa/pull/196#issuecomment-259666959 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#173][+ack] Ensure correct IPA CA nickname in DS and HTTP NSSDBs

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/173 Title: #173: Ensure correct IPA CA nickname in DS and HTTP NSSDBs Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#173][comment] Ensure correct IPA CA nickname in DS and HTTP NSSDBs

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/173 Title: #173: Ensure correct IPA CA nickname in DS and HTTP NSSDBs tomaskrizek commented: """ Works as expected. """ See the full comment at https://github.com/freeipa/freeipa/pull/173#issuecomment-259669927 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#227][synchronized] cert-request: match names against principal alises

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/227 Author: frasertweedale Title: #227: cert-request: match names against principal alises Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/227/head:pr227 git

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context tiran commented: """ No, env vars are **the** standard way to change the behavior of a program for a local session. They are used all over the place: MIT KRB5 as KRB5_CONFIG,

[Freeipa-devel] [freeipa PR#180][comment] Make api.env.nss_dir relative to api.env.confdir

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/180 Title: #180: Make api.env.nss_dir relative to api.env.confdir jcholast commented: """ See my comment on #143. """ See the full comment at https://github.com/freeipa/freeipa/pull/180#issuecomment-259663799 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#220][comment] Build: fix make clean to remove build artifacts from top-level directory

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/220 Title: #220: Build: fix make clean to remove build artifacts from top-level directory mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d20f6a5ef2467e780026f1040f5a11a7a77594ca """ See the full comment

[Freeipa-devel] [freeipa PR#220][closed] Build: fix make clean to remove build artifacts from top-level directory

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/220 Author: pspacek Title: #220: Build: fix make clean to remove build artifacts from top-level directory Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#220][+pushed] Build: fix make clean to remove build artifacts from top-level directory

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/220 Title: #220: Build: fix make clean to remove build artifacts from top-level directory Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#219][comment] Refactor installer code requesting certificates

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates jcholast commented: """ Can we fix this in a separate PR to unblock the merge of this one? """ See the full comment at

[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir tiran commented: """ I don't understand your comment. """ See the full comment at https://github.com/freeipa/freeipa/pull/143#issuecomment-259672798 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#225][comment] tests: Added basic tests for certs in idoverrides

2016-11-10 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/225 Title: #225: tests: Added basic tests for certs in idoverrides apophys commented: """ Please address the inline comments. """ See the full comment at https://github.com/freeipa/freeipa/pull/225#issuecomment-259679240 -- Manage your

[Freeipa-devel] [freeipa PR#215][comment] Add script to setup krb5 NFS exports

2016-11-10 Thread rcritten
URL: https://github.com/freeipa/freeipa/pull/215 Title: #215: Add script to setup krb5 NFS exports rcritten commented: """ Quite a lot of this code can be eliminated if you use ipalib instead of manually reading configuration files, forking out to ipa, doing a kinit, etc or do you

[Freeipa-devel] [freeipa PR#214][comment] ipaldap: remove do_bind from LDAPClient

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/214 Title: #214: ipaldap: remove do_bind from LDAPClient mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/a68c95d11612108375877ff45bdb53ce6fc8fbe4 """ See the full comment at

[Freeipa-devel] [freeipa PR#214][closed] ipaldap: remove do_bind from LDAPClient

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/214 Author: tomaskrizek Title: #214: ipaldap: remove do_bind from LDAPClient Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/214/head:pr214 git checkout pr214 --

[Freeipa-devel] [freeipa PR#214][+pushed] ipaldap: remove do_bind from LDAPClient

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/214 Title: #214: ipaldap: remove do_bind from LDAPClient Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#215][comment] Add script to setup krb5 NFS exports

2016-11-10 Thread jumitche
URL: https://github.com/freeipa/freeipa/pull/215 Title: #215: Add script to setup krb5 NFS exports jumitche commented: """ The idea was to produce a script to simplify the setup of kerberos encrypted NFS exports, to make something that was as simple to use as ipa-*-install is, including the

[Freeipa-devel] [freeipa PR#224][comment] Integration tests for certs in idoverrides

2016-11-10 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/224 Title: #224: Integration tests for certs in idoverrides mirielka commented: """ Functionally OK. Please extend commit message for the first commit and add links to tickets if applicable. Also ticket https://fedorahosted.org/freeipa/ticket/6146

[Freeipa-devel] [freeipa PR#214][+ack] ipaldap: remove do_bind from LDAPClient

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/214 Title: #214: ipaldap: remove do_bind from LDAPClient Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#215][synchronized] Add script to setup krb5 NFS exports

2016-11-10 Thread jumitche
URL: https://github.com/freeipa/freeipa/pull/215 Author: jumitche Title: #215: Add script to setup krb5 NFS exports Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/215/head:pr215 git checkout pr215 From

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context jcholast commented: """ @tiran, setting `confdir` explicitly is not a hack, but the proper way to set the config directory path and there is nothing that makes the environment

[Freeipa-devel] [freeipa PR#225][opened] tests: Added basic tests for certs in idoverrides

2016-11-10 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/225 Author: ofayans Title: #225: tests: Added basic tests for certs in idoverrides Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6412 """ To pull the PR as Git branch: git remote add ghfreeipa

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-11-10 Thread Oleg Fayans
All the patches from this thread were converted into github pull requests: [1]: https://github.com/freeipa/freeipa/pull/224 [2]: https://github.com/freeipa/freeipa/pull/225 On 11/09/2016 04:43 PM, Milan KubĂ­k wrote: On 10/25/2016 10:24 AM, Oleg Fayans wrote: Integration part of the tests is

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context tiran commented: """ Everyone else does it is a very good argument. Standards and common practices provide a good user and developer experience. I detest _Not Invented Here_

[Freeipa-devel] [freeipa PR#227][opened] cert-request: match names against principal alises

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/227 Author: frasertweedale Title: #227: cert-request: match names against principal alises Action: opened PR body: """ Currently we do not check Kerberos principal aliases when validating a CSR. Enhance cert-request to accept the following

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context jcholast commented: """ Care to point me to some actual standard which recommends this? Using explicit configuration via library initialization arguments is no NIH, everyone

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context tiran commented: """ Let me google that for you: * https://specifications.freedesktop.org/basedir-spec/latest/ar01s03.html *

[Freeipa-devel] [freeipa PR#219][comment] Refactor installer code requesting certificates

2016-11-10 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates frasertweedale commented: """ @jcholast sure, especially if it is related to renewal locks or some other tangential matter. ( @flo-renaud I have not yet confirmed the cause; will get

[Freeipa-devel] [freeipa PR#168][comment] Update cli.py

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/168 Title: #168: Update cli.py tomaskrizek commented: """ I was not able to find the issue and reproduce the error. Both unicode and ascii strings seem to be printed correctly. Closing for missing issue/reproducer. """ See the full comment at

[Freeipa-devel] [freeipa PR#168][closed] Update cli.py

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/168 Author: Garont Title: #168: Update cli.py Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/168/head:pr168 git checkout pr168 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#229][opened] Remove the renewal lock file upon uninstall

2016-11-10 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/229 Author: flo-renaud Title: #229: Remove the renewal lock file upon uninstall Action: opened PR body: """ Make sure that the file /var/run/ipa/renewal.lock is deleted upon uninstallation, in order to avoid subsequent installation issues. Part of

[Freeipa-devel] [freeipa PR#226][comment] Build refactoring phase 5

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/226 Title: #226: Build refactoring phase 5 tomaskrizek commented: """ I don't understand Makefiles, but I tested building the git snapshots and srpms and it works. Just a few notes: - `make clean` removes only the most recently created tarball -

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context tiran commented: """ The argument is mood. Even now you can't tell which config file ```ipa ping``` is going to load. There are tons of ways to modify behavior, e.g. mount

Re: [Freeipa-devel] [PATCH] webui: Fix coverity bugs

2016-11-10 Thread Petr Vobornik
Commenting only on top, it's too long. ACK for everything. I've rebased patch 90. pushed to master master: * a2525ff64518038eaa64b0d855154a984030f7f3 Coverity - null pointer exception * d4ad0ca04c0ae445c784787a675ac84d2cbfd766 Coverity - null pointer exception *

[Freeipa-devel] [freeipa PR#209][comment] Enumerate available options in IPA installer

2016-11-10 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/209 Title: #209: Enumerate available options in IPA installer Akasurde commented: """ ping """ See the full comment at https://github.com/freeipa/freeipa/pull/209#issuecomment-259639629 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#224][opened] Integration tests for certs in idoverrides

2016-11-10 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/224 Author: ofayans Title: #224: Integration tests for certs in idoverrides Action: opened PR body: """ Original mailing list thread: https://www.redhat.com/archives/freeipa-devel/2016-September/msg00134.html """ To pull the PR as Git branch: git

[Freeipa-devel] [freeipa PR#226][opened] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Author: pspacek Title: #226: Build refactoring phase 5 Action: opened PR body: """ This PR fixes IPA_VERSION_IS_GIT_SNAPSHOT option and vendor version passing from SPEC to configure. At also contains minor cleanup and srpm target which is

Re: [Freeipa-devel] [PATCH] webui: 0084, 0101: refactoring rpc module

2016-11-10 Thread Petr Vobornik
On 08/09/2016 01:29 PM, Pavel Vomacka wrote: > Hello, > > please review attached patches. > > The rpc module is now separated from display layer > and changing activity text while loading metadata. > > https://fedorahosted.org/freeipa/ticket/6144 > > > patch 84: Looks good, works fine, it

[Freeipa-devel] [freeipa PR#143][+ack] Issue6386 nss dir

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#182][+ack] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context tomaskrizek commented: """ In that case, we probably need to properly handle the exception somewhere. Since that's out of the scope of this PR, I'm going to ACK this. We can

[Freeipa-devel] [freeipa PR#180][comment] Make api.env.nss_dir relative to api.env.confdir

2016-11-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/180 Title: #180: Make api.env.nss_dir relative to api.env.confdir tomaskrizek commented: """ I've discussed this change with @jcholast. He doesn't like this change unless we use `nss_dir` everywhere. However, like you mentioned in #143, that might

[Freeipa-devel] [freeipa PR#219][comment] Refactor installer code requesting certificates

2016-11-10 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/219 Title: #219: Refactor installer code requesting certificates flo-renaud commented: """ Hi Fraser, can you check if the renewal lock was released after the last uninstallation? The file /var/run/ipa/renewal.lock should display something like ```

[Freeipa-devel] [freeipa PR#221][closed] gitignore: ignore tar ball

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/221 Author: tomaskrizek Title: #221: gitignore: ignore tar ball Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/221/head:pr221 git checkout pr221 -- Manage your

[Freeipa-devel] [freeipa PR#221][+pushed] gitignore: ignore tar ball

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/221 Title: #221: gitignore: ignore tar ball Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#221][comment] gitignore: ignore tar ball

2016-11-10 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/221 Title: #221: gitignore: ignore tar ball mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/9bb6d8643f4eb7214897de28821839a14a3bcb37 """ See the full comment at

  1   2   >