URL: https://github.com/freeipa/freeipa/pull/62
Author: simo5
Title: #62: Configure Anonymous PKINIT on server install
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/62/head:pr62
git checkout pr62
From
URL: https://github.com/freeipa/freeipa/pull/62
Title: #62: Configure Anonymous PKINIT on server install
simo5 commented:
"""
@martbab your concerns should be addressed in this revision
I also started adding upgrade code, but it is still not fully tested.
In the process I locally get 2 pylint
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast returning cert and chain in `ca_find` when `--all` is given will
incur `n * 2` additional round-trips to Dogtag. I am hesitant to do
URL: https://github.com/freeipa/freeipa/pull/206
Title: #206: Properly handle multiple cookies in rpcclient
mbasti-rh commented:
"""
could you please fix PEP8?
```
./ipalib/rpc.py:702:80: E501 line too long (93 > 79 characters)
```
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
I would like rather explicit pylint version than autodetection
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/293
Author: martbab
Title: #293: Run out-of-tree tests in Travis CI
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/293/head:pr293
git checkout pr293
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/293
Title: #293: Run out-of-tree tests in Travis CI
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/206
Title: #206: Properly handle multiple cookies in rpcclient
simo5 commented:
"""
Sorry I thought this PR was the priv sep one, I have fixes for this, pushing in
a moment.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/293
Title: #293: Run out-of-tree tests in Travis CI
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/5ecaea6bc4f49c2665597ca38fc52f4fae8a9d24
URL: https://github.com/freeipa/freeipa/pull/177
Author: frasertweedale
Title: #177: Add options to write lightweight CA cert or chain to file
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/177/head:pr177
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
But could you make `ca-find` return the cert/chain as well if (and only if)
`--all` is specified? Do not add the `--chain` and `--certificate-out`
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
Could you make `ca-find` return the cert/chain as well if (and only if) `--all`
is specified? Do not add the `--chain` and `--certificate-out` options
URL: https://github.com/freeipa/freeipa/pull/293
Title: #293: Run out-of-tree tests in Travis CI
stlaz commented:
"""
Good. I see the tests pass now and both @tiran's nitpicks and @mbasti-rh's
comment have been resolved, so an ACK is in order.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/293
Title: #293: Run out-of-tree tests in Travis CI
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/206
Title: #206: Properly handle multiple cookies in rpcclient
simo5 commented:
"""
Yes, getting there, be patient, I discovered other stuff as I fixed pylint per
single patch :)
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast returning cert and chain in `ca_find` when `--all` is given will
incur `n * 2` additional round-trips to Dogtag where `n` = number of
URL: https://github.com/freeipa/freeipa/pull/314
Title: #314: RFC: privilege separation for ipa framework code
simo5 commented:
"""
Updated branch, hopefully lint will be happy.
While there I discovered dcerpc.py ws using the HTTP keytab, after discussing
with @abbra we decided to just remove
URL: https://github.com/freeipa/freeipa/pull/62
Author: simo5
Title: #62: Configure Anonymous PKINIT on server install
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/62/head:pr62
git checkout pr62
From
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
Akasurde commented:
"""
@jcholast @mbasti-rh I will work on modifying `Knob()` to handle metavar
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
jcholast commented:
"""
@Akasurde, `Knob()` already handles metavar properly, you need to work on the
interface between the installer and `optparse` - `ipapython.install.cli`.
"""
See
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
mbasti-rh commented:
"""
@jcholast any update? Should reject this PR and wait for `argparse` or fix it
with `optparse` as well? IMO fixing it now is better for UX, we dont know when
or
URL: https://github.com/freeipa/freeipa/pull/316
Author: stlaz
Title: #316: Fix error in permission-find post_callback search
Action: opened
PR body:
"""
This pull requests fixes a bug introduced when fixing a different issue in
URL: https://github.com/freeipa/freeipa/pull/312
Title: #312: bindinstance: use data in named.conf to determine configuration
status
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/f0e09c42b76f229486e5dea097cd2b660243
ipa-4-4:
URL: https://github.com/freeipa/freeipa/pull/312
Title: #312: bindinstance: use data in named.conf to determine configuration
status
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/312
Author: martbab
Title: #312: bindinstance: use data in named.conf to determine configuration
status
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/316
Title: #316: Fix error in permission-find post_callback search
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/316
Author: stlaz
Title: #316: Fix error in permission-find post_callback search
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/316/head:pr316
git checkout pr316
--
URL: https://github.com/freeipa/freeipa/pull/316
Title: #316: Fix error in permission-find post_callback search
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/0c044cb084780ee45860169dd5d12689cf05fa49
URL: https://github.com/freeipa/freeipa/pull/316
Title: #316: Fix error in permission-find post_callback search
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
@frasertweedale, yep, I'm aware of that - `cert-find` does the same. Not a big
deal IMO since it has to be explicitly requested by the user. But
URL: https://github.com/freeipa/freeipa/pull/294
Title: #294: client, platform: Use paths.SSH* instead of get_config_dir().
mbasti-rh commented:
"""
@tjaalton just one nitpick, otherwise it looks good to me
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/284
Title: #284: ipautil: check for open ports on all resolved IPs
mbasti-rh commented:
"""
needs rebase
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/284#issuecomment-265426083
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
mbasti-rh commented:
"""
NACK
You replaced os.random() by ipa_generate_password, but ipa_generate password
does not generate random bytes but random printable characters (entropy--) so
you
URL: https://github.com/freeipa/freeipa/pull/62
Title: #62: Configure Anonymous PKINIT on server install
martbab commented:
"""
I have a few small comments on this PR, nothing serious.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/62#issuecomment-265425006
--
Manage
URL: https://github.com/freeipa/freeipa/pull/314
Title: #314: RFC: privilege separation for ipa framework code
pspacek commented:
"""
@simo5 Please extend the design page with image description which explains each
of the steps. There are numbers and letters in the image which are not
URL: https://github.com/freeipa/freeipa/pull/317
Author: stlaz
Title: #317: Unify password generation across FreeIPA
Action: opened
PR body:
"""
When installing FreeIPA in FIPS mode I noticed that there were often different
ways of generating passwords in different spots raising the same
URL: https://github.com/freeipa/freeipa/pull/314
Title: #314: RFC: privilege separation for ipa framework code
simo5 commented:
"""
Note: this PR also depends on and includes commits from #206
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/314#issuecomment-265432380
--
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
jcholast commented:
"""
@mbasti-rh, I don't care as long as it's done right (i.e. without hardcoding
`cli_metavar` in knob definitions).
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/318
Author: jcholast
Title: #318: server install: fix external CA install
Action: opened
PR body:
"""
Replace the dual definitions of domain_name, dm_password and admin_password
knobs in server install with single definitions using the original
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
mbasti-rh commented:
"""
Please replace this by something sane,
```
return sha1(ipautil.ipa_generate_password()).hexdigest()
```
security by obscurity worked well in Roman empire, but now
Chad Cravens wrote:
> Hello:
>
> We are working with RedHat IDM and I'm trying to understand how
> Permissions and Roles are represented/stored in the LDAP Directory
> Server. What we would like to do is create roles in the web GUI and
> programmatically retrieve the Roles and Permissions, as
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
I had discussion with Petr, and currently we cannot run both pylints in build
system and it is not easy to add it there.
So we have to
URL: https://github.com/freeipa/freeipa/pull/284
Title: #284: ipautil: check for open ports on all resolved IPs
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/a24cd01304aaef77b66d0e178585c9ec8bbce9b5
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/284
Author: tomaskrizek
Title: #284: ipautil: check for open ports on all resolved IPs
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/284/head:pr284
git checkout
URL: https://github.com/freeipa/freeipa/pull/284
Title: #284: ipautil: check for open ports on all resolved IPs
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
It's easily possible with my proposal, just saying:
```make pylint PYTHON=python3```
```make pylint PYTHON=python2```
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
Or we can run both pylints as far as we wants py2/3 compatible versions
"""
See the full comment at
Hello:
We are working with RedHat IDM and I'm trying to understand how Permissions
and Roles are represented/stored in the LDAP Directory Server. What we
would like to do is create roles in the web GUI and programmatically
retrieve the Roles and Permissions, as well as who they are associated
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
PS: I'd rather not run both linters in parallel. We use pylint in parallel
mode, which runs as many workers as CPU cores. ```make pylint```
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
Ok if Petr agree we can go with your proposal
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/292
Title: #292: Increase the timeout waiting for certificate issuance in installer
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/292
Author: flo-renaud
Title: #292: Increase the timeout waiting for certificate issuance in installer
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/292/head:pr292
URL: https://github.com/freeipa/freeipa/pull/292
Title: #292: Increase the timeout waiting for certificate issuance in installer
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/9e3c17c6ded868b4261aa76137c703a4fb866578
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/292
Title: #292: Increase the timeout waiting for certificate issuance in installer
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/320
Author: martbab
Title: #320: add missing attribute to ipaca replica during CA topology update
Action: opened
PR body:
"""
The previous fix for missing 'nsds5replicabinddngroupcheckinterval' fails when
the first CA master is being set up. The
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
But we build both 2/3 versions at once
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/272#issuecomment-265469455
--
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
It makes more sense to follow the principal *test what you build, build what
you test*.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/284
Author: tomaskrizek
Title: #284: ipautil: check for open ports on all resolved IPs
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/284/head:pr284
git
URL: https://github.com/freeipa/freeipa/pull/320
Author: martbab
Title: #320: add missing attribute to ipaca replica during CA topology update
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/320/head:pr320
59 matches
Mail list logo
