[Freeipa-devel] [freeipa PR#315][+ack] [ipa-4-4] gracefully handle setting replica bind dn group on old masters

2016-12-09 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/315 Title: #315: [ipa-4-4] gracefully handle setting replica bind dn group on old masters Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [freeipa PR#314][edited] RFC: privilege separation for ipa framework code

2016-12-09 Thread Simo Sorce
On Fri, 2016-12-09 at 08:31 +0100, Martin Basti wrote: > > On 08.12.2016 22:47, Simo Sorce wrote: > > On Thu, 2016-12-08 at 21:46 +0100, simo5 wrote: > >> URL: https://github.com/freeipa/freeipa/pull/314 > >> Author: simo5 > >> Title: #314: RFC: privilege separation for ipa framework code >

[Freeipa-devel] [freeipa PR#313][comment] ipaclient.plugins: Use api_version from internally called commands

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/313 Title: #313: ipaclient.plugins: Use api_version from internally called commands mbasti-rh commented: """ Can you please provide better commit description in commit message? What, why and how it fixes? Think about our future us when we will be

[Freeipa-devel] [freeipa PR#322][comment] masters DS<1.3.3 do not support bind group

2016-12-09 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/322 Title: #322: masters DS<1.3.3 do not support bind group flo-renaud commented: """ Hi, there is already an open PR for this issue: https://github.com/freeipa/freeipa/pull/319 for master and https://github.com/freeipa/freeipa/pull/315 for

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-09 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA tiran commented: """ @mbasti-rh ```uppercase + lowercase + num + special``` should be limited to a sensible value. A large value invalidates the formula that calculates the length of the

Re: [Freeipa-devel] using Reviewer field on Github instead of Trac

2016-12-09 Thread Martin Basti
On 09.12.2016 09:05, Petr Spacek wrote: Dear FreeIPA developers, I just noticed that Github PRs now have Reviewers field. Can we replace reviewed-by field in Trac with Reviewers field on Github? It is easier to set myself as Reviewer on Github as it does not force me to edit ticket. Assuming

[Freeipa-devel] [freeipa PR#321][comment] certdb: fix PKCS#12 import with empty password

2016-12-09 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/321 Title: #321: certdb: fix PKCS#12 import with empty password dkupka commented: """ Works for me. """ See the full comment at https://github.com/freeipa/freeipa/pull/321#issuecomment-265970429 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#321][+ack] certdb: fix PKCS#12 import with empty password

2016-12-09 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/321 Title: #321: certdb: fix PKCS#12 import with empty password Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#307][+ack] Lowered the version of gettext

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#315][comment] [ipa-4-4] gracefully handle setting replica bind dn group on old masters

2016-12-09 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/315 Title: #315: [ipa-4-4] gracefully handle setting replica bind dn group on old masters flo-renaud commented: """ Hi, thanks for the patch. Everything works as expected. """ See the full comment at

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ ACK, but travis runs tests under PY3 and should be, I tried locally and tests works for me (ipa-run-tests is still py2 by default), so

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ ACK, but travis runs tests under PY3 and should be, I tried locally and tests works for me (ipa-run-tests is still py2 by default), so

[Freeipa-devel] [freeipa PR#319][comment] [master] gracefully handle setting replica bind dn group on old masters

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/319 Title: #319: [master] gracefully handle setting replica bind dn group on old masters martbab commented: """ PR #322 was closed, it was agreed that this fix is better. """ See the full comment at

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time martbab commented: """ I have re-built RPMs in the F25 image and found out that the /usr/bin/ipa command has the following shebang: ``` #!/usr/bin/python3 ``` so

[Freeipa-devel] [freeipa PR#320][comment] add missing attribute to ipaca replica during CA topology update

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/320 Title: #320: add missing attribute to ipaca replica during CA topology update martbab commented: """ @tbordaz mentioned that this fix is better and that we should discard https://github.com/freeipa/freeipa/pull/322. Please continue review. """

[Freeipa-devel] [freeipa PR#322][closed] masters DS<1.3.3 do not support bind group

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/322 Author: tbordaz Title: #322: masters DS<1.3.3 do not support bind group Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/322/head:pr322 git checkout pr322 --

[Freeipa-devel] [freeipa PR#322][comment] masters DS<1.3.3 do not support bind group

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/322 Title: #322: masters DS<1.3.3 do not support bind group martbab commented: """ OK closing and marking as rejected. """ See the full comment at https://github.com/freeipa/freeipa/pull/322#issuecomment-266003647 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#315][comment] [ipa-4-4] gracefully handle setting replica bind dn group on old masters

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/315 Title: #315: [ipa-4-4] gracefully handle setting replica bind dn group on old masters martbab commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/e94046f646d85e1c1ef62e0931b447883026f685 """ See the full comment at

[Freeipa-devel] [freeipa PR#315][closed] [ipa-4-4] gracefully handle setting replica bind dn group on old masters

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/315 Author: martbab Title: #315: [ipa-4-4] gracefully handle setting replica bind dn group on old masters Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#315][+pushed] [ipa-4-4] gracefully handle setting replica bind dn group on old masters

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/315 Title: #315: [ipa-4-4] gracefully handle setting replica bind dn group on old masters Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ `make install` will install whatever is auto-detected during configure (or overriden by `$PYTHON` variable while calling `make install`).

[Freeipa-devel] [freeipa PR#307][comment] Lowered the version of gettext

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/e5686c0ccb4a71fa0ab460fd45280d9adba91cca """ See the full comment at

[Freeipa-devel] [freeipa PR#62][synchronized] Configure Anonymous PKINIT on server install

2016-12-09 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/62 Author: simo5 Title: #62: Configure Anonymous PKINIT on server install Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/62/head:pr62 git checkout pr62 From

[Freeipa-devel] [freeipa PR#307][closed] Lowered the version of gettext

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/307 Author: pvomacka Title: #307: Lowered the version of gettext Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/307/head:pr307 git checkout pr307 -- Manage your

[Freeipa-devel] [freeipa PR#307][+pushed] Lowered the version of gettext

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#139][synchronized] WebUI: Vault Management

2016-12-09 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/139 Author: pvomacka Title: #139: WebUI: Vault Management Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/139/head:pr139 git checkout pr139 From

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ `make install` put `#!/usr/bin/python` into `ipa-run-tests` and it causes that on F25 our tests are running by default under PY3 Probably

[Freeipa-devel] [freeipa PR#322][+rejected] masters DS<1.3.3 do not support bind group

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/322 Title: #322: masters DS<1.3.3 do not support bind group Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time martbab commented: """ Travis installs the built RPMs and then runs server install and outoftree test suite. It does not use `make install`. BTW does this mean

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ @martbab Yes for this PR travis run tests under PY3, see tracebacks it is from python3.5 site-packages """ See the full comment at

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ @martbab Yes for this PR travis run tests under PY3, see tracebacks it is from python3.5 site-packages """ See the full comment at

[Freeipa-devel] [freeipa PR#62][synchronized] Configure Anonymous PKINIT on server install

2016-12-09 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/62 Author: simo5 Title: #62: Configure Anonymous PKINIT on server install Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/62/head:pr62 git checkout pr62 From

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ To be sure I re-built RPMs from this PR using `makerpms.sh` script. My findings are: - `/usr/bin/ipa-run-tests` is a symlink to

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ @tiran True, I would like to have there at least assert witch prevents devs to use more than let say 15% per class and more than 50% together, to prevent silly

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ @tiran True, I would like to have there at least assert witch prevents devs to use more than let say 15% per class and more than 50% together, to prevent silly

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ Relevant parts of SPEC file are here:

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ @martbab Can I do something in the build system to make your CI implementation easier? """ See the full comment at

[Freeipa-devel] [freeipa PR#320][comment] add missing attribute to ipaca replica during CA topology update

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/320 Title: #320: add missing attribute to ipaca replica during CA topology update martbab commented: """ @mbasti-rh also this PR solves a bit different issue that the others (https://github.com/freeipa/freeipa/pull/315 and

[Freeipa-devel] using Reviewer field on Github instead of Trac

2016-12-09 Thread Petr Spacek
Dear FreeIPA developers, I just noticed that Github PRs now have Reviewers field. Can we replace reviewed-by field in Trac with Reviewers field on Github? It is easier to set myself as Reviewer on Github as it does not force me to edit ticket. Assuming the Github workflow works, the ipatool

[Freeipa-devel] [freeipa PR#322][comment] masters DS<1.3.3 do not support bind group

2016-12-09 Thread tbordaz
URL: https://github.com/freeipa/freeipa/pull/322 Title: #322: masters DS<1.3.3 do not support bind group tbordaz commented: """ Oppss I missed that thanks for the heads up. PR #319 and #315 are better fixes for this issue. #322 should be discard """ See the full comment at

[Freeipa-devel] [freeipa PR#282][+ack] replicainstall: give correct error message on DL mismatch

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/282 Title: #282: replicainstall: give correct error message on DL mismatch Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA pspacek commented: """ @mbasti-rh You are missing the point and thus do not answer my question: The docstring does not tell anything about relation of 'entropy' and the output. What is the

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time martbab commented: """ Yep, running `ipa ping` on Fedora 25 confirms this: ``` # ipa ping ipa: ERROR: AttributeError: 'str' object has no attribute 'decode'

[Freeipa-devel] [freeipa PR#282][comment] replicainstall: give correct error message on DL mismatch

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/282 Title: #282: replicainstall: give correct error message on DL mismatch mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/2dcbc9416f1de708336a9afe92a138da9360ec5b """ See the full comment at

[Freeipa-devel] [freeipa PR#282][+pushed] replicainstall: give correct error message on DL mismatch

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/282 Title: #282: replicainstall: give correct error message on DL mismatch Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#282][closed] replicainstall: give correct error message on DL mismatch

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/282 Author: stlaz Title: #282: replicainstall: give correct error message on DL mismatch Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/282/head:pr282 git checkout

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA pspacek commented: """ Guys, I'm confused. What exactly is the purpose of `TokenGenerator`? The docstring does not explain to me what is relation between arguments in `__init__` and

[Freeipa-devel] [freeipa PR#323][opened] ipactl: pass api as argument to services

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/323 Author: mbasti-rh Title: #323: ipactl: pass api as argument to services Action: opened PR body: """ Commit 6409abf1 removes hard dependency of ipalib in ipalatform to avoid cyclic dependenies, this commit updates ipactl accordingly Removes

[Freeipa-devel] [freeipa PR#320][+ack] add missing attribute to ipaca replica during CA topology update

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/320 Title: #320: add missing attribute to ipaca replica during CA topology update Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#320][+pushed] add missing attribute to ipaca replica during CA topology update

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/320 Title: #320: add missing attribute to ipaca replica during CA topology update Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#320][comment] add missing attribute to ipaca replica during CA topology update

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/320 Title: #320: add missing attribute to ipaca replica during CA topology update martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/6086a6dbad21d93ed584d508f9844d73f64a4542

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-09 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ It generates random tokens than can be used as: - passwords - anything else that should be random It is written in class docstring Yes we can randomly generate

[Freeipa-devel] [freeipa PR#324][comment] Check for conflict entries before raising domain level

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/324 Title: #324: Check for conflict entries before raising domain level martbab commented: """ I have some comments regarding the logic of the check. These will also fix the warning reported by pylint checker. """ See the full comment at

[Freeipa-devel] [freeipa PR#319][comment] [master] gracefully handle setting replica bind dn group on old masters

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/319 Title: #319: [master] gracefully handle setting replica bind dn group on old masters martbab commented: """ @flo-renaud I was able to reproduce the issue you observed when trying to test the patch. I have opened an upstream ticket for it

[Freeipa-devel] [freeipa PR#320][closed] add missing attribute to ipaca replica during CA topology update

2016-12-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/320 Author: martbab Title: #320: add missing attribute to ipaca replica during CA topology update Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/320/head:pr320 git