[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-02-13 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code simo5 commented: """ @HonzaCholasta push it before we break it again! :-) """ See the full comment at https://github.com/freeipa/freeipa/pull/314#issuecomment-279538680 -- Manage

[Freeipa-devel] [freeipa PR#462][opened] [WIP] pylint: add custom check for forbidden imports

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/462 Author: MartinBasti Title: #462: [WIP] pylint: add custom check for forbidden imports Action: opened PR body: """ Some modules of FreeIPA should not be imported to some other FreeIPA modules, like ipalib into ipapython This is WIP, it misses a

[Freeipa-devel] [freeipa PR#462][synchronized] [WIP] pylint: add custom check for forbidden imports

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/462 Author: MartinBasti Title: #462: [WIP] pylint: add custom check for forbidden imports Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/462/head:pr462 git

[Freeipa-devel] [freeipa PR#462][comment] [WIP] pylint: add custom check for forbidden imports

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/462 Title: #462: [WIP] pylint: add custom check for forbidden imports tiran commented: """ Can you turn module matching into a regular expression? We need bit more advanced checks, e.g. ```ipalib``` should not import from ```ipaplatform``` except

[Freeipa-devel] [freeipa PR#462][closed] [WIP] pylint: add custom check for forbidden imports

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/462 Author: MartinBasti Title: #462: [WIP] pylint: add custom check for forbidden imports Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/462/head:pr462 git checkout

[Freeipa-devel] [freeipa PR#462][comment] [WIP] pylint: add custom check for forbidden imports

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/462 Title: #462: [WIP] pylint: add custom check for forbidden imports MartinBasti commented: """ @HonzaCholasta has some WIP patches for this in his drawer which may be better than this, so closing this PR in favor of Honza's patches """ See the

[Freeipa-devel] [freeipa PR#459][synchronized] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/459 Author: tiran Title: #459: [WIP] Faster JSON encoder/decoder Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/459/head:pr459 git checkout pr459 From

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder tiran commented: """ @pvoborni I have modified the PR and added a pretty_print option. JSON is now pretty printed for verbose level 2 and higher. The old implementation converted all list to

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 05:05), Christian Heimes wrote: >I'm following the development principals of **minimum viable product**. This >PR solves a critical use case for me. With

[Freeipa-devel] [freeipa PR#444][comment] Allow nsaccountlock to be searched in user-find commands

2017-02-13 Thread redhatrises
URL: https://github.com/freeipa/freeipa/pull/444 Title: #444: Allow nsaccountlock to be searched in user-find commands redhatrises commented: """ @MartinBasti I believe that this is ready for your review. """ See the full comment at

[Freeipa-devel] [freeipa PR#398][synchronized] Support for Certificate Identity Mapping

2017-02-13 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/398 Author: flo-renaud Title: #398: Support for Certificate Identity Mapping Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/398/head:pr398 git checkout pr398

[Freeipa-devel] [freeipa PR#460][opened] [Py3] ipa-server-install, ipa-server-upgrade fixes

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/460 Author: MartinBasti Title: #460: [Py3] ipa-server-install, ipa-server-upgrade fixes Action: opened PR body: """ ipa-server-install --setup-dns now work without BytesWarnings under python3, ipa-server-upgrade should work on IPA side but there

[Freeipa-devel] [freeipa PR#460][synchronized] [Py3] ipa-server-install, ipa-server-upgrade fixes

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/460 Author: MartinBasti Title: #460: [Py3] ipa-server-install, ipa-server-upgrade fixes Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/460/head:pr460 git

[Freeipa-devel] [bind-dyndb-ldap PR#9][comment] Remove duplicate const declaration specifier

2017-02-13 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Title: #9: Remove duplicate const declaration specifier tomaskrizek commented: """ @pemensik Hi, could you please take a look at this PR and ACK? It's just a typo that was preventing a build on fedora rawhide to due some warnings. """

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 03:08), Christian Heimes wrote: >Packaging is a different issue. The PR does not provide RPM packaging for >client-only build. It merely implements

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder pvoborni commented: """ Is there a way(I did not read changes thoroughly) to enable sorting and indentation, e.g. for testing purposes? """ See the full comment at

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Two reasons 1. ```make install``` 2. I need ipatests to be part of the build process in order to get a Python package for tox later. """ See the full comment at

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 03:56), Christian Heimes wrote: >Two reasons > >1. ```make install``` >2. I need ipatests to be part of the build process in order to get a Python

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder tiran commented: """ Why would you want to sort or indent the raw output? The extra verbose output of ```ipa``` just loads and dumps the output a second time. It's less efficient but who cares

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder abbra commented: """ Right, as long as ipa CLI is capable to print formatted debug output, that's enough. """ See the full comment at

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder pvoborni commented: """ It's usually quicker to read raw response in browser than the folded "preview" because everything is visible and no clicking is required. Same for curl testing. But for curl

[Freeipa-devel] [freeipa PR#459][edited] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/459 Author: tiran Title: #459: [WIP] Faster JSON encoder/decoder Action: edited Changed field: title Original value: """ Faster JSON encoder/decoder """ -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ @lslebodn it works even better without your proposed changes. Parts ```ipatests``` work fine for ```--disable-server``` builds. I need the package to run tests. """ See

[Freeipa-devel] [freeipa PR#459][opened] Faster JSON encoder/decoder

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/459 Author: tiran Title: #459: Faster JSON encoder/decoder Action: opened PR body: """ Improve performance of FreeIPA's JSON serializer and deserializer. * Don't indent and sort keys. Both options trigger a slow path in Python's json package.

[Freeipa-devel] [freeipa PR#445][+ack] Remove is_fips_enabled checks in installers and ipactl

2017-02-13 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/445 Title: #445: Remove is_fips_enabled checks in installers and ipactl Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#398][synchronized] Support for Certificate Identity Mapping

2017-02-13 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/398 Author: flo-renaud Title: #398: Support for Certificate Identity Mapping Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/398/head:pr398 git checkout pr398

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder pvoborni commented: """ As mention on meeting, if rpcserver prettyprints into output in debug mode then it is fine. """ See the full comment at

[Freeipa-devel] [freeipa PR#444][comment] Allow nsaccountlock to be searched in user-find commands

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/444 Title: #444: Allow nsaccountlock to be searched in user-find commands MartinBasti commented: """ LGTM, I'll test it later """ See the full comment at https://github.com/freeipa/freeipa/pull/444#issuecomment-279455811 -- Manage your

[Freeipa-devel] [freeipa PR#461][opened] Bump required version of bind-dyndb-ldap to 11.0-2

2017-02-13 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/461 Author: tomaskrizek Title: #461: Bump required version of bind-dyndb-ldap to 11.0-2 Action: opened PR body: """ Fedora release bind-dyndb-ldap 11.0-2 transforms existing named.conf old style API to the new style API. This package version is

[Freeipa-devel] [freeipa PR#445][comment] Remove is_fips_enabled checks in installers and ipactl

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/445 Title: #445: Remove is_fips_enabled checks in installers and ipactl MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/08c71703a44d8aec308781351c3a9dd4a4ba94a7 """ See the full comment at

[Freeipa-devel] [freeipa PR#445][closed] Remove is_fips_enabled checks in installers and ipactl

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/445 Author: stlaz Title: #445: Remove is_fips_enabled checks in installers and ipactl Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/445/head:pr445 git checkout

[Freeipa-devel] [freeipa PR#445][+pushed] Remove is_fips_enabled checks in installers and ipactl

2017-02-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/445 Title: #445: Remove is_fips_enabled checks in installers and ipactl Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 01:25), Christian Heimes wrote: >@lslebodn it works even better without your proposed changes. Parts >```ipatests``` work fine for ```--disable-server```

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Packaging is a different issue. The PR does not provide RPM packaging for client-only build. It merely implements configuration and building without server components.

[Freeipa-devel] [freeipa PR#459][synchronized] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/459 Author: tiran Title: #459: [WIP] Faster JSON encoder/decoder Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/459/head:pr459 git checkout pr459 From

[Freeipa-devel] [freeipa PR#398][synchronized] Support for Certificate Identity Mapping

2017-02-13 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/398 Author: flo-renaud Title: #398: Support for Certificate Identity Mapping Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/398/head:pr398 git checkout pr398

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ I'm following the development principals of **minimum viable product**. This PR solves a critical use case for me. With the PR I can build FreeIPA client packages in a

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder tiran commented: """ ```curl url | python -m json.tool``` """ See the full comment at https://github.com/freeipa/freeipa/pull/459#issuecomment-279375693 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ No, the test runner should either detect missing packages and skip tests automatically, or should grow an option to load and execute client tests only. It's a separate

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-13 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 04:32), Christian Heimes wrote: >No, the test runner should either detect missing packages and skip tests >automatically, or should grow an option to load

[Freeipa-devel] [bind-dyndb-ldap PR#9][opened] Remove duplicate const declaration specifier

2017-02-13 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Author: tomaskrizek Title: #9: Remove duplicate const declaration specifier Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch