[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Thanks for your contribution. I added your patch to my PR. On my system I ran into a minor issue. Some C99 types like ```uint8_t``` were not defined and I had to include

[Freeipa-devel] [freeipa PR#478][opened] [4.4] Do not configure PKI ajp redirection to use "::1"

2017-02-17 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/478 Author: flo-renaud Title: #478: [4.4] Do not configure PKI ajp redirection to use "::1" Action: opened PR body: """ When ipa-server-install configures PKI, it provides a configuration file with the parameter pki_ajp_host set to ::1. This

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ At the moment wheels are not required for RPM building. python-wheel is not available on RHEL, but I can work around it. Should the RPM spec file only contain dependencies

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-17 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop simo5 commented: """ Uhm I just tried setting KRB5CCNAME=/tmp/krb5_httpd in my install and ... I found out we do not actually generate an httpd ccache, so why are we trying to destroy the

[Freeipa-devel] [freeipa PR#395][comment] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" MartinBasti commented: """ Please create a backport PR for IPA 4.4.x """ See the full comment at https://github.com/freeipa/freeipa/pull/395#issuecomment-280656391

[Freeipa-devel] [freeipa PR#395][comment] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/eaa87c75b9f57500265b2dc9480b996b2b92e1e3 """ See the full comment at

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread npmccallum
URL: https://github.com/freeipa/freeipa/pull/469 Title: #469: Ignore unlink error in ipa-otpd.socket npmccallum commented: """ We shouldn't use either. We should use RemoveOnStop= now. """ See the full comment at https://github.com/freeipa/freeipa/pull/469#issuecomment-280657734 -- Manage

[Freeipa-devel] [freeipa PR#477][opened] Use RemoveOnStop to cleanup systemd sockets

2017-02-17 Thread npmccallum
URL: https://github.com/freeipa/freeipa/pull/477 Author: npmccallum Title: #477: Use RemoveOnStop to cleanup systemd sockets Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/477/head:pr477 git

[Freeipa-devel] [freeipa PR#477][comment] Use RemoveOnStop to cleanup systemd sockets

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/477 Title: #477: Use RemoveOnStop to cleanup systemd sockets tiran commented: """ RemoveonStop was added in systemd-214. Let me figure which version is on RHEL. """ See the full comment at

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread npmccallum
URL: https://github.com/freeipa/freeipa/pull/469 Title: #469: Ignore unlink error in ipa-otpd.socket npmccallum commented: """ This PR can be closed. """ See the full comment at https://github.com/freeipa/freeipa/pull/469#issuecomment-280660092 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#469][+rejected] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/469 Title: #469: Ignore unlink error in ipa-otpd.socket Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#477][comment] Use RemoveOnStop to cleanup systemd sockets

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/477 Title: #477: Use RemoveOnStop to cleanup systemd sockets MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d05d1115e409962fee3576a4bfc5cecfacef4fd3 """ See the full comment at

[Freeipa-devel] [freeipa PR#477][+pushed] Use RemoveOnStop to cleanup systemd sockets

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/477 Title: #477: Use RemoveOnStop to cleanup systemd sockets Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#477][closed] Use RemoveOnStop to cleanup systemd sockets

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/477 Author: npmccallum Title: #477: Use RemoveOnStop to cleanup systemd sockets Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/477/head:pr477 git checkout pr477 --

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-17 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ It looks like @tiran does not want to move this PR forward. So here is a link to patch which does not misuse client-only build and add configure time option to install

[Freeipa-devel] [freeipa PR#457][synchronized] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Author: martbab Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/457/head:pr457 git

[Freeipa-devel] [freeipa PR#364][synchronized] Client-only builds with --disable-server

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Author: tiran Title: #364: Client-only builds with --disable-server Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/364/head:pr364 git checkout pr364 From

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ I'm not an expert about how PyPI is working, but shouldn't be there also placeholder packages for: - ipaserver - ipaplatform - ipatests How about [free]ipa-server and

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Shouldn't we have build dependency on `python[3]-wheel` without it `bdist_wheel` target is not working """ See the full comment at

[Freeipa-devel] [freeipa PR#457][comment] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab martbab commented: """ I have added some commits to cope with changes made during privliege spearation work """ See the full comment at

[Freeipa-devel] [freeipa PR#403][closed] Add new ipa passwd-generate command

2017-02-17 Thread redhatrises
URL: https://github.com/freeipa/freeipa/pull/403 Author: redhatrises Title: #403: Add new ipa passwd-generate command Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/403/head:pr403 git checkout pr403 -- Manage

[Freeipa-devel] [freeipa PR#403][comment] Add new ipa passwd-generate command

2017-02-17 Thread redhatrises
URL: https://github.com/freeipa/freeipa/pull/403 Title: #403: Add new ipa passwd-generate command redhatrises commented: """ Thanks @abbra The command would have been `ipa passwd-generate --user user1` without piping any commands to it and would have kept the initial password as well as only

[Freeipa-devel] python-ipaserver & freeipa-server-trust-ad split

2017-02-17 Thread Timo Aaltonen
Hi, So Fedora puts all of dist-packages/ipaserver/* in python-ipaserver, but dcerpc.py imports python-samba which -ipaserver does not depend on. So I've kept dcerpc.py and adtrustinstance.py in freeipa-server-trust-ad on Debian, but now with 4.4.3 (because of fd8c17252fbc) it seems that

[Freeipa-devel] [freeipa PR#471][comment] Fix some privilege separation regressions

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/471 Title: #471: Fix some privilege separation regressions tiran commented: """ @HonzaCholasta, we got merge conflicts. """ See the full comment at https://github.com/freeipa/freeipa/pull/471#issuecomment-280659419 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#468][synchronized] Remove non-sensical kdestroy on https stop

2017-02-17 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Author: simo5 Title: #468: Remove non-sensical kdestroy on https stop Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/468/head:pr468 git checkout pr468 From

[Freeipa-devel] [freeipa PR#368][comment] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox MartinBasti commented: """ Works for me """ See the full comment at https://github.com/freeipa/freeipa/pull/368#issuecomment-280669975 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-17 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop simo5 commented: """ I guess we can simply set KRB5CCNAME=/tmp/krb5_httpd in the unit file and we should be ok then. @martbab or @mbasti, can you try that ? If it solves your scenario we

[Freeipa-devel] [freeipa PR#395][+pushed] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#395][closed] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/395 Author: flo-renaud Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/395/head:pr395

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/469 Title: #469: Ignore unlink error in ipa-otpd.socket simo5 commented: """ @tiran I do not know, @npmccallum may know. """ See the full comment at https://github.com/freeipa/freeipa/pull/469#issuecomment-280656899 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#468][synchronized] Remove non-sensical kdestroy on https stop

2017-02-17 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Author: simo5 Title: #468: Remove non-sensical kdestroy on https stop Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/468/head:pr468 git checkout pr468 From

[Freeipa-devel] [freeipa PR#468][synchronized] Remove non-sensical kdestroy on https stop

2017-02-17 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Author: simo5 Title: #468: Remove non-sensical kdestroy on https stop Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/468/head:pr468 git checkout pr468 From

[Freeipa-devel] [freeipa PR#395][+ack] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-02-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#477][comment] Use RemoveOnStop to cleanup systemd sockets

2017-02-17 Thread npmccallum
URL: https://github.com/freeipa/freeipa/pull/477 Title: #477: Use RemoveOnStop to cleanup systemd sockets npmccallum commented: """ This PR supersedes PR #469. """ See the full comment at https://github.com/freeipa/freeipa/pull/477#issuecomment-280659813 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#477][comment] Use RemoveOnStop to cleanup systemd sockets

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/477 Title: #477: Use RemoveOnStop to cleanup systemd sockets tiran commented: """ RemoveonStop was added in systemd-214. Let me figure which version is on RHEL. """ See the full comment at

[Freeipa-devel] [freeipa PR#477][+ack] Use RemoveOnStop to cleanup systemd sockets

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/477 Title: #477: Use RemoveOnStop to cleanup systemd sockets Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#368][+ack] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#368][comment] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox pvoborni commented: """ ACK given that Martin did functional testing """ See the full comment at https://github.com/freeipa/freeipa/pull/368#issuecomment-280700948 --

[Freeipa-devel] [freeipa PR#368][closed] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/368 Author: pvomacka Title: #368: WebUI: fix incorrect behavior of ESC button on combobox Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/368/head:pr368 git

[Freeipa-devel] [freeipa PR#368][comment] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/1a96e7f9e737941480436269668ccde0a50395f9

[Freeipa-devel] [freeipa PR#472][synchronized] Packaging: Add placeholder packages

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/472 Author: tiran Title: #472: Packaging: Add placeholder packages Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/472/head:pr472 git checkout pr472 From

[Freeipa-devel] [freeipa PR#479][opened] Merge AD trust installer into composite ones

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Author: martbab Title: #479: Merge AD trust installer into composite ones Action: opened PR body: """ This PR implements setup of Samba/Winbind as a part of server/replica install. I will update installation tests in a separate PR in order not

[Freeipa-devel] [freeipa PR#368][+pushed] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#442][+rejected] Add option to run tests in-tree and out-of-tree mode

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/442 Title: #442: Add option to run tests in-tree and out-of-tree mode Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#442][comment] Add option to run tests in-tree and out-of-tree mode

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/442 Title: #442: Add option to run tests in-tree and out-of-tree mode tiran commented: """ Not useful or relevant any more. """ See the full comment at https://github.com/freeipa/freeipa/pull/442#issuecomment-280708021 -- Manage your subscription

[Freeipa-devel] [freeipa PR#442][closed] Add option to run tests in-tree and out-of-tree mode

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/442 Author: tiran Title: #442: Add option to run tests in-tree and out-of-tree mode Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/442/head:pr442 git checkout pr442

[Freeipa-devel] [freeipa PR#453][synchronized] Cleanup certdb

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/453 Author: tiran Title: #453: Cleanup certdb Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/453/head:pr453 git checkout pr453 From

[Freeipa-devel] [freeipa PR#429][synchronized] [py3] ipactl restart: log httplib failues as debug

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/429 Author: MartinBasti Title: #429: [py3] ipactl restart: log httplib failues as debug Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/429/head:pr429 git

[Freeipa-devel] [freeipa PR#429][comment] [py3] ipactl restart: log httplib failues as debug

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/429 Title: #429: [py3] ipactl restart: log httplib failues as debug MartinBasti commented: """ Ticket corrected, commit msg ammended """ See the full comment at https://github.com/freeipa/freeipa/pull/429#issuecomment-280601652 -- Manage your

[Freeipa-devel] [freeipa PR#429][+ack] [py3] ipactl restart: log httplib failues as debug

2017-02-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/429 Title: #429: [py3] ipactl restart: log httplib failues as debug Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#429][comment] [py3] ipactl restart: log httplib failues as debug

2017-02-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/429 Title: #429: [py3] ipactl restart: log httplib failues as debug stlaz commented: """ Thanks, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/429#issuecomment-280602243 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-17 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop abbra commented: """ Yes, when namespaced /tmp is used, unit file does not have any view into that. """ See the full comment at

[Freeipa-devel] [freeipa PR#475][synchronized] Add options to run only ipaclient unittests

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/475 Author: tiran Title: #475: Add options to run only ipaclient unittests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/475/head:pr475 git checkout pr475

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/469 Title: #469: Ignore unlink error in ipa-otpd.socket tiran commented: """ Would you rather use ```/usr/bin/rm -f``` to only ignore missing files but propagate permission errors? I'm not sure why unlink was used in favor of rm. @simo5 ? """ See

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ I have to validate client-only Python wheel packages any way. We can just reuse the same infrastructure to test client-only RPMs later. See PR #475. By the way,

[Freeipa-devel] [freeipa PR#464][synchronized] Bump required python-cryptography version

2017-02-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/464 Author: stlaz Title: #464: Bump required python-cryptography version Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/464/head:pr464 git checkout pr464 From

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ I still fail to see why we should care about `make dist` with `configure --disable-server` this is not a combination of options which should be used together, there

[Freeipa-devel] [freeipa PR#464][comment] Bump required python-cryptography version

2017-02-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/464 Title: #464: Bump required python-cryptography version stlaz commented: """ @martbab Sure, done. """ See the full comment at https://github.com/freeipa/freeipa/pull/464#issuecomment-280596751 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#394][+ack] Add fix for ipa plugins command

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#394][+pushed] Add fix for ipa plugins command

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#394][comment] Add fix for ipa plugins command

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/b3c41f21e51e5389d95b5486dcdfdc3f9a8b0424 """ See the full comment at

[Freeipa-devel] [freeipa PR#394][closed] Add fix for ipa plugins command

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/394 Author: Akasurde Title: #394: Add fix for ipa plugins command Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/394/head:pr394 git checkout pr394 -- Manage your

[Freeipa-devel] [freeipa PR#429][comment] [py3] ipactl restart: log httplib failues as debug

2017-02-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/429 Title: #429: [py3] ipactl restart: log httplib failues as debug stlaz commented: """ I don't see what this has to do with Py3. The issue is the same on Py2. Swap the ticket for the one of @tiran and I'll ack this. If this gets triaged for 4.4

[Freeipa-devel] [freeipa PR#421][synchronized] Update warning message for replica install

2017-02-17 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/421 Author: Akasurde Title: #421: Update warning message for replica install Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/421/head:pr421 git checkout pr421

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server martbab commented: """ Well you won't, and they were not tested automatically before AFAIK (checked with FreeIPA 4.2.0 sources). We can agree that they *should* be, but since this

[Freeipa-devel] [freeipa PR#446][+ack] Add password file to certutil calls in ipapython.certdb module

2017-02-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/446 Title: #446: Add password file to certutil calls in ipapython.certdb module Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#474][comment] Update man page of ipa-server-install

2017-02-17 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/474 Title: #474: Update man page of ipa-server-install Akasurde commented: """ @martbab @stlaz Thanks for review """ See the full comment at https://github.com/freeipa/freeipa/pull/474#issuecomment-280595269 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#396][closed] Explicitly remove support of SSLv2

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/396 Author: stlaz Title: #396: Explicitly remove support of SSLv2 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/396/head:pr396 git checkout pr396 -- Manage your

[Freeipa-devel] [freeipa PR#396][+pushed] Explicitly remove support of SSLv2

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/396 Title: #396: Explicitly remove support of SSLv2 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#396][comment] Explicitly remove support of SSLv2

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/396 Title: #396: Explicitly remove support of SSLv2 MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ac6f573a3014aa09811ca1559d470afe75eadbec """ See the full comment at

[Freeipa-devel] [freeipa PR#446][closed] Add password file to certutil calls in ipapython.certdb module

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/446 Author: stlaz Title: #446: Add password file to certutil calls in ipapython.certdb module Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/446/head:pr446 git

[Freeipa-devel] [freeipa PR#446][+pushed] Add password file to certutil calls in ipapython.certdb module

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/446 Title: #446: Add password file to certutil calls in ipapython.certdb module Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#446][comment] Add password file to certutil calls in ipapython.certdb module

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/446 Title: #446: Add password file to certutil calls in ipapython.certdb module MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ca457eb5ce12291f555f1bf771114d6d7d191987

[Freeipa-devel] [freeipa PR#464][comment] Bump required python-cryptography version

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/464 Title: #464: Bump required python-cryptography version martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/66867319d903f7693a535471d3b81716a258ce9d """ See the full comment at

[Freeipa-devel] [freeipa PR#475][comment] Add options to run only ipaclient unittests

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests tiran commented: """ My first PoC used the approach. ipa-run-tests can already takes arguments to limit tests to subdirectories. One has to remember that ipa-run-tests performs chdir()...

[Freeipa-devel] [freeipa PR#464][+ack] Bump required python-cryptography version

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/464 Title: #464: Bump required python-cryptography version Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#473][comment] Fix session/cookie related issues introduced with the privilege separation patches

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/473 Title: #473: Fix session/cookie related issues introduced with the privilege separation patches MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/b895f4a34bcbd0b1787d2bfc1db25f34c3584b9c

[Freeipa-devel] [freeipa PR#473][closed] Fix session/cookie related issues introduced with the privilege separation patches

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/473 Author: simo5 Title: #473: Fix session/cookie related issues introduced with the privilege separation patches Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#473][+pushed] Fix session/cookie related issues introduced with the privilege separation patches

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/473 Title: #473: Fix session/cookie related issues introduced with the privilege separation patches Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

[Freeipa-devel] [freeipa PR#465][closed] Tests: search for disabled users

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/465 Author: MartinBasti Title: #465: Tests: search for disabled users Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/465/head:pr465 git checkout pr465 -- Manage

[Freeipa-devel] [freeipa PR#465][comment] Tests: search for disabled users

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/465 Title: #465: Tests: search for disabled users MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/79b3fbf97d66adb1f5c960e5473b90f85cbe145a """ See the full comment at

[Freeipa-devel] [freeipa PR#465][+pushed] Tests: search for disabled users

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/465 Title: #465: Tests: search for disabled users Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#464][closed] Bump required python-cryptography version

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/464 Author: stlaz Title: #464: Bump required python-cryptography version Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/464/head:pr464 git checkout pr464 -- Manage

[Freeipa-devel] [freeipa PR#464][+pushed] Bump required python-cryptography version

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/464 Title: #464: Bump required python-cryptography version Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#454][+ack] Move AD trust installation code to a separate module

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/454 Title: #454: Move AD trust installation code to a separate module Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#454][comment] Move AD trust installation code to a separate module

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/454 Title: #454: Move AD trust installation code to a separate module MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/98bf0cc9663ac281247ac8d9ee8488e3ab8102eb """ See the full comment at

[Freeipa-devel] [freeipa PR#454][closed] Move AD trust installation code to a separate module

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/454 Author: martbab Title: #454: Move AD trust installation code to a separate module Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/454/head:pr454 git checkout

[Freeipa-devel] [freeipa PR#454][+pushed] Move AD trust installation code to a separate module

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/454 Title: #454: Move AD trust installation code to a separate module Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop tiran commented: """ How about we use systemd PrivateTmp for temporary files? It is not only more secure but it also automatically removes all temporary files when the service is stopped:

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-17 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (17/02/17 01:12), Petr Vobornik wrote: >I still fail to see why we should care about `make dist` with `configure >--disable-server` this is not a combination of

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop tiran commented: """ That's my point. Why is the ccache file not stored in ```PrivateTmp```? The ccache can be removed at any time. It doesn't have to be retained. ```PrivateTmp``` solves

[Freeipa-devel] [freeipa PR#421][synchronized] Update warning message for replica install

2017-02-17 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/421 Author: Akasurde Title: #421: Update warning message for replica install Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/421/head:pr421 git checkout pr421

[Freeipa-devel] [freeipa PR#421][comment] Update warning message for replica install

2017-02-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/421 Title: #421: Update warning message for replica install stlaz commented: """ Wonderful, thank you for your patch. """ See the full comment at https://github.com/freeipa/freeipa/pull/421#issuecomment-280624285 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#421][comment] Update warning message for replica install

2017-02-17 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/421 Title: #421: Update warning message for replica install Akasurde commented: """ @MartinBasti Thanks for your comments. """ See the full comment at https://github.com/freeipa/freeipa/pull/421#issuecomment-280624790 -- Manage your subscription

[Freeipa-devel] [freeipa PR#476][opened] vault: cache the transport certificate on client

2017-02-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/476 Author: HonzaCholasta Title: #476: vault: cache the transport certificate on client Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6652 """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#25][closed] Added install check before executing ipa-* command

2017-02-17 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/25 Author: Akasurde Title: #25: Added install check before executing ipa-* command Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/25/head:pr25 git checkout pr25 --

[Freeipa-devel] [freeipa PR#470][comment] WebUI: Size limit warning on details pages fixed

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/470 Title: #470: WebUI: Size limit warning on details pages fixed pvoborni commented: """ Would it be better to suppress the warning and use sensible size limit. I.e. the entity select doesn't need to show all entries. I'm afraid that it might have

[Freeipa-devel] [freeipa PR#368][comment] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox pvoborni commented: """ Code LGTM, but I did not tests the behavior, so cannot give ACK now. """ See the full comment at

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-17 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop abbra commented: """ @tiran we do use PrivateTmp already. This is not about PrivateTmp, though, because we don't store credentials caches in a private tmp. """ See the full comment at

[Freeipa-devel] [freeipa PR#429][+pushed] [py3] ipactl restart: log httplib failues as debug

2017-02-17 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/429 Title: #429: [py3] ipactl restart: log httplib failues as debug Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

  1   2   >