[Freeipa-devel] [freeipa PR#596][synchronized] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Author: HonzaCholasta Title: #596: spec file: support client-only build Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/596/head:pr596 git checkout pr596

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build HonzaCholasta commented: """ This PR now depends on PR #597. """ See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286715408 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ >PR #593 is not related to default yes; It is about something else. Current version does not fix concerns; because default should be yes as it was discussed in

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional HonzaCholasta commented: """ @lslebodn, nobody said that this has to be the last lint build related patch ever, we can change the behavior later, even on top of this PR. I would rather push this now and

[Freeipa-devel] [freeipa PR#480][comment] Add request_type doc string in cert-request

2017-03-15 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/480 Title: #480: Add request_type doc string in cert-request Akasurde commented: """ @HonzaCholasta Thanks I will use `no_option` flag and update PR. """ See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-286698411 --

[Freeipa-devel] [freeipa PR#480][edited] Hide request_type doc string in cert-request help

2017-03-15 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/480 Author: Akasurde Title: #480: Hide request_type doc string in cert-request help Action: edited Changed field: title Original value: """ Add request_type doc string in cert-request """ -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#502][+ack] Make pylint and jsl optional

2017-03-15 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#591][comment] spec file: add unconditional python-setuptools BuildRequires

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/591 Title: #591: spec file: add unconditional python-setuptools BuildRequires lslebodn commented: """ Post push comment. This is a reason why there was configure time check in **rejected** PR#494. Spec file change is not very upstream friendly.

[Freeipa-devel] [freeipa PR#560][+ack] rpcserver: x509_login: Handle unsuccessful certificate login gracefully

2017-03-15 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/560 Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#560][comment] rpcserver: x509_login: Handle unsuccessful certificate login gracefully

2017-03-15 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/560 Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully flo-renaud commented: """ Hi, the invalid cert login correctly returns 401. """ See the full comment at

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build tiran commented: """ ```ipa-getkeytab``` uses ```libini_config``` and ```libsasl2```. """ See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286687873 -- Manage

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build HonzaCholasta commented: """ I can't, both are required to build client components (`ipa-getkeytab` specifically), moving them to the server section would break client-only RPM build. """ See

[Freeipa-devel] [freeipa PR#598][opened] Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/598 Author: tiran Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb Action: opened PR body: """ Debian packages should be installed under dist-packages, not site-packages. Debian has patched distutils and setuptools to add a

[Freeipa-devel] [freeipa PR#480][edited] Hide request_type doc string in cert-request help

2017-03-15 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/480 Author: Akasurde Title: #480: Hide request_type doc string in cert-request help Action: edited Changed field: body Original value: """ Fix adds correct description to request_type argument in cert-request command help Fixes

[Freeipa-devel] [freeipa PR#596][synchronized] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Author: HonzaCholasta Title: #596: spec file: support client-only build Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/596/head:pr596 git checkout pr596

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ >PR #593 is not related to default yes; It is about something else. Current version does not fix concerns; because default should be yes as it was discussed in

[Freeipa-devel] [freeipa PR#596][synchronized] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Author: HonzaCholasta Title: #596: spec file: support client-only build Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/596/head:pr596 git checkout pr596

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build pvomacka commented: """ @HonzaCholasta Thank you for update - only client build on Fedora now works. So ACK once the travis pass. """ See the full comment at

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ > This PR makes packaging IPA 4.5 on RHEL 7 easier for me, so thumbs up from me. I understand it is more convenient to have less extra configure options in rhel; But it was

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ On (14/03/17 16:05), Christian Heimes wrote: >https://github.com/freeipa/freeipa/pull/502#issue-209980292 > >two thumbs up, one heart, no thumbs down > My naive assumption was

[Freeipa-devel] [freeipa PR#589][comment] ipaplatform/debian/paths: Add some missing values.

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/589 Title: #589: ipaplatform/debian/paths: Add some missing values. MartinBasti commented: """ master: * e20ad9c251d9118959e501cd49997662de8cdbfc ipaplatform/debian/paths: Add some missing values. """ See the full comment at

[Freeipa-devel] [freeipa PR#589][closed] ipaplatform/debian/paths: Add some missing values.

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/589 Author: tjaalton Title: #589: ipaplatform/debian/paths: Add some missing values. Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/589/head:pr589 git checkout pr589

[Freeipa-devel] [freeipa PR#589][+pushed] ipaplatform/debian/paths: Add some missing values.

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/589 Title: #589: ipaplatform/debian/paths: Add some missing values. Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build lslebodn commented: """ You can also move few dependencies to server only build ``` BuildRequires: libini_config-devel BuildRequires: cyrus-sasl-devel ``` Check spec file changes in

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build pvomacka commented: """ Client only build does not work on Fedora. So NACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286692657 -- Manage your

[Freeipa-devel] [freeipa PR#594][synchronized] Fix Python 3 pylint errors

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/594 Author: tiran Title: #594: Fix Python 3 pylint errors Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/594/head:pr594 git checkout pr594 From

[Freeipa-devel] [freeipa PR#593][synchronized] WIP: Add make patchcheck for developers

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/593 Author: tiran Title: #593: WIP: Add make patchcheck for developers Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/593/head:pr593 git checkout pr593 From

[Freeipa-devel] [freeipa PR#475][synchronized] Add options to run only ipaclient unittests

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/475 Author: tiran Title: #475: Add options to run only ipaclient unittests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/475/head:pr475 git checkout pr475

[Freeipa-devel] [freeipa PR#480][synchronized] Add request_type doc string in cert-request

2017-03-15 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/480 Author: Akasurde Title: #480: Add request_type doc string in cert-request Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/480/head:pr480 git checkout pr480

[Freeipa-devel] [freeipa PR#597][synchronized] spec file: support build without ipatests

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/597 Author: HonzaCholasta Title: #597: spec file: support build without ipatests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/597/head:pr597 git checkout

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build lslebodn commented: """ On (15/03/17 02:32), Jan Cholasta wrote: >I can't, both are required to build client components (`ipa-getkeytab` >specifically), moving them to the server section would

[Freeipa-devel] [freeipa PR#594][synchronized] Fix Python 3 pylint errors

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/594 Author: tiran Title: #594: Fix Python 3 pylint errors Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/594/head:pr594 git checkout pr594 From

[Freeipa-devel] [freeipa PR#517][synchronized] [WIP] Use Custodia 0.3 features

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/517 Author: tiran Title: #517: [WIP] Use Custodia 0.3 features Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/517/head:pr517 git checkout pr517 From

[Freeipa-devel] [freeipa PR#596][synchronized] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Author: HonzaCholasta Title: #596: spec file: support client-only build Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/596/head:pr596 git checkout pr596

[Freeipa-devel] [freeipa PR#595][+ack] idviews: correctly handle modification of non-existent view

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/595 Title: #595: idviews: correctly handle modification of non-existent view Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#592][closed] slapi plugins: fix CFLAGS

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/592 Author: HonzaCholasta Title: #592: slapi plugins: fix CFLAGS Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/592/head:pr592 git checkout pr592 -- Manage your

[Freeipa-devel] [freeipa PR#592][+pushed] slapi plugins: fix CFLAGS

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/592 Title: #592: slapi plugins: fix CFLAGS Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#595][closed] idviews: correctly handle modification of non-existent view

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/595 Author: martbab Title: #595: idviews: correctly handle modification of non-existent view Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/595/head:pr595 git

[Freeipa-devel] [freeipa PR#595][comment] idviews: correctly handle modification of non-existent view

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/595 Title: #595: idviews: correctly handle modification of non-existent view MartinBasti commented: """ master: * 1cdd5dee006426c996f67240b6cb2c1aa05e5168 idviews: correctly handle modification of non-existent view """ See the full comment at

[Freeipa-devel] [freeipa PR#595][+pushed] idviews: correctly handle modification of non-existent view

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/595 Title: #595: idviews: correctly handle modification of non-existent view Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#588][comment] CONFIGURE: Properly detect libpopt on el7

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/588 Title: #588: CONFIGURE: Properly detect libpopt on el7 HonzaCholasta commented: """ master: * 4fe9166ac9f9a100d69ce37f19ae1ae971bb2ce1 CONFIGURE: Properly detect libpopt on el7 """ See the full comment at

[Freeipa-devel] [freeipa PR#588][closed] CONFIGURE: Properly detect libpopt on el7

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/588 Author: HonzaCholasta Title: #588: CONFIGURE: Properly detect libpopt on el7 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/588/head:pr588 git checkout pr588 --

[Freeipa-devel] [freeipa PR#588][+pushed] CONFIGURE: Properly detect libpopt on el7

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/588 Title: #588: CONFIGURE: Properly detect libpopt on el7 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#592][comment] slapi plugins: fix CFLAGS

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/592 Title: #592: slapi plugins: fix CFLAGS HonzaCholasta commented: """ master: * b7329e31f5c985b9721e3a21b1cd1bec6430129d slapi plugins: fix CFLAGS """ See the full comment at https://github.com/freeipa/freeipa/pull/592#issuecomment-286677194 --

[Freeipa-devel] [freeipa PR#597][opened] spec file: support build without ipatests

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/597 Author: HonzaCholasta Title: #597: spec file: support build without ipatests Action: opened PR body: """ Build ipatests only if %with_ipatests RPM macro is specified. By default the macro is specified if ONLY_CLIENT is not specified. """ To

[Freeipa-devel] [freeipa PR#588][+ack] CONFIGURE: Properly detect libpopt on el7

2017-03-15 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/588 Title: #588: CONFIGURE: Properly detect libpopt on el7 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [DRAFT] Release notes FreeIPA 4.5.0

2017-03-15 Thread Fraser Tweedale
On Wed, Mar 15, 2017 at 09:13:35AM +0100, Martin Basti wrote: > > > On 15.03.2017 00:49, Fraser Tweedale wrote: > > On Tue, Mar 14, 2017 at 01:51:19PM +0100, Martin Basti wrote: > >> Hello, > >> > >> DRAFT for FreeIPA 4.5.0 release notes is ready > >> http://www.freeipa.org/page/Releases/4.5.0 >

[Freeipa-devel] [freeipa PR#596][synchronized] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Author: HonzaCholasta Title: #596: spec file: support client-only build Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/596/head:pr596 git checkout pr596

[Freeipa-devel] [freeipa PR#594][synchronized] Fix Python 3 pylint errors

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/594 Author: tiran Title: #594: Fix Python 3 pylint errors Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/594/head:pr594 git checkout pr594 From

[Freeipa-devel] [freeipa PR#598][+ack] Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/598 Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#596][synchronized] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Author: HonzaCholasta Title: #596: spec file: support client-only build Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/596/head:pr596 git checkout pr596

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ On (15/03/17 05:17), Jan Cholasta wrote: >@lslebodn, nobody said that this has to be the last lint build related patch >ever, we can change the behavior later, even on top of this

[Freeipa-devel] [freeipa PR#600][comment] CONFIGURE: Improve detection of xmlrpc_c flags

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/600 Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags lslebodn commented: """ @tjaalton It should simplify you work on debian """ See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286733233 -- Manage your

[Freeipa-devel] [freeipa PR#597][+pushed] spec file: support build without ipatests

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/597 Title: #597: spec file: support build without ipatests Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#597][comment] spec file: support build without ipatests

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/597 Title: #597: spec file: support build without ipatests HonzaCholasta commented: """ master: * e42a846506ee7ad5e8a395da154bec64f6be3654 spec file: support build without ipatests """ See the full comment at

[Freeipa-devel] [freeipa PR#598][comment] Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb

2017-03-15 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/598 Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb tjaalton commented: """ Yep, works great, thanks! """ See the full comment at https://github.com/freeipa/freeipa/pull/598#issuecomment-286727748 -- Manage your subscription

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional HonzaCholasta commented: """ 4.5.1 will be an official release too. """ See the full comment at https://github.com/freeipa/freeipa/pull/502#issuecomment-286727609 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#597][synchronized] spec file: support build without ipatests

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/597 Author: HonzaCholasta Title: #597: spec file: support build without ipatests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/597/head:pr597 git checkout

[Freeipa-devel] [freeipa PR#596][synchronized] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Author: HonzaCholasta Title: #596: spec file: support client-only build Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/596/head:pr596 git checkout pr596

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build HonzaCholasta commented: """ Now that PR #502 was pushed this should finally work. """ See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286729368 -- Manage your

[Freeipa-devel] [freeipa PR#599][synchronized] CONFIGURE: Improve error messages for optional dependencies

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/599 Author: lslebodn Title: #599: CONFIGURE: Improve error messages for optional dependencies Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/599/head:pr599 git

[Freeipa-devel] [freeipa PR#590][comment] Validate user input for cert-get-requestdata

2017-03-15 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/590 Title: #590: Validate user input for cert-get-requestdata Akasurde commented: """ @rcritten I don't know about backward compatibility of changing helper to StrEnum. @MartinBasti @HonzaCholasta Can you please comment on this? """ See the full

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional pvoborni commented: """ There was no result in the upstream discussion. My personal opinion is that one way or the other can work. They are for different use cases. I tend to prefer the "be easier for

[Freeipa-devel] [freeipa PR#502][closed] Make pylint and jsl optional

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/502 Author: tiran Title: #502: Make pylint and jsl optional Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/502/head:pr502 git checkout pr502 -- Manage your

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional HonzaCholasta commented: """ master: * f1f63506caf88e4d86ea2bfdc7d25eceaf689bc5 Make pylint and jsl optional """ See the full comment at

[Freeipa-devel] [freeipa PR#502][+pushed] Make pylint and jsl optional

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional pvoborni commented: """ If it improves messages then I assume so provided that in won't be controversial in other aspects. """ See the full comment at

[Freeipa-devel] [freeipa PR#599][opened] CONFIGURE: Improve error messages for optional dependencies

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/599 Author: lslebodn Title: #599: CONFIGURE: Improve error messages for optional dependencies Action: opened PR body: """ https://www.redhat.com/archives/freeipa-devel/2017-March/msg00307.html """ To pull the PR as Git branch: git remote add

[Freeipa-devel] [freeipa PR#598][+pushed] Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/598 Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#598][closed] Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/598 Author: tiran Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/598/head:pr598 git checkout

[Freeipa-devel] [freeipa PR#598][comment] Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/598 Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb MartinBasti commented: """ master: * b280c7bb0192485dfb622c731e31deb89d517b6f Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb """ See the full comment at

[Freeipa-devel] [freeipa PR#600][opened] CONFIGURE: Improve detection of xmlrpc_c flags

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/600 Author: lslebodn Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags Action: opened PR body: """ The pkg-config files for xmlrpc_c libraries are shipped just in fedora/rhel due to downstream patch. Debian does not have pkg-config files

[Freeipa-devel] [freeipa PR#600][comment] CONFIGURE: Improve detection of xmlrpc_c flags

2017-03-15 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/600 Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags abbra commented: """ LGTM. Falling back to a standard check is fine. """ See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286735880 -- Manage your

[Freeipa-devel] [freeipa PR#590][comment] Validate user input for cert-get-requestdata

2017-03-15 Thread rcritten
URL: https://github.com/freeipa/freeipa/pull/590 Title: #590: Validate user input for cert-get-requestdata rcritten commented: """ You are duplicating the list of helpers. It would have been better to have helper defined as a StrEnum. If it isn't too late to change (e.g. no release has

[Freeipa-devel] [freeipa PR#590][comment] Validate user input for cert-get-requestdata

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/590 Title: #590: Validate user input for cert-get-requestdata MartinBasti commented: """ I have no context about how exactly certrequest is supposed to work, but IMO it was done in that way to allow dynamically adding more helpers as plugins,

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional tiran commented: """ @pvoborni For the use case "easy for developers" the ```make lint``` target is not sufficient. It tests only a small subset and doesn't check Python 3 issues. PR #593 provides a

[Freeipa-devel] [freeipa PR#599][comment] CONFIGURE: Improve error messages for optional dependencies

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/599 Title: #599: CONFIGURE: Improve error messages for optional dependencies tiran commented: """ NACK, you are changing the spirit of the accepted PR #502. """ See the full comment at

[Freeipa-devel] [freeipa PR#599][comment] CONFIGURE: Improve error messages for optional dependencies

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/599 Title: #599: CONFIGURE: Improve error messages for optional dependencies lslebodn commented: """ >NACK, you are changing the spirit of the accepted PR #502. The approach PR #502 was not accepted in upstream discussion

[Freeipa-devel] [freeipa PR#601][+ack] spec file: always provide python package aliases

2017-03-15 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/601 Title: #601: spec file: always provide python package aliases Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build pvomacka commented: """ ipa server build without tests does not work, so NACK """ See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286728170 -- Manage your

[Freeipa-devel] [freeipa PR#599][comment] CONFIGURE: Improve error messages for optional dependencies

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/599 Title: #599: CONFIGURE: Improve error messages for optional dependencies lslebodn commented: """ @tiran one more time: The approach in PR #502 was not accepted in upstream discussion

[Freeipa-devel] [freeipa PR#597][+ack] spec file: support build without ipatests

2017-03-15 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/597 Title: #597: spec file: support build without ipatests Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#601][opened] spec file: always provide python package aliases

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/601 Author: HonzaCholasta Title: #601: spec file: always provide python package aliases Action: opened PR body: """ Provide python-ipa* aliases for python2-ipa* subpackages when the python_provide RPM macro is not available. """ To pull the PR as

[Freeipa-devel] [freeipa PR#596][comment] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build HonzaCholasta commented: """ master: * 417f1926c48b426b34b18edb28869f4f06824873 spec file: support client-only build """ See the full comment at

[Freeipa-devel] [freeipa PR#596][closed] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Author: HonzaCholasta Title: #596: spec file: support client-only build Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/596/head:pr596 git checkout pr596 --

[Freeipa-devel] [freeipa PR#596][+pushed] spec file: support client-only build

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/596 Title: #596: spec file: support client-only build Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#597][closed] spec file: support build without ipatests

2017-03-15 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/597 Author: HonzaCholasta Title: #597: spec file: support build without ipatests Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/597/head:pr597 git checkout pr597 --

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ On (15/03/17 05:32), Petr Vobornik wrote: >In any case spending so much time discussing so minor change is a waste of >time. I'd push it. > Will you accept patch whith improves

[Freeipa-devel] [freeipa PR#594][comment] Fix Python 3 pylint errors

2017-03-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/594 Title: #594: Fix Python 3 pylint errors tiran commented: """ @stlaz I fixed the problem with shadowed builtin type ```type```. """ See the full comment at https://github.com/freeipa/freeipa/pull/594#issuecomment-286729958 -- Manage your

[Freeipa-devel] [freeipa PR#594][+ack] Fix Python 3 pylint errors

2017-03-15 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/594 Title: #594: Fix Python 3 pylint errors Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#600][comment] CONFIGURE: Improve detection of xmlrpc_c flags

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/600 Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags MartinBasti commented: """ Could you add ticket to commit message please https://fedorahosted.org/freeipa/ticket/6418 """ See the full comment at

[Freeipa-devel] [freeipa PR#560][comment] rpcserver: x509_login: Handle unsuccessful certificate login gracefully

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/560 Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully MartinBasti commented: """ master: * 70889d4d5e7e2bd65ab1d4a28e5eda4a51c9b0c0 rpcserver: x509_login: Handle unsuccessful certificate login gracefully """ See

[Freeipa-devel] [freeipa PR#560][closed] rpcserver: x509_login: Handle unsuccessful certificate login gracefully

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/560 Author: dkupka Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#560][+pushed] rpcserver: x509_login: Handle unsuccessful certificate login gracefully

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/560 Title: #560: rpcserver: x509_login: Handle unsuccessful certificate login gracefully Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#480][synchronized] Add request_type doc string in cert-request

2017-03-15 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/480 Author: Akasurde Title: #480: Add request_type doc string in cert-request Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/480/head:pr480 git checkout pr480

[Freeipa-devel] [freeipa PR#590][synchronized] Validate user input for cert-get-requestdata

2017-03-15 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/590 Author: Akasurde Title: #590: Validate user input for cert-get-requestdata Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/590/head:pr590 git checkout pr590

[Freeipa-devel] [freeipa PR#598][comment] Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/598 Title: #598: Add PYTHON_INSTALL_EXTRA_OPTIONS and --install-layout=deb MartinBasti commented: """ @tjaalton could you please check this PR? """ See the full comment at https://github.com/freeipa/freeipa/pull/598#issuecomment-286719071 --

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ > This PR makes packaging IPA 4.5 on RHEL 7 easier for me, so thumbs up from me. I understand it is more convenient to have less extra configure options in rhel; But it was

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ >PR #593 is not related to default yes; It is about something else. Current version does not fix concerns; because default should be yes as it was discussed in

[Freeipa-devel] [freeipa PR#590][comment] Validate user input for cert-get-requestdata

2017-03-15 Thread LiptonB
URL: https://github.com/freeipa/freeipa/pull/590 Title: #590: Validate user input for cert-get-requestdata LiptonB commented: """ I don't think one could really add a new helper without modifying the code, so there's probably no need to allow arbitrary strings. Given that, StrEnum seems

  1   2   >