[Freeipa-devel] [freeipa PR#622][opened] replica prepare: fix wrong IPA CA nickname in replica file

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/622 Author: HonzaCholasta Title: #622: replica prepare: fix wrong IPA CA nickname in replica file Action: opened PR body: """ Lookup IPA CA subject and pass it to CertDB when creating dscert.p12 and httpcert.p12, otherwise a generic nickname will

[Freeipa-devel] [freeipa PR#623][opened] client install: do not assume /etc/krb5.conf.d exists

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/623 Author: HonzaCholasta Title: #623: client install: do not assume /etc/krb5.conf.d exists Action: opened PR body: """ Add `includedir /etc/krb5.conf.d` to /etc/krb5.conf only if /etc/krb5.conf.d exists. This fixes client install on platforms

[Freeipa-devel] [freeipa PR#623][comment] client install: do not assume /etc/krb5.conf.d exists

2017-03-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/623 Title: #623: client install: do not assume /etc/krb5.conf.d exists tiran commented: """ I'd rather create ```/etc/krb5.conf.d``` than to make the line conditional. """ See the full comment at

[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/616 Title: #616: Simplify KRA transport cert cache HonzaCholasta commented: """ @tiran, * patches targeted at backport branches should be as small as possible, * it's hard to see what is an actual change and what is just a formatting / naming

[Freeipa-devel] [freeipa PR#623][comment] client install: do not assume /etc/krb5.conf.d exists

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/623 Title: #623: client install: do not assume /etc/krb5.conf.d exists HonzaCholasta commented: """ There is no reason to, the directory is not owned by us and we don't use it for anything anyway (see ticket triage for relevant discussion). """ See

[Freeipa-devel] [freeipa PR#624][opened] Use connection keep-alive

2017-03-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/624 Author: tiran Title: #624: Use connection keep-alive Action: opened PR body: """ Do not forcefully close the connection after every request. This enables HTTP connection keep-alive, also known as persistent TCP and TLS/SSL connection.

[Freeipa-devel] [freeipa PR#608][comment] tasks: run `systemctl daemon-reload` after httpd.service.d updates

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/608 Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates HonzaCholasta commented: """ @martbab, and httpd journal as well. """ See the full comment at https://github.com/freeipa/freeipa/pull/608#issuecomment-287747491 --

[Freeipa-devel] [freeipa PR#625][comment] [RFC] remote plugins: add option to force compat plugins

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/625 Title: #625: [RFC] remote plugins: add option to force compat plugins HonzaCholasta commented: """ @tiran, please review this, I'm not sure whether this kind of workaround is good enough or not. """ See the full comment at

[Freeipa-devel] [freeipa PR#608][comment] tasks: run `systemctl daemon-reload` after httpd.service.d updates

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/608 Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates HonzaCholasta commented: """ @martbab, can I see httpd error_log? Uninstall works fine for me. """ See the full comment at

[Freeipa-devel] [freeipa PR#626][edited] Move helper code for integration plugin

2017-03-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/626 Author: tiran Title: #626: Move helper code for integration plugin Action: edited Changed field: body Original value: """ Helper code for ```ipatests.pytest_plugins.integration``` was in ```ipatests.test_integration```. This doesn't play nice

[Freeipa-devel] [freeipa PR#629][opened] adtrust: make sure that runtime hostname result is consistent with the configuration

2017-03-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/629 Author: abbra Title: #629: adtrust: make sure that runtime hostname result is consistent with the configuration Action: opened PR body: """ FreeIPA's `ipasam` module to Samba uses gethostname() call to identify own server's host name. This

[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/616 Title: #616: Simplify KRA transport cert cache HonzaCholasta commented: """ @tiran, you are right about the interface change, I was seeing things that are not there, I'm sorry. Please address inline comments (mainly the one about missing info

[Freeipa-devel] [freeipa PR#616][edited] Simplify KRA transport cert cache

2017-03-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/616 Author: tiran Title: #616: Simplify KRA transport cert cache Action: edited Changed field: body Original value: """ In-memory cache causes problem in forking servers. A file based cache is good enough. It's easier to understand and avoids

[Freeipa-devel] [freeipa PR#266][closed] ipapython: simplify Env object initialization

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/266 Author: HonzaCholasta Title: #266: ipapython: simplify Env object initialization Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/266/head:pr266 git checkout pr266

[Freeipa-devel] [freeipa PR#623][comment] client install: do not assume /etc/krb5.conf.d exists

2017-03-20 Thread puiterwijk
URL: https://github.com/freeipa/freeipa/pull/623 Title: #623: client install: do not assume /etc/krb5.conf.d exists puiterwijk commented: """ Would you be upgrading the krb5.conf after people upgrade krb5-libs to include the new includedir then? Since that's what would happen if you don't

[Freeipa-devel] [freeipa PR#623][comment] client install: do not assume /etc/krb5.conf.d exists

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/623 Title: #623: client install: do not assume /etc/krb5.conf.d exists HonzaCholasta commented: """ @puiterwijk, upgrade will be handled by krb5 itself, see https://bugzilla.redhat.com/show_bug.cgi?id=1431198. """ See the full comment at

[Freeipa-devel] [freeipa PR#620][comment] [WIP] Fixing 6549

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/620 Title: #620: [WIP] Fixing 6549 MartinBasti commented: """ Please merge commits into one and please use full description in commit message instead of ticket number. """ See the full comment at

[Freeipa-devel] [freeipa PR#625][opened] [RFC] remote plugins: add option to force compat plugins

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/625 Author: HonzaCholasta Title: #625: [RFC] remote plugins: add option to force compat plugins Action: opened PR body: """ Add a new `force_client_compat` env flag to force client API not to do any RPC calls to initialize remote plugins in

[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache

2017-03-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/616 Title: #616: Simplify KRA transport cert cache tiran commented: """ Size of a patch is a wrong metric. It's about code complexity. My patch reduces code complexity and logic complexity. It also fixes at least two bugs: multi-process concurrency

[Freeipa-devel] [freeipa PR#626][comment] Move helper code for integration plugin

2017-03-20 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/626 Title: #626: Move helper code for integration plugin pvoborni commented: """ From the PR description it is not clear what problem it solves or if it solves a problem. "doesn't play nice " is vague. " Certain aspects of pytest are not available

[Freeipa-devel] [freeipa PR#266][+rejected] ipapython: simplify Env object initialization

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/266 Title: #266: ipapython: simplify Env object initialization Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#620][comment] [WIP] Fixing 6549

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/620 Title: #620: [WIP] Fixing 6549 tomaskrizek commented: """ Please try to keep the commit message summary short and append the link to the ticket at the end. For example: ``` server install: require IPv6 stack to be enabled Add checks to

[Freeipa-devel] [freeipa PR#620][comment] [WIP] Fixing 6549

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/620 Title: #620: [WIP] Fixing 6549 tomaskrizek commented: """ Seems all right, but I'd go with a more informative summary to make it a bit more clear what's changed when looking through the log: ``` replica install: fix ldap connection in domlvl 0

[Freeipa-devel] [freeipa PR#609][closed] [4.4] Fix cookie with Max-Age processing

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/609 Author: stlaz Title: #609: [4.4] Fix cookie with Max-Age processing Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/609/head:pr609 git checkout pr609 -- Manage

[Freeipa-devel] [freeipa PR#609][+pushed] [4.4] Fix cookie with Max-Age processing

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/609 Title: #609: [4.4] Fix cookie with Max-Age processing Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#610][+pushed] [4.3] Fix cookie with Max-Age processing

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/610 Title: #610: [4.3] Fix cookie with Max-Age processing Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#610][comment] [4.3] Fix cookie with Max-Age processing

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/610 Title: #610: [4.3] Fix cookie with Max-Age processing tomaskrizek commented: """ ipa-4-3: * 0d66046e501a4a1a09a0a74a96a499cb88ffb03b Fix cookie with Max-Age processing * 71475e3153117e554d22a2a27d7882ba4f890be8 Add debug log in case cookie

[Freeipa-devel] [freeipa PR#610][closed] [4.3] Fix cookie with Max-Age processing

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/610 Author: stlaz Title: #610: [4.3] Fix cookie with Max-Age processing Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/610/head:pr610 git checkout pr610 -- Manage

[Freeipa-devel] [freeipa PR#609][comment] [4.4] Fix cookie with Max-Age processing

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/609 Title: #609: [4.4] Fix cookie with Max-Age processing tomaskrizek commented: """ ipa-4-4: * 40f3b8f8a3d33864528138e517ce3240da6c9a4a Fix cookie with Max-Age processing * 5caade99127ff46141d2f6b7137f7aa62c0ff3bc Add debug log in case cookie

[Freeipa-devel] [freeipa PR#611][comment] Add debug log in case cookie retrieval went wrong

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/611 Title: #611: Add debug log in case cookie retrieval went wrong tomaskrizek commented: """ ipa-4-5: * c59729d783993f60582f5cc6ca018545231df22b Add debug log in case cookie retrieval went wrong master: * 0bb858ea770e081817dc243579d08ad1f113e825

[Freeipa-devel] [freeipa PR#611][closed] Add debug log in case cookie retrieval went wrong

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/611 Author: stlaz Title: #611: Add debug log in case cookie retrieval went wrong Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/611/head:pr611 git checkout pr611 --

[Freeipa-devel] [freeipa PR#611][+pushed] Add debug log in case cookie retrieval went wrong

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/611 Title: #611: Add debug log in case cookie retrieval went wrong Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#606][comment] [ipa-4-4] ipa-kdb: support KDB DAL version 6.1

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/606 Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1 MartinBasti commented: """ works for me """ See the full comment at https://github.com/freeipa/freeipa/pull/606#issuecomment-287803795 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#610][+ack] [4.3] Fix cookie with Max-Age processing

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/610 Title: #610: [4.3] Fix cookie with Max-Age processing Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#606][closed] [ipa-4-4] ipa-kdb: support KDB DAL version 6.1

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/606 Author: tomaskrizek Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/606/head:pr606 git checkout pr606

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread redhatrises
URL: https://github.com/freeipa/freeipa/pull/621 Title: #621: Add --force-password-reset to user_mod in user.py redhatrises commented: """ @abbra why not have it in both `ipa user-mod` and `ipa passwd`? """ See the full comment at

[Freeipa-devel] [freeipa PR#612][+ack] [4.5] Add debug log in case cookie retrieval went wrong

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/612 Title: #612: [4.5] Add debug log in case cookie retrieval went wrong Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#609][+ack] [4.4] Fix cookie with Max-Age processing

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/609 Title: #609: [4.4] Fix cookie with Max-Age processing Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#606][+ack] [ipa-4-4] ipa-kdb: support KDB DAL version 6.1

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/606 Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#611][+ack] Add debug log in case cookie retrieval went wrong

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/611 Title: #611: Add debug log in case cookie retrieval went wrong Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread redhatrises
URL: https://github.com/freeipa/freeipa/pull/621 Title: #621: Add --force-password-reset to user_mod in user.py redhatrises commented: """ Okay, so since it will reside in one location, should it be `user-mod` (PR already uses `user-mod`) or `passwd`? """ See the full comment at

[Freeipa-devel] [freeipa PR#606][comment] [ipa-4-4] ipa-kdb: support KDB DAL version 6.1

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/606 Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1 MartinBasti commented: """ ipa-4-4: * 95daecbae86f51271f5ea48cb628ace72e676351 ipa-kdb: support KDB DAL version 6.1 """ See the full comment at

[Freeipa-devel] [freeipa PR#606][+pushed] [ipa-4-4] ipa-kdb: support KDB DAL version 6.1

2017-03-20 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/606 Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#624][comment] Use connection keep-alive

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/624 Title: #624: Use connection keep-alive tomaskrizek commented: """ @tiran I checked that code as well, `getaddrinfo` returns both IPv6 and IPv4. That could explain two connections, but I'm not sure where the third one comes from. """ See the

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/621 Title: #621: Add --force-password-reset to user_mod in user.py abbra commented: """ Hm. `ipa user-mod` has --random and also supports specifying --password, so yes, both interfaces should be provided. """ See the full comment at

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/621 Title: #621: Add --force-password-reset to user_mod in user.py HonzaCholasta commented: """ I don't agree. There should be one and only one obvious way to do it. There is no real benefit in having this in multiple different places, it just adds

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/621 Title: #621: Add --force-password-reset to user_mod in user.py HonzaCholasta commented: """ I don't agree. There should be one and only one obvious way to do it. There is no real benefit in having this in multiple different places, it just adds

[Freeipa-devel] [freeipa PR#517][edited] [WIP] Use Custodia 0.3 features

2017-03-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/517 Author: tiran Title: #517: [WIP] Use Custodia 0.3 features Action: edited Changed field: body Original value: """ * Use sd-notify in ipa-custodia.service * Introduce libexec/ipa/ipa-custodia script. It comes with correct default setting for

[Freeipa-devel] [freeipa PR#517][synchronized] [WIP] Use Custodia 0.3 features

2017-03-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/517 Author: tiran Title: #517: [WIP] Use Custodia 0.3 features Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/517/head:pr517 git checkout pr517 From

[Freeipa-devel] [freeipa PR#624][+ack] Use connection keep-alive

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/624 Title: #624: Use connection keep-alive Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#624][comment] Use connection keep-alive

2017-03-20 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/624 Title: #624: Use connection keep-alive tiran commented: """ This behavior could be caused by https://github.com/python/cpython/blob/master/Lib/socket.py#L688 . What's ```socket.getaddrinfo(host, 443, 0, socket.SOCK_STREAM)``` for your host? """

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/621 Title: #621: Add --force-password-reset to user_mod in user.py HonzaCholasta commented: """ Actually, maybe `user-mod` is a better place for the option, as it does LDAP modify operation, whereas `passwd` does LDAP password change extended

[Freeipa-devel] [freeipa PR#624][comment] Use connection keep-alive

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/624 Title: #624: Use connection keep-alive tomaskrizek commented: """ The extra connections seem to come from the internals of `httplib` library. If the hostname resolves to both IPv4 and IPv6 address, one connection is established to IPv4 and two

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/621 Title: #621: Add --force-password-reset to user_mod in user.py abbra commented: """ Ok, let's go with `user-mod` as original request goes, based on the fact that we are not changing the password, we are changing its properties. LGTM. """ See

[Freeipa-devel] [freeipa PR#620][synchronized] [WIP] Fixing 6549

2017-03-20 Thread felipevolpone
URL: https://github.com/freeipa/freeipa/pull/620 Author: felipevolpone Title: #620: [WIP] Fixing 6549 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/620/head:pr620 git checkout pr620 From

[Freeipa-devel] [freeipa PR#620][comment] [WIP] Fixing 6549

2017-03-20 Thread felipevolpone
URL: https://github.com/freeipa/freeipa/pull/620 Title: #620: [WIP] Fixing 6549 felipevolpone commented: """ @HonzaCholasta, @MartinBasti done :) Please, check if the commit message and the code comment are good enough. Thank you """ See the full comment at

[Freeipa-devel] [freeipa PR#620][comment] [WIP] Fixing 6549

2017-03-20 Thread felipevolpone
URL: https://github.com/freeipa/freeipa/pull/620 Title: #620: [WIP] Fixing 6549 felipevolpone commented: """ What do you think about: ``` Fixing the replica install against IPA 3.0.0 master. Now, at the domain level 0, the replica install always uses Directory Manager credentials to create

[Freeipa-devel] [freeipa PR#624][comment] Use connection keep-alive

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/624 Title: #624: Use connection keep-alive tomaskrizek commented: """ I examined this in wireshark. Without this patch, `ipa vault-add` would establish 7 TCP connections to apache, while it establishes only 3 with this patch. I wasn't able to track

[Freeipa-devel] [freeipa PR#630][opened] ipapython.ipautil.nolog_replace: Do not replace empty value

2017-03-20 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/630 Author: dkupka Title: #630: ipapython.ipautil.nolog_replace: Do not replace empty value Action: opened PR body: """ When provided empty value in nolog parameter nolog_replace added '' three (once for plain value, once for http quoted

[Freeipa-devel] [freeipa PR#624][+pushed] Use connection keep-alive

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/624 Title: #624: Use connection keep-alive Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#624][closed] Use connection keep-alive

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/624 Author: tiran Title: #624: Use connection keep-alive Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/624/head:pr624 git checkout pr624 -- Manage your

[Freeipa-devel] [freeipa PR#624][comment] Use connection keep-alive

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/624 Title: #624: Use connection keep-alive tomaskrizek commented: """ master: * 7beb6d1cad7e2200208cb14be6c823a89abf0dc3 Use connection keep-alive * b2bdd2e1a912573ae4a3e8e5f40831a800d972f7 Add debug logging for keep-alive *

[Freeipa-devel] [freeipa PR#612][comment] [4.5] Add debug log in case cookie retrieval went wrong

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/612 Title: #612: [4.5] Add debug log in case cookie retrieval went wrong tomaskrizek commented: """ ipa-4-5: * c59729d783993f60582f5cc6ca018545231df22b Add debug log in case cookie retrieval went wrong """ See the full comment at

[Freeipa-devel] [freeipa PR#612][+pushed] [4.5] Add debug log in case cookie retrieval went wrong

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/612 Title: #612: [4.5] Add debug log in case cookie retrieval went wrong Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#612][closed] [4.5] Add debug log in case cookie retrieval went wrong

2017-03-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/612 Author: stlaz Title: #612: [4.5] Add debug log in case cookie retrieval went wrong Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/612/head:pr612 git checkout