[Freeipa-devel] [PATCH] 0001 Refactor selinuxenabled check

2014-09-26 Thread Francesco Marella
From 81d3d673944fc61de4616b5572d24719637d1d50 Mon Sep 17 00:00:00 2001 From: Francesco Marella Date: Fri, 26 Sep 2014 14:07:25 +0200 Subject: [PATCH] Refactor selinuxenabled check Ticket: https://fedorahosted.org/freeipa/ticket/4571 --- ipaplatform/fedora/tasks.py | 44

Re: [Freeipa-devel] [PATCH] 0001 Refactor selinuxenabled check

2014-09-26 Thread Francesco Marella
replacing return from their functions. You'd need to use something like: if not selinux_enabled(): return instead of: self.check_enabled_selinux() From d7422bb4de03219ec8e8326b04bde4c5e7fe4b02 Mon Sep 17 00:00:00 2001 From: Francesco Marella Date: Fri, 26 Sep 2014 14:07:2

Re: [Freeipa-devel] [PATCH] 0001 Refactor selinuxenabled check

2014-09-26 Thread Francesco Marella
This should be the final one. fm On 26/09/2014 16:30, Francesco Marella wrote: On 26/09/2014 15:41, Petr Viktorin wrote: Hello! Thanks for the patch! The new function is not one of the platform-independent tasks, and doesn't even use `self`, so you can define it as a module-level h

Re: [Freeipa-devel] [PATCH] 0001 Refactor selinuxenabled check

2014-09-26 Thread Francesco Marella
thanks thierry On 09/26/2014 05:26 PM, Francesco Marella wrote: This should be the final one. fm On 26/09/2014 16:30, Francesco Marella wrote: On 26/09/2014 15:41, Petr Viktorin wrote: Hello! Thanks for the patch! The new function is not one of the platform-independent tasks, and do