Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-18 Thread Milan Kubík
On 08/18/2015 11:37 AM, Jan Cholasta wrote: On 17.8.2015 16:47, Milan Kubík wrote: On 08/17/2015 04:44 PM, Milan Kubík wrote: On 08/17/2015 10:23 AM, Martin Basti wrote: On 08/12/2015 01:10 PM, Milan Kubík wrote: On 08/10/2015 04:41 PM, Jan Cholasta wrote: Dne 10.8.2015 v 16:03 Milan

Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-17 Thread Milan Kubík
On 08/17/2015 10:23 AM, Martin Basti wrote: On 08/12/2015 01:10 PM, Milan Kubík wrote: On 08/10/2015 04:41 PM, Jan Cholasta wrote: Dne 10.8.2015 v 16:03 Milan Kubík napsal(a): Forwarded Message Subject: Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-17 Thread Milan Kubík
On 08/17/2015 04:44 PM, Milan Kubík wrote: On 08/17/2015 10:23 AM, Martin Basti wrote: On 08/12/2015 01:10 PM, Milan Kubík wrote: On 08/10/2015 04:41 PM, Jan Cholasta wrote: Dne 10.8.2015 v 16:03 Milan Kubík napsal(a): Forwarded Message Subject: Re: [Freeipa-devel

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-18 Thread Milan Kubík
On 08/11/2015 03:17 AM, Fraser Tweedale wrote: On Mon, Aug 10, 2015 at 11:36:31AM +0200, Milan Kubík wrote: On 08/05/2015 02:57 PM, Milan Kubík wrote: Hi list, I'm sending the test plan [1] for certificate profiles and preliminary patches for it. The plan covers basic CRUD test and some

[Freeipa-devel] [patch 0011] Temporary workaround for [patch 0010] Python list comprehension leak breaking the test execution

2015-08-17 Thread Milan Kubík
On 08/11/2015 03:23 PM, Milan Kubík wrote: On 08/11/2015 09:53 AM, Jan Cholasta wrote: On 11.8.2015 09:46, Milan Kubík wrote: On 08/11/2015 09:08 AM, Jan Cholasta wrote: On 11.8.2015 09:00, Milan Kubík wrote: On 08/10/2015 06:22 PM, Milan Kubík wrote: On 08/10/2015 06:02 PM, Milan Kubík

[Freeipa-devel] programmer documentation

2015-07-30 Thread Milan Kubík
Hi all, I'm curious, is there some documentation of the IPA internals? During my playing with plugins, I was quite amazed and frustrated at the code, not entirely (or remotely) understanding what happens after the call to a command starts and before I get the result. The main problem I have is

[Freeipa-devel] cert profiles - test plan + patches

2015-08-05 Thread Milan Kubík
Hi list, I'm sending the test plan [1] for certificate profiles and preliminary patches for it. The plan covers basic CRUD test and some corner cases. I'm open to more suggestions. More complicated tests involving certificate profiles will require the code (and tests) for CA ACLs merged, so

Re: [Freeipa-devel] programmer documentation

2015-07-31 Thread Milan Kubík
On 07/31/2015 10:42 AM, Petr Vobornik wrote: On 07/31/2015 10:39 AM, Milan Kubík wrote: On 07/30/2015 05:42 PM, Alexander Bokovoy wrote: On Thu, 30 Jul 2015, Milan Kubík wrote: Hi all, I'm curious, is there some documentation of the IPA internals? During my playing with plugins, I was quite

Re: [Freeipa-devel] programmer documentation

2015-07-31 Thread Milan Kubík
On 07/30/2015 05:42 PM, Alexander Bokovoy wrote: On Thu, 30 Jul 2015, Milan Kubík wrote: Hi all, I'm curious, is there some documentation of the IPA internals? During my playing with plugins, I was quite amazed and frustrated at the code, not entirely (or remotely) understanding what happens

Re: [Freeipa-devel] programmer documentation

2015-07-30 Thread Milan Kubík
On 07/30/2015 05:42 PM, Alexander Bokovoy wrote: On Thu, 30 Jul 2015, Milan Kubík wrote: Hi all, I'm curious, is there some documentation of the IPA internals? During my playing with plugins, I was quite amazed and frustrated at the code, not entirely (or remotely) understanding what happens

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-11 Thread Milan Kubík
On 08/11/2015 09:08 AM, Jan Cholasta wrote: On 11.8.2015 09:00, Milan Kubík wrote: On 08/10/2015 06:22 PM, Milan Kubík wrote: On 08/10/2015 06:02 PM, Milan Kubík wrote: On 08/10/2015 05:54 PM, Jan Cholasta wrote: On 10.8.2015 17:43, Milan Kubík wrote: Hi all, this patch fixes

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-11 Thread Milan Kubík
On 08/10/2015 06:22 PM, Milan Kubík wrote: On 08/10/2015 06:02 PM, Milan Kubík wrote: On 08/10/2015 05:54 PM, Jan Cholasta wrote: On 10.8.2015 17:43, Milan Kubík wrote: Hi all, this patch fixes problem described in the ticket [1] that caused the test run to fail completely at every other

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-11 Thread Milan Kubík
On 08/11/2015 12:38 PM, Jan Cholasta wrote: On 11.8.2015 12:33, Milan Kubík wrote: On 08/11/2015 12:33 PM, Milan Kubík wrote: On 08/11/2015 10:03 AM, Milan Kubík wrote: On 08/11/2015 09:57 AM, Martin Babinsky wrote: On 08/10/2015 05:43 PM, Milan Kubík wrote: Hi all, this patch fixes

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-11 Thread Milan Kubík
On 08/11/2015 10:03 AM, Milan Kubík wrote: On 08/11/2015 09:57 AM, Martin Babinsky wrote: On 08/10/2015 05:43 PM, Milan Kubík wrote: Hi all, this patch fixes problem described in the ticket [1] that caused the test run to fail completely at every other or so run. I took the liberty to fix

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-11 Thread Milan Kubík
On 08/11/2015 12:33 PM, Milan Kubík wrote: On 08/11/2015 10:03 AM, Milan Kubík wrote: On 08/11/2015 09:57 AM, Martin Babinsky wrote: On 08/10/2015 05:43 PM, Milan Kubík wrote: Hi all, this patch fixes problem described in the ticket [1] that caused the test run to fail completely at every

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-11 Thread Milan Kubík
On 08/11/2015 01:46 PM, Christian Heimes wrote: On 2015-08-11 09:46, Milan Kubík wrote: On 08/11/2015 09:08 AM, Jan Cholasta wrote: On 11.8.2015 09:00, Milan Kubík wrote: On 08/10/2015 06:22 PM, Milan Kubík wrote: On 08/10/2015 06:02 PM, Milan Kubík wrote: On 08/10/2015 05:54 PM, Jan

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-11 Thread Milan Kubík
On 08/11/2015 09:53 AM, Jan Cholasta wrote: On 11.8.2015 09:46, Milan Kubík wrote: On 08/11/2015 09:08 AM, Jan Cholasta wrote: On 11.8.2015 09:00, Milan Kubík wrote: On 08/10/2015 06:22 PM, Milan Kubík wrote: On 08/10/2015 06:02 PM, Milan Kubík wrote: On 08/10/2015 05:54 PM, Jan Cholasta

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-10 Thread Milan Kubík
Hi, On 08/10/2015 05:24 PM, Scott Poore wrote: - Original Message - From: Milan Kubík mku...@redhat.com To: freeipa-devel freeipa-devel@redhat.com, Scott Poore spo...@redhat.com, Fraser Tweedale ftwee...@redhat.com Cc: Namita Soman nso...@redhat.com, Ales Marecek amare...@redhat.com

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-10 Thread Milan Kubík
On 08/10/2015 05:54 PM, Jan Cholasta wrote: On 10.8.2015 17:43, Milan Kubík wrote: Hi all, this patch fixes problem described in the ticket [1] that caused the test run to fail completely at every other or so run. I took the liberty to fix most of the pep8 issues while I was at it. Thanks

Re: [Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-10 Thread Milan Kubík
On 08/10/2015 06:02 PM, Milan Kubík wrote: On 08/10/2015 05:54 PM, Jan Cholasta wrote: On 10.8.2015 17:43, Milan Kubík wrote: Hi all, this patch fixes problem described in the ticket [1] that caused the test run to fail completely at every other or so run. I took the liberty to fix most

[Freeipa-devel] [patch 0010] Python list comprehension leak breaking the test execution

2015-08-10 Thread Milan Kubík
Hi all, this patch fixes problem described in the ticket [1] that caused the test run to fail completely at every other or so run. I took the liberty to fix most of the pep8 issues while I was at it. Thanks to Jan Cholasta for help with identifying this one. [1]:

Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-12 Thread Milan Kubík
On 08/10/2015 04:41 PM, Jan Cholasta wrote: Dne 10.8.2015 v 16:03 Milan Kubík napsal(a): Forwarded Message Subject: Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch Date: Mon, 10 Aug 2015 15:55:35 +0200 From: Jan Cholasta jchol...@redhat.com

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-08-10 Thread Milan Kubík
On 08/05/2015 02:57 PM, Milan Kubík wrote: Hi list, I'm sending the test plan [1] for certificate profiles and preliminary patches for it. The plan covers basic CRUD test and some corner cases. I'm open to more suggestions. More complicated tests involving certificate profiles will require

Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-10 Thread Milan Kubík
Forwarded Message Subject:Re: [Freeipa-devel] Unable to install bits from ipa-4-2 branch Date: Mon, 10 Aug 2015 15:55:35 +0200 From: Jan Cholasta jchol...@redhat.com To: Milan Kubík mku...@redhat.com CC: Martin Kosek mko...@redhat.com Dne 10.8.2015 v 15

[Freeipa-devel] Unable to install bits from ipa-4-2 branch

2015-08-06 Thread Milan Kubík
Hi list, I just noticed that the bits built from ipa-4-2 branch cannot be installed. The freeipa packages built have version such as freeipa-server-dns-4.2.0-0.20150806083844Zjenkins9git2812242.fc22.x86_64 The version check in the spec file makes the server-dns package obsolete the server

[Freeipa-devel] [patch 0007] tests: Allow Tracker.dn be an instance of Fuzzy

2015-07-27 Thread Milan Kubík
Hi, the patch changes the check on the Tracker.dn setter, allowing to use an instance of ipatests.util.Fuzzy to ease writing Trackers for plugins like CA ACL, which use ipaUniqueID as their primary key. Thanks, Milan From 0d586dffbb424f8292faa90ea92021b075b34926 Mon Sep 17 00:00:00 2001 From:

Re: [Freeipa-devel] [PATCHES 0042-45] new commands for adding/removing certificates from entries

2015-07-14 Thread Milan Kubík
On 07/02/2015 04:44 PM, Jan Cholasta wrote: Dne 2.7.2015 v 16:36 Martin Babinsky napsal(a): On 07/02/2015 02:37 PM, Martin Babinsky wrote: On 07/02/2015 11:28 AM, Martin Babinsky wrote: On 07/02/2015 11:12 AM, Martin Babinsky wrote: On 07/01/2015 03:05 PM, Martin Babinsky wrote: On

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-23 Thread Milan Kubík
On 10/20/2015 02:19 PM, Martin Basti wrote: NACK 1) I still see many hardcoded passwords in the code with change_principal(smime_user, "Secret123"): For now changed to module variable. 2) Also the 'alice' username can be extracted to module variable instead hardcoding The fixture

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

2015-11-10 Thread Milan Kubík
On 11/09/2015 04:35 PM, Filip Škola wrote: Another patch was applied in the meantime. Attaching an updated version. F. On Mon, 9 Nov 2015 13:35:02 +0100 Milan Kubík <mku...@redhat.com> wrote: On 11/06/2015 11:32 AM, Filip Škola wrote: Hi, the patch doesn't apply. Plea

[Freeipa-devel] [patch 0024] Fix missed module import in ipaserver tests

2015-11-12 Thread Milan Kubík
-- Milan Kubik From 7dabe3f38005e1553b28b98a32578390f2bc629b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Thu, 12 Nov 2015 10:39:48 +0100 Subject: [PATCH] ipatests: Fix missed module import in ipaserver tests --- ipatests/test_ipaserver/test_ldap.py

Re: [Freeipa-devel] ipa-4-2 branch is broken !!!

2015-11-12 Thread Milan Kubík
On 11/12/2015 10:35 AM, Martin Basti wrote: Lint failed in current ipa-4-2 branch. === Errors were found during the static code check. If you are certain that any of the reported errors are false positives, please

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

2015-11-12 Thread Milan Kubík
On 11/10/2015 12:13 PM, Filip Škola wrote: Hi, fixed. F. On Tue, 10 Nov 2015 10:52:45 +0100 Milan Kubík <mku...@redhat.com> wrote: On 11/09/2015 04:35 PM, Filip Škola wrote: Another patch was applied in the meantime. Attaching an updated version. F. On Mon, 9 Nov 2015 13:35:02

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-16 Thread Milan Kubík
On 09/30/2015 02:47 PM, Martin Basti wrote: On 09/24/2015 02:49 PM, Milan Kubík wrote: Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how to change the identity during acceptance cest run, which allows to test CA ACLs (and perhaps

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-20 Thread Milan Kubík
On 10/19/2015 01:38 PM, Martin Basti wrote: On 16.10.2015 15:43, Milan Kubík wrote: On 09/30/2015 02:47 PM, Martin Basti wrote: On 09/24/2015 02:49 PM, Milan Kubík wrote: Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how

Re: [Freeipa-devel] [PATCHES 0321 - 0322] CI: vault CI test

2015-10-12 Thread Milan Kubík
On 10/08/2015 06:53 PM, Martin Basti wrote: Patches attached. Tests for https://fedorahosted.org/freeipa/ticket/5302 LGTM, ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH] Workaround for trac N 5348

2015-10-09 Thread Milan Kubík
On 10/08/2015 02:50 PM, Martin Basti wrote: On 10/08/2015 02:39 PM, Martin Kosek wrote: On 10/08/2015 02:08 PM, Oleg Fayans wrote: Hi, On 10/08/2015 11:18 AM, Jan Pazdziora wrote: On Thu, Oct 08, 2015 at 11:12:37AM +0200, Oleg Fayans wrote: When the ticket is addressed and these

Re: [Freeipa-devel] [PATCH] Workaround for trac N 5348

2015-10-09 Thread Milan Kubík
On 10/09/2015 09:01 AM, Milan Kubík wrote: On 10/08/2015 02:50 PM, Martin Basti wrote: On 10/08/2015 02:39 PM, Martin Kosek wrote: On 10/08/2015 02:08 PM, Oleg Fayans wrote: Hi, On 10/08/2015 11:18 AM, Jan Pazdziora wrote: On Thu, Oct 08, 2015 at 11:12:37AM +0200, Oleg Fayans wrote: When

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-10 Thread Milan Kubík
On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm running it through lite-server, so here's the traceback from there: http://pastebin.test.redhat.com/310598 I can't really get to the

[Freeipa-devel] INFO: CA ACL test and kerberos usage in functional tests

2015-09-10 Thread Milan Kubík
Hi list, before my PTO, I was trying to write a functional test for CA ACLs with the tracker along all other acceptance/functional tests. I wasn't successful, the approach doesn't seem to work for CA ACLs as they have specific requirements for kerberos credentials that none of my attempts

Re: [Freeipa-devel] INFO: CA ACL test and kerberos usage in functional tests

2015-09-10 Thread Milan Kubík
On 09/10/2015 06:36 PM, Alexander Bokovoy wrote: On Thu, 10 Sep 2015, Milan Kubík wrote: Hi list, before my PTO, I was trying to write a functional test for CA ACLs with the tracker along all other acceptance/functional tests. I wasn't successful, the approach doesn't seem to work for CA

Re: [Freeipa-devel] [PATCH 0312] CI: extend backup restore tests with DNS/DNSSEC

2015-09-16 Thread Milan Kubík
On 09/11/2015 10:23 AM, Martin Basti wrote: On 09/10/2015 10:48 AM, Martin Basti wrote: Self NACK On 09/10/2015 10:21 AM, Martin Basti wrote: Patch attached. Updated patch attached. Looks good to me. The reinstall tests are failing. Is this known? Apart from that, ACK for the code.

Re: [Freeipa-devel] [PATCH 0312] CI: extend backup restore tests with DNS/DNSSEC

2015-09-16 Thread Milan Kubík
On 09/16/2015 04:18 PM, Milan Kubík wrote: On 09/11/2015 10:23 AM, Martin Basti wrote: On 09/10/2015 10:48 AM, Martin Basti wrote: Self NACK On 09/10/2015 10:21 AM, Martin Basti wrote: Patch attached. Updated patch attached. Looks good to me. The reinstall tests are failing

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Milan Kubík
On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Milan Kubík
On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Milan Kubík
On 09/11/2015 12:43 PM, Lenka Doudova wrote: On 09/11/2015 11:45 AM, Milan Kubík wrote: On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-15 Thread Milan Kubík
On 09/14/2015 05:47 PM, Martin Basti wrote: On 09/14/2015 01:49 PM, Lenka Doudova wrote: All good, ACK On 09/14/2015 11:54 AM, Milan Kubík wrote: On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc

Re: [Freeipa-devel] Early feedback on Tracker based tests

2015-09-17 Thread Milan Kubík
On 09/17/2015 03:30 PM, Milan Kubík wrote: Hi list, I would like to ask you for any feedback you can provide me on $SUBJ. Currently the tests for host, certprofiles and stage user plugins are implemented with the use of the tracker that Petr Viktorin originally designed as a replacement

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Milan Kubík
On 09/17/2015 02:51 PM, Jan Cholasta wrote: On 17.9.2015 14:08, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 02:00 PM, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas Babej wrote: Hi fellow developers, more

[Freeipa-devel] Early feedback on Tracker based tests

2015-09-17 Thread Milan Kubík
Hi list, I would like to ask you for any feedback you can provide me on $SUBJ. Currently the tests for host, certprofiles and stage user plugins are implemented with the use of the tracker that Petr Viktorin originally designed as a replacement for the declarative xmlrpc tests. With these

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Milan Kubík
PM, Milan Kubík wrote: On 09/11/2015 12:43 PM, Lenka Doudova wrote: On 09/11/2015 11:45 AM, Milan Kubík wrote: On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin

Re: [Freeipa-devel] [PATCHES 466-468, 0316] install: Add common base class for server and replica install

2015-09-29 Thread Milan Kubík
On 09/23/2015 05:01 PM, Martin Basti wrote: On 09/22/2015 12:10 PM, Jan Cholasta wrote: On 22.9.2015 10:29, Martin Babinsky wrote: On 09/16/2015 10:44 AM, Jan Cholasta wrote: On 16.9.2015 08:11, Jan Cholasta wrote: On 15.9.2015 07:22, Jan Cholasta wrote: On 10.8.2015 16:58, Martin

[Freeipa-devel] [patch 0020] ipatests: configure Network Manager not to manage resolv.conf

2015-10-01 Thread Milan Kubík
Fixes https://fedorahosted.org/freeipa/ticket/5331 Patch attached. From 4200b386058489f8ad73ee2d2f7eed582dea70b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Fri, 25 Sep 2015 21:09:24 +0200 Subject: [PATCH] ipatests: configure Network Manager not to

Re: [Freeipa-devel] [patch 0020] ipatests: configure Network Manager not to manage resolv.conf

2015-10-01 Thread Milan Kubík
On 10/01/2015 10:06 AM, Milan Kubík wrote: Fixes https://fedorahosted.org/freeipa/ticket/5331 Patch attached. Patch for ipa-4-2 branch. Milan From 5d19b29474b577688910a60fbc5efdf38ff6c455 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= <mku...@redhat.com> Date: Fri,

Re: [Freeipa-devel] [patch 0020] ipatests: configure Network Manager not to manage resolv.conf

2015-10-01 Thread Milan Kubík
On 10/01/2015 12:39 PM, Alexander Bokovoy wrote: On Thu, 01 Oct 2015, Milan Kubík wrote: On 10/01/2015 11:23 AM, Martin Basti wrote: On 10/01/2015 10:18 AM, Milan Kubík wrote: On 10/01/2015 10:06 AM, Milan Kubík wrote: Fixes https://fedorahosted.org/freeipa/ticket/5331 Patch attached

Re: [Freeipa-devel] [PATCH] Proper fix for ticket 5306

2015-10-02 Thread Milan Kubík
On 10/02/2015 04:11 PM, Martin Basti wrote: On 10/01/2015 02:48 PM, Martin Basti wrote: On 10/01/2015 02:43 PM, Oleg Fayans wrote: Hi Martin, On 10/01/2015 11:18 AM, Martin Basti wrote: On 09/30/2015 01:24 PM, Martin Basti wrote: On 09/30/2015 12:19 PM, Oleg Fayans wrote: On

[Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-09-24 Thread Milan Kubík
Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how to change the identity during acceptance cest run, which allows to test CA ACLs (and perhaps other areas with some form of access controll). This allowed me to write a test for CA ACLs and

Re: [Freeipa-devel] [PATCH 0315] CI: backup with KRA installed

2015-09-24 Thread Milan Kubík
On 09/11/2015 04:42 PM, Martin Basti wrote: Patch mbasti-0312-2 Patch attached. LGTM, ack Milan -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [patch 0022] ipatests: remove the ipatests specific config from ipaplatform

2015-10-06 Thread Milan Kubík
To keep the test specific configuration in the ipatest package. Patch attached. -- Milan Kubik From 49701f9775e59bd19bc62295af6ed332f1aa054b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Tue, 6 Oct 2015 14:55:49 +0200 Subject: [PATCH] ipatests: remove

Re: [Freeipa-devel] [patch 0022] ipatests: remove the ipatests specific config from ipaplatform

2015-10-06 Thread Milan Kubík
On 10/06/2015 03:01 PM, Milan Kubík wrote: To keep the test specific configuration in the ipatest package. Patch attached. Self NACK. This is not necessary in upstream. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo

[Freeipa-devel] [patch 0021] Include ipatests/test_xmlrpc/data directory into distribution

2015-10-05 Thread Milan Kubík
Adds ipatests/test_xmlrpc/data directory and its content into package. The files are needed for certprofile (and CA ACL) tests. Patch attached. -- Milan Kubik From 2e7e84f27590efd7b5097551104f723e018c722f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date:

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2015-12-07 Thread Milan Kubík
On 12/03/2015 08:15 PM, Filip Škola wrote: On Mon, 30 Nov 2015 17:18:30 +0100 Milan Kubík <mku...@redhat.com> wrote: On 11/23/2015 04:42 PM, Filip Škola wrote: Sending updated patch. F. On Mon, 23 Nov 2015 14:59:34 +0100 Filip Škola <fsk...@redhat.com> wrote: Found couple of i

Re: [Freeipa-devel] [PATCH 0003] Refactor test_replace

2015-12-04 Thread Milan Kubík
On 12/04/2015 10:04 AM, Filip Škola wrote: Hi, sending rather short one this time. F. NACK, UserTracker is implemented in ipatests.test_xmlrpc.tracker.user_plugin. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

2015-12-15 Thread Milan Kubík
On 12/15/2015 05:04 PM, Aleš Mareček wrote: - Original Message - From: "Milan Kubík" <mku...@redhat.com> To: "Petr Vobornik" <pvobo...@redhat.com> Cc: "freeipa-devel" <freeipa-devel@redhat.com>, "Ales Marecek" <amare...@re

[Freeipa-devel] [patch 0026] ipatests: replace the test-example.com domain in tests

2015-12-16 Thread Milan Kubík
Applies to ipa-4-3 and master. Reason in commit message. -- Milan Kubik From 912ecd6c48149696eb8ca3c60644e5b24af6e534 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Wed, 16 Dec 2015 16:27:34 +0100 Subject: [PATCH] ipatests: replace the

Re: [Freeipa-devel] [PATCH 0116] CI tests: remove '-p' option from ipa-dns-install calls

2015-12-14 Thread Milan Kubík
On 12/10/2015 04:35 PM, Martin Babinsky wrote: See commit message. Works for me. ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [patch 0027] ipatests: Roll back the forwarder config after a test case

2015-12-17 Thread Milan Kubík
Patch attached. -- Milan Kubik From 66db35cf2a315f0a58e002b06f0fcc5bd915a5c5 Mon Sep 17 00:00:00 2001 From: Milan Kubik Date: Thu, 17 Dec 2015 14:17:22 +0100 Subject: [PATCH] ipatests: Roll back the forwarder config after a test case ---

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

2015-12-15 Thread Milan Kubík
On 12/15/2015 04:35 PM, Petr Vobornik wrote: On 12/15/2015 01:05 AM, Petr Vobornik wrote: Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. Master branch is ready for 4.4 development. A build is available for testing in my pvoborni/freeipa-4-3 COPR repo [1] until the

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

2016-01-07 Thread Milan Kubík
. I'll use this one then. On 01/07/2016 09:36 AM, Milan Kubík wrote: 0029: Add 10.in-addr.arpa. zone to ipa 0030: If the IP addresses in the topology are resolvable, do not add them to master. How about other private subnets? What if I run test under 172.16.1.0/24 range, or 192.168.1.0/24

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-11-27 Thread Milan Kubík
On 11/27/2015 03:31 PM, Milan Kubík wrote: On 11/23/2015 10:43 AM, Lenka Doudova wrote: NACK - there's a "typo" in /tracker/user_plugin.py, line 17-18: def get_user_dn(cn): return DN(('cn', cn), api.env.container_user, api.env.basedn) should be def get_user_dn(uid):

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2015-11-30 Thread Milan Kubík
On 11/23/2015 04:42 PM, Filip Škola wrote: Sending updated patch. F. On Mon, 23 Nov 2015 14:59:34 +0100 Filip Škola wrote: Found couple of issues (broke some dependencies). NACK F. On Fri, 20 Nov 2015 13:56:36 +0100 Filip Škola wrote: Another one.

Re: [Freeipa-devel] [PATCH 0102] update idrange tests to reflect disabled modification of local ID ranges

2015-11-20 Thread Milan Kubík
On 11/20/2015 04:06 PM, Martin Babinsky wrote: When I fixed https://fedorahosted.org/freeipa/ticket/4826 I forgot to fix the corresponding xmlrpc tests. This oversight bit me today when I ran in-tree tests on my VM. Here is the patch that makes idrange tests green and shiny again. Tests are

Re: [Freeipa-devel] [patch 0028] ipatests: Fix configuration problems in dns tests

2016-01-11 Thread Milan Kubík
On 01/07/2016 10:37 AM, Martin Basti wrote: On 07.01.2016 10:23, Milan Kubík wrote: On 01/07/2016 09:31 AM, Oleg Fayans wrote: Hi Milan, As we are eventialy going to move to python3, I would make the code python3-compatible: 1. from __future__ import unicode_literals 2. get rid of all u's

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

2016-01-11 Thread Milan Kubík
On 01/07/2016 09:36 AM, Milan Kubík wrote: 0029: Add 10.in-addr.arpa. zone to ipa 0030: If the IP addresses in the topology are resolvable, do not add them to master. Hi. I'm dropping 0029 for now. 0030 gets an update. -- Milan Kubik From df95013b33fa1954cc92425fb7e6ea8dc6ac7e15 Mon Sep

Re: [Freeipa-devel] [PATCH 0003] Refactor test_replace

2016-01-12 Thread Milan Kubík
On 12/04/2015 11:29 AM, Filip Škola wrote: On Fri, 4 Dec 2015 10:08:40 +0100 Milan Kubík <mku...@redhat.com> wrote: On 12/04/2015 10:04 AM, Filip Škola wrote: Hi, sending rather short one this time. F. NACK, UserTracker is implemented in ipatests.test_xmlrpc.tracker.user_plugin

[Freeipa-devel] [Testplan review] Sub CAs

2016-06-10 Thread Milan Kubík
Hi Fraser and list, I've wrote a (minimal) draft [1] of the test plan for the Sub CAs feature and I also have several questions. Could you please take a look at it? Questions: As described in the last (currently) test case, should it be possible to specify both the CA and certificate

[Freeipa-devel] [patch 0038-0040] Sub CA test patches

2016-06-21 Thread Milan Kubík
Hi Fraser and list, I have made changes to the test plan on the wiki [1] according to the information in "[Testplan review] Sub CAs" thread. I also implemented the tests in the test plan: patch 0038 - CATracker and CA CRUD test patch 0039 - extension to CA ACL test patch 0040 - functional test

Re: [Freeipa-devel] [PATCH] 0077 Check for CA subject name collision before attempting creation

2016-06-24 Thread Milan Kubík
On 06/24/2016 09:34 AM, Fraser Tweedale wrote: Hi, Attached patch fixes https://fedorahosted.org/freeipa/ticket/5981. Cheers, Fraser Thanks for the patch, ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [patch 0038-0040] Sub CA test patches

2016-06-24 Thread Milan Kubík
On 06/24/2016 03:42 AM, Fraser Tweedale wrote: On Tue, Jun 21, 2016 at 05:01:35PM +0200, Milan Kubík wrote: Hi Fraser and list, I have made changes to the test plan on the wiki [1] according to the information in "[Testplan review] Sub CAs" thread. I also implemented the tests i

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

2016-01-18 Thread Milan Kubík
On 01/15/2016 03:37 PM, Filip Skola wrote: Hi, sending rebased patch. F. - Original Message - Hi, the patch no longer applies to master. Please rebase it. Thanks, Milan - Original Message - From: "Filip Skola" <fsk...@redhat.com> To: freeipa-devel@redha

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2016-01-18 Thread Milan Kubík
On 01/15/2016 03:38 PM, Filip Skola wrote: Hi, sending rebased patch. F. - Original Message - Hello, sorry for delays. The patch no longer applies to master. Rebase it, please. Milan - Original Message - From: "Filip Škola" <fsk...@redhat.com> To: &q

[Freeipa-devel] Broken pki 10.3.3-1 packages in freeipa-master COPR

2016-06-27 Thread Milan Kubík
Hi all, the pki packages that are currently in the COPR repo [1] are broken. There is a conflict between pki-server and pki-base: Error: Transaction check error: file /usr/lib/python2.7/site-packages/pki/server/deployment/pkiparser.pyc from install of pki-server-10.3.3-1.fc24.noarch

Re: [Freeipa-devel] Broken pki 10.3.3-1 packages in freeipa-master COPR

2016-06-28 Thread Milan Kubík
On 06/28/2016 01:20 PM, Alexander Bokovoy wrote: On Tue, 28 Jun 2016, Lukas Slebodnik wrote: On (28/06/16 10:57), Alexander Bokovoy wrote: On Tue, 28 Jun 2016, Petr Vobornik wrote: On 06/27/2016 08:11 PM, Lukas Slebodnik wrote: > On (27/06/16 17:55), Milan Kubík wrote: > &g

Re: [Freeipa-devel] Broken pki 10.3.3-1 packages in freeipa-master COPR

2016-06-28 Thread Milan Kubík
On 06/28/2016 01:03 PM, Lukas Slebodnik wrote: On (28/06/16 10:57), Alexander Bokovoy wrote: On Tue, 28 Jun 2016, Petr Vobornik wrote: On 06/27/2016 08:11 PM, Lukas Slebodnik wrote: On (27/06/16 17:55), Milan Kubík wrote: Hi all, the pki packages that are currently in the COPR repo [1

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2016-02-09 Thread Milan Kubík
no longer applies to master. Rebase it, please. Milan - Original Message - From: "Filip Škola" <fsk...@redhat.com> To: "Milan Kubík" <mku...@redhat.com> Cc: freeipa-devel@redhat.com Sent: Wednesday, 9 December, 2015 7:01:02 PM Subject: Re: [Freeipa-devel] [PATCH

Re: [Freeipa-devel] [patch 0032] ipatests: add missing certprofile fixture

2016-02-09 Thread Milan Kubík
On 02/09/2016 02:37 PM, Milan Kubík wrote: Fixes the CA ACL tests broken by removed import. This patch doesn't rely on undocumented behavior of pytest. The patch invalidates patch 133 by Martin Babinsky. Patch updated with trac link -- Milan Kubik From

[Freeipa-devel] [patch 0032] ipatests: add missing certprofile fixture

2016-02-09 Thread Milan Kubík
Fixes the CA ACL tests broken by removed import. This patch doesn't rely on undocumented behavior of pytest. The patch invalidates patch 133 by Martin Babinsky. -- Milan Kubik From 73dc9e91605c9299e48cdf62ddc0eb4927471a57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?=

Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology

2016-02-12 Thread Milan Kubík
On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group

Re: [Freeipa-devel] [PATCH] CI: Add simple replication test in 2-connected topology.

2016-02-12 Thread Milan Kubík
On 02/12/2016 10:50 AM, David Kupka wrote: On 10/02/16 08:51, David Kupka wrote: This topology should be closer to the ones in real world than our current ones. But it is still impractical and (hopefully) no one has such deployment. If some user could share his/her deployment topology I will be

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-02-12 Thread Milan Kubík
On 02/04/2016 08:49 AM, Oleg Fayans wrote: Hi Petr, On 02/03/2016 02:19 PM, Petr Spacek wrote: On 3.2.2016 10:22, Oleg Fayans wrote: Guys, can anyone take a look at this? The commit message does not explain why you are setting search path. Fixed. I have to say that I do not like touching

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2016-02-10 Thread Milan Kubík
On 02/09/2016 04:19 PM, Milan Kubík wrote: On 01/28/2016 10:42 AM, Filip Skola wrote: - Original Message - On 01/25/2016 11:11 AM, Filip Skola wrote: - Original Message - On 01/15/2016 03:38 PM, Filip Skola wrote: Hi, sending rebased patch. F. - Original Message

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2016-02-10 Thread Milan Kubík
On 02/10/2016 09:17 AM, Milan Kubík wrote: On 02/09/2016 04:19 PM, Milan Kubík wrote: On 01/28/2016 10:42 AM, Filip Skola wrote: - Original Message - On 01/25/2016 11:11 AM, Filip Skola wrote: - Original Message - On 01/15/2016 03:38 PM, Filip Skola wrote: Hi, sending

Re: [Freeipa-devel] [patch 0032] ipatests: add missing certprofile fixture

2016-02-11 Thread Milan Kubík
On 02/11/2016 10:00 AM, Martin Babinsky wrote: On 02/09/2016 04:06 PM, Milan Kubík wrote: On 02/09/2016 02:37 PM, Milan Kubík wrote: Fixes the CA ACL tests broken by removed import. This patch doesn't rely on undocumented behavior of pytest. The patch invalidates patch 133 by Martin Babinsky

Re: [Freeipa-devel] [PATCH 0133] re-add missing fixture import to the CA ACL plugin test

2016-02-02 Thread Milan Kubík
On 02/02/2016 03:36 PM, Martin Babinsky wrote: This was causing some of the CA ACL plugin tests to fail/error. Possible NACK. This is not an officially supported way how to reuse fixtures. [1] I was working on a fix, that would contain all of the needed fixtures in the module that requires

Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

2016-02-23 Thread Milan Kubík
On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik Review bump. -- Milan Kubik -- Manage your subscription for the Freeipa

Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

2016-02-25 Thread Milan Kubík
On 02/24/2016 07:05 PM, Martin Basti wrote: On 24.02.2016 08:34, Milan Kubík wrote: On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well

Re: [Freeipa-devel] [patch 0033] spec file: update the python-polib dependency name to python2-polib

2016-02-25 Thread Milan Kubík
On 02/15/2016 05:39 PM, Lukas Slebodnik wrote: On (15/02/16 17:00), Petr Vobornik wrote: On 02/15/2016 04:37 PM, Milan Kubík wrote: Reflect the updated name of the package. Seems to me as a packaging bug in python-polib. It should use python_provide macro to handle the transition

Re: [Freeipa-devel] [patch 0033] spec file: update the python-polib dependency name to python2-polib

2016-02-25 Thread Milan Kubík
On 02/25/2016 11:07 AM, Jan Cholasta wrote: On 25.2.2016 11:03, Milan Kubík wrote: On 02/15/2016 05:39 PM, Lukas Slebodnik wrote: On (15/02/16 17:00), Petr Vobornik wrote: On 02/15/2016 04:37 PM, Milan Kubík wrote: Reflect the updated name of the package. Seems to me as a packaging bug

Re: [Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

2016-01-25 Thread Milan Kubík
On 01/22/2016 02:22 PM, Martin Babinsky wrote: On 01/19/2016 05:56 PM, Milan Kubík wrote: On 01/19/2016 05:31 PM, Milan Kubík wrote: Patch attached. This actually has a ticket opened. Patch with fixed commit message. ;) -- Milan Kubik Hi Milan, for the step 1 installation I would

Re: [Freeipa-devel] [PATCH 0003] Refactor test_replace

2016-01-26 Thread Milan Kubík
On 01/12/2016 03:04 PM, Milan Kubík wrote: On 12/04/2015 11:29 AM, Filip Škola wrote: On Fri, 4 Dec 2015 10:08:40 +0100 Milan Kubík <mku...@redhat.com> wrote: On 12/04/2015 10:04 AM, Filip Škola wrote: Hi, sending rather short one this time. F. NACK, UserTracker is imple

Re: [Freeipa-devel] [PATCH 0004] Refactor test_attr

2016-01-26 Thread Milan Kubík
On 01/12/2016 03:03 PM, Milan Kubík wrote: On 12/07/2015 01:25 PM, Filip Škola wrote: Now the tier marker have lost somewhere on the way... which is corrected in this patch. /me apologizes for the noise F. On Mon, 7 Dec 2015 13:00:41 +0100 Filip Škola <fsk...@redhat.com> wrote: Sel

  1   2   >