Re: [Freeipa-devel] [PATCH] 546 webui: Datetime parsing and formatting

2014-03-06 Thread Misnyovszki Adam
On Tue, 25 Feb 2014 18:05:28 +0100 Petr Vobornik pvobo...@redhat.com wrote: prerequisite for patch 547, 548 depends on tbabej's datetime patch this patch implements: - output_formatter in field. It should be used in par with formatter. Formatter serves for datasource-widget conversion,

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-03-12 Thread Misnyovszki Adam
On Wed, 12 Mar 2014 15:41:31 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 7.3.2014 18:10, Petr Vobornik wrote: Attaching new version of 537 which adds combobox control for owner attribute instead of textbox. All other patches are attached as well to reduce confusion in case of ACK

Re: [Freeipa-devel] [PATCH] 549 webui: use unique ids for checkboxes

2014-03-12 Thread Misnyovszki Adam
On Tue, 25 Feb 2014 18:12:20 +0100 Petr Vobornik pvobo...@redhat.com wrote: This is a minor fix. Please don't close ticket 3904 yet if committed. Checkboxes have not used unique ids across the whole UI. It broke checking by clicking on label for later displayed instances. It became serious

Re: [Freeipa-devel] [PATCH] 546 webui: Datetime parsing and formatting

2014-03-13 Thread Misnyovszki Adam
On Thu, 06 Mar 2014 13:26:03 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 6.3.2014 13:01, Misnyovszki Adam wrote: On Tue, 25 Feb 2014 18:05:28 +0100 Petr Vobornik pvobo...@redhat.com wrote: prerequisite for patch 547, 548 depends on tbabej's datetime patch this patch

Re: [Freeipa-devel] [PATCH] 548 webui: change ipatokennotbefore and ipatokennotafter types to datetime

2014-03-13 Thread Misnyovszki Adam
On Tue, 25 Feb 2014 18:10:13 +0100 Petr Vobornik pvobo...@redhat.com wrote: Depends on tbabej's patches # 137, 140 and pvoborni's 546 and 531-541. https://fedorahosted.org/freeipa/ticket/3369 ACK ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-03-14 Thread Misnyovszki Adam
Hi, automember-rebuild uses asynchronous 389 task, and returned success even if the task didn't run. This patch fixes this issue adding a --nowait parameter to 'ipa automember-rebuild', defaulting to False, thus when the script runs without it, it waits for the 'nstaskexitcode' attribute, which

Re: [Freeipa-devel] [PATCH] 550 webui-css: improve radio, checkbox keyboard support and color

2014-03-19 Thread Misnyovszki Adam
On Fri, 14 Mar 2014 18:39:14 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 13.3.2014 16:55, Petr Vobornik wrote: On 7.3.2014 15:34, Petr Vobornik wrote: checkboxes and radio buttons: - do not change color on hover when disabled - are focusable and checkable by keyboard again. This

Re: [Freeipa-devel] [PATCH] 552-557 Permissions v2 Web UI

2014-03-19 Thread Misnyovszki Adam
On Wed, 19 Mar 2014 10:52:10 +0100 Petr Viktorin pvikt...@redhat.com wrote: On 03/18/2014 04:56 PM, Petr Vobornik wrote: On 18.3.2014 15:07, Petr Viktorin wrote: On 03/18/2014 01:09 PM, Petr Vobornik wrote: New revision for patch patch #557 attached. On 17.3.2014 15:22, Petr Viktorin

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-03-20 Thread Misnyovszki Adam
On Fri, 14 Mar 2014 13:26:15 -0400 Rob Crittenden rcrit...@redhat.com wrote: Misnyovszki Adam wrote: Hi, automember-rebuild uses asynchronous 389 task, and returned success even if the task didn't run. This patch fixes this issue adding a --nowait parameter to 'ipa automember-rebuild

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-03-20 Thread Misnyovszki Adam
On Thu, 20 Mar 2014 14:19:51 +0100 Misnyovszki Adam amisn...@redhat.com wrote: On Fri, 14 Mar 2014 13:26:15 -0400 Rob Crittenden rcrit...@redhat.com wrote: Misnyovszki Adam wrote: Hi, automember-rebuild uses asynchronous 389 task, and returned success even if the task didn't run

Re: [Freeipa-devel] [PATCH] 560 webui: rename domNode to dom_node

2014-03-20 Thread Misnyovszki Adam
On Wed, 19 Mar 2014 16:02:12 +0100 Petr Vobornik pvobo...@redhat.com wrote: - unites domNode and dom_node usage to dom_node Nack, install/ui/test/details_tests.js:236 install/ui/test/details_tests.js:242

Re: [Freeipa-devel] [PATCHES] 0499-0502 permission CLI: rename --permissions to --right

2014-03-20 Thread Misnyovszki Adam
On Tue, 18 Mar 2014 12:02:06 +0100 Petr Viktorin pvikt...@redhat.com wrote: Hello, This renames --permissions to --right. The old name is kept as a deprecated alias. FreeIPA didn't have a mechanism for doing this, so I added one. Also, while I was digging around in this part, I made the new

Re: [Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-03-21 Thread Misnyovszki Adam
On Fri, 21 Feb 2014 16:06:27 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 21.2.2014 15:45, Adam Misnyovszki wrote: Hi, According to http://tools.ietf.org/html/rfc2798 ipa client and web ui extended with employeenumber field. https://fedorahosted.org/freeipa/ticket/4165

Re: [Freeipa-devel] [PATCH] typo in migrate-ds

2014-03-21 Thread Misnyovszki Adam
On Tue, 18 Mar 2014 19:31:31 -0600 Gabe Alford redhatri...@gmail.com wrote: All, It looks like the only typos exist in the uk and fr .po files for this ticket https://fedorahosted.org/freeipa/ticket/2546 Point me in the right direction if I am wrong. Thanks, Gabe ACK, thanks for

Re: [Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-03-21 Thread Misnyovszki Adam
On Fri, 21 Mar 2014 10:13:55 +0100 Misnyovszki Adam amisn...@redhat.com wrote: On Fri, 21 Feb 2014 16:06:27 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 21.2.2014 15:45, Adam Misnyovszki wrote: Hi, According to http://tools.ietf.org/html/rfc2798 ipa client and web ui extended

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-03-21 Thread Misnyovszki Adam
On Fri, 21 Mar 2014 10:33:00 +0100 Petr Viktorin pvikt...@redhat.com wrote: On 03/21/2014 10:29 AM, Petr Viktorin wrote: On 03/20/2014 04:22 PM, Misnyovszki Adam wrote: On Thu, 20 Mar 2014 14:19:51 +0100 Misnyovszki Adam amisn...@redhat.com wrote: On Fri, 14 Mar 2014 13:26:15 -0400

Re: [Freeipa-devel] [PATCHES] 0499-0502 permission CLI: rename --permissions to --right

2014-03-21 Thread Misnyovszki Adam
On Fri, 21 Mar 2014 11:14:43 +0100 Petr Viktorin pvikt...@redhat.com wrote: On 03/20/2014 07:20 PM, Misnyovszki Adam wrote: On Tue, 18 Mar 2014 12:02:06 +0100 Petr Viktorin pvikt...@redhat.com wrote: Hello, This renames --permissions to --right. The old name is kept as a deprecated

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-03-24 Thread Misnyovszki Adam
On Fri, 21 Mar 2014 13:06:21 +0100 Petr Viktorin pvikt...@redhat.com wrote: On 03/21/2014 12:58 PM, Martin Kosek wrote: On 03/21/2014 12:38 PM, Petr Viktorin wrote: On 03/21/2014 12:00 PM, Misnyovszki Adam wrote: On Fri, 21 Mar 2014 10:33:00 +0100 Petr Viktorin pvikt...@redhat.com wrote

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-03-25 Thread Misnyovszki Adam
On Mon, 24 Mar 2014 17:06:41 +0100 Martin Kosek mko...@redhat.com wrote: On 03/24/2014 11:42 AM, Misnyovszki Adam wrote: On Fri, 21 Mar 2014 13:06:21 +0100 Petr Viktorin pvikt...@redhat.com wrote: On 03/21/2014 12:58 PM, Martin Kosek wrote: On 03/21/2014 12:38 PM, Petr Viktorin wrote

Re: [Freeipa-devel] [PATCH] 560 webui: rename domNode to dom_node

2014-03-25 Thread Misnyovszki Adam
On Tue, 25 Mar 2014 12:49:24 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 20.3.2014 16:51, Misnyovszki Adam wrote: On Wed, 19 Mar 2014 16:02:12 +0100 Petr Vobornik pvobo...@redhat.com wrote: - unites domNode and dom_node usage to dom_node Nack, install/ui/test

Re: [Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-03-26 Thread Misnyovszki Adam
On Tue, 25 Mar 2014 18:26:53 +0100 Misnyovszki Adam amisn...@redhat.com wrote: On Tue, 25 Mar 2014 14:31:15 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 21.3.2014 11:00, Misnyovszki Adam wrote: On Fri, 21 Mar 2014 10:13:55 +0100 Misnyovszki Adam amisn...@redhat.com wrote

Re: [Freeipa-devel] [PATCH] 561 webui: make navigation module independent on app module

2014-03-26 Thread Misnyovszki Adam
On Wed, 19 Mar 2014 16:02:19 +0100 Petr Vobornik pvobo...@redhat.com wrote: When some module used 'freeipa/navigation' it pulled the entire Web UI because navigation depended on app. This patch splits the app into two modules: app and app_container. App specifies the entities which are part

Re: [Freeipa-devel] [PATCH] 562-563 webui: move RPC code from IPA module to its own module

2014-03-27 Thread Misnyovszki Adam
On Wed, 19 Mar 2014 16:02:29 +0100 Petr Vobornik pvobo...@redhat.com wrote: depends on path #561(make navigation module independent on app module) [PATCH] 562 webui: move RPC code from IPA module to its own module - moves RPC code from ipa.js to it's own module - part of ongoing effort

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-03-27 Thread Misnyovszki Adam
On Wed, 26 Mar 2014 13:15:55 +0100 Petr Viktorin pvikt...@redhat.com wrote: On 03/25/2014 03:36 PM, Misnyovszki Adam wrote: On Mon, 24 Mar 2014 17:06:41 +0100 Martin Kosek mko...@redhat.com wrote: On 03/24/2014 11:42 AM, Misnyovszki Adam wrote: On Fri, 21 Mar 2014 13:06:21 +0100 Petr

Re: [Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-03-27 Thread Misnyovszki Adam
On Wed, 26 Mar 2014 14:07:50 +0100 Misnyovszki Adam amisn...@redhat.com wrote: On Tue, 25 Mar 2014 18:26:53 +0100 Misnyovszki Adam amisn...@redhat.com wrote: On Tue, 25 Mar 2014 14:31:15 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 21.3.2014 11:00, Misnyovszki Adam wrote

Re: [Freeipa-devel] [PATCH] 565-568 webui: field and widget binding refactoring

2014-04-02 Thread Misnyovszki Adam
On Thu, 27 Mar 2014 16:07:55 +0100 Petr Vobornik pvobo...@redhat.com wrote: The last refactoring I did while implementing RCUE login or more precisely support for standalone facets which have forms but are not details facets. [PATCH] webui: field and widget binding refactoring This is

[Freeipa-devel] [PATCH][RFC] 9 CA-less tests generate failure

2014-04-04 Thread Misnyovszki Adam
Hi, CA-less test suite always generate failures when installing revoked certificates. This is a known issue, described in https://fedorahosted.org/freeipa/ticket/4270 , this fix skips these tests, outputting a notification message for the ticket. Now it outputs this: [amisnyov@host freeipa]$

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-04-08 Thread Misnyovszki Adam
On Mon, 07 Apr 2014 09:43:10 +0200 Petr Viktorin pvikt...@redhat.com wrote: On 03/27/2014 03:37 PM, Misnyovszki Adam wrote: On Wed, 26 Mar 2014 13:15:55 +0100 Petr Viktorin pvikt...@redhat.com wrote: [...] Looks great! I'm just concerned about the error returned when the task takes

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-04-09 Thread Misnyovszki Adam
On Tue, 08 Apr 2014 17:31:25 +0200 Petr Viktorin pvikt...@redhat.com wrote: On 04/08/2014 04:17 PM, Misnyovszki Adam wrote: On Mon, 07 Apr 2014 09:43:10 +0200 Petr Viktorin pvikt...@redhat.com wrote: On 03/27/2014 03:37 PM, Misnyovszki Adam wrote: On Wed, 26 Mar 2014 13:15:55 +0100

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-04-09 Thread Misnyovszki Adam
On Wed, 09 Apr 2014 14:53:34 +0200 Petr Viktorin pvikt...@redhat.com wrote: On 04/09/2014 01:45 PM, Petr Viktorin wrote: On 04/09/2014 01:43 PM, Misnyovszki Adam wrote: On Tue, 08 Apr 2014 17:31:25 +0200 Petr Viktorin pvikt...@redhat.com wrote: On 04/08/2014 04:17 PM, Misnyovszki Adam

Re: [Freeipa-devel] [PATCH] 0454 Test fixes

2014-04-10 Thread Misnyovszki Adam
On Tue, 25 Mar 2014 10:23:56 +0100 Petr Viktorin pvikt...@redhat.com wrote: On 01/28/2014 03:35 PM, Petr Viktorin wrote: On 01/23/2014 01:54 PM, Petr Viktorin wrote: [...] Patch 454 changes the cert generation script for CA-less tests to use sequential serial numbers rather than random

Re: [Freeipa-devel] [PATCH] 569-583 New Login Screen

2014-04-11 Thread Misnyovszki Adam
On Fri, 28 Mar 2014 14:04:13 +0100 Petr Vobornik pvobo...@redhat.com wrote: Attached patches replace IPA.unauthorized dialog with new Login Screen. To make it happen, a support for standalone facets had to be developed because current framework was limited by facets dependent on entities

Re: [Freeipa-devel] [PATCH] 569-583 New Login Screen

2014-04-15 Thread Misnyovszki Adam
On Tue, 15 Apr 2014 09:39:54 +0200 Petr Vobornik pvobo...@redhat.com wrote: On 11.4.2014 14:31, Misnyovszki Adam wrote: On Fri, 28 Mar 2014 14:04:13 +0100 Petr Vobornik pvobo...@redhat.com wrote: Attached patches replace IPA.unauthorized dialog with new Login Screen. To make

[Freeipa-devel] [PATCH] 11 - CI - test_forced_client_reenrollment stability fix

2014-04-15 Thread Misnyovszki Adam
Hi, this patch fixes FreeIPA Jenkins CI test freeipa-integration-forced_client_reenrollment-f19, by turning sshfp records into a set, and sorting them before assertion. https://fedorahosted.org/freeipa/ticket/4298 Greets AdamFrom 552620f7924aff6b083c867af6101ebb49f8fef0 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 585 webui: fix OTP Token add regression

2014-04-15 Thread Misnyovszki Adam
On Tue, 15 Apr 2014 09:54:22 +0200 Petr Vobornik pvobo...@redhat.com wrote: OTP Token add failed because of invalid function call. qr_widget doesn't contain `on_value_changed` method since it inherits from `IPA.widget` and not from `IPA.input_widget`. Emitting the event was preserved for

Re: [Freeipa-devel] [PATCH] 11 - CI - test_forced_client_reenrollment stability fix

2014-04-15 Thread Misnyovszki Adam
On Tue, 15 Apr 2014 12:51:47 +0200 Petr Viktorin pvikt...@redhat.com wrote: On 04/15/2014 12:41 PM, Misnyovszki Adam wrote: Hi, this patch fixes FreeIPA Jenkins CI test freeipa-integration-forced_client_reenrollment-f19, by turning sshfp records into a set, and sorting them before

[Freeipa-devel] [PATCH][RFC] 13 - Log pretty-printed request and response

2014-04-16 Thread Misnyovszki Adam
Hi, this patch enables logging json dumps of request and response, using the --log-payload switch in ipa cli. RFC tag is to ensure that I handled the --log-payload switch correctly in ipa cli. Be careful, it only logs, so --log-payload without -v switch doesn't make the dump visible in command

Re: [Freeipa-devel] [PATCH] 11 - CI - test_forced_client_reenrollment stability fix

2014-04-16 Thread Misnyovszki Adam
On Wed, 16 Apr 2014 07:59:39 +0200 Martin Kosek mko...@redhat.com wrote: On 04/15/2014 05:36 PM, Misnyovszki Adam wrote: On Tue, 15 Apr 2014 12:51:47 +0200 Petr Viktorin pvikt...@redhat.com wrote: On 04/15/2014 12:41 PM, Misnyovszki Adam wrote: Hi, this patch fixes FreeIPA Jenkins CI

[Freeipa-devel] [PATCH] 12 Call generate-rndc-key.sh during ipa-server-install

2014-04-17 Thread Misnyovszki Adam
Hi, this patch modifies ipa-server-install to warn the user, if there is a lack of entropy, also runs generate-rndc-key.sh before named restart, to ensure, that it can start before systemd timeouts. Thanks Adam From d405cea8dae5a03ab0f9d429d3251e8be9ae9fe2 Mon Sep 17 00:00:00 2001 From: Adam

[Freeipa-devel] [PATCH] 15 webui doc: typo fixes in guides

2014-04-18 Thread Misnyovszki Adam
Hi, $SUBJ tells everything. Thanks AdamFrom 38ecbfc95dde8f2a968165e1db42922c9a8b8fa1 Mon Sep 17 00:00:00 2001 From: Adam Misnyovszki amisn...@redhat.com Date: Fri, 11 Apr 2014 19:31:19 +0200 Subject: [PATCH] webui doc: typo fixes in guides --- install/ui/doc/guides.json | 4

Re: [Freeipa-devel] [PATCH] 12 Call generate-rndc-key.sh during ipa-server-install

2014-04-18 Thread Misnyovszki Adam
On Thu, 17 Apr 2014 16:21:19 +0200 Martin Kosek mko...@redhat.com wrote: On 04/17/2014 04:10 PM, Rob Crittenden wrote: Misnyovszki Adam wrote: Hi, this patch modifies ipa-server-install to warn the user, if there is a lack of entropy, also runs generate-rndc-key.sh before named restart

Re: [Freeipa-devel] [PATCH][RFC] 13 - Log pretty-printed request and response

2014-04-23 Thread Misnyovszki Adam
On Wed, 16 Apr 2014 11:42:00 -0400 Rob Crittenden rcrit...@redhat.com wrote: Misnyovszki Adam wrote: Hi, this patch enables logging json dumps of request and response, using the --log-payload switch in ipa cli. RFC tag is to ensure that I handled the --log-payload switch correctly in ipa

Re: [Freeipa-devel] [PATCH] 14 webui: select all checkbox remains selected after operation

2014-04-24 Thread Misnyovszki Adam
On Wed, 23 Apr 2014 16:57:35 +0200 Petr Vobornik pvobo...@redhat.com wrote: On 18.4.2014 10:43, Misnyovszki Adam wrote: Hi, this patch fixes select_all checkbox issue, after any bulk modify or delete operation, the checkbox is deselected. https://fedorahosted.org/freeipa/ticket/4245

[Freeipa-devel] [PATCH] 16-17 Attribute box in permission UI is too small

2014-04-25 Thread Misnyovszki Adam
Hi, first patch redesigns attribute box in permission forms, making it a bigger scrollable checkboxlist. Second one adds a filter field to it for better user experience, if the checkboxlist would be too large. Also, webui unit tests for rbac are updated to work properly with the new widget. Thanks

[Freeipa-devel] [PATCH] 18 webui otptoken test data added

2014-04-25 Thread Misnyovszki Adam
Hi, this patch adds some static test data for the webui otptoken part. AdamFrom a119f23cde594a0c9a4a2bf3cb91d259c5ce06b1 Mon Sep 17 00:00:00 2001 From: Adam Misnyovszki amisn...@redhat.com Date: Fri, 25 Apr 2014 16:33:11 +0200 Subject: [PATCH] webui OTP token test data added ---

Re: [Freeipa-devel] [PATCH] webui: regression - enable fields on idrange type change (add)

2014-04-29 Thread Misnyovszki Adam
On Fri, 25 Apr 2014 15:01:36 +0200 Petr Vobornik pvobo...@redhat.com wrote: ID range adder dialog was not properly addressed in field binding refactoring. The usage of reset caused some weird loops. https://fedorahosted.org/freeipa/ticket/4326 tests with and without trusts ran smoothly,

Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added

2014-04-29 Thread Misnyovszki Adam
On Fri, 25 Apr 2014 17:16:48 +0200 Misnyovszki Adam amisn...@redhat.com wrote: Hi, this patch adds some static test data for the webui otptoken part. Adam Attached corrected DN's. Thanks AdamFrom e5816ae2dca48841c7c3b3edf591257b89fcb49b Mon Sep 17 00:00:00 2001 From: Adam Misnyovszki amisn

[Freeipa-devel] plugin registration refactoring for pwpolicy

2014-05-02 Thread Misnyovszki Adam
SSIA Thanks AdamFrom eece77de2869e484f0cfede4e05205026fecd709 Mon Sep 17 00:00:00 2001 From: Adam Misnyovszki amisn...@redhat.com Date: Fri, 2 May 2014 13:52:49 +0200 Subject: [PATCH] plugin registration refactoring for pwpolicy decorators used for plugin registration in pwpolicy according to:

Re: [Freeipa-devel] [PATCH] 587 webui-ci: adjust id range tests to new validator

2014-05-05 Thread Misnyovszki Adam
On Fri, 25 Apr 2014 15:02:27 +0200 Petr Vobornik pvobo...@redhat.com wrote: SSIA LGFM, integration tests for range now runs smoothly. ACK Thanks Adam ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 588 webui: fix switching between multiple_choice_section choices

2014-05-05 Thread Misnyovszki Adam
On Fri, 25 Apr 2014 19:24:35 +0200 Petr Vobornik pvobo...@redhat.com wrote: - required indicators are not present for all sections except the last - validation has wrong color for the same sections There was only one layout for all choices. Layout should not be reused because `create`

Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added

2014-05-05 Thread Misnyovszki Adam
On Wed, 30 Apr 2014 13:37:10 +0200 Petr Vobornik pvobo...@redhat.com wrote: On 29.4.2014 16:30, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 17:16:48 +0200 Misnyovszki Adam amisn...@redhat.com wrote: Hi, this patch adds some static test data for the webui otptoken part. Adam

Re: [Freeipa-devel] [PATCH] 629 webui: otptoken-adder dialog - remove obsolete comment

2014-05-06 Thread Misnyovszki Adam
On Tue, 06 May 2014 13:34:28 +0200 Petr Vobornik pvobo...@redhat.com wrote: No longer valid. HOTP tokens are also supported. ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 20 Trust add datetime fix

2014-05-06 Thread Misnyovszki Adam
Hi, this patch fixes trust add, since now datetime object is returned for 'modifytimestamp', which cannot be split like a string, thus causing an error. Thanks AdamFrom afe6d32cb0912c18fa046992a1e27f352b454dcb Mon Sep 17 00:00:00 2001 From: Adam Misnyovszki amisn...@redhat.com Date: Mon, 5 May

[Freeipa-devel] [PATCH] 22-23 webui tests extended by checking field disable property

2014-05-06 Thread Misnyovszki Adam
Hi, first patch extends webui tests with a callback function, and an assert_disabled function, to check if a field is disabled under certain conditions. Second patch extends range tests with this checking functionality depending on range types. Thanks AdamFrom

Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added

2014-05-07 Thread Misnyovszki Adam
On Tue, 06 May 2014 10:29:32 +0200 Petr Vobornik pvobo...@redhat.com wrote: On 5.5.2014 16:39, Misnyovszki Adam wrote: On Wed, 30 Apr 2014 13:37:10 +0200 Petr Vobornik pvobo...@redhat.com wrote: On 29.4.2014 16:30, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 17:16:48 +0200

Re: [Freeipa-devel] [PATCH] 22-23 webui tests extended by checking field disable property

2014-05-07 Thread Misnyovszki Adam
On Tue, 6 May 2014 17:58:09 +0200 Misnyovszki Adam amisn...@redhat.com wrote: Hi, first patch extends webui tests with a callback function, and an assert_disabled function, to check if a field is disabled under certain conditions. Second patch extends range tests with this checking

Re: [Freeipa-devel] [PATCH] 592-628 Update to PatternFly

2014-05-12 Thread Misnyovszki Adam
Hi, see my review notes below: On Mon, 05 May 2014 18:41:13 +0200 Petr Vobornik pvobo...@redhat.com wrote: This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based PatternFly (v0.2.4) according to plan described at:

Re: [Freeipa-devel] [PATCH] 589-590 webui-ci: save screenshot on test failure

2014-05-12 Thread Misnyovszki Adam
On Wed, 30 Apr 2014 10:40:43 +0200 Petr Vobornik pvobo...@redhat.com wrote: Very handy for debugging failures... New decorator: ui_driver.screenshot created. It should be applied on test methods. Screenshot is saved on each exception except SkipTest. Configuration: - add:

Re: [Freeipa-devel] [PATCH 0052] Only specify the ipatokenuniqueid default in the add operation

2014-05-12 Thread Misnyovszki Adam
On Tue, 06 May 2014 11:46:14 -0400 Nathaniel McCallum npmccal...@redhat.com wrote: On Tue, 2014-05-06 at 11:38 -0400, Nathaniel McCallum wrote: On Tue, 2014-05-06 at 17:34 +0200, Petr Vobornik wrote: On 6.5.2014 17:13, Nathaniel McCallum wrote: On Tue, 2014-05-06 at 17:04 +0200, Petr