[Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

2016-06-05 Thread Pavel Vomacka
Hello, please review attached patches which add WebUI part of DNS Locations feature. -- Pavel^3 Vomacka From b2e30e910608d8be549e126889ff9a011149f58b Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Sun, 5 Jun 2016 18:03:17 +0200 Subject: [PATCH 1/2] Add a

Re: [Freeipa-devel] [PATCH] 0036-38 webui: Server roles

2016-06-05 Thread Pavel Vomacka
On 06/03/2016 03:10 PM, Petr Vobornik wrote: On 06/02/2016 01:40 PM, Pavel Vomacka wrote: Hello, please review my patches which add webui for server roles. Did not test yet. I'm waiting for rebase of backend. Patch 36: ACK (assuming it works when ^^ is available) Patch 37: 1. typo

Re: [Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

2016-06-09 Thread Pavel Vomacka
On 06/09/2016 10:44 AM, Pavel Vomacka wrote: On 06/09/2016 10:15 AM, Pavel Vomacka wrote: On 06/08/2016 04:40 PM, Petr Vobornik wrote: On 06/07/2016 10:07 AM, Pavel Vomacka wrote: On 06/06/2016 07:51 PM, Martin Basti wrote: On 05.06.2016 18:34, Pavel Vomacka wrote: Hello, please

Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts

2016-06-09 Thread Pavel Vomacka
On 06/09/2016 02:03 PM, Petr Vobornik wrote: On 06/08/2016 03:32 PM, Pavel Vomacka wrote: On 06/08/2016 02:20 PM, Petr Vobornik wrote: On 06/06/2016 04:17 PM, Pavel Vomacka wrote: Hello, please review attached patch. Ticket: https://fedorahosted.org/freeipa/ticket/5931 Also tables

Re: [Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

2016-06-09 Thread Pavel Vomacka
On 06/09/2016 10:15 AM, Pavel Vomacka wrote: On 06/08/2016 04:40 PM, Petr Vobornik wrote: On 06/07/2016 10:07 AM, Pavel Vomacka wrote: On 06/06/2016 07:51 PM, Martin Basti wrote: On 05.06.2016 18:34, Pavel Vomacka wrote: Hello, please review attached patches which add WebUI part

Re: [Freeipa-devel] [PATCH] 0042: Fix bad searching of reverse DNS zone

2016-06-09 Thread Pavel Vomacka
On 06/08/2016 06:36 PM, Petr Vobornik wrote: On 06/07/2016 10:30 AM, Pavel Vomacka wrote: On 06/07/2016 09:08 AM, Petr Spacek wrote: Hi, the commit message does not say what was wrong and why and what works now. Please improve the commit message before pushing this. Commit message

Re: [Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

2016-06-09 Thread Pavel Vomacka
On 06/08/2016 04:40 PM, Petr Vobornik wrote: On 06/07/2016 10:07 AM, Pavel Vomacka wrote: On 06/06/2016 07:51 PM, Martin Basti wrote: On 05.06.2016 18:34, Pavel Vomacka wrote: Hello, please review attached patches which add WebUI part of DNS Locations feature. -- Pavel^3 Vomacka

Re: [Freeipa-devel] [PATCH] 0036-38 webui: Server roles

2016-06-09 Thread Pavel Vomacka
On 06/08/2016 04:09 PM, Petr Vobornik wrote: On 06/05/2016 07:22 PM, Pavel Vomacka wrote: On 06/03/2016 03:10 PM, Petr Vobornik wrote: On 06/02/2016 01:40 PM, Pavel Vomacka wrote: Hello, please review my patches which add webui for server roles. Did not test yet. I'm waiting for rebase

Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts

2016-06-08 Thread Pavel Vomacka
On 06/08/2016 02:20 PM, Petr Vobornik wrote: On 06/06/2016 04:17 PM, Pavel Vomacka wrote: Hello, please review attached patch. Ticket: https://fedorahosted.org/freeipa/ticket/5931 Also tables for host groups are needed. + the same UI should be also on host page. Added, please see

Re: [Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

2016-06-07 Thread Pavel Vomacka
On 06/06/2016 07:51 PM, Martin Basti wrote: On 05.06.2016 18:34, Pavel Vomacka wrote: Hello, please review attached patches which add WebUI part of DNS Locations feature. -- Pavel^3 Vomacka NACK 1) When I edit location description and click on revert button, then that nice

Re: [Freeipa-devel] [PATCH 0499] Pylint: exclude some files/dirs from check

2016-06-07 Thread Pavel Vomacka
On 06/06/2016 04:26 PM, Martin Basti wrote: See commit message, yacctab.py causes lint errors and must be excluded Patch attached. Works well, ACK. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0042: Fix bad searching of reverse DNS zone

2016-06-07 Thread Pavel Vomacka
On 06/07/2016 09:08 AM, Petr Spacek wrote: Hi, the commit message does not say what was wrong and why and what works now. Please improve the commit message before pushing this. Commit message improved. Petr^2 Spacek On 6.6.2016 19:03, Pavel Vomacka wrote: Fix bad searching of reverse DNS

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

2016-06-06 Thread Pavel Vomacka
On 06/02/2016 06:22 PM, Petr Vobornik wrote: On 06/01/2016 10:41 AM, Pavel Vomacka wrote: On 05/27/2016 05:58 PM, Pavel Vomacka wrote: On 05/27/2016 05:44 PM, Nathaniel McCallum wrote: On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote: On 05/12/2016 11:13 PM, Nathaniel McCallum

Re: [Freeipa-devel] [PATCH] 0059..0064 Lightweight sub-CAs

2016-06-08 Thread Pavel Vomacka
On 06/08/2016 05:15 AM, Fraser Tweedale wrote: On Tue, Jun 07, 2016 at 03:42:22PM +1000, Fraser Tweedale wrote: On Wed, Jun 01, 2016 at 02:51:04PM +1000, Fraser Tweedale wrote: Hi team, This patchset implements the 'ca' plugin for creating and managing lightweight sub-CAs, and updates the

Re: [Freeipa-devel] [PATCH] 0059..0064 Lightweight sub-CAs

2016-06-08 Thread Pavel Vomacka
On 06/08/2016 01:21 PM, Pavel Vomacka wrote: On 06/08/2016 05:15 AM, Fraser Tweedale wrote: On Tue, Jun 07, 2016 at 03:42:22PM +1000, Fraser Tweedale wrote: On Wed, Jun 01, 2016 at 02:51:04PM +1000, Fraser Tweedale wrote: Hi team, This patchset implements the 'ca' plugin for creating

[Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts

2016-06-06 Thread Pavel Vomacka
Hello, please review attached patch. Ticket: https://fedorahosted.org/freeipa/ticket/5931 -- Pavel^3 Vomacka From bef7a296008a32b981d78d521ce452e06b8b59c8 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 6 Jun 2016 12:59:24 +0200 Subject: [PATCH] Add

[Freeipa-devel] [PATCH] 0042: Fix bad searching of reverse DNS zone

2016-06-06 Thread Pavel Vomacka
Fix bad searching of reverse DNS zone https://fedorahosted.org/freeipa/ticket/5796 -- Pavel^3 Vomacka From ff1e9d9930146ae998bec34e739d0cd8a1fdaa55 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 6 Jun 2016 18:56:03 +0200 Subject: [PATCH] Fix bad sea

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

2016-06-06 Thread Pavel Vomacka
On 06/06/2016 07:03 PM, Petr Vobornik wrote: On 06/06/2016 12:27 PM, Pavel Vomacka wrote: On 06/02/2016 06:22 PM, Petr Vobornik wrote: On 06/01/2016 10:41 AM, Pavel Vomacka wrote: On 05/27/2016 05:58 PM, Pavel Vomacka wrote: On 05/27/2016 05:44 PM, Nathaniel McCallum wrote: On Fri, 2016

Re: [Freeipa-devel] [PATCHES 0146-0152] Server Roles v2

2016-06-07 Thread Pavel Vomacka
On 06/07/2016 12:07 PM, Martin Babinsky wrote: On 06/03/2016 05:25 PM, Martin Babinsky wrote: I am sending rebased patches implementing http://www.freeipa.org/page/V4/Server_Roles I hope the patches work since I have had a lot of fun rebasing them on top of thin client and DNS locations

Re: [Freeipa-devel] [PATCH] 0208-0209 webUI changes for external trust and UPN suffixes

2016-06-10 Thread Pavel Vomacka
On 06/09/2016 02:19 PM, Alexander Bokovoy wrote: On Thu, 09 Jun 2016, Sumit Bose wrote: On Thu, Jun 09, 2016 at 02:30:52PM +0300, Alexander Bokovoy wrote: Hi, webUI changes to support external trust and showing UPN suffixes are attached. UPN Suffixes defined on AD side and fetched with

Re: [Freeipa-devel] [PATCH] 0013, 0017 webui: Add ability to convert users from preserved to staged state

2016-06-03 Thread Pavel Vomacka
On 06/02/2016 06:45 PM, Petr Vobornik wrote: On 04/20/2016 07:05 PM, Pavel Vomacka wrote: On 04/15/2016 06:44 PM, Petr Vobornik wrote: On 04/13/2016 02:56 PM, Pavel Vomacka wrote: Hello, This patch adds ability to convert users from preserved to staged state. Fixes this ticket:https

[Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-10 Thread Pavel Vomacka
Hello, please review these new patches which add WebUI for Sub-CAs. https://fedorahosted.org/freeipa/ticket/5939 -- Pavel^3 Vomacka From e76324180aa9518a93867fd6c9daa50a8fa79c1f Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 10 Jun 2016 16:12:45 +0200 S

Re: [Freeipa-devel] [PATCH] 0051: webui: correct jslint warning

2016-06-13 Thread Pavel Vomacka
On 06/13/2016 12:00 PM, Pavel Vomacka wrote: Hello, I forgot to run jslint during the last review and there was one warning, so this patch fixes it. -- Pavel^3 Vomacka Added ticket to the commit message. From 21a8d78e680e06389b17447ecac34fa1042bda2e Mon Sep 17 00:00:00 2001 From

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-13 Thread Pavel Vomacka
On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: Hello, please review these new patches which add WebUI for Sub-CAs. https://fedorahosted.org/freeipa/ticket/5939 Hi Pavel, I have reviewed the functionality of the patches

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-14 Thread Pavel Vomacka
On 06/14/2016 06:42 AM, Fraser Tweedale wrote: On Mon, Jun 13, 2016 at 07:48:58PM +0200, Pavel Vomacka wrote: On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: Hello, please review these new patches which add WebUI for Sub-CAs

Re: [Freeipa-devel] [WIP] Thin client

2016-05-28 Thread Pavel Vomacka
On 05/27/2016 10:33 AM, Petr Spacek wrote: On 27.5.2016 09:26, Martin Basti wrote: On 27.05.2016 07:49, Jan Cholasta wrote: On 26.5.2016 18:43, Martin Basti wrote: On 26.05.2016 11:21, Martin Basti wrote: On 26.05.2016 07:15, Jan Cholasta wrote: On 25.5.2016 18:17, Martin Basti wrote:

Re: [Freeipa-devel] [WIP] Thin client

2016-05-30 Thread Pavel Vomacka
On 05/30/2016 08:28 AM, Jan Cholasta wrote: On 28.5.2016 18:33, Pavel Vomacka wrote: On 05/27/2016 10:33 AM, Petr Spacek wrote: On 27.5.2016 09:26, Martin Basti wrote: On 27.05.2016 07:49, Jan Cholasta wrote: On 26.5.2016 18:43, Martin Basti wrote: On 26.05.2016 11:21, Martin Basti

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

2016-05-27 Thread Pavel Vomacka
On 05/12/2016 11:13 PM, Nathaniel McCallum wrote: On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote: Hi, the patch adds webui part for authentication indicators. Ticket: https://fedorahosted.org/freeipa/ticket/5872 The otp option displays as: OTP. The radius option displays as: Radius

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

2016-05-27 Thread Pavel Vomacka
On 05/27/2016 05:44 PM, Nathaniel McCallum wrote: On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote: On 05/12/2016 11:13 PM, Nathaniel McCallum wrote: On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote: Hi, the patch adds webui part for authentication indicators. Ticket: https

Re: [Freeipa-devel] [PATCH 0149-0152] Server Roles: user-facing part

2016-06-02 Thread Pavel Vomacka
On 05/30/2016 07:13 PM, Martin Babinsky wrote: These patches implement the usable part of Server Roles design. There might be some discrepancies between the design and actual implementation, I was head first in hacking and was not very disciplined in keeping the design up to date. I will

Re: [Freeipa-devel] [PATCH 0473-0476, 0478-0482]DNS Locations: Prologue

2016-06-02 Thread Pavel Vomacka
On 06/02/2016 02:20 PM, Jan Cholasta wrote: On 2.6.2016 14:06, Petr Spacek wrote: On 1.6.2016 18:00, Martin Basti wrote: updated patches attached freeipa-mbasti-0473.6-DNS-Locations-Always-create-DNS-related-privileges.patch From 549379a36281d80818fca4ec929d499efafda044 Mon Sep 17

[Freeipa-devel] [PATCH] 0036-38 webui: Server roles

2016-06-02 Thread Pavel Vomacka
Hello, please review my patches which add webui for server roles. -- Pavel^3 Vomacka From 142e46045f6fe4f64ce20a1b822508fece767579 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 2 Jun 2016 13:07:00 +0200 Subject: [PATCH 1/3] Association table can be rea

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

2016-06-01 Thread Pavel Vomacka
On 05/27/2016 05:58 PM, Pavel Vomacka wrote: On 05/27/2016 05:44 PM, Nathaniel McCallum wrote: On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote: On 05/12/2016 11:13 PM, Nathaniel McCallum wrote: On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote: Hi, the patch adds webui part

[Freeipa-devel] [PATCH] 0053: webui: allow to set weight of server without location

2016-06-15 Thread Pavel Vomacka
:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 10 Jun 2016 09:39:36 +0200 Subject: [PATCH] Allow to set weight of a server without location There was a bug when a new server was added it was not possible to set weight until a location was set. This change corrects it and

[Freeipa-devel] [PATCH] 0054-55: WebUI: extend DNS and trust config pages

2016-06-21 Thread Pavel Vomacka
Hello, please review attached patches - they extend DNS and trust config pages. https://fedorahosted.org/freeipa/ticket/5906 -- Pavel^3 Vomacka From 8b637991feda190c53430d0f281eafab5d6f5250 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Wed, 15 Jun 2016 17:43:13

Re: [Freeipa-devel] [PATCH 0162] Do not update result of *-config-show with empty server attributes

2016-06-21 Thread Pavel Vomacka
On 06/20/2016 03:35 PM, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5960 Hello, thank you for the patch, it works for me. But I didn't do the code review. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}

2016-06-16 Thread Pavel Vomacka
On 06/16/2016 12:06 PM, Pavel Vomacka wrote: Hello, please review attached patch. https://fedorahosted.org/freeipa/ticket/5905 Fixed commit message -- Pavel^3 Vomacka From c61e0dd9190be2537ecd8da0a4fa5c0ace81a81e Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Dat

[Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}

2016-06-16 Thread Pavel Vomacka
Hello, please review attached patch. https://fedorahosted.org/freeipa/ticket/5905 -- Pavel^3 Vomacka From 16270e37ce76796e76513270f5833241d4f5c892 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 16 Jun 2016 10:09:36 +0200 Subject: [PATCH] DNS Servers: Web U

[Freeipa-devel] [PATCH] 0060: webui: Add dnsdefaultttl field on DNS Zone config page

2016-06-21 Thread Pavel Vomacka
Hello, please review the attached patch. It is counterpart of: https://fedorahosted.org/freeipa/ticket/2956 -- Pavel^3 Vomacka From 9ac60ab982aceff128542c3ca1c91f250347b464 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Tue, 21 Jun 2016 15:43:18 +0200 Subject:

[Freeipa-devel] [PATCH] 0061: webui: Add support for 'dns_update_system_records' command

2016-06-23 Thread Pavel Vomacka
Hello, please review attached patch. Part of: https://fedorahosted.org/freeipa/ticket/5905 -- Pavel^3 Vomacka From d8efa6ec479f61bde2dce321337d1ac6b8c75f74 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Wed, 22 Jun 2016 18:13:27 +0200 Subject: [PATCH] Add

Re: [Freeipa-devel] [PATCH] 0048-50: webui: extend topology graph functionality

2016-06-20 Thread Pavel Vomacka
On 06/13/2016 10:48 AM, Pavel Vomacka wrote: Hello, please review attached patches which extend topology graph functionality. First two add possibility to create agreement using mouse and the third one adds 'Autogenerated' placeholder. 0047,48: https://fedorahosted.org/freeipa/ticket/5648

Re: [Freeipa-devel] [PATCH] 0018-0030, 52 webui: add support for more certificates

2016-06-20 Thread Pavel Vomacka
On 06/14/2016 09:41 PM, Pavel Vomacka wrote: On 05/13/2016 06:56 PM, Petr Vobornik wrote: On 04/26/2016 04:23 PM, Pavel Vomacka wrote: Self-NACK for patches 0027, 28, 29, 30 - used incorrect policy. I also attach all patches which were not changed - it is easier to get the whole patchset

[Freeipa-devel] [PATCH] 0058 WebUI: certificate widget on ID override user page

2016-06-20 Thread Pavel Vomacka
Hello, please review attached patch. https://fedorahosted.org/freeipa/ticket/5926 -- Pavel^3 Vomacka From aa6ef0a9b51d8c2d955399a044d1ee90cc6f936e Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 17 Jun 2016 10:05:52 +0200 Subject: [PATCH] Add certificate

[Freeipa-devel] [PATCH] 0059: webui: make 'Actions' strings translatable

2016-06-20 Thread Pavel Vomacka
Hello, please review attached patch. -- Pavel^3 Vomacka From ff35b4ae33714783c42751f917e2c21fd390cbd7 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 20 Jun 2016 20:43:26 +0200 Subject: [PATCH] Make Actions string translatable Remove hardcoded strings 'A

Re: [Freeipa-devel] [PATCHES 551-552, 623-624] cert: add owner information, allow search by certificate

2016-06-21 Thread Pavel Vomacka
: On 6.4.2016 15:46, Pavel Vomacka wrote: On 03/16/2016 01:50 PM, Jan Cholasta wrote: Hi, the attached patches implement the server-side part of <https://fedorahosted.org/freeipa/ticket/5381>. Honza Hi, thank you for the patches. I tested them and they work well. But I would like to ask you w

[Freeipa-devel] [PATCH] 0062, 63: webui: Add button for 'server-del' command

2016-06-24 Thread Pavel Vomacka
Hello, please review attached patches, they add 'Delete Server' button. -- Pavel^3 Vomacka From d8100e60bb7cf248f65191223e3e11340372d193 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 24 Jun 2016 12:07:03 +0200 Subject: [PATCH 1/2] Add support to change

Re: [Freeipa-devel] [PATCH] 0061: webui: Add support for 'dns_update_system_records' command

2016-06-27 Thread Pavel Vomacka
On 06/23/2016 04:58 PM, Petr Vobornik wrote: On 06/23/2016 04:34 PM, Martin Basti wrote: On 23.06.2016 09:57, Pavel Vomacka wrote: Hello, please review attached patch. Part of: https://fedorahosted.org/freeipa/ticket/5905 Works for me In this patch and also in some other(cert

[Freeipa-devel] [PATCH] 0064: webui: simplify confirmation messages in confirmation dialogs

2016-06-27 Thread Pavel Vomacka
Hello, Please review attached patch which simplifies confirmation messages for 'remove cert hold' and 'restore cert' actions. -- Pavel^3 Vomacka From d3d10e8481be242dac5f66cc1ba6c622696a6758 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 27 Jun 2016 17

Re: [Freeipa-devel] [PATCH] 0004 webui: topology graph: Add pan and zoom functionality

2016-02-12 Thread Pavel Vomacka
On 02/03/2016 03:37 PM, Pavel Vomacka wrote: Hello, I'm sending a patch for review. This patch adds pan and zoom functionality to the topology graph. The page remembers old position and size of the graph. So, it keeps these settings after refreshing the page. The patch is in atachement

Re: [Freeipa-devel] [PATCH] 0005 webui: topology graph: canvas resizes itself according to the window size

2016-02-12 Thread Pavel Vomacka
On 02/11/2016 12:31 PM, Pavel Vomacka wrote: Hello, The canvas of the graph had static size. This patch fixes this issue and from now the graph canvas is resized according to the window size. Pavel Vomacka Because of changes in previous patch I'm sending also this one again. Plus I

[Freeipa-devel] [PATCH] 0005 webui: topology graph: canvas resizes itself according to the window size

2016-02-11 Thread Pavel Vomacka
Hello, The canvas of the graph had static size. This patch fixes this issue and from now the graph canvas is resized according to the window size. Pavel Vomacka >From 648037bf3952d6cb55c1951d55fad6b05f11f4b7 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: T

Re: [Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

2016-01-29 Thread Pavel Vomacka
'instructions' or just 'message' - consistent with spec option. Fixed. I chose 'message' instead of 'message_html_widget'. Also I've filed: https://fedorahosted.org/freeipa/ticket/5652 Pavel Vomacka >From 242a52390de84025efab2fb878aa95d46c1386a4 Mon Sep 17 00:00:00 2001 From: Pavel Voma

Re: [Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

2016-01-28 Thread Pavel Vomacka
Hello, On 01/28/2016 12:20 PM, Pavel Vomacka wrote: 'Issue new certificate' dialog now validates whether user fills 'principal' and 'csr' field. In case that one of these fields is empty then it does not allow to submit the dialog. https://fedorahosted.org/freeipa/ticket/5432 I'm sending

[Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

2016-01-28 Thread Pavel Vomacka
Hello, I made a patch for the https://fedorahosted.org/freeipa/ticket/5432 ticket. All Issue new certificate dialogs now validates input data. -- Pavel Vomacka >From 2d323f8cf997af594de01405b9d242360f625b86 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Th

[Freeipa-devel] [PATCH] 0004 webui: topology graph: Add pan and zoom functionality

2016-02-03 Thread Pavel Vomacka
Hello, I'm sending a patch for review. This patch adds pan and zoom functionality to the topology graph. The page remembers old position and size of the graph. So, it keeps these settings after refreshing the page. The patch is in atachement. Pavel Vomacka >F

Re: [Freeipa-devel] [PATCH] 0005 webui: topology graph: canvas resizes itself according to the window size

2016-02-25 Thread Pavel Vomacka
On 02/17/2016 06:29 PM, Petr Vobornik wrote: On 02/15/2016 04:20 PM, Pavel Vomacka wrote: On 02/12/2016 01:52 PM, Pavel Vomacka wrote: On 02/11/2016 12:31 PM, Pavel Vomacka wrote: Hello, The canvas of the graph had static size. This patch fixes this issue and from now the graph canvas

Re: [Freeipa-devel] [PATCH] 0004 webui: topology graph: Add pan and zoom functionality

2016-02-22 Thread Pavel Vomacka
On 02/18/2016 06:21 PM, Petr Vobornik wrote: On 02/03/2016 03:37 PM, Pavel Vomacka wrote: Hello, I'm sending a patch for review. This patch adds pan and zoom functionality to the topology graph. The page remembers old position and size of the graph. So, it keeps these settings after

[Freeipa-devel] [PATCH] 0002 Add support for user parameter for /ipa/ui/reset_password.html

2016-01-25 Thread Pavel Vomacka
/5001 . Pavel Vomacka InternFrom 1ee0ea7aad2ccb39a070e3a5dc4a8732a2ff08cc Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 25 Jan 2016 14:44:51 +0100 Subject: [PATCH] Add support for the 'user' url parameter for the reset_password.html The /ipa/ui/reset_passwor

[Freeipa-devel] New tool tips for Refresh, Revert, Undo and Undo All buttons

2016-01-25 Thread Pavel Vomacka
Hello everyone, I just made a patch for the https://fedorahosted.org/freeipa/ticket/5428 ticket. The patch adds tool tips to the buttons in detail views. The text of new tool tips is written in the comment of the ticket. Pavel Vomacka InternFrom 8e291c698b0bb6275ce4cb220815ba54446f62fe Mon Sep

Re: [Freeipa-devel] [PATCH] 0005 webui: topology graph: canvas resizes itself according to the window size

2016-02-15 Thread Pavel Vomacka
On 02/12/2016 01:52 PM, Pavel Vomacka wrote: On 02/11/2016 12:31 PM, Pavel Vomacka wrote: Hello, The canvas of the graph had static size. This patch fixes this issue and from now the graph canvas is resized according to the window size. Pavel Vomacka Because of changes in previous

[Freeipa-devel] [PATCH] 0006 webui: topology graph: Nodes are switched to fixed state after initial animation

2016-02-17 Thread Pavel Vomacka
. If you think that there should be another ticket for this minor bug, let me know. -- Pavel^3 Vomacka >From 78133bbe1655025c37e8388ee52bec2f4146230b Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 11 Feb 2016 10:55:48 +0100 Subject: [PATCH] Nodes stay fi

Re: [Freeipa-devel] [PATCH] 946 webui: fixed showing of success message after password change on login

2016-02-18 Thread Pavel Vomacka
On 02/18/2016 03:56 PM, Petr Vobornik wrote: On 01/20/2016 06:42 PM, Petr Vobornik wrote: similar issue and cause as in https://fedorahosted.org/freeipa/ticket/5567 root cause is that binding triggers validation which clears messages in validation summary. Maybe it could be refactored in a

Re: [Freeipa-devel] [PATCH] 947 webui: use API call ca_is_enabled instead of enable_ra env variable.

2016-02-18 Thread Pavel Vomacka
On 02/18/2016 03:56 PM, Petr Vobornik wrote: On 01/20/2016 07:02 PM, Petr Vobornik wrote: To be consistent with backend code. https://fedorahosted.org/freeipa/ticket/5622 bump for review Ack. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH] 0008 Add X-Frame-Options and frame-ancestors options

2016-03-10 Thread Pavel Vomacka
On 03/10/2016 07:02 PM, Simo Sorce wrote: On Thu, 2016-03-10 at 18:47 +0100, Pavel Vomacka wrote: Hi, These two options allow preventing clickjacking attacks. They don't allow open FreeIPA in frame, iframe or object element. Will these apply to the whole server or just to /ipa ? Yes, you

[Freeipa-devel] [PATCH] 0008 Add X-Frame-Options and frame-ancestors options

2016-03-10 Thread Pavel Vomacka
Hi, These two options allow preventing clickjacking attacks. They don't allow open FreeIPA in frame, iframe or object element. -- Pavel^3 Vomacka >From c5a92092d87b3afeeaae0c37ce2bf8e892b9be84 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 10 Mar 2016

Re: [Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views

2016-03-11 Thread Pavel Vomacka
On 03/08/2016 02:34 PM, Lenka Doudova wrote: On 03/08/2016 12:43 PM, Pavel Vomacka wrote: On 02/23/2016 03:20 PM, Lenka Doudova wrote: Hi, attached is patch providing missing test coverage for ID views in webUI. Lenka Hi, Thank you for your patch. I have small one comment

Re: [Freeipa-devel] [PATCH] 0008 Add X-Frame-Options and frame-ancestors options

2016-03-11 Thread Pavel Vomacka
On 03/11/2016 09:25 AM, Petr Vobornik wrote: On 03/10/2016 07:22 PM, Simo Sorce wrote: On Thu, 2016-03-10 at 19:20 +0100, Pavel Vomacka wrote: On 03/10/2016 07:02 PM, Simo Sorce wrote: On Thu, 2016-03-10 at 18:47 +0100, Pavel Vomacka wrote: Hi, These two options allow preventing

Re: [Freeipa-devel] [PATCH] 0005 webui: topology graph: canvas resizes itself according to the window size

2016-03-11 Thread Pavel Vomacka
On 03/10/2016 06:08 PM, Petr Vobornik wrote: On 02/25/2016 03:50 PM, Pavel Vomacka wrote: On 02/17/2016 06:29 PM, Petr Vobornik wrote: On 02/15/2016 04:20 PM, Pavel Vomacka wrote: On 02/12/2016 01:52 PM, Pavel Vomacka wrote: On 02/11/2016 12:31 PM, Pavel Vomacka wrote: Hello

[Freeipa-devel] [PATCH] 0009 webui: Show certificates in useful format

2016-03-15 Thread Pavel Vomacka
Hello, patch for https://fedorahosted.org/freeipa/ticket/5311 is attached. -- Pavel^3 Vomacka >From 01d99f2a8b576c48ccf31c8dbccb293021104f5e Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Tue, 15 Mar 2016 11:51:35 +0100 Subject: [PATCH] Show certificate

[Freeipa-devel] [PATCH] 0013 webui: Add ability to convert users from preserved to staged state

2016-04-13 Thread Pavel Vomacka
Hello, This patch adds ability to convert users from preserved to staged state. Fixes this ticket: https://fedorahosted.org/freeipa/ticket/5371 -- Pavel^3 Vomacka >From ac0396b8644fe9cf421a491c35c7eed017dc5cca Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: We

Re: [Freeipa-devel] [PATCHES 551-552] ipalib: add basecert plugins

2016-04-06 Thread Pavel Vomacka
On 03/16/2016 01:50 PM, Jan Cholasta wrote: Hi, the attached patches implement the server-side part of . Honza Hi, thank you for the patches. I tested them and they work well. But I would like to ask you whether would be possible to extend

Re: [Freeipa-devel] [PATCH] 0005 webui: topology graph: canvas resizes itself according to the window size

2016-03-21 Thread Pavel Vomacka
On 03/16/2016 06:34 PM, Petr Vobornik wrote: On 03/11/2016 10:09 AM, Pavel Vomacka wrote: On 03/10/2016 06:08 PM, Petr Vobornik wrote: On 02/25/2016 03:50 PM, Pavel Vomacka wrote: On 02/17/2016 06:29 PM, Petr Vobornik wrote: On 02/15/2016 04:20 PM, Pavel Vomacka wrote: On 02/12/2016

Re: [Freeipa-devel] [PATCH] 0007 webui: Add a field for GID in the user add dialog

2016-03-07 Thread Pavel Vomacka
On 03/04/2016 07:03 PM, Petr Vobornik wrote: On 03/01/2016 01:37 PM, Pavel Vomacka wrote: Hi, The patch adds new field in user add dialog. This combo box lists GIDs of posix groups so user can choose one. It is also possible to fill a GID number which is not in the list. Link to the ticket

Re: [Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views

2016-03-08 Thread Pavel Vomacka
On 02/23/2016 03:20 PM, Lenka Doudova wrote: Hi, attached is patch providing missing test coverage for ID views in webUI. Lenka Hi, Thank you for your patch. I have small one comment: The delete_associtaion() function duplicates code, it would be good to create auxiliary function and

[Freeipa-devel] [PATCH] 0007 webui: Add a field for GID in the user add dialog

2016-03-01 Thread Pavel Vomacka
rom 6f6dbaea8a964bd1af50831c482cad4b66ec95c8 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Tue, 1 Mar 2016 12:17:04 +0100 Subject: [PATCH] Add field for group id in user add dialog Add new field in user add dialog. This combo box lists all posix groups so user can choose one. It is also

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

2016-03-07 Thread Pavel Vomacka
On 02/25/2016 03:08 PM, Lenka Doudova wrote: Hi, here's a patch for webUI tests that provides test for creating user without private group. Related to ticket https://fedorahosted.org/freeipa/ticket/4986 Since the option to specify GID when creating a user is not available

Re: [Freeipa-devel] [PATCH] 0009 webui: Show certificates in useful format

2016-03-30 Thread Pavel Vomacka
On 03/29/2016 11:42 AM, Pavel Vomacka wrote: On 03/16/2016 06:56 PM, Petr Vobornik wrote: On 03/15/2016 01:23 PM, Pavel Vomacka wrote: Hello, patch for https://fedorahosted.org/freeipa/ticket/5311 is attached. -- Pavel^3 Vomacka Not tested, but can we avoid using s with "white-

[Freeipa-devel] [PATCH] 0011 webui: Offer OTP generation for host enrollment in the UI

2016-03-31 Thread Pavel Vomacka
rom 28ce87a474fa1488cb3b61d32cb4790a482348c7 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Wed, 30 Mar 2016 10:19:39 +0200 Subject: [PATCH] Add option to show OTP when adding host Add option to add host dialog which allows to show generated OTP. This patch also change

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

2016-04-01 Thread Pavel Vomacka
On 03/31/2016 04:16 PM, Lenka Doudova wrote: On 03/31/2016 12:42 PM, Pavel Vomacka wrote: On 03/18/2016 11:24 AM, Lenka Doudova wrote: On 03/10/2016 06:58 PM, Petr Vobornik wrote: On 03/08/2016 01:17 PM, Lenka Doudova wrote: On 03/08/2016 12:59 PM, Petr Vobornik wrote: On 03/07

Re: [Freeipa-devel] [PATCH] 0009 webui: Show certificates in useful format

2016-03-29 Thread Pavel Vomacka
On 03/16/2016 06:56 PM, Petr Vobornik wrote: On 03/15/2016 01:23 PM, Pavel Vomacka wrote: Hello, patch for https://fedorahosted.org/freeipa/ticket/5311 is attached. -- Pavel^3 Vomacka Not tested, but can we avoid using s with "white-space: pre" and therefor

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

2016-03-31 Thread Pavel Vomacka
On 03/18/2016 11:24 AM, Lenka Doudova wrote: On 03/10/2016 06:58 PM, Petr Vobornik wrote: On 03/08/2016 01:17 PM, Lenka Doudova wrote: On 03/08/2016 12:59 PM, Petr Vobornik wrote: On 03/07/2016 04:29 PM, Pavel Vomacka wrote: On 02/25/2016 03:08 PM, Lenka Doudova wrote: Hi, here's

[Freeipa-devel] [PATCH] 0015, 16 webui: Add 'Skip overlap check' checkbox to the dns adder dialogs

2016-04-14 Thread Pavel Vomacka
shouldn't contain that checkbox. -- Pavel^3 Vomacka >From f1ce4ef65fbfd1f4f05c34b4bb89e0de294fa909 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 14 Apr 2016 12:21:49 +0200 Subject: [PATCH] Add 'skip overlap check' checkbox into add zone dial

Re: [Freeipa-devel] [PATCH] Added fix for notifying user about locked user account in WebUI

2016-04-28 Thread Pavel Vomacka
On 04/20/2016 07:52 AM, Abhijeet Kasurde wrote: Hi All, Please review this patch. Fixes : https://fedorahosted.org/freeipa/ticket/5076 Thanks, Abhijeet Kasurde Hi, Javascript part LGTM. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [PATCH] 0032 webui: change lang.hitch to the javascript bind method

2016-04-29 Thread Pavel Vomacka
Hi, please review the attached patch. https://fedorahosted.org/freeipa/ticket/5702 -- Pavel^3 Vomacka From 0e197613accb6ac94563507d67477fc8b5851767 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 29 Apr 2016 15:02:18 +0200 Subject: [PATCH] Change lang

Re: [Freeipa-devel] [PATCH] 0018-0030 webui: add support for more certificates

2016-04-26 Thread Pavel Vomacka
I forgot to mention that my patches requires patches from : https://www.redhat.com/archives/freeipa-devel/2016-April/msg00209.html On 04/26/2016 01:33 PM, Pavel Vomacka wrote: Hello, the attached patches add support for more certificates and ability to add and remove certificates. Fixes

[Freeipa-devel] [PATCH] 0018-0030 webui: add support for more certificates

2016-04-26 Thread Pavel Vomacka
/freeipa/ticket/5776 -- Pavel^3 Vomacka From 7a0f73dd7f103b3ac4f4d28af2f0cb6654a6d95f Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 22 Apr 2016 10:22:30 +0200 Subject: [PATCH 01/13] Add support for dropdown menu in multivalued widget Every single widget

[Freeipa-devel] [PATCH] 0031 webui: add ability to review certificate request dialog

2016-04-27 Thread Pavel Vomacka
Hi please review the attached patch. Fixes this ticket: https://fedorahosted.org/freeipa/ticket/5652 -- Pavel^3 Vomacka From e9dcb0e1c1f7e557f336c0d7346047442824a962 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Tue, 26 Apr 2016 14:55:54 +0200 Subject: [PATC

Re: [Freeipa-devel] [PATCH] 0018-0030 webui: add support for more certificates

2016-04-26 Thread Pavel Vomacka
Self-NACK for patches 0027, 28, 29, 30 - used incorrect policy. I also attach all patches which were not changed - it is easier to get the whole patchset. On 04/26/2016 02:02 PM, Pavel Vomacka wrote: I forgot to mention that my patches requires patches from : https://www.redhat.com/archives

Re: [Freeipa-devel] [PATCH] Added warning to user for Internet Explorer

2016-04-26 Thread Pavel Vomacka
On 04/25/2016 01:00 PM, Abhijeet Kasurde wrote: Hi All, Please review the attached patch. Thanks, Abhijeet Kasurde Hi, thank you for the patch, ACK. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 0035: webui: change Restore cert to Remove cert hold

2016-05-20 Thread Pavel Vomacka
Hi, please review attached patch. It change Restore certificate strings to Remove certificate hold to be consistent with CLI. https://fedorahosted.org/freeipa/ticket/5878 -- Pavel^3 Vomacka From bd0c90c5c52120a5cc7989fd2e6160a13a845ee4 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pv

[Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

2016-05-11 Thread Pavel Vomacka
Hi, the patch adds webui part for authentication indicators. Ticket: https://fedorahosted.org/freeipa/ticket/5872 -- Pavel^3 Vomacka From 912519a2d1a834763f553c2b7b254d8908d85122 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Wed, 11 May 2016 12:54:43 +0200 S

Re: [Freeipa-devel] [PATCHES 0089-0093] Authentication Indicators

2016-05-11 Thread Pavel Vomacka
On 05/06/2016 02:44 PM, Sumit Bose wrote: On Wed, May 04, 2016 at 05:33:55PM -0400, Nathaniel McCallum wrote: This series of patches implements authentication indicator insertion, evaluation and management in FreeIPA. Besides these patches, two other patches are needed to round out support.

Re: [Freeipa-devel] [PATCH] 0011 webui: Offer OTP generation for host enrollment in the UI

2016-05-12 Thread Pavel Vomacka
On 05/11/2016 03:28 PM, Petr Vobornik wrote: On 03/31/2016 04:59 PM, Pavel Vomacka wrote: Hello, This patch adds option to add host dialog which allows to show generated OTP. The patch also changes the way of informing user about success of adding host but only when the 'Generate OTP' option

Re: [Freeipa-devel] [PATCH] pwpolicy: Do not expire passwords when maxlife is set to 0 (infinity).

2016-05-04 Thread Pavel Vomacka
On 05/04/2016 04:36 PM, Simo Sorce wrote: On Wed, 2016-05-04 at 15:39 +0200, Martin Kosek wrote: On 05/02/2016 02:28 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/2795 That patch looks suspiciously short given the struggles I saw in

[Freeipa-devel] [PATCH] 0033 webui: Mention SAN names in 'Issue new certificate'

2016-05-10 Thread Pavel Vomacka
:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 25 Apr 2016 09:38:30 +0200 Subject: [PATCH] Extend the certificate request dialog The command for requesting certificate for hosts and services is extended. There is added how to add DNS name as subjectAltName. https://fedorahosted.or

Re: [Freeipa-devel] [PATCH] 0009 webui: Show certificates in useful format

2016-04-20 Thread Pavel Vomacka
On 04/15/2016 03:42 PM, Petr Vobornik wrote: On 03/30/2016 12:46 PM, Pavel Vomacka wrote: On 03/29/2016 11:42 AM, Pavel Vomacka wrote: On 03/16/2016 06:56 PM, Petr Vobornik wrote: On 03/15/2016 01:23 PM, Pavel Vomacka wrote: Hello, patch for https://fedorahosted.org/freeipa/ticket/5311

Re: [Freeipa-devel] [PATCH] 0015, 16 webui: Add 'Skip overlap check' checkbox to the dns adder dialogs

2016-04-20 Thread Pavel Vomacka
On 04/14/2016 02:03 PM, Martin Basti wrote: On 14.04.2016 13:03, Pavel Vomacka wrote: Hello, The first patch (0015) adds the checkbox to the dns zone adder dialog. The second patch (0016) adds the 'skip overlap check' checkbox to the dns forward zone adder dialog. This patch requires

Re: [Freeipa-devel] [PATCH] 0013, 0017 webui: Add ability to convert users from preserved to staged state

2016-04-20 Thread Pavel Vomacka
On 04/15/2016 06:44 PM, Petr Vobornik wrote: On 04/13/2016 02:56 PM, Pavel Vomacka wrote: Hello, This patch adds ability to convert users from preserved to staged state. Fixes this ticket: https://fedorahosted.org/freeipa/ticket/5371 -- Pavel^3 Vomacka The patch requires rebase

[Freeipa-devel] [PATCH] 0014 webui: Update delete dialog on active user details page

2016-04-14 Thread Pavel Vomacka
17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Sun, 10 Apr 2016 23:46:15 +0200 Subject: [PATCH] Update the delete dialog on details user page Add option to preserve user to the delete dialog on active user's details page. The delete dialog is the same as on the page of a

[Freeipa-devel] [PATCH] webui: Fix coverity bugs

2016-07-29 Thread Pavel Vomacka
Hello, please review attached patches which fixes errors from Coverity. -- Pavel^3 Vomacka From 0391289b3f6844897e2a9f3ae549bd4c33233ffc Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 25 Jul 2016 10:36:47 +0200 Subject: [PATCH 01/13] Coverity - null p

  1   2   >