[Freeipa-devel] [PATCH] 0001 Switch --group and --membergroup in example for delegation

2012-02-06 Thread Petr Viktorin
4789a3d201156866713e2cb9d632105f6a7f236e Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Mon, 6 Feb 2012 07:18:11 -0500 Subject: [PATCH] Switch --group and --membergroup in example for delegation The example mistakenly showed how to allow employees to edit addresses of managers

[Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page

2012-02-06 Thread Petr Viktorin
This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277), and adds options that were missing. From 69836c87eb5f4bcee1664dcc0cf71c53862f7341 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Mon, 6 Feb 2012 07:59:47 -0500

Re: [Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page

2012-02-07 Thread Petr Viktorin
On 02/06/2012 06:51 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/06/2012 10:26 AM, Martin Kosek wrote: On Mon, 2012-02-06 at 10:22 -0500, Rob Crittenden wrote: Petr Viktorin wrote: This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277

[Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-07 Thread Petr Viktorin
53a9c0aef831a51566508ce6fcf51ecfb0147e9e Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 7 Feb 2012 07:13:52 -0500 Subject: [PATCH] Honor the default home directory in user_add The homedirectory argument had a default_from '/home/name', ignoring the ipahomesrootdir config setting. This patch

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-07 Thread Petr Viktorin
On 02/07/2012 01:52 PM, Petr Viktorin wrote: Honor the default home directory base when creating a new user. Test included. I also cleaned up the way home directory was created. This patch removes the default from the --homedirectory option, letting the server fill it in pre_callback. If I'm

Re: [Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

2012-02-08 Thread Petr Viktorin
On 02/07/2012 10:31 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/07/2012 01:52 PM, Petr Viktorin wrote: Honor the default home directory base when creating a new user. Test included. I also cleaned up the way home directory was created. This patch removes the default from

[Freeipa-devel] [PATCH] Make ipausers a non-posix group on new installs

2012-02-08 Thread Petr Viktorin
https://fedorahosted.org/freeipa/ticket/2238 This patch modifies bootstrap-template.ldif to create ipausers as a non-posix group. -- Petr³ From cec813fe9ff4699432dd2abb778477b5122e5a67 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 8 Feb 2012 06:47:23 -0500

[Freeipa-devel] [PATCH] Add common helper for interactive prompts

2012-02-09 Thread Petr Viktorin
: Petr Viktorin pvikt...@redhat.com Date: Thu, 9 Feb 2012 09:09:03 -0500 Subject: [PATCH] Add common helper for interactive prompts This patch adds a common method, textui.prompt_helper, that handles encoding, decoding and error handling for interactive prompts. On EOFError (Ctrl+D

[Freeipa-devel] [PATCH] 0007 Clean up i18n strings

2012-02-10 Thread Petr Viktorin
). -- Petr³ From de473d9eda10455fb174b8aa0ab0eccbe51e2fbc Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 10 Feb 2012 04:27:53 -0500 Subject: [PATCH] Clean up i18n strings This patch switches to named (%(name)s) instead of positional (%s) substitutions

[Freeipa-devel] [PATCH] 0008 - Make sure the nolog argument to ipautil.run is not a bare string

2012-02-13 Thread Petr Viktorin
a call in ipaserver/install/krbinstance.py. -- Petr³ P.S. Iterability of strings is one of my least favorite Python features. From bb75dfd34e8c63f8bcd3ea10b910ee6bf01cf561 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Mon, 13 Feb 2012 08:10:16 -0500 Subject: [PATCH] Make

[Freeipa-devel] [PATCH] 0009 - Internationalize HBAC rule all category exceptions

2012-02-14 Thread Petr Viktorin
This patch wraps exception messages in _() https://fedorahosted.org/freeipa/ticket/2267 -- Petr³ From ef61ff93af13e46400e9bff22586b6f9e0d0a63a Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 10 Feb 2012 05:27:24 -0500 Subject: [PATCH] Internationalize HBAC rule all

Re: [Freeipa-devel] [PATCH] 0009 - Internationalize HBAC rule all category exceptions

2012-02-14 Thread Petr Viktorin
On 02/14/2012 10:49 AM, Alexander Bokovoy wrote: On Tue, 14 Feb 2012, Petr Viktorin wrote: This patch wraps exception messages in _() https://fedorahosted.org/freeipa/ticket/2267 ACK. I was looking at hbactest and there are also some non-internationalized messages returned. Maybe you could

[Freeipa-devel] [PATCH] 0010 Use stricter semantics when checking IP address for DNS records

2012-02-15 Thread Petr Viktorin
This fixes https://fedorahosted.org/freeipa/ticket/2379 by using inet_pton instead of inet_aton. -- Petr³ From 5f81db8537b7af6e23acc1ad07d3a8a5118d41b7 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 15 Feb 2012 05:11:24 -0500 Subject: [PATCH] Use stricter semantics

[Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-02-20 Thread Petr Viktorin
config options as required. -- Petr³ From c58da9f4f1b374ddc84ceb04b3ea58d839cd26a6 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Thu, 16 Feb 2012 07:11:56 -0500 Subject: [PATCH 12/13] Enforce that required attributes can't be set to None in CRUD Update The `required

Re: [Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-02-21 Thread Petr Viktorin
On 02/20/2012 08:51 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2159 says various config options are not marked Required, so entering an empty value for it will pass validation (and IPA will blow up later when it expects a string,not None). Forexample

[Freeipa-devel] [PATCH] 0014 Move install script error handling to a common function

2012-02-22 Thread Petr Viktorin
48a5bb0893d130bd66754e2efe8840f2c296cda5 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 21 Feb 2012 05:10:51 -0500 Subject: [PATCH] Move install script error handling to a common function All of our install scripts had a try/except block calling the main function and handling

[Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-23 Thread Petr Viktorin
handling in the server will break the UI, which at places uses `join(',')` (no escaping commas, no single place to change it), even though it can just send a list. -- Petr³ From 694c81cd6d5ace2115dd89ddbe04d5935be1b7fe Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Thu, 23

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Viktorin
:29, Petr Viktorin wrote: ... If we only keep one of those, the fix for #2227 should be quite easy. If not (backwards compatibility), we need to document this properly, test all the corner cases, and fix the UI to handle CSV escaping. Since it's subtly broken in lots of places, maybe it's best

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Viktorin
On 02/24/2012 11:09 AM, Petr Viktorin wrote: On 02/23/2012 04:08 PM, Jan Cholasta wrote: Can't you just re-escape the values before forwarding the call? That would be a fairly straightforward fix and it would remove the need for all the _forwarded_call hackery. All right, I'll do

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Viktorin
On 02/24/2012 12:09 PM, Martin Kosek wrote: On Fri, 2012-02-24 at 11:09 +0100, Petr Viktorin wrote: ... You need four backslashes for a literal backslash, three to escape a comma. I think 2.1 clients are already broken, and the backwards incompatibility would only affect workarounds. Yes

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Viktorin
On 02/24/2012 03:08 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/24/2012 12:09 PM, Martin Kosek wrote: On Fri, 2012-02-24 at 11:09 +0100, Petr Viktorin wrote: ... Old clients *already send* plain arrays; but the server currently errorneously parses each part again. Maybe a better

[Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-02-27 Thread Petr Viktorin
no_create and no_update. https://fedorahosted.org/freeipa/ticket/2405 https://fedorahosted.org/freeipa/ticket/2407 https://fedorahosted.org/freeipa/ticket/2408 -- Petr³ From c0063003f85de64b08e3d6d39cb0ca60a8cb07c2 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 24 Feb

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once (updated)

2012-02-27 Thread Petr Viktorin
it. -- Petr³ From b8a091514ee74283bbcb02d8b54fdfe4b49a7f04 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Thu, 23 Feb 2012 07:29:47 -0500 Subject: [PATCH] Only split CSV strings once When a call comes from XML-RPMC, set a flag that prevents the server from parsing CSV

[Freeipa-devel] [PATCH] 0018 - Simplify CSV escaping syntax

2012-02-27 Thread Petr Viktorin
: https://fedorahosted.org/freeipa/ticket/2402 https://fedorahosted.org/freeipa/ticket/2417 -- Petr³ --- ¹ These should really use JSON/XMLRPC directly :) From fe0d95a4c21d6889db3684f1d1d148ec1b40566d Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Mon, 27 Feb 2012 08:08:35

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Petr Viktorin
On 02/27/2012 03:44 PM, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as binary internally).

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Petr Viktorin
On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes.

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-28 Thread Petr Viktorin
On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema

Re: [Freeipa-devel] [PATCH] 0018 - Simplify CSV escaping syntax

2012-02-28 Thread Petr Viktorin
On 02/27/2012 11:11 PM, Rob Crittenden wrote: Petr Viktorin wrote: This depends on my patch 0015. Since CSV escaping was entirely broken before that patch (however we decide to fix the problem), let's also fix the escaping syntax itself, without worrying about backwards compatibility. I tried

Re: [Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-02-28 Thread Petr Viktorin
On 02/27/2012 10:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/20/2012 08:51 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2159 says various config options are not marked Required, so entering an empty value for it will pass validation

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-28 Thread Petr Viktorin
On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-29 Thread Petr Viktorin
On 02/28/2012 09:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote

Re: [Freeipa-devel] [PATCH] 0010 Use stricter semantics when checking IP address for DNS records

2012-02-29 Thread Petr Viktorin
On 02/15/2012 12:57 PM, Martin Kosek wrote: On Wed, 2012-02-15 at 11:20 +0100, Petr Viktorin wrote: This fixes https://fedorahosted.org/freeipa/ticket/2379 by using inet_pton instead of inet_aton. Yeah, this would fix the stricter checking. I planed to improve A/ validation in a scope

Re: [Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-02-29 Thread Petr Viktorin
On 02/28/2012 03:19 PM, Jan Cholasta wrote: On 28.2.2012 11:54, Petr Viktorin wrote: On 02/27/2012 10:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/20/2012 08:51 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2159 says various config options

Re: [Freeipa-devel] [PATCH] 956 user lockout status

2012-02-29 Thread Petr Viktorin
On 02/27/2012 06:31 PM, Martin Kosek wrote: 4) Minor change: -except Exception: +except: Don't do that. It would for example disable Ctrl+C by trapping KeyboardInterrupt. PEP8 has a paragraph on this, search for 'except Exception:' -- Petr³

Re: [Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-02-29 Thread Petr Viktorin
On 02/29/2012 11:14 AM, Jan Cholasta wrote: On 29.2.2012 11:09, Petr Viktorin wrote: On 02/28/2012 03:19 PM, Jan Cholasta wrote: On 28.2.2012 11:54, Petr Viktorin wrote: On 02/27/2012 10:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/20/2012 08:51 PM, Rob Crittenden wrote: Petr

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-02-29 Thread Petr Viktorin
On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket #2405), and so that the end result of these operations

Re: [Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-02-29 Thread Petr Viktorin
On 02/29/2012 03:53 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 11:14 AM, Jan Cholasta wrote: On 29.2.2012 11:09, Petr Viktorin wrote: On 02/28/2012 03:19 PM, Jan Cholasta wrote: On 28.2.2012 11:54, Petr Viktorin wrote: On 02/27/2012 10:44 PM, Rob Crittenden wrote: Petr

Re: [Freeipa-devel] [PATCHES] 0016 Fixes for{add, set, del}attr with managed attributes

2012-02-29 Thread Petr Viktorin
On 02/29/2012 03:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused

Re: [Freeipa-devel] [PATCHES] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-01 Thread Petr Viktorin
On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-01 Thread Petr Viktorin
On 02/29/2012 07:46 PM, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-02-27 at 17:51 +0100, Petr Viktorin wrote: On 02/22/2012 10:41 AM, Petr Viktorin wrote: This fixes https://fedorahosted.org/freeipa/ticket/2071 (Add final debug message in installers). The try/except blocks

Re: [Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-03-02 Thread Petr Viktorin
On 02/29/2012 04:09 PM, Petr Viktorin wrote: On 02/29/2012 03:53 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 11:14 AM, Jan Cholasta wrote: On 29.2.2012 11:09, Petr Viktorin wrote: On 02/28/2012 03:19 PM, Jan Cholasta wrote: On 28.2.2012 11:54, Petr Viktorin wrote: On 02/27

[Freeipa-devel] [PATCH] 0019 Use reboot from /sbin

2012-03-02 Thread Petr Viktorin
Commit message says it all. So does the ticket. https://fedorahosted.org/freeipa/ticket/2480 -- Petr³ From aad19e793e3ea882ef5069d678f9ba739b2e6eb4 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 2 Mar 2012 07:18:56 -0500 Subject: [PATCH] Use reboot from /sbin

Re: [Freeipa-devel] [PATCH] 0019 Use reboot from /sbin

2012-03-02 Thread Petr Viktorin
On 03/02/2012 01:42 PM, Jakub Hrozek wrote: On Fri, Mar 02, 2012 at 01:28:56PM +0100, Petr Viktorin wrote: Commit message says it all. So does the ticket. https://fedorahosted.org/freeipa/ticket/2480 -- Petr³ Does it matter? It the UsrMoved world, both are just symlinks to systemctl

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once (updated)

2012-03-02 Thread Petr Viktorin
On 02/29/2012 07:13 PM, Petr Vobornik wrote: On 02/27/2012 02:01 PM, Petr Viktorin wrote: It seems I didn't communicate the problem and my solution clearly enough, so let me try again. (Also, I learned from the discussions!) Currently, both the client and the server parse CSV options

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once (updated)

2012-03-05 Thread Petr Viktorin
On 02/29/2012 07:13 PM, Petr Vobornik wrote: On 02/27/2012 02:01 PM, Petr Viktorin wrote: It seems I didn't communicate the problem and my solution clearly enough, so let me try again. (Also, I learned from the discussions!) Currently, both the client and the server parse CSV options

[Freeipa-devel] [PATCH] 0020 Allow removing sudo commands with special characters from command groups

2012-03-05 Thread Petr Viktorin
This patch fixes DN handling when removing LDAP entries from groups. Because they deal with commas and backslashes in a CSV param, the tests here rely on my patch 0015. -- Petr³ From 1b4a0ef6d5c02495a03581f7f543d93d7f43636e Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date

Re: [Freeipa-devel] [PATCH] 0020 Allow removing sudo commands with special characters from command groups

2012-03-06 Thread Petr Viktorin
On 03/05/2012 04:10 PM, Petr Viktorin wrote: This patch fixes DN handling when removing LDAP entries from groups. Because they deal with commas and backslashes in a CSV param, the tests here rely on my patch 0015. ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 231 Ignore case in yes/no prompts

2012-03-07 Thread Petr Viktorin
On 03/06/2012 06:40 PM, Martin Kosek wrote: We did not accept answers like Yes, YES, No, etc. as valid answers to yes/no prompts (used for example in dnsrecord-del interactive mode). This could confuse users. This patch changes the behavior to ignore the answer case.

Re: [Freeipa-devel] [PATCH] 231 Ignore case in yes/no prompts

2012-03-07 Thread Petr Viktorin
On 03/07/2012 10:40 AM, Petr Viktorin wrote: On 03/06/2012 06:40 PM, Martin Kosek wrote: We did not accept answers like Yes, YES, No, etc. as valid answers to yes/no prompts (used for example in dnsrecord-del interactive mode). This could confuse users. This patch changes the behavior to ignore

[Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-07 Thread Petr Viktorin
case in yes/no prompts). -- Petr³ From 440f2abc1636c42d30ba18ac677ec00aa31294e9 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 6 Mar 2012 07:01:53 -0500 Subject: [PATCH 21/22] Add CLI parsing tests These test that command lines are parsed to correct Command arguments

[Freeipa-devel] [PATCH] 0022 Use ipauniqueid for the RDN of sudo commands

2012-03-08 Thread Petr Viktorin
sensitivity are included. https://fedorahosted.org/freeipa/ticket/2482 -- Petr³ From e07451ae2c152feb3ce87c5241793025f12f8b2e Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Thu, 8 Mar 2012 07:55:00 -0500 Subject: [PATCH] Use ipauniqueid for the RDN of sudo commands Since

[Freeipa-devel] [PATCH] 0023 Don't crash when searching with empty relationship options

2012-03-09 Thread Petr Viktorin
See commit message. https://fedorahosted.org/freeipa/ticket/2479 -- Petr³ From 074afddae80c7f1851f54324e746ed6a01b878f2 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 9 Mar 2012 04:45:15 -0500 Subject: [PATCH] Don't crash when searching with empty relationship

[Freeipa-devel] [PATCH] 0024 Fix expected exception checking in tests

2012-03-09 Thread Petr Viktorin
these correct ones to raises/assert_raises as well. I've also uncovered and fixed a few test bugs that were hidden by this. -- Petr³ From 378576d6252f6b304671d13b12276beffd7dd12d Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 9 Mar 2012 09:41:16 -0500 Subject: [PATCH] Use

[Freeipa-devel] Git post-commit hook

2012-03-09 Thread Petr Viktorin
Let me share my post-commit hook with you. Save this as .git/hooks/post-commit, chmod +x it, and each time you make a commit, it will run pylint and a PEP8 check on all .py files you've changed. It takes a long time, but it runs after the commit is made, so you can quite safely kill it or

[Freeipa-devel] [PATCHES] 0025-26 Test improvements

2012-03-12 Thread Petr Viktorin
, args_, kw_) ) (name, args, kw, result) = self.__calls[self.__i] self.__i += 1 -- 1.7.7.6 From 14bd9132fc427c3fe0f4a4af88bfb5148f3ea777 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Mon, 12 Mar 2012 05:58:44 -0400 Subject: [PATCH 26/26] Test

Re: [Freeipa-devel] [PATCH] 0022 Use ipauniqueid for the RDN of sudo commands (rebased)

2012-03-12 Thread Petr Viktorin
On 03/12/2012 01:26 PM, Martin Kosek wrote: On Thu, 2012-03-08 at 16:57 +0100, Petr Viktorin wrote: Since sudo commands are case-sensitive, we can't use the CN as the RDN. With this patch, the UUID is used instead. It seems like a too easy fix. What am I missing? As far as I understand

Re: [Freeipa-devel] [PATCH] 0022 Use ipauniqueid for the RDN of sudo commands (rebased)

2012-03-12 Thread Petr Viktorin
On 03/12/2012 04:01 PM, Martin Kosek wrote: On Mon, 2012-03-12 at 14:38 +0100, Petr Viktorin wrote: On 03/12/2012 01:26 PM, Martin Kosek wrote: On Thu, 2012-03-08 at 16:57 +0100, Petr Viktorin wrote: Since sudo commands are case-sensitive, we can't use the CN as the RDN. With this patch

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-13 Thread Petr Viktorin
On 03/12/2012 09:18 PM, Rob Crittenden wrote: Petr Viktorin wrote: Most of the tests we have check if the server does the right thing with XML-RPC calls. How the commandline is converted to command arguments, including interactive prompting, is untested. This patch adds some tests in this area

Re: [Freeipa-devel] [PATCH] 0022 Use ipauniqueid for the RDN of sudo commands (rebased)

2012-03-13 Thread Petr Viktorin
On 03/12/2012 06:10 PM, Martin Kosek wrote: On Mon, 2012-03-12 at 17:12 +0100, Petr Viktorin wrote: On 03/12/2012 04:01 PM, Martin Kosek wrote: On Mon, 2012-03-12 at 14:38 +0100, Petr Viktorin wrote: On 03/12/2012 01:26 PM, Martin Kosek wrote: On Thu, 2012-03-08 at 16:57 +0100, Petr Viktorin

Re: [Freeipa-devel] [PATCH] 0022 Use ipauniqueid for the RDN of sudo commands (rebased)

2012-03-13 Thread Petr Viktorin
On 03/12/2012 04:44 PM, Martin Kosek wrote: On Mon, 2012-03-12 at 16:01 +0100, Martin Kosek wrote: On Mon, 2012-03-12 at 14:38 +0100, Petr Viktorin wrote: On 03/12/2012 01:26 PM, Martin Kosek wrote: On Thu, 2012-03-08 at 16:57 +0100, Petr Viktorin wrote: Since sudo commands are case

Re: [Freeipa-devel] [PATCH] Fixed rpm build warning - extension.js listed twice

2012-03-14 Thread Petr Viktorin
On 03/14/2012 03:40 PM, Petr Vobornik wrote: First, I have to say that I'm new to rpm specs and I don't like this patch but I don't have better solution. Problem: Building the ipa rpms returns this: warning: File listed twice: /usr/share/ipa/ui/extension.js Cause: This is because of a glob:

[Freeipa-devel] [PATCH] 0027 Use valid argument names in tests

2012-03-14 Thread Petr Viktorin
the tests, so we don't get new bugs in production code. -- Petr³ From e794bf4fe5d55e3313ec239e29397aaf934bb07d Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 14 Mar 2012 11:33:41 -0400 Subject: [PATCH] Use valid argument names in tests Some of our tests used

Re: [Freeipa-devel] [PATCH] 924 display both hex and decimal serial numbers

2012-03-15 Thread Petr Viktorin
On 03/13/2012 10:57 PM, Rob Crittenden wrote: Jan Cholasta wrote: ..snip.. This patch works for me, but let me repeat myself: BTW, wouldn't it make sense to format serial numbers in the cert plugin in the same way? Honza Updated. rob diff --git a/ipaserver/plugins/dogtag.py

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-15 Thread Petr Viktorin
On 03/01/2012 11:45 AM, Petr Viktorin wrote: On 02/29/2012 07:46 PM, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-02-27 at 17:51 +0100, Petr Viktorin wrote: On 02/22/2012 10:41 AM, Petr Viktorin wrote: This fixes https://fedorahosted.org/freeipa/ticket/2071 (Add final debug message

[Freeipa-devel] [PATCH] 0028 Remove ipausers' gidnumber from tests

2012-03-15 Thread Petr Viktorin
Here's an one-liner: don't test for the gidnumber attribute on ipausers, since it's not there by default now. -- Petr³ From 600c7722db6accd17e97425914cc69b08b082eb7 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Thu, 15 Mar 2012 08:49:41 -0400 Subject: [PATCH] Remove

Re: [Freeipa-devel] [PATCHES] Improve framework parameter validation

2012-03-15 Thread Petr Viktorin
On 03/15/2012 12:05 PM, Jan Cholasta wrote: On 15.3.2012 11:36, Jan Cholasta wrote: (this is a continuation of http://www.redhat.com/archives/freeipa-devel/2011-September/msg00327.html) Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/1847 and

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-16 Thread Petr Viktorin
On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's not idempotent (baskslashes are eaten when

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-16 Thread Petr Viktorin
On 03/13/2012 12:23 PM, Petr Viktorin wrote: On 03/12/2012 09:18 PM, Rob Crittenden wrote: Petr Viktorin wrote: Most of the tests we have check if the server does the right thing with XML-RPC calls. How the commandline is converted to command arguments, including interactive prompting

Re: [Freeipa-devel] [PATCH] 987 Don't allow IPA master hosts and services to be disabled

2012-03-16 Thread Petr Viktorin
On 03/15/2012 10:04 PM, Rob Crittenden wrote: diff --git a/ipalib/plugins/baseldap.py b/ipalib/plugins/baseldap.py index 9562ff98729ead6ac9e56d504f6ee0a7c0ca377a..f3c89a0fc5e3f00ed7f132dbff2510d89bc7370d 100644 --- a/ipalib/plugins/baseldap.py +++ b/ipalib/plugins/baseldap.py @@ -887,12

Re: [Freeipa-devel] [PATCH] 986 remove unnecessary serial conversions

2012-03-16 Thread Petr Viktorin
On 03/15/2012 06:31 PM, Rob Crittenden wrote: This is related to my patch 924. Petr Viktorin noticed a couple of serial to hex conversions were wrong and it turns out they aren't needed at all. This patch removes them. rob On 03/15/2012 06:32 PM, Rob Crittenden wrote: Petr Viktorin wrote

Re: [Freeipa-devel] [PATCH] 0024 Fix expected exception checking in tests

2012-03-16 Thread Petr Viktorin
On 03/15/2012 10:36 PM, Rob Crittenden wrote: Petr Viktorin wrote: Can you spot the bug in this test code? try: do_invalid_operation() except ExpectedError: pass Our test suite had several of those. Nose provides nice tools, `raises` (a decorator) and `assert_raises` (a context manager

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: .. snip .. Patch 17 makes these options honor params marked

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/16/2012 02:34 PM, Rob Crittenden wrote: Petr Viktorin wrote: I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/16/2012 06:33 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/16/2012 06:35 PM, Petr Viktorin wrote: On 03/16/2012 06:33 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote: On 02/29/2012 03:50 PM, Rob Crittenden wrote

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-19 Thread Petr Viktorin
On 03/16/2012 10:23 PM, Rob Crittenden wrote: When using *attr we should return the param.name of in the exception and when using a cli option we should return param.cli_name. This didn't work consistently in the framework. This is a bit of a kludge, catching exceptions and re-raising them, but

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-19 Thread Petr Viktorin
On 03/19/2012 03:02 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/16/2012 10:23 PM, Rob Crittenden wrote: When using *attr we should return the param.name of in the exception and when using a cli option we should return param.cli_name. This didn't work consistently in the framework

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-20 Thread Petr Viktorin
On 03/16/2012 08:01 PM, Petr Viktorin wrote: On 03/16/2012 06:35 PM, Petr Viktorin wrote: On 03/16/2012 06:33 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-20 Thread Petr Viktorin
On 03/16/2012 12:55 PM, Petr Viktorin wrote: On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-21 Thread Petr Viktorin
On 03/20/2012 10:08 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/16/2012 12:55 PM, Petr Viktorin wrote: On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting

Re: [Freeipa-devel] [PATCH] 241 Fix precallback validators in DNS plugin

2012-03-22 Thread Petr Viktorin
On 03/21/2012 01:51 PM, Martin Kosek wrote: DNS plugin contains several RR type record validators run in pre_callback which cannot be used as standard param validator as it needs more data and resources that standard validators provide. However, the precallback validators are not run for DNS

Re: [Freeipa-devel] [PATCH] 241 Fix precallback validators in DNS plugin

2012-03-22 Thread Petr Viktorin
On 03/22/2012 04:53 PM, Martin Kosek wrote: On Thu, 2012-03-22 at 16:30 +0100, Petr Viktorin wrote: On 03/21/2012 01:51 PM, Martin Kosek wrote: DNS plugin contains several RR type record validators run in pre_callback which cannot be used as standard param validator as it needs more data

Re: [Freeipa-devel] [PATCH] 242 Harden raw record processing in DNS plugin

2012-03-22 Thread Petr Viktorin
On 03/22/2012 05:38 PM, Martin Kosek wrote: On Wed, 2012-03-21 at 16:58 +0100, Martin Kosek wrote: Few test cases are attached to the ticket. This patch depends on my patch 241. --- There were cases where DNS plugin was too tolerant in a raw DNS record option (--rrtype-rec) processing. It let

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-22 Thread Petr Viktorin
On 03/22/2012 07:02 PM, John Dennis wrote: [resending because I originally sent this to the wrong list] This addresses tickets 2044 and 1958. Ticket 2044 was on my short list but the code had already been written for ticket 1958 (validation of substitution variables). It had been sitting in my

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-23 Thread Petr Viktorin
On 03/22/2012 10:13 PM, John Dennis wrote: On 03/22/2012 02:59 PM, Petr Viktorin wrote: On 03/22/2012 06:01 PM, John Dennis wrote: .. snip .. When I ran the validation on our complete set of files a lot of errors were reported for ipalib/plugins/hbactest.py:27 msgid has whitespace between

Re: [Freeipa-devel] [PATCH] 234 Avoid deleting DNS zone when a context is reused

2012-03-23 Thread Petr Viktorin
On 03/23/2012 10:33 AM, Martin Kosek wrote: On Thu, 2012-03-08 at 14:57 +0100, Martin Kosek wrote: When dnsrecord-del pre_callback detects that the record does not contain any records, it set a flag to connection context and deletes the record object later. However, when more dnsrecord-del

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-23 Thread Petr Viktorin
On 03/15/2012 11:30 AM, Petr Viktorin wrote: On 03/01/2012 11:45 AM, Petr Viktorin wrote: On 02/29/2012 07:46 PM, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-02-27 at 17:51 +0100, Petr Viktorin wrote: On 02/22/2012 10:41 AM, Petr Viktorin wrote: This fixes https

Re: [Freeipa-devel] [PATCH] 18 Typos in FreeIPA messages

2012-03-23 Thread Petr Viktorin
On 03/14/2012 01:32 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2526 Rebased patch sent by Yuri Chornoivan (yurc...@ukr.net). Fixes 'occured' and 'commond' typos in FreeIPA messages. Longtitude/Longitude typo was already corrected in patch for ticket #2382

Re: [Freeipa-devel] [PATCH] 995 update min version of 389-ds-base

2012-03-23 Thread Petr Viktorin
On 03/23/2012 08:11 PM, Rob Crittenden wrote: Rob Crittenden wrote: Set new minimum version of 389-ds-base to fix db corruption during upgrade problem. This patch is against 2.2. Corrected changelog entry. You've attached a different patch. -- Petr³

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-26 Thread Petr Viktorin
On 03/23/2012 10:33 PM, John Dennis wrote: Attached is is a new patch addressing Petr's review comment as well as some sample output for illustration purposes (I suggest you review the example.txt). Rather than wading through a log of dialog in the previous emails let me address Petr's issues

Re: [Freeipa-devel] [PATCH] 0027 Use valid argument names in tests

2012-03-26 Thread Petr Viktorin
On 03/14/2012 05:02 PM, Petr Viktorin wrote: This patch depends on my patch 0024 (but I can rebase if it needs to be pushed earlied). It fixes some of the test bugs that would be found by a fix for https://fedorahosted.org/freeipa/ticket/2509 (Unknown Command arguments are allowed (and ignored

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-26 Thread Petr Viktorin
On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line arguments in some uniform way (which is also needed before logging setup to detect ipa-server-install --uninstall). The original patch

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-26 Thread Petr Viktorin
On 03/26/2012 05:49 PM, John Dennis wrote: On 03/26/2012 04:24 AM, Petr Viktorin wrote: Great! Just two issues now. According to the style guide, we do allow %s in a string iff it only appears once. The reason for named substitutions is that the word order can be changed, providing context

Re: [Freeipa-devel] [PATCHES] 0025-26 Test improvements

2012-03-27 Thread Petr Viktorin
On 03/26/2012 10:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 25 fixes errors I found by running pylint on the testsuite. They were in code that was unused, either by error or because it only runs on errors. Patch 26 adds a test for the batch plugin. In patch 25 the second

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-27 Thread Petr Viktorin
On 03/26/2012 10:34 PM, John Dennis wrote: On 03/26/2012 01:11 PM, Petr Viktorin wrote: Just a one-liner: The docstring of validate_anonymous_substitutions isn't up to par ­­– there's a missing quote, extra “a”, and the '%s occurred' has no context. I suggest: We do not permit multiple

Re: [Freeipa-devel] [PATCH] 244 Fix dnsrecord-del interactive mode

2012-03-27 Thread Petr Viktorin
On 03/27/2012 01:06 PM, Martin Kosek wrote: User was not able to select multiple values in dnsrecord-del interactive mode. https://fedorahosted.org/freeipa/ticket/2581 ACK -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-27 Thread Petr Viktorin
Updated with a regression test for https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp records interactively) which Martin fixed recently. -- Petr³ From 585423feb041cd434977130bd6f00975808ccf30 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread Petr Viktorin
On 03/27/2012 04:58 PM, John Dennis wrote: [...] def test_create_translation(): f = text.create_translation key = ('foo', None) @@ -129,6 +45,84 @@ def test_create_translation(): assert context.__dict__[key] is t +class test_TestLang(object): +def setUp(self): +

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-28 Thread Petr Viktorin
On 03/28/2012 09:11 AM, Martin Kosek wrote: On Tue, 2012-03-27 at 19:02 +0200, Petr Viktorin wrote: Updated with a regression test for https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp records interactively) which Martin fixed recently. Thank's for adding a specific

  1   2   3   4   5   6   7   8   9   10   >