[Freeipa-devel] [freeipa PR#448][opened] Tests: Basic coverage with tree root domain

2017-02-08 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Author: gkaihorodova Title: #448: Tests: Basic coverage with tree root domain Action: opened PR body: """ Tests: Basic coverage with tree root domain Extend existing legacy client tests to cover test cases with tree roo

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-09 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain gkaihorodova commented: """ Can you be a little bit more specific about "triplication of the test cases ", please. Because, to be honest, I'm having hard time

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain gkaihorodova commented: """ Thank you for explanation and tips. I noticed it as well and I agree that it (and not only that) worth refactoring. Yes, my PR is more or

[Freeipa-devel] [freeipa PR#448][synchronized] Tests: Basic coverage with tree root domain

2017-02-16 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Author: gkaihorodova Title: #448: Tests: Basic coverage with tree root domain Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/448/head:pr448 git checkout

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain gkaihorodova commented: """ Yes, sure I'll work on these issues """ See the full comment at https://github.com/freeipa/freeipa/pull/448#issuecom

[Freeipa-devel] [freeipa PR#210][synchronized] Tests: Stage User Tracker implementation

2017-01-18 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/210/head:pr210 git checkout pr210

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2017-01-18 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-28 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain gkaihorodova commented: """ Thanks you for review. Let's hope for the best . """ See the full comment at https://github.com/freeipa/freeipa/pull/448#issuecom

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-27 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain gkaihorodova commented: """ Bump for review """ See the full comment at https://github.com/freeipa/freeipa/pull/448#issuecomment-282664683 -- Manage you

[Freeipa-devel] [freeipa PR#17] Tests: Random issuer certificate can be added to a service (+ack)

2016-08-31 Thread gkaihorodova
mirielka's pull request #17: "Tests: Random issuer certificate can be added to a service" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/17 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#39] Tests: Add missing attributes to test_xmlrpc/test_trust tests (+ack)

2016-08-31 Thread gkaihorodova
mirielka's pull request #39: "Tests: Add missing attributes to test_xmlrpc/test_trust tests" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/39 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#147][closed] Tests: Unaccessible variable self.attrs in Tracker

2016-10-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/147 Author: gkaihorodova Title: #147: Tests: Unaccessible variable self.attrs in Tracker Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/147/head:pr147 git checkout

[Freeipa-devel] [freeipa PR#148][opened] Unaccessible variable self.attrs in Tracker

2016-10-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/148 Author: gkaihorodova Title: #148: Unaccessible variable self.attrs in Tracker Action: opened PR body: """ In tracker, 'self.attrs' variable is created and filled in track_create method. Some objects are not created but still

[Freeipa-devel] [freeipa PR#147][opened] Tests: Unaccessible variable self.attrs in Tracker

2016-10-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/147 Author: gkaihorodova Title: #147: Tests: Unaccessible variable self.attrs in Tracker Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6125 """ To pull the PR as Git branch: git remote ad

[Freeipa-devel] [freeipa PR#32] Test for caacl-add-service (opened)

2016-08-29 Thread gkaihorodova
gkaihorodova's pull request #32: "Test for caacl-add-service" was opened PR body: """ Test for caacl-add-service: incorrect error message when service does not exists https://fedorahosted.org/freeipa/ticket/6171 """ See the full pull-request at https://github.com/freeipa/freeipa/pull/32 ... or

[Freeipa-devel] [freeipa PR#148][closed] Unaccessible variable self.attrs in Tracker

2016-10-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/148 Author: gkaihorodova Title: #148: Unaccessible variable self.attrs in Tracker Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/148/head:pr148 git checkout pr148

[Freeipa-devel] [freeipa PR#148][comment] Unaccessible variable self.attrs in Tracker

2016-10-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/148 Title: #148: Unaccessible variable self.attrs in Tracker gkaihorodova commented: """ You're right, empty dict is more applicable here. I will close that one and open new with suggested fix. """ See the full

[Freeipa-devel] [freeipa PR#149][opened] Tests: Unaccessible variable self.attrs in Tracker

2016-10-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/149 Author: gkaihorodova Title: #149: Tests: Unaccessible variable self.attrs in Tracker Action: opened PR body: """ In tracker, 'self.attrs' variable is created and filled in track_create method. Some objects are not created bu

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2016-10-25 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ Yes, It's a valid point to add testcases for these changes . Will do. Thank you. """ See the full comment at http

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-10-24 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-10-24 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#181][opened] Tests : User Tracker creation of user with minimal values

2016-10-24 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: opened PR body: """ Fix provide possibility to create user-add test with minimal values, where uid is not specified, to provide

[Freeipa-devel] [freeipa PR#119][+ack] Tests: Providing trust tests with tree root domain

2016-11-14 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/119 Title: #119: Tests: Providing trust tests with tree root domain Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-11-02 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#210][opened] Tests: Stage User Tracker implementation

2016-11-02 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: opened PR body: """ Fix provide possibility of creation stage user with minimal values, with uid not specified. Implementation is the same as f

[Freeipa-devel] [freeipa PR#210][synchronized] Tests: Stage User Tracker implementation

2016-11-02 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/210/head:pr210 git checkout pr210

[Freeipa-devel] [freeipa PR#148][synchronized] Unaccessible variable self.attrs in Tracker

2016-10-11 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/148 Author: gkaihorodova Title: #148: Unaccessible variable self.attrs in Tracker Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/148/head:pr148 git checkout

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-12-08 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2017-01-12 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ @mbasti-rh done. hope now it's fine """ See the full comment at https://github.com/freeipa/freeipa/pull/181#iss

[Freeipa-devel] [freeipa PR#386][opened] Tests: Add tree root domain role in legacy client tests

2017-01-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/386 Author: gkaihorodova Title: #386: Tests: Add tree root domain role in legacy client tests Action: opened PR body: """ Legacy client tests inherits test cases from trust tests, that have role for tree root domain. That role was mi

[Freeipa-devel] [freeipa PR#386][edited] Tests: Add tree root domain role in legacy client tests

2017-01-11 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/386 Author: gkaihorodova Title: #386: Tests: Add tree root domain role in legacy client tests Action: edited Changed field: body Original value: """ Legacy client tests inherits test cases from trust tests, that have role for t

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-11-30 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#210][synchronized] Tests: Stage User Tracker implementation

2016-11-30 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/210/head:pr210 git checkout pr210

[Freeipa-devel] [freeipa PR#210][synchronized] Tests: Stage User Tracker implementation

2016-11-30 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/210/head:pr210 git checkout pr210

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-12-01 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2017-01-06 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ Yes, the intention was to have repr() of the given string , so I'll use ''{!r} instead of '{}', and apply that change to #210

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2017-01-06 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#210][synchronized] Tests: Stage User Tracker implementation

2017-01-06 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/210/head:pr210 git checkout pr210

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2017-01-05 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ will do, but before let me do small changes that was requested by @stlaz in #210, to use str.format() instead of " %r "

[Freeipa-devel] [freeipa PR#210][synchronized] Tests: Stage User Tracker implementation

2017-01-05 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/210 Author: gkaihorodova Title: #210: Tests: Stage User Tracker implementation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/210/head:pr210 git checkout pr210

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2017-01-05 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2017-01-09 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ Thank you for review! """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-27123664