[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-31 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code martbab commented: """ I have disabled updates-testing in the CI because of multitude of unrelated breakages (recent openldap-client vs. nss breakage comes to mind), b

[Freeipa-devel] [freeipa PR#437][comment] FIPS: replica install check

2017-02-06 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/437 Title: #437: FIPS: replica install check martbab commented: """ @tomaskrizek since you added a new key to the Env object, you will have to fix `test_ipalib/test_config.py` to account for this change, see https://travis-ci.org/

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-02-07 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code martbab commented: """ I have figured out that the previous Travis failures were caused by missing version in mod_auth_gssapi Requires. If I downgrade the package to

[Freeipa-devel] [freeipa PR#431][+ack] py3: ldapupdate: fix logging str(bytes) issue

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/431 Title: #431: py3: ldapupdate: fix logging str(bytes) issue Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#447][opened] AD trust installer modularization: prelude

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/447 Author: martbab Title: #447: AD trust installer modularization: prelude Action: opened PR body: """ This PR is more of a preparatory work for modularization of AD trust installer code. The code was formatted to conform with PEP-8

[Freeipa-devel] [freeipa PR#449][synchronized] Travis CI: Upload the logs from failed jobs to transfer.sh

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/449 Author: martbab Title: #449: Travis CI: Upload the logs from failed jobs to transfer.sh Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/449/head:pr449 git

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain martbab commented: """ I have quickly skimmed through code and have one comment. Also, I have noticed the extreme code triplication of the test cases. I think that this

[Freeipa-devel] [freeipa PR#370][comment] ci: send build log to paste.fedoraproject.org

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: ci: send build log to paste.fedoraproject.org martbab commented: """ We were discussing yout PR with @HonzaCholasta yesterday and he suggested that we could pack the test runner log, HTTP and dirsrv logs and server

[Freeipa-devel] [freeipa PR#370][comment] ci: send build log to paste.fedoraproject.org

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: ci: send build log to paste.fedoraproject.org martbab commented: """ @HonzaCholasta ok in that case I will archive: `/var/log/httpd`, `/var/log/dirsrv/`, `/var/log/pki/pki-tomcat`, `ipaserver/client-install.log`

[Freeipa-devel] [freeipa PR#424][+pushed] Tests: fix wait_for_replication task

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/424 Title: #424: Tests: fix wait_for_replication task Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#424][comment] Tests: fix wait_for_replication task

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/424 Title: #424: Tests: fix wait_for_replication task martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ad1a5551d5ec716dc745f39e82d38cc634229cb0 """ See the full comment at http

[Freeipa-devel] [freeipa PR#424][closed] Tests: fix wait_for_replication task

2017-02-08 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/424 Author: MartinBasti Title: #424: Tests: fix wait_for_replication task Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/424/head:pr424 git checkout pr424 -- Manage

[Freeipa-devel] [freeipa PR#420][comment] WIP: Allow login to WebUI using Kerberos aliases/enterprise principals

2017-02-03 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/420 Title: #420: WIP: Allow login to WebUI using Kerberos aliases/enterprise principals martbab commented: """ I would wait with ACKing/pushing this PR until https://github.com/freeipa/freeipa/pull/314 is pushed. """

[Freeipa-devel] [freeipa PR#411][+pushed] Remove deprecated ipa-upgradeconfig command

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/411 Title: #411: Remove deprecated ipa-upgradeconfig command Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#411][+ack] Remove deprecated ipa-upgradeconfig command

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/411 Title: #411: Remove deprecated ipa-upgradeconfig command Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#406][+ack] _resolve_records: fix assert, nameserver_ip can be none

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/406 Title: #406: _resolve_records: fix assert, nameserver_ip can be none Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#370][comment] ci: send build log to paste.fedoraproject.org

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: ci: send build log to paste.fedoraproject.org martbab commented: """ LGTM, it would be nice if you could temporarily sneak in some breaking commit so that we can see how the paste looks like. """

[Freeipa-devel] [freeipa PR#353][comment] [RFE] Pwdpolicy

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/353 Title: #353: [RFE] Pwdpolicy martbab commented: """ LGTM, but the PR needs some more love since it breaks CI. """ See the full comment at https://github.com/freeipa/freeipa/pull/353#issuecomment-27475040

[Freeipa-devel] [freeipa PR#407][comment] New lite-server implementation

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/407 Title: #407: New lite-server implementation martbab commented: """ @rcritten AFAIK most of us develop plugins locally, then build RPMs which we sync to a VM, install IPA server and use ipa-run-tests to test the new plugin. I

[Freeipa-devel] [freeipa PR#406][closed] _resolve_records: fix assert, nameserver_ip can be none

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/406 Author: MartinBasti Title: #406: _resolve_records: fix assert, nameserver_ip can be none Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/406/head:pr406 git

[Freeipa-devel] [freeipa PR#406][comment] _resolve_records: fix assert, nameserver_ip can be none

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/406 Title: #406: _resolve_records: fix assert, nameserver_ip can be none martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ccea23138ba6e9b54c08d472341ddbd64ffc45df """

[Freeipa-devel] [freeipa PR#406][+pushed] _resolve_records: fix assert, nameserver_ip can be none

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/406 Title: #406: _resolve_records: fix assert, nameserver_ip can be none Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#196][comment] ipatests: unresolvable nested netgroups

2017-01-23 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/196 Title: #196: ipatests: unresolvable nested netgroups martbab commented: """ Since the re-implementation of this test suite is done by @celestian in https://github.com/freeipa/freeipa/pull/409 can I close this PR? "&quo

[Freeipa-devel] [freeipa PR#411][comment] Remove deprecated ipa-upgradeconfig command

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/411 Title: #411: Remove deprecated ipa-upgradeconfig command martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/c56e02b3c5257edbfd3709848ca7eda07e271e38 """ See the full comment

[Freeipa-devel] [freeipa PR#411][closed] Remove deprecated ipa-upgradeconfig command

2017-01-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/411 Author: Akasurde Title: #411: Remove deprecated ipa-upgradeconfig command Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/411/head:pr411 git checkout pr411 --

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-30 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code martbab commented: """ @simo5 the simplest way to fix CI is to add WIP commit that enables your COPR repos during 'builddep' step like this (untested): ```

[Freeipa-devel] [freeipa PR#420][opened] WIP: Allow login to WebUI using Kerberos aliases/enterprise principals

2017-01-30 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/420 Author: martbab Title: #420: WIP: Allow login to WebUI using Kerberos aliases/enterprise principals Action: opened PR body: """ The logic of the extraction/validation of principal from the request and subsequent authentication

[Freeipa-devel] [freeipa PR#401][+pushed] [4.4] Wait until http principal entry is replicated to replica

2017-01-25 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/401 Title: #401: [4.4] Wait until http principal entry is replicated to replica Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#347][+pushed] Improvements in {get|set}_directive functions

2017-01-25 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#347][closed] Improvements in {get|set}_directive functions

2017-01-25 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/347 Author: martbab Title: #347: Improvements in {get|set}_directive functions Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/347/head:pr347 git checkout pr347

[Freeipa-devel] [freeipa PR#401][comment] [4.4] Wait until http principal entry is replicated to replica

2017-01-25 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/401 Title: #401: [4.4] Wait until http principal entry is replicated to replica martbab commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/3d0a0728766aed7245427b9eaf210e31fd40e440 https://fedorahos

[Freeipa-devel] [freeipa PR#401][closed] [4.4] Wait until http principal entry is replicated to replica

2017-01-25 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/401 Author: MartinBasti Title: #401: [4.4] Wait until http principal entry is replicated to replica Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/401/head:pr401 git

[Freeipa-devel] [freeipa PR#347][synchronized] Improvements in {get|set}_directive functions

2017-01-25 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/347 Author: martbab Title: #347: Improvements in {get|set}_directive functions Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/347/head:pr347 git checkout pr347

[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions

2017-01-25 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions martbab commented: """ Thank's, let's hope that all this code will be replaced by some proper configuration parsing mechanism in the future. """

[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions

2017-01-25 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/e1ed8b5eff40331ba532d37f3fb08814d8a55b77 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#399][comment] Certificate mapping test

2017-02-21 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/399 Title: #399: Certificate mapping test martbab commented: """ I have some inline comments. I was also thinking about the nomenclature of the Tracker mixins and I think we should name them based on the noun of the action that i

[Freeipa-devel] [freeipa PR#479][comment] Merge AD trust installer into composite ones

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Title: #479: Merge AD trust installer into composite ones martbab commented: """ Bump for review. """ See the full comment at https://github.com/freeipa/freeipa/pull/479#issuecomment-281635086 -- Manage your subs

[Freeipa-devel] [freeipa PR#457][comment] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab martbab commented: """ Bump for review. """ See the full comment at https://github.com/freeipa/freeipa/pull/457#issuecomment-28163516

[Freeipa-devel] [freeipa PR#485][comment] Fix session logout

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/485 Title: #485: Fix session logout martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/908d2eaba46f5f123b49af400a8b696545c62b54 """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#485][+pushed] Fix session logout

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/485 Title: #485: Fix session logout Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#485][closed] Fix session logout

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/485 Author: simo5 Title: #485: Fix session logout Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/485/head:pr485 git checkout pr485 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ I have also noticed that the ccache is not created there, strange. However I think it is better to explicitly specify file-based ccache anyway

[Freeipa-devel] [freeipa PR#479][synchronized] Merge AD trust installer into composite ones

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Author: martbab Title: #479: Merge AD trust installer into composite ones Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/479/head:pr479 git checkout pr479

[Freeipa-devel] [freeipa PR#479][comment] Merge AD trust installer into composite ones

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Title: #479: Merge AD trust installer into composite ones martbab commented: """ I have added a basic integration tests for the built-in AD trust installation, you can run them on 3 machines (master + 2 replicas) by running ``

[Freeipa-devel] [freeipa PR#468][+ack] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#478][closed] [4.4] Do not configure PKI ajp redirection to use "::1"

2017-02-20 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/478 Author: flo-renaud Title: #478: [4.4] Do not configure PKI ajp redirection to use "::1" Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/478/head:pr478 git

[Freeipa-devel] [freeipa PR#478][+pushed] [4.4] Do not configure PKI ajp redirection to use "::1"

2017-02-20 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/478 Title: #478: [4.4] Do not configure PKI ajp redirection to use "::1" Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#478][comment] [4.4] Do not configure PKI ajp redirection to use "::1"

2017-02-20 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/478 Title: #478: [4.4] Do not configure PKI ajp redirection to use "::1" martbab commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/4a30e9d53475d60fb76242a098f1d969d6b19f75 "&quo

[Freeipa-devel] [freeipa PR#457][synchronized] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Author: martbab Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/457/head:pr457 git

[Freeipa-devel] [freeipa PR#457][comment] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab martbab commented: """ I have added some commits to cope with changes made during privliege spearation work """ See the full comment at http

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ Could we use just keep the post command as "kdestroy -c {apache_ccache_path}"? Or is everything chrooted into name-spaced /tmp and we can no

[Freeipa-devel] [freeipa PR#479][synchronized] Merge AD trust installer into composite ones

2017-02-23 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Author: martbab Title: #479: Merge AD trust installer into composite ones Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/479/head:pr479 git checkout pr479

[Freeipa-devel] [freeipa PR#368][closed] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/368 Author: pvomacka Title: #368: WebUI: fix incorrect behavior of ESC button on combobox Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/368/head:pr368 git

[Freeipa-devel] [freeipa PR#368][comment] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/1a96e7f9e737941480436269668ccde0a50395f9 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#479][opened] Merge AD trust installer into composite ones

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Author: martbab Title: #479: Merge AD trust installer into composite ones Action: opened PR body: """ This PR implements setup of Samba/Winbind as a part of server/replica install. I will update installation tests in a separ

[Freeipa-devel] [freeipa PR#368][+pushed] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#468][closed] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Author: simo5 Title: #468: Remove non-sensical kdestroy on https stop Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/468/head:pr468 git checkout pr468 -- Manage

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/b8f304c66994ae82ea484a4e8bd057d4ccf1e6bd """ See the full comment

[Freeipa-devel] [freeipa PR#468][+pushed] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ @pvoborni should the fix go also into 4-4 branch? see https://fedorahosted.org/freeipa/ticket/6673#comment:3 """ See the full comment

[Freeipa-devel] [freeipa PR#449][synchronized] Travis CI: Upload the logs from failed jobs to transfer.sh

2017-02-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/449 Author: martbab Title: #449: Travis CI: Upload the logs from failed jobs to transfer.sh Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/449/head:pr449 git

[Freeipa-devel] [freeipa PR#447][+pushed] AD trust installer modularization: prelude

2017-02-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/447 Title: #447: AD trust installer modularization: prelude Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#454][opened] Move AD trust installation code to a separate module

2017-02-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/454 Author: martbab Title: #454: Move AD trust installation code to a separate module Action: opened PR body: """ This facilitates calling the necessary checks and configuration code as a module from e.g. a composite installer. The c

[Freeipa-devel] [freeipa PR#447][comment] AD trust installer modularization: prelude

2017-02-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/447 Title: #447: AD trust installer modularization: prelude martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/847be3a8a85cd58e5a011c0c2bc7e1123eb4a1aa https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#447][closed] AD trust installer modularization: prelude

2017-02-09 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/447 Author: martbab Title: #447: AD trust installer modularization: prelude Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/447/head:pr447 git checkout pr447

[Freeipa-devel] [freeipa PR#457][opened] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Author: martbab Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Action: opened PR body: """ In order to be able to function as a part of composite installer, samba configuration code must be able to wor

[Freeipa-devel] [freeipa PR#457][comment] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab martbab commented: """ Sorry I just got confused for a bit. Fixed the docstring now refer only to 'samba keytab'. """ See the full comment

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain martbab commented: """ If you look at the test cases (e.g. test_login_ipa-user, test_login_ad_user, test_login_subdomain_user are the 'best: examples) you can see that the

[Freeipa-devel] [freeipa PR#457][synchronized] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Author: martbab Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/457/head:pr457 git

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/469 Title: #469: Ignore unlink error in ipa-otpd.socket martbab commented: """ LGTM, but do we require this fix also in 4-4 branch? """ See the full comment at https://github.com/freeipa/freeipa/pull/469#issuecom

[Freeipa-devel] [freeipa PR#454][synchronized] Move AD trust installation code to a separate module

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/454 Author: martbab Title: #454: Move AD trust installation code to a separate module Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/454/head:pr454 git

[Freeipa-devel] [freeipa PR#454][synchronized] Move AD trust installation code to a separate module

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/454 Author: martbab Title: #454: Move AD trust installation code to a separate module Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/454/head:pr454 git

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-15 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ @rcritten I apologize for sounding rude. I misread your comment and interpreted it differently than intended. That said, if the restore to a run

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-15 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ We do not backup ccache, we back up apache keytab. During restore into installer server we back up old Kerberos keys, but without any mechanism t

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-15 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ @rcritten can you please re-read my comment very slowly? I wrote that we *do* backup keytabs. """ See the full comment at https://g

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-15 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ And indeed I can reproduce the original failure reported in https://fedorahosted.org/freeipa/ticket/5296 with this PR. If I manually remove apache c

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-15 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ I would rather keep `kdestroy` there, but only really purge the apache ccache explicitly: ```diff --- a/ipaplatform/redhat/tasks.py +++ b/ipaplatform/

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain martbab commented: """ Well you still have some issues to fix, notably the failing Travis CI and the not-so nice multiline-string literal. """ See the full

[Freeipa-devel] [freeipa PR#475][comment] Add options to run only ipaclient unittests

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests martbab commented: """ I was thinking that instead of making up more options to test runner we could reorganize the `ipatests/` directory to actually make sense from the

[Freeipa-devel] [freeipa PR#474][closed] Update man page of ipa-server-install

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/474 Author: Akasurde Title: #474: Update man page of ipa-server-install Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/474/head:pr474 git checkout pr474 -- Manage

[Freeipa-devel] [freeipa PR#474][+pushed] Update man page of ipa-server-install

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/474 Title: #474: Update man page of ipa-server-install Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#474][comment] Update man page of ipa-server-install

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/474 Title: #474: Update man page of ipa-server-install martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/08b8bfa9b59b30e1bec1fa8c1cfce992dc80c49f """ See the full comment at http

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server martbab commented: """ Well you won't, and they were not tested automatically before AFAIK (checked with FreeIPA 4.2.0 sources). We can agree that they *should

[Freeipa-devel] [freeipa PR#464][comment] Bump required python-cryptography version

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/464 Title: #464: Bump required python-cryptography version martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/66867319d903f7693a535471d3b81716a258ce9d """ See the full comment

[Freeipa-devel] [freeipa PR#464][closed] Bump required python-cryptography version

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/464 Author: stlaz Title: #464: Bump required python-cryptography version Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/464/head:pr464 git checkout pr464 -- Manage

[Freeipa-devel] [freeipa PR#464][+pushed] Bump required python-cryptography version

2017-02-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/464 Title: #464: Bump required python-cryptography version Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#179][closed] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/179 Author: Akasurde Title: #179: Fix for handling CalledProcessError in authconfig Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/179/head:pr179 git checkout pr179

[Freeipa-devel] [freeipa PR#179][comment] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/6d52c0fe6acb09f3b8525840dfacc3f0885eac37 """ See the full

[Freeipa-devel] [freeipa PR#210][comment] Tests: Stage User Tracker implementation

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation martbab commented: """ @gkaihorodova the PR cannot be pushed in current form because the first commit 298e1a136c6a430e8deaa558a946ba51874ffd95 is already pushed to master

[Freeipa-devel] [freeipa PR#387][+pushed] Update warning message for ipa server uninstall

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/387 Title: #387: Update warning message for ipa server uninstall Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#387][comment] Update warning message for ipa server uninstall

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/387 Title: #387: Update warning message for ipa server uninstall martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ae2d0a221772267ecda30896dc8897a3f4b4a97b """ See the full

[Freeipa-devel] [freeipa PR#387][closed] Update warning message for ipa server uninstall

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/387 Author: Akasurde Title: #387: Update warning message for ipa server uninstall Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/387/head:pr387 git checkout pr387 --

[Freeipa-devel] [freeipa PR#378][comment] Clean / ignore make check artefact

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/378 Title: #378: Clean / ignore make check artefact martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d8343a96dd206c9f25cf032a50f3b48fb8166db1 """ See the full comment at http

[Freeipa-devel] [freeipa PR#394][comment] Add fix for ipa plugins command

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command martbab commented: """ @Akasurde are you OK with writing a simple regression test for this command as a part of this PR? """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#389][+pushed] Fix build in mock

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/389 Title: #389: Fix build in mock Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#386][comment] Tests: Add tree root domain role in legacy client tests

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/386 Title: #386: Tests: Add tree root domain role in legacy client tests martbab commented: """ Looks good, let's see if it fixes our CI """ See the full comment at https://github.com/freeipa/freeipa/pull/386#issuecom

[Freeipa-devel] [freeipa PR#386][+ack] Tests: Add tree root domain role in legacy client tests

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/386 Title: #386: Tests: Add tree root domain role in legacy client tests Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#179][+pushed] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#378][closed] Clean / ignore make check artefact

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/378 Author: tiran Title: #378: Clean / ignore make check artefact Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/378/head:pr378 git checkout pr378 -- Manage your

[Freeipa-devel] [freeipa PR#389][closed] Fix build in mock

2017-01-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/389 Author: lslebodn Title: #389: Fix build in mock Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/389/head:pr389 git checkout pr389 -- Manage your subscription for

  1   2   3   4   5   6   7   8   >