[Freeipa-devel] [bind-dyndb-ldap PR#1] [WIP] Port bind-dyndb-ldap to BIND 9.11 (synchronize)

2016-09-01 Thread pspacek
ons(+), 384 deletions(-) delete mode 100644 src/zone_manager.c delete mode 100644 src/zone_manager.h diff --git a/README b/README index 2fd09b5..e90fc26 100644 --- a/README +++ b/README @@ -2,15 +2,9 @@ === The dynamic LDAP back-end is a plug-in for BIND that provides an LDAP -

[Freeipa-devel] [bind-dyndb-ldap PR#1] Port bind-dyndb-ldap to BIND 9.11 (edited)

2016-09-02 Thread pspacek
pspacek's pull request #1: "Port bind-dyndb-ldap to BIND 9.11" was edited See the full pull-request at https://github.com/freeipa/bind-dyndb-ldap/pull/1 ... or pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap

[Freeipa-devel] [bind-dyndb-ldap PR#1] [WIP] Port bind-dyndb-ldap to BIND 9.11 (synchronize)

2016-09-01 Thread pspacek
ons(+), 384 deletions(-) delete mode 100644 src/zone_manager.c delete mode 100644 src/zone_manager.h diff --git a/README b/README index 2fd09b5..e90fc26 100644 --- a/README +++ b/README @@ -2,15 +2,9 @@ === The dynamic LDAP back-end is a plug-in for BIND that provides an LDAP -

[Freeipa-devel] [freeipa PR#36] Fix tests for forward zones (opened)

2016-08-29 Thread pspacek
pspacek's pull request #36: "Fix tests for forward zones" was opened PR body: """ """ See the full pull-request at https://github.com/freeipa/freeipa/pull/36 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/36/head:pr36 git

[Freeipa-devel] [freeipa PR#25] Added install check before executing ipa-* command (comment)

2016-08-30 Thread pspacek
pspacek commented on a pull request """ All this is consequence of nonsensical defaults in ipalib.constants module. I would say that this needs to be fixed in a systematic way and not by scattering ifs around. IMHO we need to drop nonsensical defaults form ipalib.constants mod

[Freeipa-devel] [freeipa PR#111][+ack] Prompt for forwarder in dnsforwardzone-add

2016-09-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/111 Title: #111: Prompt for forwarder in dnsforwardzone-add Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#113][opened] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2016-09-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/113 Author: pspacek Title: #113: ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri Action: opened PR body: """ Domain, realm, basedn, xmlrpc_uri, ldap_uri do not have any reasonable default. This patch re

[Freeipa-devel] [freeipa PR#114][opened] Raise errors from service.py:_ldap_mod() by default

2016-09-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/114 Author: pspacek Title: #114: Raise errors from service.py:_ldap_mod() by default Action: opened PR body: """ This is to prevent situations when installer prints CRITICAL Failed to load ldif and continues just to crash l

[Freeipa-devel] [freeipa PR#98][+ack] Make server uninstaller exit with non-zero exit status during failed validation

2016-09-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/98 Title: #98: Make server uninstaller exit with non-zero exit status during failed validation Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#98][comment] Make server uninstaller exit with non-zero exit status during failed validation

2016-09-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/98 Title: #98: Make server uninstaller exit with non-zero exit status during failed validation pspacek commented: """ Works for me! """ See the full comment at https://github.com/freeipa/freeipa/pull/98#issuecom

[Freeipa-devel] [freeipa PR#120][comment] Pretty-print structures in assert_deepequal

2016-09-30 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/120 Title: #120: Pretty-print structures in assert_deepequal pspacek commented: """ ACK as well :-) """ See the full comment at https://github.com/freeipa/freeipa/pull/120#issuecomment-250680762 -- Manage your subs

[Freeipa-devel] [freeipa PR#138][+ack] Fix ipa-cacert-manage man page

2016-10-05 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/138 Title: #138: Fix ipa-cacert-manage man page Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#25][comment] Added install check before executing ipa-* command

2016-10-05 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/25 Title: #25: Added install check before executing ipa-* command pspacek commented: """ Let's wait for https://github.com/freeipa/freeipa/pull/113 . We will see if it improves things or not. """ See the full comment

[Freeipa-devel] [freeipa PR#134][synchronized] DNS URI support

2016-10-06 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Author: pspacek Title: #134: DNS URI support Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/134/head:pr134 git checkout pr134 From

[Freeipa-devel] [freeipa PR#134][synchronized] DNS URI support

2016-10-06 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Author: pspacek Title: #134: DNS URI support Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/134/head:pr134 git checkout pr134 From

[Freeipa-devel] [freeipa PR#134][synchronized] DNS URI support

2016-10-06 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Author: pspacek Title: #134: DNS URI support Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/134/head:pr134 git checkout pr134 From

[Freeipa-devel] [freeipa PR#134][synchronized] DNS URI support

2016-10-06 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Author: pspacek Title: #134: DNS URI support Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/134/head:pr134 git checkout pr134 From

[Freeipa-devel] [freeipa PR#133][opened] Tests: print what was expected from exceptions and callables in xmlrpc_tests

2016-10-04 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/133 Author: pspacek Title: #133: Tests: print what was expected from exceptions and callables in xmlrpc_tests Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghfreeipa https://github

[Freeipa-devel] [freeipa PR#133][synchronized] Tests: print what was expected from exceptions and callables in xmlrpc_tests

2016-10-07 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/133 Author: pspacek Title: #133: Tests: print what was expected from exceptions and callables in xmlrpc_tests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull

[Freeipa-devel] [freeipa PR#134][comment] DNS URI support

2016-10-06 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Title: #134: DNS URI support pspacek commented: """ I was playing with an idea of automatic escaping but it cannot be done with current record format: There is no way to distinguish alredy escaped text from a text which

[Freeipa-devel] [freeipa PR#134][opened] DNS URI support

2016-10-04 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Author: pspacek Title: #134: DNS URI support Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/134/head

[Freeipa-devel] [freeipa PR#134][synchronized] DNS URI support

2016-10-04 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/134 Author: pspacek Title: #134: DNS URI support Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/134/head:pr134 git checkout pr134 From

[Freeipa-devel] [freeipa PR#107][+ack] Update man/help for --server option

2016-09-23 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/107 Title: #107: Update man/help for --server option Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [bind-dyndb-ldap PR#1] [WIP] Port bind-dyndb-ldap to BIND 9.11 (opened)

2016-08-23 Thread pspacek
pspacek's pull request #1: "[WIP] Port bind-dyndb-ldap to BIND 9.11" was opened PR body: This is work in progress patch set, do not merge it yet. See the full pull-request at https://github.com/freeipa/bind-dyndb-ldap/pull/1 ... or pull the PR as Git branch: git remote add ghbind-dyndb-ldap

[Freeipa-devel] [freeipa PR#115][comment] Don't show traceback when ipa config file is not an absolute path

2016-09-27 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/115 Title: #115: Don't show traceback when ipa config file is not an absolute path pspacek commented: """ Why the file must be absolute? I would rather remove this requirement and be done with it. `open()` the file and if it

[Freeipa-devel] [freeipa PR#189][comment] Create relative symbol links

2016-10-27 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/189 Title: #189: Create relative symbol links pspacek commented: """ As I said several times already, all the SPEC file logic is going away. I'm going to reject this as we do not need to change code which is going away and force ever

[Freeipa-devel] [freeipa PR#189][+rejected] Create relative symbol links

2016-10-27 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/189 Title: #189: Create relative symbol links Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#188][comment] Move Python build artefacts to top level directory

2016-10-27 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/188 Title: #188: Move Python build artefacts to top level directory pspacek commented: """ Why this change? It goes against the usual behavior where build artifacts are placed in the same directory as sources. Also, I intend

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 pspacek commented: """ - This version supports lint target and all configuration options for linters listed in the design document. - Fixes in systemd-tmpfiles call from make ins

[Freeipa-devel] [freeipa PR#213][edited] Build system refactoring phase 3

2016-11-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Author: pspacek Title: #213: Build system refactoring phase 3 Action: edited Changed field: body Original value: """ This monster patch-set refactors most of build system and moves most of the logic from SPEC file

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 pspacek commented: """ @tiran > autoconf and automake files are not removed (Makefile.in, /config.sub ...) According to [Automake manual section 13 What Gets Cleaned](https://ww

[Freeipa-devel] [freeipa PR#220][opened] Build: fix make clean to remove build artifacts from top-level directory

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/220 Author: pspacek Title: #220: Build: fix make clean to remove build artifacts from top-level directory Action: opened PR body: """ make lint and make dist were generating files which were not removed by make clean. https://f

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 pspacek commented: """ @tiran > autoconf and automake files are not removed (Makefile.in, /config.sub ...) According to [Automake manual section 13 What Gets Cleaned](https://ww

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 tiran commented: """ memo for me: - [ ] /freeipa*.tar.gz is not removed - [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__ and other pyc/pyo. add ```clean-local: rm -rf

[Freeipa-devel] [freeipa PR#218][+ack] test_ipagetkeytab: use system-wide IPA CA cert location in tests

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/218 Title: #218: test_ipagetkeytab: use system-wide IPA CA cert location in tests Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#218][comment] test_ipagetkeytab: use system-wide IPA CA cert location in tests

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/218 Title: #218: test_ipagetkeytab: use system-wide IPA CA cert location in tests pspacek commented: """ Jenkins tests now pass. """ See the full comment at https://github.com/freeipa/freeipa/pull/218#issuecom

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 tiran commented: """ memo for me: - [ ] /freeipa*.tar.gz is not removed - [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__ and other pyc/pyo. add ```clean-local: rm -rf

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 pspacek commented: """ @tiran > add ipasetup.py to dist_noinst_SCRIPTS ? `ipasetup.py` file is auto-generated from `ipasetup.py.in` so it should not be part of distibution ta

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 pspacek commented: """ @tiran I've tested the find command and it works. The trick is `-o` which acts like OR and allows you to specify different conditions and associate different a

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 tiran commented: """ memo for me: - [ ] /freeipa*.tar.gz is not removed - [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__ and other pyc/pyo. add ```clean-local: rm -rf

[Freeipa-devel] [freeipa PR#221][+ack] gitignore: ignore tar ball

2016-11-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/221 Title: #221: gitignore: ignore tar ball Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#226][synchronized] Build refactoring phase 5

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Author: pspacek Title: #226: Build refactoring phase 5 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/226/head:pr226 git checkout pr226 From

[Freeipa-devel] [freeipa PR#233][opened] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: opened PR body: """ This patch set is based on phase 5 - PR #226. Now all the installation steps (except Python2/3) are handled by make install. Pyt

[Freeipa-devel] [freeipa PR#233][synchronized] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/233/head:pr233 git checkout pr233 From

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup pspacek commented: """ Rebased on top of current master. """ See the full comment at https://github.com/freeipa/freeipa/pull/233#issuecomment-259937908 -- Manage you

[Freeipa-devel] [freeipa PR#213][edited] Build system refactoring phase 3

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Author: pspacek Title: #213: Build system refactoring phase 3 Action: edited Changed field: body Original value: """ This monster patch-set refactors most of build system and moves most of the logic from SPEC file

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup pspacek commented: """ @tiran Please re-review and set review status accordingly. Thanks! """ See the full comment at https://github.com/freeipa/freeipa/pull/233#iss

[Freeipa-devel] [freeipa PR#233][synchronized] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/233/head:pr233 git checkout pr233 From

[Freeipa-devel] [freeipa PR#233][synchronized] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/233/head:pr233 git checkout pr233 From

[Freeipa-devel] [freeipa PR#233][synchronized] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/233/head:pr233 git checkout pr233 From

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup pspacek commented: """ I've fixed incorrect use of `-D` in `install` calls above. """ See the full comment at https://github.com/freeipa/freeipa/pull/233#issuecom

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup pspacek commented: """ > Failed to open: 'freeipa.spec.in', not a valid spec file. Damn it! I added the last commit with comment in SPEC file and did not run tests on that. Surp

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup pspacek commented: """ This version fixes the fixable issues, i.e. everything mentioned above except changing file ownership. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#236][opened] Build phase 7: cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Author: pspacek Title: #236: Build phase 7: cleanup Action: opened PR body: """ Depends on PR #233. - Clean-up ancient leftovers and clean minor bugs here and there. - Support --enable-silent-rules and V=0 variable for make to

[Freeipa-devel] [freeipa PR#213][comment] Build system refactoring phase 3

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Title: #213: Build system refactoring phase 3 tiran commented: """ memo for me: - [ ] /freeipa*.tar.gz is not removed - [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__ and other pyc/pyo. add ```clean-local: rm -rf

[Freeipa-devel] [freeipa PR#226][synchronized] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Author: pspacek Title: #226: Build refactoring phase 5 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/226/head:pr226 git checkout pr226 From

[Freeipa-devel] [freeipa PR#226][synchronized] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Author: pspacek Title: #226: Build refactoring phase 5 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/226/head:pr226 git checkout pr226 From

[Freeipa-devel] [freeipa PR#226][comment] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Title: #226: Build refactoring phase 5 pspacek commented: """ I've added missing files to .gitignore. """ See the full comment at https://github.com/freeipa/freeipa/pull/226#issuecomment-259694249 -- Manage you

[Freeipa-devel] [freeipa PR#226][comment] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Title: #226: Build refactoring phase 5 pspacek commented: """ Rebased on top of current master. """ See the full comment at https://github.com/freeipa/freeipa/pull/226#issuecomment-259695270 -- Manage your subs

[Freeipa-devel] [freeipa PR#213][edited] Build system refactoring phase 3

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Author: pspacek Title: #213: Build system refactoring phase 3 Action: edited Changed field: body Original value: """ This monster patch-set refactors most of build system and moves most of the logic from SPEC file

[Freeipa-devel] [freeipa PR#226][opened] Build refactoring phase 5

2016-11-10 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/226 Author: pspacek Title: #226: Build refactoring phase 5 Action: opened PR body: """ This PR fixes IPA_VERSION_IS_GIT_SNAPSHOT option and vendor version passing from SPEC to configure. At also contains minor cleanup and sr

[Freeipa-devel] [freeipa PR#169][comment] Replace ipaplatform's symlinks with a meta importer

2016-10-19 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/169 Title: #169: Replace ipaplatform's symlinks with a meta importer pspacek commented: """ NACK freeipa-server-4.4.90.201610190959GITf8012c0-0.fc24.x86_64 it broke following call which is used in RPM `%post client` scriptlet: ~

[Freeipa-devel] [freeipa PR#169][comment] Replace ipaplatform's symlinks with a meta importer

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/169 Title: #169: Replace ipaplatform's symlinks with a meta importer pspacek commented: """ Uh, it is quite a lot of code to get rid of few symlinks. Is it worth? @jcholast @mbasti-rh @martbab @tomaskrizek and others? "&quo

[Freeipa-devel] [freeipa PR#170][closed] Mark all phony Makefile targets as .PHONY

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/170 Author: tiran Title: #170: Mark all phony Makefile targets as .PHONY Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/170/head:pr170 git checkout pr170 -- Manage

[Freeipa-devel] [freeipa PR#170][comment] Mark all phony Makefile targets as .PHONY

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/170 Title: #170: Mark all phony Makefile targets as .PHONY pspacek commented: """ Hand-made Makefile is completely going away and will be auto-generated, so we do not need to spend more time on this version. """

[Freeipa-devel] [freeipa PR#170][+rejected] Mark all phony Makefile targets as .PHONY

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/170 Title: #170: Mark all phony Makefile targets as .PHONY Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#169][+ack] Replace ipaplatform's symlinks with __path__

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/169 Title: #169: Replace ipaplatform's symlinks with __path__ Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ @lslebodn Decision if we need client_only build is still open. We may drop it so reimplementing it would be busy work. """ See the full comment

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-19 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ I consider CURL topic to be just bikesheding. Ad POPT: RHEL is going to require explicit configuration as designed in http://www.freeipa.org/page/V4/Build_sys

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-19 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ @lslebodn If you read the pull request description you will notice that client-only build will be solved later on. """ See the full comment at http

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-19 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ Justification is above, please push. """ See the full comment at https://github.com/freeipa/freeipa/pull/171#issuecomment-254800046 -- Manage you

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ Commit 6256e8014aa3d68dc46e6c878be813473bffd1ac breaks pylint because it is not compatible with ipaplatform implementa

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ Commit 6256e8014aa3d68dc46e6c878be813473bffd1ac breaks pylint because it is not compatible with ipaplatform implementa

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ @lslebodn Please discuss this matter on freeipa-devel list to gethigher visibility. Please note that current client-only build is quite broken and requires h

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ Version rebased on top of current master (without PR 171) is available from https://github.com/pspacek/freeipa/tree/pr159-rebase . """

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ This version replaces ipaplatform magic with symlinks generated by configure. It should work with jcholast's PR 159. """ See the full comment

[Freeipa-devel] [bind-dyndb-ldap PR#2][comment] fix ldif syntax and add idnsTemplateAttribute

2016-10-14 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Title: #2: fix ldif syntax and add idnsTemplateAttribute pspacek commented: """ Thanks! I've commited the fix as 17711141882aca3847a5daba2292bcbcc471ec63. """ See the full comment at https://github.com/

[Freeipa-devel] [bind-dyndb-ldap PR#2][closed] fix ldif syntax and add idnsTemplateAttribute

2016-10-14 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Author: stutiredboy Title: #2: fix ldif syntax and add idnsTemplateAttribute Action: closed To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap

[Freeipa-devel] [freeipa PR#132][+ack] Port all setup.py files to setuptools

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#132][comment] Port all setup.py files to setuptools

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools pspacek commented: """ Jenkins does not complain. ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/132#issuecomment-25514270

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ @lslebodn I'm really trying to explain this but I'm still not able to get the point across. > My concerns are related purely to C-code. Please understand that I

[Freeipa-devel] [bind-dyndb-ldap PR#2][+ack] fix ldif syntax and add idnsTemplateAttribute

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Title: #2: fix ldif syntax and add idnsTemplateAttribute Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] WARNING: MERGED [bind-dyndb-ldap PR#3][closed] spec: Add libuuid-devel to BuildRequires

2016-10-18 Thread pspacek
*WARNING: this pull request has been merged!* This is only mirrored repo thus any changes will be erased. Please push commit(s) to authoritative repository. URL: https://github.com/freeipa/bind-dyndb-ldap/pull/3 Author: sgallagher Title: #3: spec: Add libuuid-devel to BuildRequires Action:

[Freeipa-devel] [bind-dyndb-ldap PR#3][+ack] spec: Add libuuid-devel to BuildRequires

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/3 Title: #3: spec: Add libuuid-devel to BuildRequires Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [bind-dyndb-ldap PR#3][reopened] spec: Add libuuid-devel to BuildRequires

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/3 Author: sgallagher Title: #3: spec: Add libuuid-devel to BuildRequires Action: reopened To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap pull/3/head:pr3

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ - python2-dateutil and python2-sss-murmur packages are missing in with_lint condition. - the message from import error was confusing to me: > ipaserver

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ This version fixes minor problems in error reporing and should have no other visible effect. """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ This pull request was (again) rebased on top of PR#171. PR#171 changes ipaplatform handling to symlinks so the issue caused by `__path__` trick shoul

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires pspacek commented: """ This pull request was (again) rebased on top of PR#171. PR#171 changes ipaplatform handling to symlinks so the issue caused by `__path__` trick shoul

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ This PR including additional patches on top have passed build + all XMLRPC tests in Jenkins: job/build_refactoring-build-f24build_refactoring/18/ Additional commi

[Freeipa-devel] [freeipa PR#171][comment] Build system cleanup phase 2

2016-10-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 pspacek commented: """ Re-adding ACK which was removed while we were "resolving" our disagreement with Lukas. """ See the full comment at https://github.c

[Freeipa-devel] [freeipa PR#171][+ack] Build system cleanup phase 2

2016-10-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/171 Title: #171: Build system cleanup phase 2 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#183][comment] Add __name__ == __main__ guards to setup.pys

2016-10-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/183 Title: #183: Add __name__ == __main__ guards to setup.pys pspacek commented: """ @tiran PEP8 errors need to be fixed first: ~~~ ./ipaclient/setup.py:28:80: E501 line too long (80 > 79 characters) ./ipalib/setup.py:28:80: E501

[Freeipa-devel] [freeipa PR#159][+ack] spec file: clean up BuildRequires

2016-10-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#175][comment] Remove ipapython/ipa.conf

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/175 Title: #175: Remove ipapython/ipa.conf pspacek commented: """ Sorry for the confusing here. Marking as rejected so it does not pop out in reports. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#175][comment] Remove ipapython/ipa.conf

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/175 Title: #175: Remove ipapython/ipa.conf pspacek commented: """ Sorry for the confusing here. Marking as rejected so it does not pop out in reports. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#175][+rejected] Remove ipapython/ipa.conf

2016-10-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/175 Title: #175: Remove ipapython/ipa.conf Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#155][synchronized] Build system cleanup

2016-10-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/155 Author: pspacek Title: #155: Build system cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/155/head:pr155 git checkout pr155 From

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-14 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ Hi Lukas. Given there is no technical justification to have it I'm going to remove these. Simple is better than complex. """ See the full comment at http

[Freeipa-devel] [freeipa PR#237][synchronized] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-14 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Author: pspacek Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/237

  1   2   3   >