[Freeipa-devel] [bind-dyndb-ldap PR#8][+ack] Log when pointers are different

2017-01-31 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/8 Title: #8: Log when pointers are different Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [bind-dyndb-ldap PR#8][closed] Log when pointers are different

2017-01-31 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/8 Author: pemensik Title: #8: Log when pointers are different Action: closed To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap pull/8/head:pr8 git checkout

[Freeipa-devel] [bind-dyndb-ldap PR#8][+pushed] Log when pointers are different

2017-01-31 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/8 Title: #8: Log when pointers are different Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [bind-dyndb-ldap PR#8][comment] Log when pointers are different

2017-01-31 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/8 Title: #8: Log when pointers are different tomaskrizek commented: """ Thanks, this should help with the future debugging efforts. Fixed upstream: [ec2e125ed1b81c41448f699c8df54da66fbc5e8c](https://git.fedorahosted.org/

[Freeipa-devel] [freeipa PR#426][comment] DNSSEC: forwarders validation improvement

2017-02-07 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/426 Title: #426: DNSSEC: forwarders validation improvement tomaskrizek commented: """ I think the same issue can also occur in `validate_dnssec_zone_forwarder_step2()`. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#437][comment] FIPS: replica install check

2017-02-07 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Title: #437: FIPS: replica install check tomaskrizek commented: """ Thanks for the feedback. Hopefully I addressed all the concerns above in the update. """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-07 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#423][comment] dns-update-system-records: add support for nsupdate output format

2017-02-07 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/423 Title: #423: dns-update-system-records: add support for nsupdate output format tomaskrizek commented: """ I added some in-line comments/questions. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#426][+ack] DNSSEC: forwarders validation improvement

2017-02-08 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/426 Title: #426: DNSSEC: forwarders validation improvement Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-08 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#451][comment] certdb: remove unused keysize property

2017-02-08 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/451 Title: #451: certdb: remove unused keysize property tomaskrizek commented: """ Commit that removed valid_moths property: e736e75ce9724ae8298a5b69d093313cd6e62b60 """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-08 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ @tiran Do you need `make dist` for anything? I'm not aware of any plans to release client-only IPA sources, so I don't think it's needed. "&quo

[Freeipa-devel] [freeipa PR#451][synchronized] certdb: remove unused keysize property

2017-02-08 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/451 Author: tomaskrizek Title: #451: certdb: remove unused keysize property Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/451/head:pr451 git checkout pr451

[Freeipa-devel] [freeipa PR#451][opened] certdb: remove unused keysize property

2017-02-08 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/451 Author: tomaskrizek Title: #451: certdb: remove unused keysize property Action: opened PR body: """ Keysize property is no longer used anywhere in the code. It was originally introduced for the request_cert function, which was l

[Freeipa-devel] [freeipa PR#437][opened] FIPS: replica install check

2017-02-06 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: opened PR body: """ PR depends on the rest of the FIPS patches. """ To pull the PR as Git branch: git remote add ghfreeipa https://github

[Freeipa-devel] [freeipa PR#437][comment] FIPS: replica install check

2017-02-06 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Title: #437: FIPS: replica install check tomaskrizek commented: """ @MartinBasti Since this check is performed only during installation, the user could simply install non-FIPS replica and then turn FIPS on afterwards. There

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-06 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-06 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-08 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#359][comment] dogtag: search past the first 100 certificates

2017-01-23 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates tomaskrizek commented: """ The behavior of the command seems to be correct now, but I'm also not sure about the WebUI. There seems to be a limit of 20 items when dis

[Freeipa-devel] [freeipa PR#347][+ack] Improvements in {get|set}_directive functions

2017-01-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions

2017-01-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions tomaskrizek commented: """ I wasn't able to find any more issues with the quoting of certificate names. The directive quoting seems to work properly now. "&quo

[Freeipa-devel] [freeipa PR#359][+ack] dogtag: search past the first 100 certificates

2017-01-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#359][comment] dogtag: search past the first 100 certificates

2017-01-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates tomaskrizek commented: """ We examined the WebUI side and it behaves as expected - the size limit is respected when viewing certificates. """

[Freeipa-devel] [freeipa PR#395][comment] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-01-25 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" tomaskrizek commented: """ Since the bug is completely fixed on the PKI side, shouldn't we bump the `Requires` to require the

[Freeipa-devel] [freeipa PR#395][comment] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-01-25 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" tomaskrizek commented: """ **ACK** for z-stream with the patched PKI. Waiting for the PKI release and bump of `Requires` to ack an

[Freeipa-devel] [freeipa PR#395][comment] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-01-25 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" tomaskrizek commented: """ **ACK** for z-stream with the patched PKI. Waiting for the PKI release and bump of `Requires` to ack an

[Freeipa-devel] [bind-dyndb-ldap PR#7][synchronized] Added named.conf API transformation script to spec

2017-01-26 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/7 Author: tomaskrizek Title: #7: Added named.conf API transformation script to spec Action: synchronized To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap

[Freeipa-devel] [freeipa PR#351][synchronized] [fedora-26] named.conf template: update API for bind 9.11

2017-01-26 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/351 Author: tomaskrizek Title: #351: [fedora-26] named.conf template: update API for bind 9.11 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/351/head:pr351

[Freeipa-devel] [freeipa PR#351][synchronized] [fedora-26] named.conf template: update API for bind 9.11

2017-01-26 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/351 Author: tomaskrizek Title: #351: [fedora-26] named.conf template: update API for bind 9.11 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/351/head:pr351

[Freeipa-devel] [freeipa PR#351][comment] [fedora-26] named.conf template: update API for bind 9.11

2017-01-26 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/351 Title: #351: [fedora-26] named.conf template: update API for bind 9.11 tomaskrizek commented: """ I've updated the version of BIND and the patch should be complete. I suggest we do a review (you can use https://copr.fedorainfra

[Freeipa-devel] [freeipa PR#482][comment] Remove MD5 certificate fingerprints

2017-02-21 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Remove MD5 certificate fingerprints tomaskrizek commented: """ @stlaz I think it'd be good to discuss this change on freeipa-devel. Also, since we're removing md5, I'd consider adding sha256. """

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tomaskrizek commented: """ I'm not able to run autoreconf, it fails with the following error: ``` configure.ac:447: error: required file 'init/tmpfilesd/Makefile.in' not found asn1/Makefile

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ The PR works and the `--without-ipatests` option omits the ipatests directory. However, #494 doesn't install extra dependencies with `mock -

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tomaskrizek commented: """ @lslebodn My bad, there was some leftover stuff that `git clean -dfx` didn't clear for some reason. Nevertheless, this does work and allows a client only, as wel

[Freeipa-devel] [freeipa PR#478][+ack] [4.4] Do not configure PKI ajp redirection to use "::1"

2017-02-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/478 Title: #478: [4.4] Do not configure PKI ajp redirection to use "::1" Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#482][comment] Don't count service/host/user cert md5 fprints in FIPS

2017-02-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Don't count service/host/user cert md5 fprints in FIPS tomaskrizek commented: """ @rcritten Currently, the tests fail because we need #437 merged. It would be caught. @MartinBasti The only other option I see is t

[Freeipa-devel] [freeipa PR#482][comment] Don't count service/host/user cert md5 fprints in FIPS

2017-02-20 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Don't count service/host/user cert md5 fprints in FIPS tomaskrizek commented: """ Actually, we don't need to provide `md5_fingerprint` at all in FIPS, since the attribute is marked as `vritual_attribute`. "&quo

[Freeipa-devel] [freeipa PR#504][comment] Add SHA256 fingerprints

2017-02-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/504 Title: #504: Add SHA256 fingerprints tomaskrizek commented: """ I've dropped the commit that modified the deprecated file. """ See the full comment at https://github.com/freeipa/freeipa/pull/504#issuecom

[Freeipa-devel] [freeipa PR#504][synchronized] Add SHA256 fingerprints

2017-02-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/504 Author: tomaskrizek Title: #504: Add SHA256 fingerprints Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/504/head:pr504 git checkout pr504 From

[Freeipa-devel] [freeipa PR#504][opened] Add SHA256 fingerprints

2017-02-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/504 Author: tomaskrizek Title: #504: Add SHA256 fingerprints Action: opened PR body: """ As discussed on the [devel list](https://www.redhat.com/archives/freeipa-devel/2017-February/msg01095.html), adding SHA256 fingerprints for ce

[Freeipa-devel] [freeipa PR#504][synchronized] Add SHA256 fingerprints

2017-02-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/504 Author: tomaskrizek Title: #504: Add SHA256 fingerprints Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/504/head:pr504 git checkout pr504 From

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-23 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/484 Title: #484: FIPS: Remove pkispawn cruft tomaskrizek commented: """ Works as expected. """ See the full comment at https://github.com/freeipa/freeipa/pull/484#issuecomment-281979229 -- Manage your subscription

[Freeipa-devel] [freeipa PR#412][comment] Define template version in certmap.conf

2017-02-23 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/412 Title: #412: Define template version in certmap.conf tomaskrizek commented: """ Works as expected. """ See the full comment at https://github.com/freeipa/freeipa/pull/412#issuecomment-28194 -- Manage your subs

[Freeipa-devel] [freeipa PR#412][+ack] Define template version in certmap.conf

2017-02-23 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/412 Title: #412: Define template version in certmap.conf Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#482][+ack] Remove MD5 certificate fingerprints

2017-02-23 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Remove MD5 certificate fingerprints Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#482][comment] Remove MD5 certificate fingerprints

2017-02-23 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Remove MD5 certificate fingerprints tomaskrizek commented: """ ACK, there is no disagreement on the freeipa-devel. I'm already working on replacing SHA1 with SHA256 given the [recent events](https://security.googleb

[Freeipa-devel] [freeipa PR#484][+ack] FIPS: Remove pkispawn cruft

2017-02-23 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/484 Title: #484: FIPS: Remove pkispawn cruft Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#500][opened] Replace sha1 fingerprints with sha256

2017-02-23 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/500 Author: tomaskrizek Title: #500: Replace sha1 fingerprints with sha256 Action: opened PR body: """ - we probably want to keep SHA1 for DNS SSHFP (along with SHA256) - removing SHA1 from RSA-OAEP probably doesn't have any

[Freeipa-devel] [freeipa PR#395][+ack] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-02-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#482][comment] Remove MD5 certificate fingerprints

2017-02-21 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Remove MD5 certificate fingerprints tomaskrizek commented: """ Btw, I think sha256 can be added in a separate PR. Let's just wait if there are any concerns about removing md5 on the freeipa-devel. """

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-21 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [bind-dyndb-ldap PR#9][+ack] Remove duplicate const declaration specifier

2017-02-14 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Title: #9: Remove duplicate const declaration specifier Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#451][synchronized] certdb: remove unused keysize property

2017-02-09 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/451 Author: tomaskrizek Title: #451: certdb: remove unused keysize property Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/451/head:pr451 git checkout pr451

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-09 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ Server build works now, but there's still the `make dist` issue discussed above. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#451][comment] certdb: remove unused keysize property

2017-02-09 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/451 Title: #451: certdb: remove unused keysize property tomaskrizek commented: """ @frasertweedale Fixed. """ See the full comment at https://github.com/freeipa/freeipa/pull/451#issuecomment-278590229 -- Manage you

[Freeipa-devel] [freeipa PR#423][comment] dns-update-system-records: add support for nsupdate output format

2017-02-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/423 Title: #423: dns-update-system-records: add support for nsupdate output format tomaskrizek commented: """ Please update the ticket in trac/JIRA to mentiond the command does not support stdout. LGTM otherwise. """

[Freeipa-devel] [freeipa PR#423][+ack] dns-update-system-records: add support for nsupdate output format

2017-02-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/423 Title: #423: dns-update-system-records: add support for nsupdate output format Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [bind-dyndb-ldap PR#9][+pushed] Remove duplicate const declaration specifier

2017-02-14 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Title: #9: Remove duplicate const declaration specifier Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [bind-dyndb-ldap PR#9][closed] Remove duplicate const declaration specifier

2017-02-14 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Author: tomaskrizek Title: #9: Remove duplicate const declaration specifier Action: closed To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap pull/9

[Freeipa-devel] [bind-dyndb-ldap PR#9][comment] Remove duplicate const declaration specifier

2017-02-14 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Title: #9: Remove duplicate const declaration specifier tomaskrizek commented: """ Fixed upstream. master - f76ca3b3a4c2c030071dd23c706d8cc06e1fa2a9 """ See the full comment at https://github.com/

[Freeipa-devel] [bind-dyndb-ldap PR#9][comment] Remove duplicate const declaration specifier

2017-02-14 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Title: #9: Remove duplicate const declaration specifier tomaskrizek commented: """ @pemensik Thanks for review! """ See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/9#issuecom

[Freeipa-devel] [bind-dyndb-ldap PR#9][comment] Remove duplicate const declaration specifier

2017-02-13 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Title: #9: Remove duplicate const declaration specifier tomaskrizek commented: """ @pemensik Hi, could you please take a look at this PR and ACK? It's just a typo that was preventing a build on fedora rawhide to due

[Freeipa-devel] [freeipa PR#445][+ack] Remove is_fips_enabled checks in installers and ipactl

2017-02-13 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/445 Title: #445: Remove is_fips_enabled checks in installers and ipactl Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#461][opened] Bump required version of bind-dyndb-ldap to 11.0-2

2017-02-13 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/461 Author: tomaskrizek Title: #461: Bump required version of bind-dyndb-ldap to 11.0-2 Action: opened PR body: """ Fedora release bind-dyndb-ldap 11.0-2 transforms existing named.conf old style API to the new style API. This

[Freeipa-devel] [bind-dyndb-ldap PR#7][synchronized] Added named.conf API transformation script to spec

2017-02-09 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/7 Author: tomaskrizek Title: #7: Added named.conf API transformation script to spec Action: synchronized To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap

[Freeipa-devel] [bind-dyndb-ldap PR#7][closed] Added named.conf API transformation script to spec

2017-02-09 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/7 Author: tomaskrizek Title: #7: Added named.conf API transformation script to spec Action: closed To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap pull/7

[Freeipa-devel] [bind-dyndb-ldap PR#7][+pushed] Added named.conf API transformation script to spec

2017-02-09 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/7 Title: #7: Added named.conf API transformation script to spec Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [bind-dyndb-ldap PR#7][comment] Added named.conf API transformation script to spec

2017-02-09 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/7 Title: #7: Added named.conf API transformation script to spec tomaskrizek commented: """ master: - [f1028150504049a64b6c34c785c6a20e2a7ca76a](https://git.fedorahosted.org/cgit/bind-dyndb-ldap

[Freeipa-devel] [freeipa PR#456][opened] bindinstance: fix named.conf parsing regexs

2017-02-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/456 Author: tomaskrizek Title: #456: bindinstance: fix named.conf parsing regexs Action: opened PR body: """ Since named.conf API for bind-dyndb-ldap was updated, our parsing regexes have to change. https://fedorahosted.org/free

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#396][comment] Explicitly remove support of SSLv2

2017-02-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/396 Title: #396: Explicitly remove support of SSLv2 tomaskrizek commented: """ Please update the commit title and description to make it clear that it also removes support of SSLv3. """ See the full comment at http

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ ACK, I'm fine with pushing this PR. `make install` does install ipatests for client-only build, other server-related packages are omitted. Server

[Freeipa-devel] [freeipa PR#396][+ack] Explicitly remove support of SSLv2

2017-02-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/396 Title: #396: Explicitly remove support of SSLv2 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#450][+ack] Add FIPS-token password of HTTPD NSS database

2017-02-15 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/450 Title: #450: Add FIPS-token password of HTTPD NSS database Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-15 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-15 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-15 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-09 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [bind-dyndb-ldap PR#9][opened] Remove duplicate const declaration specifier

2017-02-13 Thread tomaskrizek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/9 Author: tomaskrizek Title: #9: Remove duplicate const declaration specifier Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyn

[Freeipa-devel] [freeipa PR#446][+ack] Add password file to certutil calls in ipapython.certdb module

2017-02-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/446 Title: #446: Add password file to certutil calls in ipapython.certdb module Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]

2017-01-18 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] tomaskrizek commented: """ I agree with @tiran here. Even though `>= 10.2.1` will match the correct package, I don't think it's a good practice to use non-existe

[Freeipa-devel] [freeipa PR#389][+ack] Fix build in mock

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/389 Title: #389: Fix build in mock Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#389][comment] Fix build in mock

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/389 Title: #389: Fix build in mock tomaskrizek commented: """ Thanks for the fix and explanation! """ See the full comment at https://github.com/freeipa/freeipa/pull/389#issuecomment-273206316 -- Manage your subs

[Freeipa-devel] [freeipa PR#395][+ack] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-01-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#395][comment] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-01-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" tomaskrizek commented: """ @flo You're right, I'm able to install the IPA server in IPv6 env now. I probably forgot some configura

[Freeipa-devel] [freeipa PR#351][synchronized] [fedora-26] named.conf template: update API for bind 9.11

2017-01-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/351 Author: tomaskrizek Title: #351: [fedora-26] named.conf template: update API for bind 9.11 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/351/head:pr351

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ I'm not really experienced with autotools, so I do not want to ack this PR without someone else taking a look. I'm also not sure about the

[Freeipa-devel] [freeipa PR#179][+ack] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#179][comment] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig tomaskrizek commented: """ Since there's been no suggestions for a more descriptive error message -> ack. """ See the full comment at https://gi

[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions tomaskrizek commented: """ I still managed to find a an issue for certain edge cases. See inline comments for more info. """ See the full comment at http

[Freeipa-devel] [freeipa PR#390][+ack] WebUI: Fix Coverity JS bugs

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/390 Title: #390: WebUI: Fix Coverity JS bugs Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]

2017-01-18 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] tomaskrizek commented: """ @HonzaCholasta Perhaps it's more of a personal preference, but I'd rather see an existing version of a certain package. Since the spec fi

[Freeipa-devel] [freeipa PR#512][opened] test_config: fix fips_mode key in Env

2017-02-27 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/512 Author: tomaskrizek Title: #512: test_config: fix fips_mode key in Env Action: opened PR body: """ Setting fips_mode to object would fail if ipaplatform.tasks module wasn't present. https://fedorahosted.org/freeipa/ticket/56

[Freeipa-devel] [freeipa PR#512][synchronized] test_config: fix fips_mode key in Env

2017-02-27 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/512 Author: tomaskrizek Title: #512: test_config: fix fips_mode key in Env Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/512/head:pr512 git checkout pr512

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-02 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional tomaskrizek commented: """ Since `--without-jslint` was removed, there's actually no way to explicitly turn off jsl (it will always be autodetected). I tried to set `--with-jslint=no`,

[Freeipa-devel] [freeipa PR#529][opened] installer: update time estimates

2017-03-01 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/529 Author: tomaskrizek Title: #529: installer: update time estimates Action: opened PR body: """ Time estimates have been updated to be more accurate. Only tasks that are estimated to take longer than 10 seconds have the estimate di

[Freeipa-devel] [freeipa PR#530][opened] man: update ipa-cacert-manage

2017-03-01 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/530 Author: tomaskrizek Title: #530: man: update ipa-cacert-manage Action: opened PR body: """ Make it clear this command is used to only renew certificate for the CA and provide guidance on how to renew other certificates. ht

[Freeipa-devel] [freeipa PR#504][synchronized] Add SHA256 fingerprints

2017-03-02 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/504 Author: tomaskrizek Title: #504: Add SHA256 fingerprints Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/504/head:pr504 git checkout pr504 From

[Freeipa-devel] [freeipa PR#504][synchronized] Add SHA256 fingerprints

2017-03-02 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/504 Author: tomaskrizek Title: #504: Add SHA256 fingerprints Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/504/head:pr504 git checkout pr504 From

  1   2   3   4   5   6   7   >