Re: [Freeipa-devel] [PATCH] 0005 Add list of domains associated to our realm to cn=etc
Hi, On 12.2.2013 17:27, Ana Krivokapic wrote: Add new LDAP container to store the list of domains associated with IPA realm. Add two new ipa commands (ipa realmdomains-show and ipa realmdomains-mod) to allow manipulation of the list of realm domains. Unit test file covering these new commands was added. https://fedorahosted.org/freeipa/ticket/2945 I have just noticed a failure in the test for this: Traceback (most recent call last): File /usr/lib/python2.7/site-packages/nose/loader.py, line 390, in loadTestsFromName addr.filename, addr.module) File /usr/lib/python2.7/site-packages/nose/importer.py, line 39, in importFromPath return self.importFromDir(dir_path, fqname) File /usr/lib/python2.7/site-packages/nose/importer.py, line 86, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File /home/jcholast/freeipa/tests/test_xmlrpc/test_realmdomains_plugin.py, line 35, in module bad_domain = u'this-domain-does-not-exist-%s.com' % ''.join(random.choice(string.lowercase) for x in range(10)) UnicodeDecodeError: 'utf8' codec can't decode byte 0xed in position 0: invalid continuation byte This is happening because string.lowercase is locale-dependent, so it might contain bad values, such as '\xed'. Please use string.ascii_lowercase instead to prevent this. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0005 Add list of domains associated to our realm to cn=etc
On 02/25/2013 04:10 PM, Jan Cholasta wrote: Hi, On 12.2.2013 17:27, Ana Krivokapic wrote: Add new LDAP container to store the list of domains associated with IPA realm. Add two new ipa commands (ipa realmdomains-show and ipa realmdomains-mod) to allow manipulation of the list of realm domains. Unit test file covering these new commands was added. https://fedorahosted.org/freeipa/ticket/2945 I have just noticed a failure in the test for this: Traceback (most recent call last): File /usr/lib/python2.7/site-packages/nose/loader.py, line 390, in loadTestsFromName addr.filename, addr.module) File /usr/lib/python2.7/site-packages/nose/importer.py, line 39, in importFromPath return self.importFromDir(dir_path, fqname) File /usr/lib/python2.7/site-packages/nose/importer.py, line 86, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File /home/jcholast/freeipa/tests/test_xmlrpc/test_realmdomains_plugin.py, line 35, in module bad_domain = u'this-domain-does-not-exist-%s.com' % ''.join(random.choice(string.lowercase) for x in range(10)) UnicodeDecodeError: 'utf8' codec can't decode byte 0xed in position 0: invalid continuation byte This is happening because string.lowercase is locale-dependent, so it might contain bad values, such as '\xed'. Please use string.ascii_lowercase instead to prevent this. Honza Thanks for the catch. I believe it is already fixed: https://www.redhat.com/archives/freeipa-devel/2013-February/msg00347.html -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0005 Add list of domains associated to our realm to cn=etc
On 25.2.2013 16:29, Ana Krivokapic wrote: On 02/25/2013 04:10 PM, Jan Cholasta wrote: Hi, On 12.2.2013 17:27, Ana Krivokapic wrote: Add new LDAP container to store the list of domains associated with IPA realm. Add two new ipa commands (ipa realmdomains-show and ipa realmdomains-mod) to allow manipulation of the list of realm domains. Unit test file covering these new commands was added. https://fedorahosted.org/freeipa/ticket/2945 I have just noticed a failure in the test for this: Traceback (most recent call last): File /usr/lib/python2.7/site-packages/nose/loader.py, line 390, in loadTestsFromName addr.filename, addr.module) File /usr/lib/python2.7/site-packages/nose/importer.py, line 39, in importFromPath return self.importFromDir(dir_path, fqname) File /usr/lib/python2.7/site-packages/nose/importer.py, line 86, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File /home/jcholast/freeipa/tests/test_xmlrpc/test_realmdomains_plugin.py, line 35, in module bad_domain = u'this-domain-does-not-exist-%s.com' % ''.join(random.choice(string.lowercase) for x in range(10)) UnicodeDecodeError: 'utf8' codec can't decode byte 0xed in position 0: invalid continuation byte This is happening because string.lowercase is locale-dependent, so it might contain bad values, such as '\xed'. Please use string.ascii_lowercase instead to prevent this. Honza Thanks for the catch. I believe it is already fixed: https://www.redhat.com/archives/freeipa-devel/2013-February/msg00347.html Oh, OK :) -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0005 Add list of domains associated to our realm to cn=etc
On Wed, 13 Feb 2013, Alexander Bokovoy wrote: On Tue, 12 Feb 2013, Ana Krivokapic wrote: Add new LDAP container to store the list of domains associated with IPA realm. Add two new ipa commands (ipa realmdomains-show and ipa realmdomains-mod) to allow manipulation of the list of realm domains. Unit test file covering these new commands was added. https://fedorahosted.org/freeipa/ticket/2945 ACK, works perfectly. We need to decide on the questions still open in the http://www.freeipa.org/page/V3/Realm_Domains but the decision should not prevent this work from being committed. Committed to master along with a one-liner that limits ipasam to look only at $SUFFIX with base scope when searching for its own domain name as now we use domainRelatedObject in two different places and previous subtree search now gives too wide answer. -- / Alexander Bokovoy ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0005 Add list of domains associated to our realm to cn=etc
Alexander Bokovoy wrote: On Wed, 13 Feb 2013, Alexander Bokovoy wrote: On Tue, 12 Feb 2013, Ana Krivokapic wrote: Add new LDAP container to store the list of domains associated with IPA realm. Add two new ipa commands (ipa realmdomains-show and ipa realmdomains-mod) to allow manipulation of the list of realm domains. Unit test file covering these new commands was added. https://fedorahosted.org/freeipa/ticket/2945 ACK, works perfectly. We need to decide on the questions still open in the http://www.freeipa.org/page/V3/Realm_Domains but the decision should not prevent this work from being committed. Committed to master along with a one-liner that limits ipasam to look only at $SUFFIX with base scope when searching for its own domain name as now we use domainRelatedObject in two different places and previous subtree search now gives too wide answer. Pushed patch (and 1-liner to ipa-3-1) rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0005 Add list of domains associated to our realm to cn=etc
On Tue, 12 Feb 2013, Ana Krivokapic wrote: Add new LDAP container to store the list of domains associated with IPA realm. Add two new ipa commands (ipa realmdomains-show and ipa realmdomains-mod) to allow manipulation of the list of realm domains. Unit test file covering these new commands was added. https://fedorahosted.org/freeipa/ticket/2945 ACK, works perfectly. We need to decide on the questions still open in the http://www.freeipa.org/page/V3/Realm_Domains but the decision should not prevent this work from being committed. Thanks! -- / Alexander Bokovoy ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
