[Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Alexander Bokovoy
https://fedorahosted.org/freeipa/ticket/1368 also replaces a tab by spaces in one else statement (cosmetic). -- / Alexander Bokovoy From bc02d3098671a2284b5764205b893facdeacf80e Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy aboko...@redhat.com Date: Tue, 19 Jul 2011 15:33:53 +0300 Subject:

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Martin Kosek
On Fri, 2011-07-29 at 11:42 +0300, Alexander Bokovoy wrote: https://fedorahosted.org/freeipa/ticket/1368 also replaces a tab by spaces in one else statement (cosmetic). This works fine. But I have few suggestion for improvement: 1) Shouldn't we also run `hostname NEW_HOSTNAME` so that the

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Alexander Bokovoy
On 29.07.2011 12:01, Martin Kosek wrote: On Fri, 2011-07-29 at 11:42 +0300, Alexander Bokovoy wrote: https://fedorahosted.org/freeipa/ticket/1368 also replaces a tab by spaces in one else statement (cosmetic). This works fine. But I have few suggestion for improvement: 1) Shouldn't we

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Martin Kosek
On Fri, 2011-07-29 at 12:46 +0300, Alexander Bokovoy wrote: On 29.07.2011 12:21, Alexander Bokovoy wrote: On 29.07.2011 12:01, Martin Kosek wrote: On Fri, 2011-07-29 at 11:42 +0300, Alexander Bokovoy wrote: https://fedorahosted.org/freeipa/ticket/1368 also replaces a tab by spaces in

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Alexander Bokovoy
On 29.07.2011 13:52, Martin Kosek wrote: Oh, this is not informative at all. I'll get this updated. Updated patch attached. Ok, hostname is properly changed now. I still have some issues: 1) Updated --hostname help doc line in the source code is too long. This should be split. Now it uses

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Alexander Bokovoy
On 29.07.2011 14:53, Alexander Bokovoy wrote: On 29.07.2011 13:52, Martin Kosek wrote: Oh, this is not informative at all. I'll get this updated. Updated patch attached. Ok, hostname is properly changed now. I still have some issues: Updated again to use more reliable regexp for parsing.

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Martin Kosek
On Fri, 2011-07-29 at 16:05 +0300, Alexander Bokovoy wrote: On 29.07.2011 14:53, Alexander Bokovoy wrote: On 29.07.2011 13:52, Martin Kosek wrote: Oh, this is not informative at all. I'll get this updated. Updated patch attached. Ok, hostname is properly changed now. I still have some

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Alexander Bokovoy
On 29.07.2011 16:25, Martin Kosek wrote: On Fri, 2011-07-29 at 16:05 +0300, Alexander Bokovoy wrote: On 29.07.2011 14:53, Alexander Bokovoy wrote: On 29.07.2011 13:52, Martin Kosek wrote: Oh, this is not informative at all. I'll get this updated. Updated patch attached. Ok, hostname is

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Alexander Bokovoy
On 29.07.2011 17:06, Alexander Bokovoy wrote: There was wrong comparison (I wanted to check if option is not None and then compare it to 'HOSTNAME' but brain short-circuited. My bad. ... and one more update, to get common style for comparisons. -- / Alexander Bokovoy From

Re: [Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

2011-07-29 Thread Martin Kosek
On Fri, 2011-07-29 at 17:06 +0300, Alexander Bokovoy wrote: On 29.07.2011 16:25, Martin Kosek wrote: On Fri, 2011-07-29 at 16:05 +0300, Alexander Bokovoy wrote: On 29.07.2011 14:53, Alexander Bokovoy wrote: On 29.07.2011 13:52, Martin Kosek wrote: Oh, this is not informative at all. I'll