Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Petr Vobornik]

On 06/06/2016 08:33 PM, Pavel Vomacka wrote:
> 
> 
> On 06/06/2016 07:03 PM, Petr Vobornik wrote:
>> On 06/06/2016 12:27 PM, Pavel Vomacka wrote:
>>>
>>> On 06/02/2016 06:22 PM, Petr Vobornik wrote:
 On 06/01/2016 10:41 AM, Pavel Vomacka wrote:
> On 05/27/2016 05:58 PM, Pavel Vomacka wrote:
>> On 05/27/2016 05:44 PM, Nathaniel McCallum wrote:
>>> On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:
 On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:
> On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:
>> Hi,
>>
>> the patch adds webui part for authentication indicators.
>>
>> Ticket: https://fedorahosted.org/freeipa/ticket/5872
> The otp option displays as: OTP.
> The radius option displays as: Radius.
>
> However, both are acronyms. The capitalization should be
> consistent.
 I'm sorry for late answer. They are displayed this way: 'OTP' and
 'Radius'. So it should not require any change.
>>> That is incorrect. It should be: OTP and RADIUS.
>> I'm sorry, I didn't understand correctly. Fixed patch attached.
>>
>>
>>
> The last patch changes the 'Radius' to 'RADIUS' in whole WebUI.
>
 After some though, we should really support the arbitrary values
 also in
 Web UI.

 I'd reuse aci.attributes_widget - move the widget elsewhere, make it a
 general widget and a base class for the original aci.attributes_widget.

 The only difference should be populate method and some strings.

 The base widget can populate from options - same as normal checkboxes
 widget so that service page doesn't need to inherit from the base
 class.

>>> Ok, thank you for advice. The edited patch is attached.
>>
>> 1. The new base class should have different name, e.g.
>> custom_checkboxes_widget . It is not related to (aci) attributes.
>>
>> Then it can be registered as such widget and the attributes widget can
>> be registered in ACI plugin. It would then also remove the ugly usage of
>> both $type and $factory.
> Fixed.
>>
>> 2. Why not implement empty placeholder populate function in the base
>> class? Then
>>if (that.populate && typeof that.populate === 'function')
>> that.populate();
>>
>> could be changed into:
>>that.populate();
>>
>> Child class should simply override.
> I just did not like a empty method there. But it's true that it is more
> readable with empty method and the method is documented.
>>
>> 3. If I add a custom indicator to one server and then switch to another.
>> It will offer the custom option as well, but unchecked. The added
>> options are not cleared on page reset. I'm not sure if it should be
>> called a feature or a bug. It is remnant of the original implementation.
> From my point of view it is a feature. I.e. When I add custom
> authentication indicator to one service there is a big chance that I
> would like to add it to another one. And in this case the custom auth.
> ind. is already present.
> 
> Fixed patch attached.
> 
> -- 
> Pavel^3 Vomacka

I've fixed trailing whitespace error on line:

"* Additional options "

And also a typo("custom_checkobox_widget") in commit message is fixed.

ACK

master:
* afededacb92ce1903885b265c7adca87b634c21a Auth Indicators WebUI part
-- 
Petr Vobornik

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Pavel Vomacka]

On 06/06/2016 07:03 PM, Petr Vobornik wrote:

On 06/06/2016 12:27 PM, Pavel Vomacka wrote:


On 06/02/2016 06:22 PM, Petr Vobornik wrote:

On 06/01/2016 10:41 AM, Pavel Vomacka wrote:

On 05/27/2016 05:58 PM, Pavel Vomacka wrote:

On 05/27/2016 05:44 PM, Nathaniel McCallum wrote:

On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:

On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:

On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:

Hi,

the patch adds webui part for authentication indicators.

Ticket: https://fedorahosted.org/freeipa/ticket/5872

The otp option displays as: OTP.
The radius option displays as: Radius.

However, both are acronyms. The capitalization should be
consistent.

I'm sorry for late answer. They are displayed this way: 'OTP' and
'Radius'. So it should not require any change.

That is incorrect. It should be: OTP and RADIUS.

I'm sorry, I didn't understand correctly. Fixed patch attached.




The last patch changes the 'Radius' to 'RADIUS' in whole WebUI.


After some though, we should really support the arbitrary values also in
Web UI.

I'd reuse aci.attributes_widget - move the widget elsewhere, make it a
general widget and a base class for the original aci.attributes_widget.

The only difference should be populate method and some strings.

The base widget can populate from options - same as normal checkboxes
widget so that service page doesn't need to inherit from the base class.


Ok, thank you for advice. The edited patch is attached.


1. The new base class should have different name, e.g.
custom_checkboxes_widget . It is not related to (aci) attributes.

Then it can be registered as such widget and the attributes widget can
be registered in ACI plugin. It would then also remove the ugly usage of
both $type and $factory.

Fixed.


2. Why not implement empty placeholder populate function in the base
class? Then
   if (that.populate && typeof that.populate === 'function') that.populate();

could be changed into:
   that.populate();

Child class should simply override.
I just did not like a empty method there. But it's true that it is more 
readable with empty method and the method is documented.


3. If I add a custom indicator to one server and then switch to another.
It will offer the custom option as well, but unchecked. The added
options are not cleared on page reset. I'm not sure if it should be
called a feature or a bug. It is remnant of the original implementation.
From my point of view it is a feature. I.e. When I add custom 
authentication indicator to one service there is a big chance that I 
would like to add it to another one. And in this case the custom auth. 
ind. is already present.


Fixed patch attached.

--
Pavel^3 Vomacka
From e15dd899ce14e6df6ad1be6bd1c00488908e3c06 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Mon, 6 Jun 2016 12:11:06 +0200
Subject: [PATCH] Auth Indicators webUI part

Add custom_checkbox_widget on service page. The old  aci.attribute_widget
now inherits from the new base class custom_checkobox_widget and overrides
the populate method.

https://fedorahosted.org/freeipa/ticket/5872
---
 install/ui/src/freeipa/aci.js  | 173 ++
 install/ui/src/freeipa/service.js  |  20 
 install/ui/src/freeipa/widget.js   | 187 +
 install/ui/test/data/ipa_init.json |  11 ++-
 ipaserver/plugins/internal.py  |  11 ++-
 5 files changed, 233 insertions(+), 169 deletions(-)

diff --git a/install/ui/src/freeipa/aci.js b/install/ui/src/freeipa/aci.js
index 9a19dd7b45a362640ab1a93d2fe148dc15103248..6ac7f4c71b4632418805bd77682e2d3d5ac92bc0 100644
--- a/install/ui/src/freeipa/aci.js
+++ b/install/ui/src/freeipa/aci.js
@@ -537,146 +537,24 @@ return {
 }
 };};
 
-/**
- * @class aci.attributes_widget
- * @extends IPA.checkboxes_widget
- */
 aci.attributes_widget = function(spec) {
 
 spec = spec || {};
 spec.layout = spec.layout || 'columns attribute_widget';
-spec.sort = spec.sort === undefined ? true : spec.sort;
+spec.add_dialog_title = spec.add_dialog_title ||
+"@i18n:objects.permission.add_custom_attr";
+spec.add_field_label = spec.add_field_label ||
+'@i18n:objects.permission.attribute';
 
-var that = IPA.checkboxes_widget(spec);
-
-/**
- * Additional options which are not defined in metadata
- * @property {string[]}
- */
-that.custom_options = spec.custom_options || [];
+var that = IPA.custom_checkboxes_widget(spec);
 
 that.object_type = spec.object_type;
-that.skip_unmatched = spec.skip_unmatched === undefined ? false : spec.skip_unmatched;
 
-var id = spec.name;
+that.populate = function() {
 
-that.create = function(container) {
-that.container = container;
-that.widget_create(container);
+if (!that.object_type || that.object_type === '') return;
 
-that.controls = $('', {
-

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Petr Vobornik]

On 06/06/2016 12:27 PM, Pavel Vomacka wrote:
> 
> 
> On 06/02/2016 06:22 PM, Petr Vobornik wrote:
>> On 06/01/2016 10:41 AM, Pavel Vomacka wrote:
>>>
>>> On 05/27/2016 05:58 PM, Pavel Vomacka wrote:

 On 05/27/2016 05:44 PM, Nathaniel McCallum wrote:
> On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:
>> On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:
>>> On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:
 Hi,

 the patch adds webui part for authentication indicators.

 Ticket: https://fedorahosted.org/freeipa/ticket/5872
>>> The otp option displays as: OTP.
>>> The radius option displays as: Radius.
>>>
>>> However, both are acronyms. The capitalization should be
>>> consistent.
>> I'm sorry for late answer. They are displayed this way: 'OTP' and
>> 'Radius'. So it should not require any change.
> That is incorrect. It should be: OTP and RADIUS.
 I'm sorry, I didn't understand correctly. Fixed patch attached.



>>> The last patch changes the 'Radius' to 'RADIUS' in whole WebUI.
>>>
>> After some though, we should really support the arbitrary values also in
>> Web UI.
>>
>> I'd reuse aci.attributes_widget - move the widget elsewhere, make it a
>> general widget and a base class for the original aci.attributes_widget.
>>
>> The only difference should be populate method and some strings.
>>
>> The base widget can populate from options - same as normal checkboxes
>> widget so that service page doesn't need to inherit from the base class.
>>
> Ok, thank you for advice. The edited patch is attached.


1. The new base class should have different name, e.g.
custom_checkboxes_widget . It is not related to (aci) attributes.

Then it can be registered as such widget and the attributes widget can
be registered in ACI plugin. It would then also remove the ugly usage of
both $type and $factory.

2. Why not implement empty placeholder populate function in the base
class? Then
  if (that.populate && typeof that.populate === 'function') that.populate();

could be changed into:
  that.populate();

Child class should simply override.

3. If I add a custom indicator to one server and then switch to another.
It will offer the custom option as well, but unchecked. The added
options are not cleared on page reset. I'm not sure if it should be
called a feature or a bug. It is remnant of the original implementation.
-- 
Petr Vobornik

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Pavel Vomacka]

On 06/02/2016 06:22 PM, Petr Vobornik wrote:

On 06/01/2016 10:41 AM, Pavel Vomacka wrote:


On 05/27/2016 05:58 PM, Pavel Vomacka wrote:


On 05/27/2016 05:44 PM, Nathaniel McCallum wrote:

On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:

On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:

On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:

Hi,

the patch adds webui part for authentication indicators.

Ticket: https://fedorahosted.org/freeipa/ticket/5872

The otp option displays as: OTP.
The radius option displays as: Radius.

However, both are acronyms. The capitalization should be
consistent.

I'm sorry for late answer. They are displayed this way: 'OTP' and
'Radius'. So it should not require any change.

That is incorrect. It should be: OTP and RADIUS.

I'm sorry, I didn't understand correctly. Fixed patch attached.




The last patch changes the 'Radius' to 'RADIUS' in whole WebUI.


After some though, we should really support the arbitrary values also in
Web UI.

I'd reuse aci.attributes_widget - move the widget elsewhere, make it a
general widget and a base class for the original aci.attributes_widget.

The only difference should be populate method and some strings.

The base widget can populate from options - same as normal checkboxes
widget so that service page doesn't need to inherit from the base class.


Ok, thank you for advice. The edited patch is attached.
From 813a20cbb5becf6e98329d8278e5230430849bc7 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Mon, 6 Jun 2016 12:11:06 +0200
Subject: [PATCH] Auth Indicators webUI part

Add attribute widget on service page. To achieve that the attribute widget is
moved to the widget module. aci.attribute_widget now inherits from the new base
class.

https://fedorahosted.org/freeipa/ticket/5872
---
 install/ui/src/freeipa/aci.js  | 176 ++-
 install/ui/src/freeipa/service.js  |  20 
 install/ui/src/freeipa/widget.js   | 184 +
 install/ui/test/data/ipa_init.json |  11 ++-
 ipaserver/plugins/internal.py  |  11 ++-
 5 files changed, 232 insertions(+), 170 deletions(-)

diff --git a/install/ui/src/freeipa/aci.js b/install/ui/src/freeipa/aci.js
index 9a19dd7b45a362640ab1a93d2fe148dc15103248..4827138fd33fce3ea85358e082ed2a120b9014d5 100644
--- a/install/ui/src/freeipa/aci.js
+++ b/install/ui/src/freeipa/aci.js
@@ -498,6 +498,7 @@ return {
 other_field: 'cn'
 },
 {
+$factory: aci.attributes_widget,
 $type: 'attributes',
 name: 'attrs',
 object_type: 'user'
@@ -529,6 +530,7 @@ return {
 other_field: 'cn'
 },
 {
+$factory: aci.attributes_widget,
 $type: 'attributes',
 name: 'attrs',
 object_type: 'user'
@@ -537,146 +539,24 @@ return {
 }
 };};

-/**
- * @class aci.attributes_widget
- * @extends IPA.checkboxes_widget
- */
 aci.attributes_widget = function(spec) {

 spec = spec || {};
 spec.layout = spec.layout || 'columns attribute_widget';
-spec.sort = spec.sort === undefined ? true : spec.sort;
+spec.add_dialog_title = spec.add_dialog_title ||
+"@i18n:objects.permission.add_custom_attr";
+spec.add_field_label = spec.add_field_label ||
+'@i18n:objects.permission.attribute';

-var that = IPA.checkboxes_widget(spec);
-
-/**
- * Additional options which are not defined in metadata
- * @property {string[]}
- */
-that.custom_options = spec.custom_options || [];
+var that = IPA.attributes_widget(spec);

 that.object_type = spec.object_type;
-that.skip_unmatched = spec.skip_unmatched === undefined ? false : spec.skip_unmatched;

-var id = spec.name;
+that.populate = function() {

-that.create = function(container) {
-that.container = container;
-that.widget_create(container);
+if (!that.object_type || that.object_type === '') return;

-that.controls = $('', {
-'class': 'form-inline controls'
-});
-that.controls.appendTo(container);
-that.create_search_filter(that.controls);
-that.create_add_control(that.controls);
-if (that.undo) {
-that.create_undo(that.controls);
-}
-
-that.owb_create(container);
-
-that.create_error_link(container);
-};
-
-that.create_search_filter = function(container) {
-var filter_container = $('', {
-'class': 'search-filter'
-});
-
-that.filter = $('', {
-type: 'text',
-name: 'filter',
-'class': 'form-control',
-placeholder: text.get('@i18n:objects.permission.filter')
-}).appendTo(filter_container);
-
- 

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Petr Vobornik]

On 06/01/2016 10:41 AM, Pavel Vomacka wrote:
> 
> 
> On 05/27/2016 05:58 PM, Pavel Vomacka wrote:
>>
>>
>> On 05/27/2016 05:44 PM, Nathaniel McCallum wrote:
>>> On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:
 On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:
> On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:
>> Hi,
>>
>> the patch adds webui part for authentication indicators.
>>
>> Ticket: https://fedorahosted.org/freeipa/ticket/5872
> The otp option displays as: OTP.
> The radius option displays as: Radius.
>
> However, both are acronyms. The capitalization should be
> consistent.
 I'm sorry for late answer. They are displayed this way: 'OTP' and
 'Radius'. So it should not require any change.
>>> That is incorrect. It should be: OTP and RADIUS.
>> I'm sorry, I didn't understand correctly. Fixed patch attached.
>>
>>
>>
> The last patch changes the 'Radius' to 'RADIUS' in whole WebUI.
> 

After some though, we should really support the arbitrary values also in
Web UI.

I'd reuse aci.attributes_widget - move the widget elsewhere, make it a
general widget and a base class for the original aci.attributes_widget.

The only difference should be populate method and some strings.

The base widget can populate from options - same as normal checkboxes
widget so that service page doesn't need to inherit from the base class.
-- 
Petr Vobornik

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Pavel Vomacka]

On 05/27/2016 05:58 PM, Pavel Vomacka wrote:



On 05/27/2016 05:44 PM, Nathaniel McCallum wrote:

On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:

On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:

On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:

Hi,

the patch adds webui part for authentication indicators.

Ticket: https://fedorahosted.org/freeipa/ticket/5872

The otp option displays as: OTP.
The radius option displays as: Radius.

However, both are acronyms. The capitalization should be
consistent.

I'm sorry for late answer. They are displayed this way: 'OTP' and
'Radius'. So it should not require any change.

That is incorrect. It should be: OTP and RADIUS.

I'm sorry, I didn't understand correctly. Fixed patch attached.




The last patch changes the 'Radius' to 'RADIUS' in whole WebUI.
From 2a2accafb1ec23a064d620628d11eff87e4949b9 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Wed, 11 May 2016 12:54:43 +0200
Subject: [PATCH] Add authentication indicators to webui

Add checkboxes for choosing authentication indicators to the service details page.
Also change 'Radius' string to capitalized 'RADIUS'.

https://fedorahosted.org/freeipa/ticket/5872
---
 install/ui/src/freeipa/service.js  | 18 ++
 install/ui/test/data/ipa_init.json |  4 +++-
 ipalib/plugins/internal.py |  4 +++-
 3 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/install/ui/src/freeipa/service.js b/install/ui/src/freeipa/service.js
index f1f8d951e415e9768aab433e28da852a732bc8ba..112c9dbf952a859519446bd249f0f148d84b6924 100644
--- a/install/ui/src/freeipa/service.js
+++ b/install/ui/src/freeipa/service.js
@@ -109,6 +109,24 @@ return {
 ]
 },
 {
+$type: 'checkboxes',
+label: '@i18n:objects.service.auth_indicators',
+name: 'krbprincipalauthind',
+options: [
+{
+label: '@i18n:authtype.otp',
+value: 'otp'
+},
+{
+label: '@i18n:authtype.type_radius',
+value: 'radius'
+}
+],
+tooltip: {
+title: '@mc-opt:service_add:krbprincipalauthind:doc'
+}
+},
+{
 name: 'ipakrbokasdelegate',
 $type: 'checkbox',
 acl_param: 'krbticketflags'
diff --git a/install/ui/test/data/ipa_init.json b/install/ui/test/data/ipa_init.json
index 1b9b69ff909a9668c1e1867008459d25d5e062a9..0d18edded6ab38d7f9637ee3fb78ae1e1f8940ce 100644
--- a/install/ui/test/data/ipa_init.json
+++ b/install/ui/test/data/ipa_init.json
@@ -50,9 +50,10 @@
 },
 "authtype": {
 "config_tooltip": "Implicit method (password) will be used if no method is chosen.Password + Two-factor: LDAP and Kerberos allow authentication with either one of the authentication types but Kerberos uses pre-authentication method which requires to use armor ccache.RADIUS with another type: Kerberos always use RADIUS, but LDAP never does. LDAP only recognize the password and two-factor authentication options.",
+"otp": "OTP",
 "type_otp": "Two factor authentication (password + OTP)",
 "type_password": "Password",
-"type_radius": "Radius",
+"type_radius": "RADIUS",
 "type_disabled": "Disable per-user override",
 "user_tooltip": "Per-user setting, overwrites the global setting if any option is checked.Password + Two-factor: LDAP and Kerberos allow authentication with either one of the authentication types but Kerberos uses pre-authentication method which requires to use armor ccache.RADIUS with another type: Kerberos always use RADIUS, but LDAP never does. LDAP only recognize the password and two-factor authentication options.",
 },
@@ -512,6 +513,7 @@
 "user": "User"
 },
 "service": {
+"auth_indicators": "Authentication indicators",
 "certificate": "Service Certificate",
 "delete_key_unprovision": "Delete Key, Unprovision",
 "details": "Service Settings",
diff --git a/ipalib/plugins/internal.py b/ipalib/plugins/internal.py
index c28693a4669805df01c2a7ac0b1384be0c1e3858..1d2ef5e92622863e1b1bc5952119cfbd5e6f07b1 100644
--- 

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Pavel Vomacka]

On 05/27/2016 05:44 PM, Nathaniel McCallum wrote:

On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:

On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:

On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:

Hi,

the patch adds webui part for authentication indicators.

Ticket: https://fedorahosted.org/freeipa/ticket/5872

The otp option displays as: OTP.
The radius option displays as: Radius.

However, both are acronyms. The capitalization should be
consistent.

I'm sorry for late answer. They are displayed this way: 'OTP' and
'Radius'. So it should not require any change.

That is incorrect. It should be: OTP and RADIUS.

I'm sorry, I didn't understand correctly. Fixed patch attached.

From f488d3e109fc40aff616a846c0857b85b6d50f61 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Wed, 11 May 2016 12:54:43 +0200
Subject: [PATCH] Add authentication indicators to webui

Add checkboxes for choosing authentication indicators to the service details page.

https://fedorahosted.org/freeipa/ticket/5872
---
 install/ui/src/freeipa/service.js  | 18 ++
 install/ui/test/data/ipa_init.json |  3 +++
 ipalib/plugins/internal.py |  3 +++
 3 files changed, 24 insertions(+)

diff --git a/install/ui/src/freeipa/service.js b/install/ui/src/freeipa/service.js
index f1f8d951e415e9768aab433e28da852a732bc8ba..5bae56abbd5414e8aa771d8c4c3092d67a077486 100644
--- a/install/ui/src/freeipa/service.js
+++ b/install/ui/src/freeipa/service.js
@@ -109,6 +109,24 @@ return {
 ]
 },
 {
+$type: 'checkboxes',
+label: '@i18n:objects.service.auth_indicators',
+name: 'krbprincipalauthind',
+options: [
+{
+label: '@i18n:authtype.otp',
+value: 'otp'
+},
+{
+label: '@i18n:authtype.radius',
+value: 'radius'
+}
+],
+tooltip: {
+title: '@mc-opt:service_add:krbprincipalauthind:doc'
+}
+},
+{
 name: 'ipakrbokasdelegate',
 $type: 'checkbox',
 acl_param: 'krbticketflags'
diff --git a/install/ui/test/data/ipa_init.json b/install/ui/test/data/ipa_init.json
index 1b9b69ff909a9668c1e1867008459d25d5e062a9..b058240371f1deab5517f37656f6062e2fa92b11 100644
--- a/install/ui/test/data/ipa_init.json
+++ b/install/ui/test/data/ipa_init.json
@@ -50,6 +50,8 @@
 },
 "authtype": {
 "config_tooltip": "Implicit method (password) will be used if no method is chosen.Password + Two-factor: LDAP and Kerberos allow authentication with either one of the authentication types but Kerberos uses pre-authentication method which requires to use armor ccache.RADIUS with another type: Kerberos always use RADIUS, but LDAP never does. LDAP only recognize the password and two-factor authentication options.",
+"otp": "OTP",
+"radius": "RADIUS",
 "type_otp": "Two factor authentication (password + OTP)",
 "type_password": "Password",
 "type_radius": "Radius",
@@ -512,6 +514,7 @@
 "user": "User"
 },
 "service": {
+"auth_indicators": "Authentication indicators",
 "certificate": "Service Certificate",
 "delete_key_unprovision": "Delete Key, Unprovision",
 "details": "Service Settings",
diff --git a/ipalib/plugins/internal.py b/ipalib/plugins/internal.py
index 54871f76de99d92f0f23129b4d636cc4fccfbb8b..714bcb7b2cd76b62f6b57d58101a5299405fef10 100644
--- a/ipalib/plugins/internal.py
+++ b/ipalib/plugins/internal.py
@@ -192,6 +192,8 @@ class i18n_messages(Command):
 },
 "authtype": {
 "config_tooltip": _("Implicit method (password) will be used if no method is chosen.Password + Two-factor: LDAP and Kerberos allow authentication with either one of the authentication types but Kerberos uses pre-authentication method which requires to use armor ccache.RADIUS with another type: Kerberos always use RADIUS, but LDAP never does. LDAP only recognize the password and two-factor authentication options."),
+"otp": _("OTP"),
+"radius": _("RADIUS"),
 "type_otp": _("Two factor authentication (password + OTP)"),
 

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Nathaniel McCallum]

On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:
> 
> On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:
> > On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:
> > > Hi,
> > > 
> > > the patch adds webui part for authentication indicators.
> > > 
> > > Ticket: https://fedorahosted.org/freeipa/ticket/5872
> > The otp option displays as: OTP.
> > The radius option displays as: Radius.
> > 
> > However, both are acronyms. The capitalization should be
> > consistent.
> I'm sorry for late answer. They are displayed this way: 'OTP' and 
> 'Radius'. So it should not require any change.

That is incorrect. It should be: OTP and RADIUS.

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Pavel Vomacka]

On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:

On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:

Hi,

the patch adds webui part for authentication indicators.

Ticket: https://fedorahosted.org/freeipa/ticket/5872

The otp option displays as: OTP.
The radius option displays as: Radius.

However, both are acronyms. The capitalization should be consistent.
I'm sorry for late answer. They are displayed this way: 'OTP' and 
'Radius'. So it should not require any change.


--
Pavel^3

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Nathaniel McCallum]

On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:
> Hi,
> 
> the patch adds webui part for authentication indicators.
> 
> Ticket: https://fedorahosted.org/freeipa/ticket/5872

The otp option displays as: OTP.
The radius option displays as: Radius.

However, both are acronyms. The capitalization should be consistent.

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Pavel Vomacka]

Hi,

the patch adds webui part for authentication indicators.

Ticket: https://fedorahosted.org/freeipa/ticket/5872

--
Pavel^3 Vomacka
From 912519a2d1a834763f553c2b7b254d8908d85122 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Wed, 11 May 2016 12:54:43 +0200
Subject: [PATCH] Add authentication indicators to webui

Add checkboxes for choosing authentication indicators to the service details page.

https://fedorahosted.org/freeipa/ticket/5872
---
 install/ui/src/freeipa/service.js  | 18 ++
 install/ui/test/data/ipa_init.json |  2 ++
 ipalib/plugins/internal.py |  2 ++
 3 files changed, 22 insertions(+)

diff --git a/install/ui/src/freeipa/service.js b/install/ui/src/freeipa/service.js
index f1f8d951e415e9768aab433e28da852a732bc8ba..e6d3a23309818335f906ce8524653810187c4596 100644
--- a/install/ui/src/freeipa/service.js
+++ b/install/ui/src/freeipa/service.js
@@ -109,6 +109,24 @@ return {
 ]
 },
 {
+$type: 'checkboxes',
+label: '@i18n:service.auth_indicators',
+name: 'krbprincipalauthind',
+options: [
+{
+label: '@i18n:authtype.otp',
+value: 'otp'
+},
+{
+label: '@i18n:authtype.type_radius',
+value: 'radius'
+}
+],
+tooltip: {
+title: '@mc-opt:service_add:krbprincipalauthind:doc'
+}
+},
+{
 name: 'ipakrbokasdelegate',
 $type: 'checkbox',
 acl_param: 'krbticketflags'
diff --git a/install/ui/test/data/ipa_init.json b/install/ui/test/data/ipa_init.json
index 1b9b69ff909a9668c1e1867008459d25d5e062a9..689ada3ce799335e40f8a44c342b6b1df4731ab0 100644
--- a/install/ui/test/data/ipa_init.json
+++ b/install/ui/test/data/ipa_init.json
@@ -50,6 +50,7 @@
 },
 "authtype": {
 "config_tooltip": "Implicit method (password) will be used if no method is chosen.Password + Two-factor: LDAP and Kerberos allow authentication with either one of the authentication types but Kerberos uses pre-authentication method which requires to use armor ccache.RADIUS with another type: Kerberos always use RADIUS, but LDAP never does. LDAP only recognize the password and two-factor authentication options.",
+"otp": "OTP",
 "type_otp": "Two factor authentication (password + OTP)",
 "type_password": "Password",
 "type_radius": "Radius",
@@ -512,6 +513,7 @@
 "user": "User"
 },
 "service": {
+"auth_indicators": "Authentication indicators",
 "certificate": "Service Certificate",
 "delete_key_unprovision": "Delete Key, Unprovision",
 "details": "Service Settings",
diff --git a/ipalib/plugins/internal.py b/ipalib/plugins/internal.py
index 54871f76de99d92f0f23129b4d636cc4fccfbb8b..b038dcf5bb65124c6eed34b2cd1958d62d289c61 100644
--- a/ipalib/plugins/internal.py
+++ b/ipalib/plugins/internal.py
@@ -192,6 +192,7 @@ class i18n_messages(Command):
 },
 "authtype": {
 "config_tooltip": _("Implicit method (password) will be used if no method is chosen.Password + Two-factor: LDAP and Kerberos allow authentication with either one of the authentication types but Kerberos uses pre-authentication method which requires to use armor ccache.RADIUS with another type: Kerberos always use RADIUS, but LDAP never does. LDAP only recognize the password and two-factor authentication options."),
+"otp": _("OTP"),
 "type_otp": _("Two factor authentication (password + OTP)"),
 "type_password": _("Password"),
 "type_radius": _("Radius"),
@@ -658,6 +659,7 @@ class i18n_messages(Command):
 "user": _("User"),
 },
 "service": {
+"auth_indicators": _("Authentication indicators"),
 "certificate": _("Service Certificate"),
 "delete_key_unprovision": _("Delete Key, Unprovision"),
 "details": _("Service Settings"),
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code