Re: [Freeipa-devel] [PATCH] 0051: webui: correct jslint warning
On 13.06.2016 13:50, Martin Basti wrote: On 13.06.2016 12:20, Pavel Vomacka wrote: On 06/13/2016 12:00 PM, Pavel Vomacka wrote: Hello, I forgot to run jslint during the last review and there was one warning, so this patch fixes it. -- Pavel^3 Vomacka Added ticket to the commit message. Would be nice to have covered jslint in make lint, can you enable this check there? Martin^2 jslint can be added later ACK Pushed to master: 3bac6de49e49d702e07a4ef3e85013e3cbd2e82b -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 0051: webui: correct jslint warning
On 13.06.2016 12:20, Pavel Vomacka wrote: On 06/13/2016 12:00 PM, Pavel Vomacka wrote: Hello, I forgot to run jslint during the last review and there was one warning, so this patch fixes it. -- Pavel^3 Vomacka Added ticket to the commit message. Would be nice to have covered jslint in make lint, can you enable this check there? Martin^2 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 0051: webui: correct jslint warning
On 06/13/2016 12:00 PM, Pavel Vomacka wrote: Hello, I forgot to run jslint during the last review and there was one warning, so this patch fixes it. -- Pavel^3 Vomacka Added ticket to the commit message. From 21a8d78e680e06389b17447ecac34fa1042bda2e Mon Sep 17 00:00:00 2001 From: Pavel Vomacka Date: Mon, 13 Jun 2016 11:05:35 +0200 Subject: [PATCH] Correct a jslint warning This patch removes comma at the end of list, just because of jslint warning. It does not have any impact on functionality. https://fedorahosted.org/freeipa/ticket/5937 --- install/ui/src/freeipa/trust.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install/ui/src/freeipa/trust.js b/install/ui/src/freeipa/trust.js index d1bc0dec999186b9ca03a1fd87a69ae7dfb9e2e1..20535be93afcaf446d4fa11d8ba920c0d860f287 100644 --- a/install/ui/src/freeipa/trust.js +++ b/install/ui/src/freeipa/trust.js @@ -149,7 +149,7 @@ return { $type: 'multivalued', name: 'ipantadditionalsuffixes', read_only: true -}, +} ] }, { -- 2.5.5 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH] 0051: webui: correct jslint warning
Hello, I forgot to run jslint during the last review and there was one warning, so this patch fixes it. -- Pavel^3 Vomacka From 5e97a7a9812294ff50630a6baa80eaa9f44e788b Mon Sep 17 00:00:00 2001 From: Pavel Vomacka Date: Mon, 13 Jun 2016 11:05:35 +0200 Subject: [PATCH] Correct a jslint warning This patch removes comma at the end of list, just because of jslint warning. It does not have any impact on functionality. --- install/ui/src/freeipa/trust.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install/ui/src/freeipa/trust.js b/install/ui/src/freeipa/trust.js index d1bc0dec999186b9ca03a1fd87a69ae7dfb9e2e1..20535be93afcaf446d4fa11d8ba920c0d860f287 100644 --- a/install/ui/src/freeipa/trust.js +++ b/install/ui/src/freeipa/trust.js @@ -149,7 +149,7 @@ return { $type: 'multivalued', name: 'ipantadditionalsuffixes', read_only: true -}, +} ] }, { -- 2.5.5 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code