Hello,
please review attached patches.
https://fedorahosted.org/freeipa/ticket/5742
--
Pavel^3 Vomacka
From 0b4898eb7eed06c4e50f6b5606736d0023a58de5 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka
Date: Thu, 11 Aug 2016 15:51:33 +0200
Subject: [PATCH 1/3] Add javascript integer validator
Javascript integer validator checks whether value entered into field is number
and is not higher than Number.MAX_SAFE_INTEGER constant.
Part of: https://fedorahosted.org/freeipa/ticket/5742
---
install/ui/src/freeipa/field.js | 34 ++
1 file changed, 34 insertions(+)
diff --git a/install/ui/src/freeipa/field.js b/install/ui/src/freeipa/field.js
index d8b957f5ab28b5ee4bc4ebce2ae6f454083bc4fd..59525a46bb9d1106e89f364165d567824f37d4c5 100644
--- a/install/ui/src/freeipa/field.js
+++ b/install/ui/src/freeipa/field.js
@@ -962,6 +962,39 @@ field.validator = IPA.validator = function(spec) {
};
/**
+ * Javascript integer validator
+ *
+ * It allows to insert only integer numbers which can be safely represented by
+ * Javascript.
+ *
+ * @class
+ * @alternateClassName IPA.metadata_validator
+ * @extends IPA.validator
+ */
+ field.integer_validator = IPA.integer_validator = function(spec) {
+
+ var that = IPA.validator(spec);
+
+ /**
+ * @inheritDoc
+ */
+ that.validate = function(value) {
+
+ if (!value.match(/^-?\d+$/)) {
+ return that.false_result(text.get('@i18n:widget.validation.integer'));
+ }
+
+ if (!Number.isSafeInteger(parseInt(value, 10))) {
+ return that.false_result(text.get('@i18n:widget.validation.unsupported'));
+ }
+
+ return that.true_result();
+ };
+
+ return that;
+ };
+
+/**
* Metadata validator
*
* Validates value according to supplied metadata
@@ -1574,6 +1607,7 @@ field.register = function() {
v.register('metadata', field.metadata_validator);
v.register('unsupported', field.unsupported_validator);
v.register('same_password', field.same_password_validator);
+v.register('integer', field.integer_validator);
l.register('adapter', field.Adapter);
l.register('object_adapter', field.ObjectAdapter);
--
2.5.5
From ee2a7b415712db3a72d4478e42a36782d03e0ee5 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka
Date: Thu, 11 Aug 2016 15:56:01 +0200
Subject: [PATCH 2/3] Make singleton from config module
Also added general setter and getter for attributes of config.
Part of: https://fedorahosted.org/freeipa/ticket/5742
---
install/ui/src/freeipa/config.js | 51 +++-
1 file changed, 45 insertions(+), 6 deletions(-)
diff --git a/install/ui/src/freeipa/config.js b/install/ui/src/freeipa/config.js
index 61922d454583c393ad68a11fcd571997b6bfab60..3bf017bdc0cab580783f7903261ebbd9a29fdc87 100644
--- a/install/ui/src/freeipa/config.js
+++ b/install/ui/src/freeipa/config.js
@@ -20,14 +20,18 @@
-define([], function() {
+define([
+'dojo/_base/declare',
+'dojo/topic'
+],
+function(declare, topic) {
/**
* Application configuration
* @class config
* @singleton
*/
-var config = {
+var config = declare([], {
/**
* Selector for application container node
@@ -82,8 +86,43 @@ define([], function() {
* Hide sections without any visible widget
* @property {boolean}
*/
-hide_empty_sections: true
-};
+hide_empty_sections: true,
-return config;
-});
\ No newline at end of file
+/**
+ * Number of lines in table on table_facets
+ * @property {Integer}
+ */
+table_page_size: 20,
+
+/**
+ * Genereal setter for config values.
+ * @param item_name {string}
+ * @param value
+ * @param store {Boolean} sets whether the value will be stored into
+ * local storage
+ */
+set: function(item_name, value, store) {
+if (!item_name) return;
+this[item_name] = value;
+
+if (store) {
+window.localStorage.setItem(item_name, value);
+}
+},
+
+/**
+ * Genereal setter for config values.
+ * @param item_name {string}
+ */
+get: function(item_name) {
+return this[item_name];
+},
+
+constructor: function() {
+var user_limit = window.localStorage.getItem('table_page_size');
+if (user_limit) this.table_page_size = user_limit;
+}
+});
+
+return new config();
+});
--
2.5.5
From 9c8c20fb0898156d61f5911710a86aa796ce3c67 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka
Date: Thu, 11 Aug 2016 15:58:23 +0200
Subject: [PATCH 3/3] Add support for custom table pagination size
New customization button opens dialog with field for setting the number of lines
in tables. After saving the new value there is new topic which starts refreshing
current tabl
