Re: [Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Endi Sukma Dewata 

On 7/8/2011 12:29 PM, Adam Young wrote:

Removed code in is_dirty check, as it deson't seem to get triggered now.


ACK and pushed to master.

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Adam Young 

On 07/08/2011 01:25 PM, Adam Young wrote:

On 07/08/2011 01:02 PM, Adam Young wrote:

On 07/08/2011 01:00 PM, Adam Young wrote:

On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:

On 7/8/2011 10:06 AM, Adam Young wrote:




Some issues:

1. The new code in IPA.widget.test_dirty() seems to be redundant.

if ((that.values.length === 0) &&
(values.length === 1) &&
values[0] === ""){
return false;
}

It's already covered by a similar code above it.


Not quite.  This happens when the widget defaults a blank field to 
[""].


2. The commented code in details.js:167 can be removed (and 158 too).

Done


3. Instead of returning empty array, the details_tests.js:173 
should return the overridden method's return value.


return widget.widget_save();


Just keeps the test from breaking.  Not really checking anything


But fixed anyway



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

This time with a patch attached


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Removed code in is_dirty check, as it deson't seem to get triggered now.


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


From 34654c9825b49542515337c74ebc26e20715255d Mon Sep 17 00:00:00 2001
From: Adam Young 
Date: Fri, 8 Jul 2011 10:15:16 -0400
Subject: [PATCH] clear errors on reset

https://fedorahosted.org/freeipa/ticket/1446
---
 install/ui/details.js|2 --
 install/ui/test/details_tests.js |2 +-
 install/ui/widget.js |   10 +-
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/install/ui/details.js b/install/ui/details.js
index 6a2def7fb5447aba59998876bb6257f2415900c5..7467697025250309dfa1bf2c5ff0e294f5947e2b 100644
--- a/install/ui/details.js
+++ b/install/ui/details.js
@@ -155,7 +155,6 @@ IPA.details_section = function(spec) {
 
 for (var j=0; j___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Adam Young 

On 07/08/2011 01:02 PM, Adam Young wrote:

On 07/08/2011 01:00 PM, Adam Young wrote:

On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:

On 7/8/2011 10:06 AM, Adam Young wrote:




Some issues:

1. The new code in IPA.widget.test_dirty() seems to be redundant.

if ((that.values.length === 0) &&
(values.length === 1) &&
values[0] === ""){
return false;
}

It's already covered by a similar code above it.


Not quite.  This happens when the widget defaults a blank field to [""].


2. The commented code in details.js:167 can be removed (and 158 too).

Done


3. Instead of returning empty array, the details_tests.js:173 should 
return the overridden method's return value.


return widget.widget_save();


Just keeps the test from breaking.  Not really checking anything


But fixed anyway



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

This time with a patch attached


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Removed code in is_dirty check, as it deson't seem to get triggered now.
From 8d2ff6033dfa57e8ff7a1c5b911a933007621bb4 Mon Sep 17 00:00:00 2001
From: Adam Young 
Date: Fri, 8 Jul 2011 10:15:16 -0400
Subject: [PATCH] clear errors on reset

https://fedorahosted.org/freeipa/ticket/1446
---
 install/ui/details.js|2 --
 install/ui/test/details_tests.js |2 +-
 install/ui/widget.js |   16 +++-
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/install/ui/details.js b/install/ui/details.js
index 6a2def7fb5447aba59998876bb6257f2415900c5..7467697025250309dfa1bf2c5ff0e294f5947e2b 100644
--- a/install/ui/details.js
+++ b/install/ui/details.js
@@ -155,7 +155,6 @@ IPA.details_section = function(spec) {
 
 for (var j=0; j___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Adam Young 

On 07/08/2011 01:00 PM, Adam Young wrote:

On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:

On 7/8/2011 10:06 AM, Adam Young wrote:




Some issues:

1. The new code in IPA.widget.test_dirty() seems to be redundant.

if ((that.values.length === 0) &&
(values.length === 1) &&
values[0] === ""){
return false;
}

It's already covered by a similar code above it.


Not quite.  This happens when the widget defaults a blank field to [""].


2. The commented code in details.js:167 can be removed (and 158 too).

Done


3. Instead of returning empty array, the details_tests.js:173 should 
return the overridden method's return value.


return widget.widget_save();


Just keeps the test from breaking.  Not really checking anything


But fixed anyway



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

This time with a patch attached
From 8d2ff6033dfa57e8ff7a1c5b911a933007621bb4 Mon Sep 17 00:00:00 2001
From: Adam Young 
Date: Fri, 8 Jul 2011 10:15:16 -0400
Subject: [PATCH] clear errors on reset

https://fedorahosted.org/freeipa/ticket/1446
---
 install/ui/details.js|2 --
 install/ui/test/details_tests.js |2 +-
 install/ui/widget.js |   16 +++-
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/install/ui/details.js b/install/ui/details.js
index 6a2def7fb5447aba59998876bb6257f2415900c5..7467697025250309dfa1bf2c5ff0e294f5947e2b 100644
--- a/install/ui/details.js
+++ b/install/ui/details.js
@@ -155,7 +155,6 @@ IPA.details_section = function(spec) {
 
 for (var j=0; j___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Adam Young 

On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:

On 7/8/2011 10:06 AM, Adam Young wrote:




Some issues:

1. The new code in IPA.widget.test_dirty() seems to be redundant.

if ((that.values.length === 0) &&
(values.length === 1) &&
values[0] === ""){
return false;
}

It's already covered by a similar code above it.


Not quite.  This happens when the widget defaults a blank field to [""].


2. The commented code in details.js:167 can be removed (and 158 too).

Done


3. Instead of returning empty array, the details_tests.js:173 should 
return the overridden method's return value.


return widget.widget_save();


Just keeps the test from breaking.  Not really checking anything
From 1cb42ebf0791653b341fdda974634d90c6ba6df9 Mon Sep 17 00:00:00 2001
From: Adam Young 
Date: Fri, 8 Jul 2011 10:15:16 -0400
Subject: [PATCH] clear errors on reset

https://fedorahosted.org/freeipa/ticket/1446
---
 install/ui/details.js|2 +-
 install/ui/test/details_tests.js |1 +
 install/ui/widget.js |   16 +++-
 3 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/install/ui/details.js b/install/ui/details.js
index 6a2def7fb5447aba59998876bb6257f2415900c5..85aa9be0b0ae4da3c22964b0ceb380c6ac551404 100644
--- a/install/ui/details.js
+++ b/install/ui/details.js
@@ -164,7 +164,7 @@ IPA.details_section = function(spec) {
 var fields = that.fields.values;
 for (var i=0; i___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Endi Sukma Dewata 

On 7/8/2011 10:06 AM, Adam Young wrote:




Some issues:

1. The new code in IPA.widget.test_dirty() seems to be redundant.

if ((that.values.length === 0) &&
(values.length === 1) &&
values[0] === ""){
return false;
}

It's already covered by a similar code above it.

2. The commented code in details.js:167 can be removed (and 158 too).

3. Instead of returning empty array, the details_tests.js:173 should 
return the overridden method's return value.


return widget.widget_save();

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Adam Young 


From 7a01d467e11cd2feec209ea12a7560bfaa80d653 Mon Sep 17 00:00:00 2001
From: Adam Young 
Date: Fri, 8 Jul 2011 10:15:16 -0400
Subject: [PATCH] clear errors on reset

https://fedorahosted.org/freeipa/ticket/1446
---
 install/ui/details.js|2 +-
 install/ui/test/details_tests.js |1 +
 install/ui/widget.js |   16 +++-
 3 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/install/ui/details.js b/install/ui/details.js
index 6a2def7fb5447aba59998876bb6257f2415900c5..85aa9be0b0ae4da3c22964b0ceb380c6ac551404 100644
--- a/install/ui/details.js
+++ b/install/ui/details.js
@@ -164,7 +164,7 @@ IPA.details_section = function(spec) {
 var fields = that.fields.values;
 for (var i=0; i___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel