Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-12 Thread Simo Sorce
On Fri, 07 Jan 2011 12:05:22 -0500 Adam Young wrote: > ACK Pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Adam Young
On 01/07/2011 11:59 AM, Jakub Hrozek wrote: On 01/07/2011 05:28 PM, Adam Young wrote: I'm Not a pythonista. What is this line doing? On 01/07/2011 10:58 AM, Jakub Hrozek wrote: + nameserver = nameserver[-1] == '.' and nameserver or nameserver + '.' This construct is called the 'and-or tri

Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Jakub Hrozek
On 01/07/2011 05:28 PM, Adam Young wrote: I'm Not a pythonista. What is this line doing? On 01/07/2011 10:58 AM, Jakub Hrozek wrote: + nameserver = nameserver[-1] == '.' and nameserver or nameserver + '.' This construct is called the 'and-or trick' and somewhat resembles ternary operator

Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Adam Young
I'm Not a pythonista. What is this line doing? On 01/07/2011 10:58 AM, Jakub Hrozek wrote: +nameserver = nameserver[-1] == '.' and nameserver or nameserver + '.' ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Jakub Hrozek
On Fri, Jan 07, 2011 at 04:54:49PM +0100, Jakub Hrozek wrote: > The attached patch fixes ticket #730 as well as a couple of typos in the > module help. > > To test: > > $ ipa dnszone-add barzone.com --name-server ns.idm.lab.bos.redhat.com > --admin-email ad...@idm.lab.bos.redhat.com > (there must

[Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Jakub Hrozek
The attached patch fixes ticket #730 as well as a couple of typos in the module help. To test: $ ipa dnszone-add barzone.com --name-server ns.idm.lab.bos.redhat.com --admin-email ad...@idm.lab.bos.redhat.com (there must be an A or record for the nameserver) $ ipa dnsrecord-add barzone.com fo