Re: [Freeipa-devel] [PATCH] 1061 disable betxn plugins
On 10/11/2012 04:45 AM, Rob Crittenden wrote: 389-ds-base 1.3.0 was released to Fedora 18 updates-testing this week. There is the chance of deadlock in the schema compat plugin at the moment. We have a candidate patch for addressing it but it is not yet reviewed. This is an interim patch that disables betxn explicitly for now. It should be reversible later by reversing the update file. I have the update file for anyone that tries upgrading from F-17 to F-18, or has an existing F-18 install with 389-ds-base. Perhaps this is overkill and we can just go with the ldif for now. rob I do not think that update file is an overkill, there might be people upgrading from F17, right? I found following issues: 1) Few whitespace errors: # git apply /home/mkosek/freeipa-rcrit-1061-betxn.patch /home/mkosek/freeipa-rcrit-1061-betxn.patch:100: new blank line at EOF. + /home/mkosek/freeipa-rcrit-1061-betxn.patch:145: new blank line at EOF. + warning: 2 lines add whitespace errors. 2) Why do we replace nsslapd-pluginType: preoperation for all different plugins? They already have nsslapd-pluginType set. Wouldn't updates that set nsslapd-pluginbetxn: off: be enough? Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 1061 disable betxn plugins
Martin Kosek wrote: On 10/11/2012 04:45 AM, Rob Crittenden wrote: 389-ds-base 1.3.0 was released to Fedora 18 updates-testing this week. There is the chance of deadlock in the schema compat plugin at the moment. We have a candidate patch for addressing it but it is not yet reviewed. This is an interim patch that disables betxn explicitly for now. It should be reversible later by reversing the update file. I have the update file for anyone that tries upgrading from F-17 to F-18, or has an existing F-18 install with 389-ds-base. Perhaps this is overkill and we can just go with the ldif for now. rob I do not think that update file is an overkill, there might be people upgrading from F17, right? I found following issues: 1) Few whitespace errors: # git apply /home/mkosek/freeipa-rcrit-1061-betxn.patch /home/mkosek/freeipa-rcrit-1061-betxn.patch:100: new blank line at EOF. + /home/mkosek/freeipa-rcrit-1061-betxn.patch:145: new blank line at EOF. + warning: 2 lines add whitespace errors. 2) Why do we replace nsslapd-pluginType: preoperation for all different plugins? They already have nsslapd-pluginType set. Wouldn't updates that set nsslapd-pluginbetxn: off: be enough? Martin This was the recommendation from the 389-ds team. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 1061 disable betxn plugins
Rob Crittenden wrote: Martin Kosek wrote: On 10/11/2012 04:45 AM, Rob Crittenden wrote: 389-ds-base 1.3.0 was released to Fedora 18 updates-testing this week. There is the chance of deadlock in the schema compat plugin at the moment. We have a candidate patch for addressing it but it is not yet reviewed. This is an interim patch that disables betxn explicitly for now. It should be reversible later by reversing the update file. I have the update file for anyone that tries upgrading from F-17 to F-18, or has an existing F-18 install with 389-ds-base. Perhaps this is overkill and we can just go with the ldif for now. rob I do not think that update file is an overkill, there might be people upgrading from F17, right? I found following issues: 1) Few whitespace errors: # git apply /home/mkosek/freeipa-rcrit-1061-betxn.patch /home/mkosek/freeipa-rcrit-1061-betxn.patch:100: new blank line at EOF. + /home/mkosek/freeipa-rcrit-1061-betxn.patch:145: new blank line at EOF. + warning: 2 lines add whitespace errors. 2) Why do we replace nsslapd-pluginType: preoperation for all different plugins? They already have nsslapd-pluginType set. Wouldn't updates that set nsslapd-pluginbetxn: off: be enough? Martin This was the recommendation from the 389-ds team. rob Whitespace removed. rob From 41b2c8f3936eda5ee29840065a8af0510a492a8c Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Wed, 10 Oct 2012 22:41:02 -0400 Subject: [PATCH] Explicitly disable betxn plugins for the time being. This should work with 389-ds-base 1.2.x and 1.3.0. Without other plugin changes 389-ds-base can deadlock. https://fedorahosted.org/freeipa/ticket/3046 --- install/share/Makefile.am | 1 + install/share/disable-betxn.ldif| 61 + install/updates/10-disable-betxn.update | 37 install/updates/Makefile.am | 1 + ipaserver/install/dsinstance.py | 4 +++ 5 files changed, 104 insertions(+) create mode 100644 install/share/disable-betxn.ldif create mode 100644 install/updates/10-disable-betxn.update diff --git a/install/share/Makefile.am b/install/share/Makefile.am index 23cd766a5a82ca5149ebad82e0ee7db9ae77..7f953bc4261b9158303e166fd5c5f1c1232986e4 100644 --- a/install/share/Makefile.am +++ b/install/share/Makefile.am @@ -18,6 +18,7 @@ app_DATA =\ default-hbac.ldif \ default-smb-group.ldif \ delegation.ldif \ + disable-betxn.ldif \ replica-acis.ldif \ ds-nfiles.ldif \ dns.ldif \ diff --git a/install/share/disable-betxn.ldif b/install/share/disable-betxn.ldif new file mode 100644 index ..57a6858ddbb161dc5153d46caf3653998a60ce9f --- /dev/null +++ b/install/share/disable-betxn.ldif @@ -0,0 +1,61 @@ +# Disable transactions in 389-ds-base + +dn: cn=7-bit check,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=attribute uniqueness,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=Auto Membership Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=Linked Attributes,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=Managed Entries,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=MemberOf Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: postoperation + +dn: cn=Multimaster Replication Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginbetxn +nsslapd-pluginbetxn: off + +dn: cn=PAM Pass Through Auth,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=referential integrity postoperation,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: postoperation + +dn: cn=Roles Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginbetxn +nsslapd-pluginbetxn: off + +dn: cn=State Change Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: postoperation + +dn: cn=USN,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginbetxn +nsslapd-pluginbetxn: off diff --git a/install/updates/10-disable-betxn.update b/install/updates/10-disable-betxn.update new file mode 100644 index ..8fca4a5e8c20938dc5eff0505b4ac27bb0a9b007 --- /dev/null +++ b/install/updates/10-disable-betxn.update @@ -0,0 +1,37 @@ +# Disable transactions in 389-ds-base + +dn: cn=7-bit check,cn=plugins,cn=config +only: nsslapd-pluginType: preoperation + +dn: cn=attribute uniqueness,cn=plugins,cn=config +only: nsslapd-pluginType: preoperation + +dn: cn=Auto Membership Plugin,cn=plugins,cn=config +only:
Re: [Freeipa-devel] [PATCH] 1061 disable betxn plugins
On 10/11/2012 03:03 PM, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On 10/11/2012 04:45 AM, Rob Crittenden wrote: 389-ds-base 1.3.0 was released to Fedora 18 updates-testing this week. There is the chance of deadlock in the schema compat plugin at the moment. We have a candidate patch for addressing it but it is not yet reviewed. This is an interim patch that disables betxn explicitly for now. It should be reversible later by reversing the update file. I have the update file for anyone that tries upgrading from F-17 to F-18, or has an existing F-18 install with 389-ds-base. Perhaps this is overkill and we can just go with the ldif for now. rob I do not think that update file is an overkill, there might be people upgrading from F17, right? I found following issues: 1) Few whitespace errors: # git apply /home/mkosek/freeipa-rcrit-1061-betxn.patch /home/mkosek/freeipa-rcrit-1061-betxn.patch:100: new blank line at EOF. + /home/mkosek/freeipa-rcrit-1061-betxn.patch:145: new blank line at EOF. + warning: 2 lines add whitespace errors. 2) Why do we replace nsslapd-pluginType: preoperation for all different plugins? They already have nsslapd-pluginType set. Wouldn't updates that set nsslapd-pluginbetxn: off: be enough? Martin This was the recommendation from the 389-ds team. rob Whitespace removed. rob Looks OK, I did not see any hangs. So ACK. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 1061 disable betxn plugins
Martin Kosek wrote: On 10/11/2012 03:03 PM, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On 10/11/2012 04:45 AM, Rob Crittenden wrote: 389-ds-base 1.3.0 was released to Fedora 18 updates-testing this week. There is the chance of deadlock in the schema compat plugin at the moment. We have a candidate patch for addressing it but it is not yet reviewed. This is an interim patch that disables betxn explicitly for now. It should be reversible later by reversing the update file. I have the update file for anyone that tries upgrading from F-17 to F-18, or has an existing F-18 install with 389-ds-base. Perhaps this is overkill and we can just go with the ldif for now. rob I do not think that update file is an overkill, there might be people upgrading from F17, right? I found following issues: 1) Few whitespace errors: # git apply /home/mkosek/freeipa-rcrit-1061-betxn.patch /home/mkosek/freeipa-rcrit-1061-betxn.patch:100: new blank line at EOF. + /home/mkosek/freeipa-rcrit-1061-betxn.patch:145: new blank line at EOF. + warning: 2 lines add whitespace errors. 2) Why do we replace nsslapd-pluginType: preoperation for all different plugins? They already have nsslapd-pluginType set. Wouldn't updates that set nsslapd-pluginbetxn: off: be enough? Martin This was the recommendation from the 389-ds team. rob Whitespace removed. rob Looks OK, I did not see any hangs. So ACK. Martin pushed to master and ipa-3-0 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 1061 disable betxn plugins
389-ds-base 1.3.0 was released to Fedora 18 updates-testing this week. There is the chance of deadlock in the schema compat plugin at the moment. We have a candidate patch for addressing it but it is not yet reviewed. This is an interim patch that disables betxn explicitly for now. It should be reversible later by reversing the update file. I have the update file for anyone that tries upgrading from F-17 to F-18, or has an existing F-18 install with 389-ds-base. Perhaps this is overkill and we can just go with the ldif for now. rob From ce78df61463efcc19514203d83884b9104f2cbb1 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Wed, 10 Oct 2012 22:41:02 -0400 Subject: [PATCH] Explicitly disable betxn plugins for the time being. This should work with 389-ds-base 1.2.x and 1.3.0. Without other plugin changes 389-ds-base can deadlock. https://fedorahosted.org/freeipa/ticket/3046 --- install/share/Makefile.am | 1 + install/share/disable-betxn.ldif| 63 + install/updates/10-disable-betxn.update | 39 install/updates/Makefile.am | 1 + ipaserver/install/dsinstance.py | 4 +++ 5 files changed, 108 insertions(+) create mode 100644 install/share/disable-betxn.ldif create mode 100644 install/updates/10-disable-betxn.update diff --git a/install/share/Makefile.am b/install/share/Makefile.am index 23cd766a5a82ca5149ebad82e0ee7db9ae77..7f953bc4261b9158303e166fd5c5f1c1232986e4 100644 --- a/install/share/Makefile.am +++ b/install/share/Makefile.am @@ -18,6 +18,7 @@ app_DATA =\ default-hbac.ldif \ default-smb-group.ldif \ delegation.ldif \ + disable-betxn.ldif \ replica-acis.ldif \ ds-nfiles.ldif \ dns.ldif \ diff --git a/install/share/disable-betxn.ldif b/install/share/disable-betxn.ldif new file mode 100644 index ..737192e494f581338c1405b3ceb747cde33b4dd0 --- /dev/null +++ b/install/share/disable-betxn.ldif @@ -0,0 +1,63 @@ +# Disable transactions in 389-ds-base + +dn: cn=7-bit check,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=attribute uniqueness,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=Auto Membership Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=Linked Attributes,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=Managed Entries,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=MemberOf Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: postoperation + +dn: cn=Multimaster Replication Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginbetxn +nsslapd-pluginbetxn: off + +dn: cn=PAM Pass Through Auth,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: preoperation + +dn: cn=referential integrity postoperation,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: postoperation + +dn: cn=Roles Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginbetxn +nsslapd-pluginbetxn: off + +dn: cn=State Change Plugin,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginType +nsslapd-pluginType: postoperation + +dn: cn=USN,cn=plugins,cn=config +changetype: modify +replace: nsslapd-pluginbetxn +nsslapd-pluginbetxn: off + + diff --git a/install/updates/10-disable-betxn.update b/install/updates/10-disable-betxn.update new file mode 100644 index ..db681807e17755f06921906c123eb89fb5796da6 --- /dev/null +++ b/install/updates/10-disable-betxn.update @@ -0,0 +1,39 @@ +# Disable transactions in 389-ds-base + +dn: cn=7-bit check,cn=plugins,cn=config +only: nsslapd-pluginType: preoperation + +dn: cn=attribute uniqueness,cn=plugins,cn=config +only: nsslapd-pluginType: preoperation + +dn: cn=Auto Membership Plugin,cn=plugins,cn=config +only: nsslapd-pluginType: preoperation + +dn: cn=Linked Attributes,cn=plugins,cn=config +only: nsslapd-pluginType: preoperation + +dn: cn=Managed Entries,cn=plugins,cn=config +only: nsslapd-pluginType: preoperation + +dn: cn=MemberOf Plugin,cn=plugins,cn=config +only: nsslapd-pluginType: postoperation + +dn: cn=Multimaster Replication Plugin,cn=plugins,cn=config +only: nsslapd-pluginbetxn: off + +dn: cn=PAM Pass Through Auth,cn=plugins,cn=config +only: nsslapd-pluginType: preoperation + +dn: cn=referential integrity postoperation,cn=plugins,cn=config +only: nsslapd-pluginType: postoperation + +dn: cn=Roles Plugin,cn=plugins,cn=config +only: nsslapd-pluginbetxn: off + +dn: cn=State Change Plugin,cn=plugins,cn=config +only: nsslapd-pluginType: postoperation + +dn:
