Re: [Freeipa-devel] [PATCH] 278 Replaced description text fields with text areas.
On 9/26/2011 10:01 AM, Petr Vobornik wrote:
On 09/17/2011 01:42 AM, Endi Sukma Dewata wrote:
Ticket #1783
It needs rebase and removing 'undo: false' because it's based on your
patch 270 and has conflicts with 271-4a and 271-4b.
Rebased. I also removed the 'undo: false' from this patch.
Should we add 'description' field to HBAC and SUDO rule add dialogs, to
be consistent with other HBAC and SUDO add dialogs?
The description is not required by HBAC/sudo rule, but I think we can
add it for 3.0.
Otherwise it's OK.
Pushed to master.
--
Endi S. Dewata
From dedf456928bae928b3f9f6a74dde16006cd8ab2d Mon Sep 17 00:00:00 2001
From: Endi S. Dewata
Date: Fri, 16 Sep 2011 18:21:41 -0500
Subject: [PATCH] Replaced description text fields with text areas.
Ticket #1783
---
install/ui/aci.js | 68 -
install/ui/automount.js | 13 +++-
install/ui/group.js | 34 -
install/ui/hbac.js | 68 +
install/ui/host.js |5 ++-
install/ui/hostgroup.js | 35 +
install/ui/netgroup.js | 29 --
install/ui/sudo.js | 76 ++
8 files changed, 251 insertions(+), 77 deletions(-)
diff --git a/install/ui/aci.js b/install/ui/aci.js
index fc62f2770979e95768a230c20c80d0aae0e3ce1e..676f5df3e63032dd6c6f32279314545608fbcc28 100644
--- a/install/ui/aci.js
+++ b/install/ui/aci.js
@@ -93,14 +93,26 @@ IPA.entity_factories.privilege = function() {
entity('privilege').
facet_groups([ 'role', 'settings', 'permission' ]).
search_facet({
-columns:['cn','description']}).
+columns: [
+'cn',
+'description'
+]
+}).
details_facet({
-sections:
-[{
-name:'identity',
-label: IPA.messages.details.identity,
-fields:['cn','description']
-}]}).
+sections: [
+{
+name: 'identity',
+label: IPA.messages.details.identity,
+fields: [
+'cn',
+{
+factory: IPA.textarea_widget,
+name: 'description'
+}
+]
+}
+]
+}).
association_facet({
name: 'member_role',
facet_group: 'role',
@@ -116,7 +128,13 @@ IPA.entity_factories.privilege = function() {
}).
standard_association_facets().
adder_dialog({
-fields:['cn', 'description']
+fields: [
+'cn',
+{
+factory: IPA.textarea_widget,
+name: 'description'
+}
+]
}).
build();
@@ -128,12 +146,26 @@ IPA.entity_factories.role = function() {
entity('role').
facet_groups([ 'member', 'settings', 'privilege' ]).
search_facet({
-columns:['cn','description']}).
-details_facet({sections:[
-{
-name:'identity',
-label:IPA.messages.objects.role.identity,
-fields:['cn','description']}]}).
+columns: [
+'cn',
+'description'
+]
+}).
+details_facet({
+sections: [
+{
+name: 'identity',
+label: IPA.messages.objects.role.identity,
+fields: [
+'cn',
+{
+factory: IPA.textarea_widget,
+name: 'description'
+}
+]
+}
+]
+}).
association_facet({
name: 'memberof_privilege',
facet_group: 'privilege',
@@ -142,7 +174,13 @@ IPA.entity_factories.role = function() {
}).
standard_association_facets().
adder_dialog({
-fields:['cn', 'description']
+fields: [
+'cn',
+{
+factory: IPA.textarea_widget,
+name: 'description'
+}
+]
}).
build();
};
diff --git a/install/ui/automount.js b/install/ui/automount.js
index a4fe166e18613b94b27ad048303715fc5d477d88..89b0f6b7eff2988a5f2efcac2358323ee956f767 100644
--- a/install/ui/automount.js
+++ b/install/ui/automount.js
@@ -81,7 +81,13 @@ IPA.entity_factories.automountmap = function() {
{
name: 'identity',
label: IPA.messages.details.identity,
-fields: [ 'automountmapname', 'description' ]
+fields:
Re: [Freeipa-devel] [PATCH] 278 Replaced description text fields with text areas.
On 09/17/2011 01:42 AM, Endi Sukma Dewata wrote: Ticket #1783 It needs rebase and removing 'undo: false' because it's based on your patch 270 and has conflicts with 271-4a and 271-4b. Should we add 'description' field to HBAC and SUDO rule add dialogs, to be consistent with other HBAC and SUDO add dialogs? Otherwise it's OK. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 278 Replaced description text fields with text areas.
Ticket #1783
--
Endi S. Dewata
From 252d019c46f243bafb801a137d2ba9aa81704d1e Mon Sep 17 00:00:00 2001
From: Endi S. Dewata
Date: Fri, 16 Sep 2011 18:21:41 -0500
Subject: [PATCH] Replaced description text fields with text areas.
Ticket #1783
---
install/ui/aci.js | 70 +-
install/ui/automount.js |9 +-
install/ui/group.js | 35 -
install/ui/hbac.js | 70 +
install/ui/host.js |5 ++-
install/ui/hostgroup.js | 36 +
install/ui/netgroup.js | 30 --
install/ui/sudo.js | 78 +++
8 files changed, 257 insertions(+), 76 deletions(-)
diff --git a/install/ui/aci.js b/install/ui/aci.js
index 13fbc7d139e5ef69f6974b9b4d32b160a2eeebc5..357e65c47ca5089e5058af69c135ac0f2ab3d4fc 100644
--- a/install/ui/aci.js
+++ b/install/ui/aci.js
@@ -97,14 +97,26 @@ IPA.entity_factories.privilege = function() {
entity('privilege').
facet_groups([ 'role', 'settings', 'permission' ]).
search_facet({
-columns:['cn','description']}).
+columns: [
+'cn',
+'description'
+]
+}).
details_facet({
-sections:
-[{
-name:'identity',
-label: IPA.messages.details.identity,
-fields:['cn','description']
-}]}).
+sections: [
+{
+name: 'identity',
+label: IPA.messages.details.identity,
+fields: [
+'cn',
+{
+factory: IPA.textarea_widget,
+name: 'description'
+}
+]
+}
+]
+}).
association_facet({
name: 'member_role',
facet_group: 'role',
@@ -120,7 +132,14 @@ IPA.entity_factories.privilege = function() {
}).
standard_association_facets().
adder_dialog({
-fields:['cn', 'description']
+fields: [
+'cn',
+{
+factory: IPA.textarea_widget,
+name: 'description',
+undo: false
+}
+]
}).
build();
@@ -132,12 +151,26 @@ IPA.entity_factories.role = function() {
entity('role').
facet_groups([ 'member', 'settings', 'privilege' ]).
search_facet({
-columns:['cn','description']}).
-details_facet({sections:[
-{
-name:'identity',
-label:IPA.messages.objects.role.identity,
-fields:['cn','description']}]}).
+columns: [
+'cn',
+'description'
+]
+}).
+details_facet({
+sections: [
+{
+name: 'identity',
+label: IPA.messages.objects.role.identity,
+fields: [
+'cn',
+{
+factory: IPA.textarea_widget,
+name: 'description'
+}
+]
+}
+]
+}).
association_facet({
name: 'memberof_privilege',
facet_group: 'privilege',
@@ -146,7 +179,14 @@ IPA.entity_factories.role = function() {
}).
standard_association_facets().
adder_dialog({
-fields:['cn', 'description']
+fields: [
+'cn',
+{
+factory: IPA.textarea_widget,
+name: 'description',
+undo: false
+}
+]
}).
build();
};
diff --git a/install/ui/automount.js b/install/ui/automount.js
index 8be2b65747fbb8d936b34ece919c9b76dc056e45..e47a920ee78770363689d09710d39d2614320db8 100644
--- a/install/ui/automount.js
+++ b/install/ui/automount.js
@@ -81,7 +81,13 @@ IPA.entity_factories.automountmap = function() {
{
name: 'identity',
label: IPA.messages.details.identity,
-fields: [ 'automountmapname', 'description' ]
+fields: [
+'automountmapname',
+{
+factory: IPA.textarea_widget,
+name: 'description'
+}
+]
}
]
}).
@@ -112,6 +118,7 @@ IPA.entity_factories.automountmap = function() {
undo: false
},
{
+
